sync_attr_with_auth0 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cbd1d27afcb626e027d6b5d610d048e52611480e
-  data.tar.gz: 1c0ba300b82dc2a2cb1a8da61ed0b16805967d96
+  metadata.gz: 3b60ecf7f9e253d574e3424fb106ba114d3bc905
+  data.tar.gz: 7d6ddfa0bee4af49a41efa160d43d9c3fedeb172
 SHA512:
-  metadata.gz: 2f8a355e4b26d652563dc2812108c13019ea5a18f1def848efdc749149e39877c3d0722780f11ae8449b2233629e130bf0fe9810943fc7a6f3c26e576e161f9c
-  data.tar.gz: 0250be3d225041f815f7960f5fb59f25834799750b405168297bdecaea174611d8115ee5352c65d68eb58432f8a5c228585a83d3638d00c3d955259f03828b81
+  metadata.gz: 9c5f7901b787108e020a90e21e698492ac8eca6d21367efb1503254068bf9c95db5825d0f6fb1e5fb997824801b04b5476f07dc615aff70585bdc4c9433d5ae7
+  data.tar.gz: 9e15675fdb73869ca0119aa5948107690de934af8e75538eed36796cfe7f49ecaaeaf8b73166dc27ca53a5e686cb676321fcae8d7d31db839112d68e7a9e143a

data/lib/sync_attr_with_auth0/adapters/active_record/auth0_sync.rb

@@ -23,40 +23,50 @@ module SyncAttrWithAuth0
         end # sync_with_auth0_on_update?
 
 
-        def save_to_auth0_on_create
+        def save_to_auth0_after_create
           return true unless sync_with_auth0_on_create?
 
           save_to_auth0
 
           true # don't abort the callback chain
-        end # save_to_auth0_on_create
+        end # save_to_auth0_after_create
 
 
-        def save_to_auth0_on_update
+        def save_to_auth0_after_update
           return true unless sync_with_auth0_on_update?
-          return true unless auth0_dirty?
+          return true unless auth0_saved_change_dirty?
 
           save_to_auth0
 
           true # don't abort the callback chain
-        end # save_to_auth0_on_update
+        end # save_to_auth0_after_update
 
 
-        def auth0_dirty?
-          is_dirty = !!(
-            auth0_attributes_to_sync.inject(false) do |memo, attrib|
-              memo || self.try("#{attrib}_changed?")
+        def auth0_saved_change_dirty?
+          is_dirty = auth0_attributes_to_sync.any? do |attrib|
+            if respond_to? :"saved_change_to_#{attrib}?"
+              # Prefer modern method
+              public_send :"saved_change_to_#{attrib}?"
+            elsif respond_to? :"#{attrib}_changed?"
+              # Legacy method. Drop when no longer supporting <= Rails 5.1
+              public_send :"#{attrib}_changed?"
+            else
+              # Specs currently verify attributes specified as needing synced
+              # that are not defined not cause an error. I'm not sure why we
+              # need this. Seems like a misconfiguration and we should blow
+              # up. But to limit scope of change keeping with defined behavior.
+              false
             end
-          )
+          end
 
           # If the password was changed, force is_dirty to be true
-          is_dirty = true if auth0_user_password_changed?
+          is_dirty = true if auth0_user_saved_change_to_password?
 
           # If the email was changed, force is_dirty to be true
-          is_dirty = true if auth0_user_email_changed?
+          is_dirty = true if auth0_user_saved_change_to_email?
 
           return is_dirty
-        end # auth0_dirty?
+        end # auth0_saved_change_dirty?
 
 
         def save_to_auth0
@@ -86,8 +96,9 @@ module SyncAttrWithAuth0
 
           response = SyncAttrWithAuth0::Auth0.create_user(auth0_user_name, params, config: auth0_sync_configuration)
 
-          # Update the record with the uid after_commit
+          # Update the record with the uid and picture after_commit
           @auth0_uid = response['user_id']
+          @auth0_picture = response['picture']
         end # create_in_auth0
 
 
@@ -97,10 +108,11 @@ module SyncAttrWithAuth0
           params = auth0_update_params
 
           begin
-            SyncAttrWithAuth0::Auth0.patch_user(user_uid, params, config: auth0_sync_configuration)
+            response = SyncAttrWithAuth0::Auth0.patch_user(user_uid, params, config: auth0_sync_configuration)
 
             # Update the record with the uid after_commit (in case it doesn't match what's on file).
             @auth0_uid = user_uid
+            @auth0_picture = response['picture']
           rescue ::Auth0::NotFound => e
             # For whatever reason, the passed in uid was invalid,
             # determine how to proceed.
@@ -113,10 +125,11 @@ module SyncAttrWithAuth0
             else
               # The uid was incorrect, so re-attempt with the new uid
               # and update the one on file.
-              SyncAttrWithAuth0::Auth0.patch_user(found_user['user_id'], params, config: auth0_sync_configuration)
+              response = SyncAttrWithAuth0::Auth0.patch_user(found_user['user_id'], params, config: auth0_sync_configuration)
 
               # Update the record with the uid after_commit
               @auth0_uid = found_user['user_id']
+              @auth0_picture = response['picture']
             end
 
           rescue Exception => e
@@ -163,13 +176,13 @@ module SyncAttrWithAuth0
             'user_metadata' => user_metadata
           }
 
-          if auth0_user_password_changed?
+          if auth0_user_saved_change_to_password?
             # The password needs to be updated.
             params['password'] = auth0_user_password
             params['verify_password'] = auth0_verify_password?
           end
 
-          if auth0_user_email_changed?
+          if auth0_user_saved_change_to_email?
             # The email needs to be updated.
             params['email'] = auth0_user_email
             params['verify_email'] = auth0_email_verified?
@@ -179,20 +192,26 @@ module SyncAttrWithAuth0
         end # auth0_update_params
 
 
-        def update_uid_from_auth0
-          if @auth0_uid
-            self.sync_with_auth0_on_update = false if self.respond_to?(:sync_with_auth0_on_update=)
-            self.send("#{auth0_sync_configuration.auth0_uid_attribute}=", @auth0_uid)
+        def update_uid_and_picture_from_auth0
+          data = {}
 
-            # Nil the instance variable to prevent an infinite loop
-            @auth0_uid = nil
+          if @auth0_uid
+            attr = auth0_sync_configuration.auth0_uid_attribute
+            data[attr] = @auth0_uid if respond_to?(attr) && @auth0_uid != public_send(attr)
+          end
 
-            # Save!
-            self.save
+          if @auth0_picture
+            attr = auth0_sync_configuration.picture_attribute
+            data[attr] = @auth0_picture if respond_to?(attr) && @auth0_picture != public_send(attr)
           end
 
+          update_columns data unless data.empty?
+
+          remove_instance_variable :@auth0_uid if defined? @auth0_uid
+          remove_instance_variable :@auth0_picture if defined? @auth0_picture
+
           true # don't abort the callback chain
-        end # update_uid_from_auth0
+        end # update_uid_and_picture_from_auth0
 
       end
     end

data/lib/sync_attr_with_auth0/adapters/active_record.rb

@@ -33,9 +33,9 @@ module SyncAttrWithAuth0
 
           # Setup callbacks
           after_validation :validate_email_with_auth0
-          after_create :save_to_auth0_on_create
-          after_update :save_to_auth0_on_update
-          after_commit :update_uid_from_auth0
+          after_create :save_to_auth0_after_create
+          after_update :save_to_auth0_after_update
+          after_commit :update_uid_and_picture_from_auth0
         end # sync_attr_with_auth0
 
       end # ClassMethods
@@ -52,18 +52,27 @@ module SyncAttrWithAuth0
       end # auth0_user_email
 
 
-      def auth0_user_email_changed?
+      def auth0_user_saved_change_to_email?
         return false unless self.respond_to?(auth0_sync_configuration.email_attribute)
         # return false unless sync_email_with_auth0? # We don't care if it changed if we aren't syncing it.
 
-        return self.send("#{auth0_sync_configuration.email_attribute}_changed?")
-      end # auth0_email_changed?
+        if respond_to? :"saved_change_to_#{auth0_sync_configuration.email_attribute}?"
+          # Modern method
+          public_send :"saved_change_to_#{auth0_sync_configuration.email_attribute}?"
+        else
+          # Legacy method. Drop when no longer supporting <= Rails 5.1
+          public_send :"#{auth0_sync_configuration.email_attribute}_changed?"
+        end
+      end # auth0_user_saved_change_to_email?
 
 
       def auth0_user_uid
         self.send(auth0_sync_configuration.auth0_uid_attribute) if self.respond_to?(auth0_sync_configuration.auth0_uid_attribute)
       end # auth0_user_uid
 
+      def auth0_picture
+        public_send auth0_sync_configuration.picture_attribute if respond_to? auth0_sync_configuration.picture_attribute
+      end
 
       def auth0_user_name
         self.send(auth0_sync_configuration.name_attribute) if self.respond_to?(auth0_sync_configuration.name_attribute)
@@ -85,18 +94,21 @@ module SyncAttrWithAuth0
       end # auth0_user_password
 
 
-      def auth0_user_password_changed?
+      def auth0_user_saved_change_to_password?
         return false unless self.respond_to?(auth0_sync_configuration.password_attribute)
-        # return false unless sync_password_with_auth0? # We don't care if it changed if we aren't syncing it.
 
-        if self.respond_to?(:"#{auth0_sync_configuration.password_attribute.to_s}_changed?")
-          # We have a changed method, use it
-          return self.send(:"#{auth0_sync_configuration.password_attribute.to_s}_changed?")
-        else
-          # We don't have a changed method, check if the attribute was set.
-          return !self.send(auth0_sync_configuration.password_attribute).nil?
+        case
+          when respond_to?(:"saved_change_to_#{auth0_sync_configuration.password_attribute}?")
+            # Prefer modern method
+            public_send :"saved_change_to_#{auth0_sync_configuration.password_attribute}?"
+          when respond_to?(:"#{auth0_sync_configuration.password_attribute}_changed?")
+            # Legacy method. Drop when no longer supporting <= Rails 5.1
+            public_send :"#{auth0_sync_configuration.password_attribute}_changed?"
+          else
+            # Neither exists so must be in-memory accessor. Just check if set.
+            public_send(auth0_sync_configuration.password_attribute).present?
         end
-      end # auth0_user_password_changed?
+      end # auth0_user_saved_change_to_password?
 
 
       def auth0_default_password

data/lib/sync_attr_with_auth0/configuration.rb

@@ -31,7 +31,7 @@ module SyncAttrWithAuth0
       :auth0_client_id, :auth0_client_secret, :auth0_namespace,
       :auth0_uid_attribute, :name_attribute, :given_name_attribute,
       :family_name_attribute, :email_attribute, :password_attribute,
-      :email_verified_attribute, :verify_password_attribute,
+      :email_verified_attribute, :verify_password_attribute, :picture_attribute,
       :connection_name
 
 
@@ -50,6 +50,7 @@ module SyncAttrWithAuth0
       @password_attribute = :password
       @email_verified_attribute = :email_verified
       @verify_password_attribute = :verify_password
+      @picture_attribute = :picture
       @connection_name = 'Username-Password-Authentication'
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sync_attr_with_auth0
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Patrick McGraw
@@ -29,16 +29,16 @@ dependencies:
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -99,14 +99,14 @@ dependencies:
   name: jwt
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.5.0
 - !ruby/object:Gem::Dependency