synapsis 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f053fe7ebb33a87d6481ae87b43a22afb95034cb
-  data.tar.gz: c56bb4477c91d0b0798e9973986a2bb33156e8ea
+  metadata.gz: 14bcbb633ac4588d0c5c2aec128086bc1a76ec6a
+  data.tar.gz: 161ed76607fc6fe4a5336e23423f1e2d3f894d8f
 SHA512:
-  metadata.gz: 4b4f36ac061188c9a2e1ce644c31dc2808d833ec9e63bce24c4510d29f2a54ef4b2201472bacd954f0b8456b9642409959555aef3f13a660e0c788ed468f5f3f
-  data.tar.gz: a85cbd37d511f08fff1c0116366ee9107649ff85610137248a4a96757b8758437b54513f09679a6db9c1cac8a634624af6a3e46b1a99ee447d70257e86c9ff1c
+  metadata.gz: 51b3daec18b29486ea45dd9b66b90cf73e6b88ec644ff8872eec042af25efc21b63558ce1c50ea3ffcce64d14bbf021faaa925fad6d7c2496d75738784df4d60
+  data.tar.gz: 55c997216c62ec91e687c59bcd651e6aca46e9d080e094a2a45706a160b481f64f76491bdb1fc6888562ee4dbacd9a61b551866708a5ec36a67fd32a46d73599

data/README.md

@@ -22,6 +22,10 @@ Or install it yourself as:
 
 TODO: Write usage instructions here
 
+## Testing
+
+Yasmin's username: `0d8b52f75e224400ba1511d411e598`
+
 ## Contributing
 
 1. Fork it ( https://github.com/[my-github-username]/synapsis/fork )

data/lib/synapsis/api_operations/create.rb

@@ -0,0 +1,14 @@
+module Synapsis::APIOperations::Create
+  def create_request(params)
+    Synapsis.connection.post do |req|
+      req.headers['Content-Type'] = 'application/json'
+      req.url create_url
+      req.body = JSON.generate(params)
+    end
+  end
+
+  def create_url
+    "#{API_V2_PATH}#{class_name}/add"
+  end
+end
+

data/lib/synapsis/api_operations/edit.rb

@@ -0,0 +1,14 @@
+module Synapsis::APIOperations::Edit
+  def edit_request(params)
+    Synapsis.connection.post do |req|
+      req.headers['Content-Type'] = 'application/json'
+      req.url edit_url
+      req.body = JSON.generate(params)
+    end
+  end
+
+  def edit_url
+    "#{API_V2_PATH}#{class_name}/edit/"
+  end
+end
+

data/lib/synapsis/api_operations/view.rb

@@ -0,0 +1,13 @@
+module Synapsis::APIOperations::View
+  def view_request(params)
+    Synapsis.connection.post do |req|
+      req.headers['Content-Type'] = 'application/json'
+      req.url view_url
+      req.body = JSON.generate(params)
+    end
+  end
+
+  def view_url
+    "#{API_V2_PATH}#{class_name}/show"
+  end
+end

data/lib/synapsis/api_resource.rb

@@ -0,0 +1,23 @@
+class Synapsis::APIResource
+  def self.class_name
+    name.partition('::').last.downcase
+  end
+
+  def class_name
+    self.class.name.partition('::').last.downcase
+  end
+
+  def self.return_response(response)
+    parsed_response = JSON.parse(response.body, object_class: Synapsis::Response)
+
+    if response.success?
+      return parsed_response
+    else
+      raise Synapsis::Error, parsed_response['reason']
+    end
+  end
+
+  def self.parse_as_synapse_resource(response)
+    return JSON.parse(response.body, object_class: Synapsis::Response)
+  end
+end

data/lib/synapsis/bank.rb

@@ -1,5 +1,6 @@
-class Synapsis::Bank
+class Synapsis::Bank < Synapsis::APIResource
   include Synapsis::Utilities
+  extend Synapsis::APIOperations::Create
 
   module AccountClass
     PERSONAL = 1
@@ -12,90 +13,70 @@ class Synapsis::Bank
   end
 
   attr_accessor :account_class,
-    :account_num,
+    :account_number_string,
     :account_type,
-    :bank,
-    :fullname,
-    :mfa,
+    :address,
+    :balance,
+    :bank_name,
+    :date,
+    :email,
+    :id,
+    :is_active,
+    :is_buyer_default,
+    :is_seller_default,
+    :is_verified,
+    :mfa_verifed,
+    :name_on_account,
     :nickname,
-    :oauth_consumer_key,
-    :password,
-    :pin,
-    :routing_num,
-    :username,
-    :access_token
+    :phone_number,
+    :resource_uri,
+    :routing_number_string
 
   def self.add(params)
-    self.new(params).add
+    added_bank = create_request(params)
+    return_response(added_bank)
   end
 
   def self.link(params)
-    self.new(params).link
-  end
-
-  def self.view_linked_banks(params)
-    self.new(params).view_linked_banks
-  end
-
-  def initialize(params)
-    params.each do |k, v|
-      send("#{k}=", v)
-    end
-  end
-
-  def add
-    added_bank = Synapsis.connection.post do |req|
-      req.headers['Content-Type'] = 'application/json'
-      req.url "#{API_V2_PATH}bank/add/"
-      req.body = build_json_from_variable_hash
-    end
-
-    if JSON.parse(added_bank.body)['success']
-      Synapsis::RetrievedBank.new(added_bank)
-    else
-      Synapsis::Error.new(JSON.parse(added_bank.body))
-    end
-  end
-
-  def link
     partially_linked_bank = Synapsis.connection.post do |req|
       req.headers['Content-Type'] = 'application/json'
       req.url "#{API_V2_PATH}bank/login/?is_dev=yes"
-      req.body = build_json_from_variable_hash
+      req.body = JSON.generate(params)
     end
 
-    parsed_partially_linked_bank = JSON.parse(partially_linked_bank.body)
+    parsed_partially_linked_bank = parse_as_synapse_resource(partially_linked_bank)
 
-    if parsed_partially_linked_bank['success']
-      if parsed_partially_linked_bank['banks'] # This happens if the added bank has no MFA
-        return Synapsis::RetrievedBank.new(partially_linked_bank)
+    if parsed_partially_linked_bank.success
+      if parsed_partially_linked_bank.banks # This happens if the added bank has no MFA
+        return parsed_partially_linked_bank
       end
 
-      @access_token = parsed_partially_linked_bank['response']['access_token']
+      @access_token = parsed_partially_linked_bank.response.access_token
 
       new_bank =  Synapsis.connection.post do |req|
         req.headers['Content-Type'] = 'application/json'
         req.url "#{API_V2_PATH}bank/mfa/?is_dev=yes"
-        req.body = build_json_from_variable_hash
+        req.body = JSON.generate(params.merge(access_token: @access_token))
       end
 
-      if JSON.parse(new_bank.body)['banks']
-        Synapsis::RetrievedBank.new(new_bank)
+      parsed_new_bank = parse_as_synapse_resource(new_bank)
+
+      if parsed_new_bank.banks
+        return parsed_new_bank
       else
-        Synapsis::Error.new({
-          "reason" => "Wrong MFA answer."
-        })
+        raise Synapsis::Error, 'Wrong MFA answer.'
       end
     else
-      # API response is different so we parse the API response to get the message we need
-      Synapsis::Error.new({
-        "reason" => JSON.parse(partially_linked_bank.body)['message']
-      })
+      raise Synapsis::Error, JSON.parse(partially_linked_bank.body)['message']
     end
   end
 
+  def self.view_linked_banks(params)
+    self.new(params).view_linked_banks
+  end
+
   def self.remove(bank_id, oauth_consumer_key)
-    return Synapsis.connection.post do |req|
+    response =  Synapsis.connection.post do |req|
       req.headers['Content-Type'] = 'application/json'
       req.url "#{API_V2_PATH}bank/delete/"
       req.body = JSON.generate(
@@ -103,6 +84,8 @@ class Synapsis::Bank
         oauth_consumer_key: oauth_consumer_key
       )
     end
+
+    return_response(response)
   end
 
   def view_linked_banks
@@ -113,39 +96,3 @@ class Synapsis::Bank
     end
   end
 end
-
-class Synapsis::RetrievedBank
-  attr_accessor :account_class,
-    :account_number_string,
-    :account_type,
-    :address,
-    :balance,
-    :bank_name,
-    :date,
-    :email,
-    :id,
-    :is_active,
-    :is_buyer_default,
-    :is_seller_default,
-    :is_verified,
-    :mfa_verifed,
-    :name_on_account,
-    :nickname,
-    :phone_number,
-    :resource_uri,
-    :routing_number_string
-
-  def initialize(synapse_response)
-    parsed_response = JSON.parse(synapse_response.body)
-
-    if parsed_response['banks']
-      parsed_response['banks'].first.each do |k, v|
-        send("#{k}=", v)
-      end
-    elsif parsed_response['bank']
-      parsed_response['bank'].each do |k, v|
-        send("#{k}=", v)
-      end
-    end
-  end
-end

data/lib/synapsis/deposit.rb

@@ -0,0 +1,10 @@
+class Synapsis::Deposit < Synapsis::APIResource
+  include Synapsis::Utilities
+  extend Synapsis::APIOperations::Create
+
+  def self.create(params)
+    response = create_request(params)
+
+    return_response(response)
+  end
+end

data/lib/synapsis/error.rb

@@ -1,7 +1 @@
-class Synapsis::Error
-  attr_accessor :reason
-
-  def initialize(error_params)
-    @reason = error_params['reason']
-  end
-end
+class Synapsis::Error < StandardError; end

data/lib/synapsis/order.rb

@@ -0,0 +1,18 @@
+class Synapsis::Order < Synapsis::APIResource
+  include Synapsis::Utilities
+  extend Synapsis::APIOperations::Create
+
+  def self.add(params)
+    response = create_request(params)
+    return_response(response)
+  end
+
+  def self.synapse_fee(transaction_amount)
+    if transaction_amount > 10
+      0.25
+    else
+      0.1
+    end
+  end
+end
+

data/lib/synapsis/user.rb

@@ -1,113 +1,35 @@
-class Synapsis::User
+class Synapsis::User < Synapsis::APIResource
   include Synapsis::Utilities
-
-  attr_accessor :email,
-    :fullname,
-    :password,
-    :ip_address,
-    :phonenumber,
-    :access_token,
-    :refresh_token,
-    :username
+  extend Synapsis::APIOperations::Create
+  extend Synapsis::APIOperations::Edit
+  extend Synapsis::APIOperations::View
 
   def self.create(params)
-    self.new(params).create
+    response = create_request(params.merge(client_credentials))
+    return_response(response)
   end
 
   def self.edit(params)
-    self.new({}).edit(params)
-  end
-
-  def self.view(params)
-    self.new({}).view(params)
-  end
-
-  def initialize(params)
-    params.each do |k, v|
-      send("#{k}=", v)
-    end
-  end
-
-  def create
-    response = Synapsis.connection.post do |req|
-      req.headers['Content-Type'] = 'application/json'
-      req.url "#{API_V2_PATH}user/create/"
-      req.body = build_json_from_params
-    end
-
-    if JSON.parse(response.body)['success']
-      update_attributes(response)
-      return self
-    else
-      return Synapsis::Error.new(JSON.parse(response.body))
-    end
+    response = edit_request(params)
+    return_response(response)
   end
 
-  def edit(params)
-    response = Synapsis.connection.post do |req|
-      req.headers['Content-Type'] = 'application/json'
-      req.url "#{API_V2_PATH}user/edit/"
-      req.body = JSON.generate(params)
-    end
-
-
-    if JSON.parse(response.body)['success']
-      update_attributes(response)
-      return self
-    else
-      return Synapsis::Error.new(JSON.parse(response.body))
-    end
-  end
-
-  def view(oauth_token = @access_token)
-    response = Synapsis.connection.post do |req|
-      req.headers['Content-Type'] = 'application/json'
-      req.url "#{API_V2_PATH}user/show/"
-      req.body = JSON.generate({ 'oauth_consumer_key' => oauth_token})
-    end
-
-    if response.success?
-      return Synapsis::RetrievedUser.new(response)
-    else
-      return response
-    end
+  def self.view(oauth_token)
+    response = view_request('oauth_consumer_key' => oauth_token)
+    return_response(response)
   end
 
   private
 
-  def update_attributes(synapse_response)
-    parsed_response = JSON.parse(synapse_response.body)
-    @access_token =  parsed_response['access_token']
-    @refresh_token =  parsed_response['refresh_token']
-    @username =  parsed_response['username']
-
-    if parsed_response['user']
-      @fullname =  parsed_response['user']['fullname']
-    end
+  def self.client_credentials
+    {
+      client_id: Synapsis.client_id,
+      client_secret: Synapsis.client_secret
+    }
   end
 
-  class Synapsis::RetrievedUser
-    attr_accessor :accept_bank_payments,
-      :accept_gratuity,
-      :balance,
-      :email,
-      :fullname,
-      :has_avatar,
-      :phone_number,
-      :resource_uri,
-      :seller_details,
-      :user_id,
-      :username,
-      :visit_count,
-      :visit_message
-
-    def initialize(synapse_response)
-      parsed_response = JSON.parse(synapse_response.body)
-
-      parsed_response['user'].each do |k, v|
-        send("#{k}=", v)
-      end
-    end
+  def self.create_url
+    "#{API_V2_PATH}user/create/"
   end
 end
 

data/lib/synapsis/utilities.rb

@@ -1,8 +1,6 @@
 require 'json'
 
 module Synapsis::Utilities
-  API_V2_PATH = 'api/v2/'
-
   def build_json_from_params
     JSON.generate(to_hash.merge(client_credentials))
   end

data/lib/synapsis/version.rb

@@ -1,3 +1,3 @@
 module Synapsis
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/lib/synapsis/withdrawal.rb

@@ -0,0 +1,25 @@
+class Synapsis::Withdrawal < Synapsis::APIResource
+  include Synapsis::Utilities
+  extend Synapsis::APIOperations::Create
+  extend Synapsis::APIOperations::View
+
+  # Note: If you do not supply the bank_id, Synapse will attempt to withdraw from the primary bank.
+  def self.create(params)
+    response = create_request(params)
+
+    return_response(response)
+  end
+
+  def self.view(params)
+    response = view_request(params)
+
+    return_response(response)
+  end
+
+  private
+
+  # SynapseAPI's URI for withdrawals is /withdraw, not /withdrawal
+  def self.class_name
+    'withdraw'
+  end
+end

data/lib/synapsis.rb

@@ -1,15 +1,29 @@
 # External dependencies
 require "faraday"
 
-# Internal dependencies
+# Namespacing
+
+module Synapsis
+  module APIOperations; end
+end
 
+# Internal dependencies
 require "synapsis/version"
 require "synapsis/utilities"
+require "synapsis/api_resource"
+require "synapsis/api_operations/create"
+require "synapsis/api_operations/edit"
+require "synapsis/api_operations/view"
 require "synapsis/authentication"
 require "synapsis/user"
 require "synapsis/bank"
+require "synapsis/withdrawal"
+require "synapsis/deposit"
+require "synapsis/order"
 require "synapsis/error"
 
+API_V2_PATH = 'api/v2/'
+
 module Synapsis
   class << self
     attr_accessor :client_id, :client_secret, :environment
@@ -34,4 +48,6 @@ module Synapsis
       yield(self)
     end
   end
+
+  class Response < OpenStruct; end
 end

data/spec/synapsis/api_resource_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+RSpec.describe Synapsis::APIResource do
+  context '.class_name' do
+    it 'gets the class name, without the Synapsis namespace' do
+      class Synapsis::Thingie < Synapsis::APIResource; end
+
+      expect(Synapsis::Thingie.class_name).to eq 'thingie'
+    end
+  end
+end

data/spec/synapsis/bank_link_spec.rb

@@ -25,13 +25,13 @@ RSpec.describe Synapsis::Bank do
 
           new_bank = Synapsis::Bank.link(bank_params)
 
-          expect(new_bank.name_on_account).to eq user_params[:fullname]
-          expect(new_bank.bank_name).to eq bank_params[:bank]
+          expect(new_bank.banks.first.name_on_account).to eq user_params[:fullname]
+          expect(new_bank.banks.first.bank_name).to eq bank_params[:bank]
         end
       end
 
       context 'errors' do
-        it 'bad username returns a SynapsisError' do
+        it 'bad username raises a SynapsisError' do
           new_user = Synapsis::User.create(user_params)
 
           bank_params = {
@@ -43,28 +43,7 @@ RSpec.describe Synapsis::Bank do
             mfa: 'test_answer'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
-        end
-
-        it 'bad password returns a SynapsisError' do
-          new_user = Synapsis::User.create(user_params)
-
-          bank_params = {
-            username: 'synapse_good',
-            password: 'WRONG PASSWORD',
-            pin: '1234',
-            oauth_consumer_key: new_user.access_token,
-            bank: 'US Bank',
-            mfa: 'test_answer'
-          }
-
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect{ Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('The input you have entered is not valid. Please check your entry and try again.')
         end
 
         it 'bad mfa answer returns a SynapsisError' do
@@ -78,10 +57,7 @@ RSpec.describe Synapsis::Bank do
             mfa: 'WRONG MFA ANSWER'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect{ Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('Wrong MFA answer.')
         end
 
         xit 'bad PIN returns a SynapsisError--pending since trying test data with a wrong PIN still completes the linking process' do
@@ -118,8 +94,8 @@ RSpec.describe Synapsis::Bank do
 
         new_bank = Synapsis::Bank.link(bank_params)
 
-        expect(new_bank.name_on_account).to eq user_params[:fullname]
-        expect(new_bank.bank_name).to eq bank_params[:bank]
+        expect(new_bank.banks.first.name_on_account).to eq user_params[:fullname]
+        expect(new_bank.banks.first.bank_name).to eq bank_params[:bank]
       end
 
       context 'errors' do
@@ -135,28 +111,7 @@ RSpec.describe Synapsis::Bank do
             mfa: 'test_answer'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
-        end
-
-        it 'bad password returns a SynapsisError' do
-          new_user = Synapsis::User.create(user_params)
-
-          bank_params = {
-            username: 'synapse_code',
-            password: 'WRONG PASSWORD',
-            pin: '1234',
-            oauth_consumer_key: new_user.access_token,
-            bank: 'Ally',
-            mfa: 'test_answer'
-          }
-
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect { Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('Please Enter the Correct Username and Password')
         end
 
         it 'bad mfa answer returns a SynapsisError' do
@@ -170,10 +125,7 @@ RSpec.describe Synapsis::Bank do
             mfa: 'WRONG MFA ANSWER'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect { Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('Wrong MFA answer.')
         end
       end
     end
@@ -192,8 +144,9 @@ RSpec.describe Synapsis::Bank do
 
           new_bank = Synapsis::Bank.link(bank_params)
 
-          expect(new_bank.name_on_account).to eq user_params[:fullname]
-          expect(new_bank.bank_name).to eq bank_params[:bank]
+          # Upcase since Synapse automatically downcases titles such as "MD, PHD" (it becomes Md or Phd)
+          expect(new_bank.banks.first.name_on_account.upcase).to eq user_params[:fullname].upcase
+          expect(new_bank.banks.first.bank_name).to eq bank_params[:bank]
         end
       end
 
@@ -208,26 +161,7 @@ RSpec.describe Synapsis::Bank do
             bank: 'Capital One 360'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
-        end
-
-        it 'bad password returns a SynapsisError' do
-          new_user = Synapsis::User.create(user_params)
-
-          bank_params = {
-            username: 'synapsenomfa',
-            password: 'test12345',
-            oauth_consumer_key: new_user.access_token,
-            bank: 'Capital One 360'
-          }
-
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect { Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('The username or password provided were not correct.')
         end
 
         it 'bad mfa answer returns a SynapsisError' do
@@ -241,12 +175,54 @@ RSpec.describe Synapsis::Bank do
             mfa: 'WRONG MFA ANSWER'
           }
 
-          new_bank = Synapsis::Bank.link(bank_params)
-
-          expect(new_bank.class).to eq Synapsis::Error
-          expect(new_bank.reason).to be_a_kind_of String
+          expect { Synapsis::Bank.link(bank_params) }.to raise_error(Synapsis::Error).with_message('Wrong MFA answer.')
         end
       end
     end
+
+    context 'multiple bank linkages' do
+      xit 'works' do
+        new_user = Synapsis::User.create(user_params)
+
+        first_bank_params = {
+          username: 'synapse_code',
+          password: 'test1234',
+          oauth_consumer_key: new_user.access_token,
+          bank: 'Ally',
+          mfa: 'test_answer'
+        }
+
+        first_bank = Synapsis::Bank.new(first_bank_params).link
+
+        expect(first_bank.name_on_account).to eq user_params[:fullname]
+        expect(first_bank.bank_name).to eq first_bank_params[:bank]
+
+        bank_params = {
+          fullname: new_user.fullname,
+          account_num: '1111111112',
+          routing_num: '121000358',
+          nickname: 'Sourcepad Bank',
+          oauth_consumer_key: new_user.access_token,
+          account_type: Synapsis::Bank::AccountType::CHECKING,
+          account_class: Synapsis::Bank::AccountClass::PERSONAL
+        }
+
+        new_bank = Synapsis::Bank.add(bank_params)
+
+        second_bank_params = {
+          username: 'synapse_good',
+          password: 'test1234',
+          oauth_consumer_key: new_user.access_token,
+          bank: 'PNC',
+          mfa: 'test_answer'
+        }
+
+        second_bank = Synapsis::Bank.new(second_bank_params).link
+
+        expect(second_bank.name_on_account).to eq user_params[:fullname]
+        expect(second_bank.bank_name).to eq second_bank_params[:bank]
+
+      end
+    end
   end
 end

data/spec/synapsis/bank_spec.rb

@@ -11,33 +11,29 @@ RSpec.describe Synapsis::Bank do
     end
   end
 
-  context '#add' do
-    it 'adds a bank account' do
-      # We need to create a user because Synapse limits bank accounts to 5 per user.
-      user_params = {
-        email: Faker::Internet.email,
-        fullname: Faker::Name.name,
-        phonenumber: Faker::PhoneNumber.phone_number,
-        password: '5ourcep4d',
-        ip_address: '8.8.8.8'
-      }
+  context '#add/ #remove' do
+    it 'adds and removes a bank account' do
+      random_persons_access_token = 'dcd234d9d9fb55ad9711c4c41e254868ef3768d4'
 
-      new_user = Synapsis::User.create(user_params)
+      viewed_user = Synapsis::User.view(random_persons_access_token)
 
       bank_params = {
-        fullname: new_user.fullname,
+        fullname: viewed_user.user.fullname,
         account_num: '1111111112',
         routing_num: '121000358',
         nickname: 'Sourcepad Bank',
-        oauth_consumer_key: new_user.access_token,
+        oauth_consumer_key: random_persons_access_token,
         account_type: Synapsis::Bank::AccountType::CHECKING,
         account_class: Synapsis::Bank::AccountClass::PERSONAL
       }
 
       new_bank = Synapsis::Bank.add(bank_params)
+      expect(new_bank.bank.name_on_account).to eq viewed_user.user.fullname
+      expect(new_bank.bank.nickname).to eq bank_params[:nickname]
 
-      expect(new_bank.name_on_account).to eq user_params[:fullname]
-      expect(new_bank.nickname).to eq bank_params[:nickname]
+      removed_bank = Synapsis::Bank.remove(new_bank.bank.id, random_persons_access_token)
+
+      expect(removed_bank.success).to eq true
     end
 
     it 'adds a bank account (errors)' do
@@ -62,40 +58,7 @@ RSpec.describe Synapsis::Bank do
         account_class: Synapsis::Bank::AccountClass::PERSONAL
       }
 
-      new_bank = Synapsis::Bank.add(bank_params)
-
-      expect(new_bank.class).to eq Synapsis::Error
-      expect(new_bank.reason).to be_a_kind_of String
-    end
-  end
-
-  context '#remove' do
-    it 'removes the bank' do
-      user_params = {
-        email: Faker::Internet.email,
-        fullname: Faker::Name.name,
-        phonenumber: Faker::PhoneNumber.phone_number,
-        password: '5ourcep4d',
-        ip_address: '8.8.8.8'
-      }
-
-      new_user = Synapsis::User.create(user_params)
-
-      bank_params = {
-        fullname: new_user.fullname,
-        account_num: '1111111112',
-        routing_num: '121000358',
-        nickname: 'Sourcepad Bank',
-        oauth_consumer_key: new_user.access_token,
-        account_type: Synapsis::Bank::AccountType::CHECKING,
-        account_class: Synapsis::Bank::AccountClass::PERSONAL
-      }
-
-      new_bank = Synapsis::Bank.add(bank_params)
-
-      removed_bank = Synapsis::Bank.remove(new_bank.id, new_user.access_token)
-
-      expect(JSON.parse(removed_bank.body)['success']).to eq true
+      expect { Synapsis::Bank.add(bank_params) }.to raise_error(Synapsis::Error).with_message('Because of security reasons you can only add a bank account that belongs to you and is in your name.')
     end
   end
 end

data/spec/synapsis/deposit_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe Synapsis::Deposit do
+  context '#add' do
+    let!(:deposit_params) {{
+      amount: 100,
+      oauth_consumer_key: '3bdb5790692d06983d8cb0feb40365886631e52d',
+      bank_id: 2182
+    }}
+
+    context 'happy path' do
+      it 'constructs the correct deposit object' do
+        deposit_response = Synapsis::Deposit.create(deposit_params)
+
+        DEPOSIT_SPECIFIC_PARAMS = ['amount', 'bank', 'date_created', 'id', 'resource_uri', 'status', 'status_url', 'user_id']
+
+        (DEPOSIT_SPECIFIC_PARAMS - ['status_url']).each do |x|
+          expect(deposit_response.deposit.send(x.to_s.gsub('@', ''))).not_to be_nil
+        end
+      end
+    end
+
+    context 'errors' do
+      it 'create a Synapsis::Error object' do
+        # Missing amount
+        expect { Synapsis::Deposit.create(deposit_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('Missing amount')
+
+        # OAuth error
+        expect { Synapsis::Deposit.create(deposit_params.merge(oauth_consumer_key: 'WRONG!!!')) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')
+
+        # Wrong bank ID (user does not own bank_id 1)
+        expect{ Synapsis::Deposit.create(deposit_params.merge(bank_id: 1))}.to raise_error(Synapsis::Error).with_message('Bank account not associated with the user')
+      end
+    end
+  end
+end

data/spec/synapsis/order_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+RSpec.describe Synapsis::Order do
+  context '#add' do
+    let!(:delta) { 0.001 }
+    let!(:buyer_consumer_key) { '3bdb5790692d06983d8cb0feb40365886631e52d' }
+    let!(:seller_consumer_key) { '325ea5c0c3a7927280c54ed3ad310c02b45129d8' }
+    let!(:order_params) {{
+      amount: 1,
+      oauth_consumer_key: buyer_consumer_key,
+      seller_id: 3437
+    }}
+
+    context 'happy path' do
+      it 'constructs the correct Order object' do
+        order = Synapsis::Order.add(order_params)
+
+        ORDER_PARAMS = ['account_type', 'amount', 'date', 'date_settled', 'discount', 'facilitator_fee', 'fee', 'id', 'is_buyer', 'note', 'resource_uri', 'seller', 'status', 'status_uri', 'ticket_number', 'tip', 'total']
+
+        (ORDER_PARAMS - ['status_uri']).each do |x|
+          expect(order.order.send(x)).not_to be_nil
+        end
+      end
+
+      it 'subtracts the money from the consumer\'s account and adds to the seller\'s account' do
+        buyer_account_balance = Synapsis::User.view(buyer_consumer_key).user.balance
+        seller_account_balance = Synapsis::User.view(seller_consumer_key).user.balance
+
+        order = Synapsis::Order.add(order_params)
+
+        new_buyer_account_balance = Synapsis::User.view(buyer_consumer_key).user.balance
+        new_seller_account_balance = Synapsis::User.view(seller_consumer_key).user.balance
+
+        expect(new_buyer_account_balance).to be_within(delta).of(buyer_account_balance - order_params[:amount])
+        expect(new_seller_account_balance).to be_within(seller_account_balance + order_params[:amount] - Synapsis::Order.synapse_fee(order_params[:amount]))
+      end
+
+      it 'subtracts the money from the consumer\'s account and adds to the seller\'s account, with a charge of ' do
+        buyer_account_balance = Synapsis::User.view(buyer_consumer_key).user.balance
+        seller_account_balance = Synapsis::User.view(seller_consumer_key).user.balance
+
+        order = Synapsis::Order.add(order_params.merge(amount: 10.1))
+
+        new_buyer_account_balance = Synapsis::User.view(buyer_consumer_key).user.balance
+        new_seller_account_balance = Synapsis::User.view(seller_consumer_key).user.balance
+
+        expect(new_buyer_account_balance).to be_within(delta).of(buyer_account_balance - 10.1)
+        expect(new_seller_account_balance).to be_within(delta).of(seller_account_balance + 10.1- 0.25)
+      end
+    end
+
+    context 'no amount specified' do
+      it 'raises a Synapsis::Error' do
+        expect{ Synapsis::Order.add(order_params.merge(oauth_consumer_key: 'WRONG!')) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')
+        expect{ Synapsis::Order.add(order_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('Missing amount')
+        expect{ Synapsis::Order.add(order_params.merge(seller_id: 0)) }.to raise_error(Synapsis::Error).with_message('Missing seller_id')
+      end
+    end
+  end
+end

data/spec/synapsis/user_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 RSpec.describe Synapsis::User do
   describe '#create' do
     it 'creates a user account and returns the SynapsePay username, access_token and refresh_token' do
-      user_email = Faker::Internet.email
+      user_email = Faker::Internet.email[0, 29] # Limit 30 characters
 
       user_params = {
         email: user_email,
@@ -15,11 +15,10 @@ RSpec.describe Synapsis::User do
 
       new_synapse_user = Synapsis::User.create(user_params)
 
-      expect(new_synapse_user.class).to eq Synapsis::User
-      expect(new_synapse_user.email).to eq user_params[:email]
-      expect(new_synapse_user.username).to be_a_kind_of String
-      expect(new_synapse_user.access_token).to be_a_kind_of String
-      expect(new_synapse_user.refresh_token).to be_a_kind_of String
+      ['access_token', 'oauth_consumer_key', 'expires_in',
+       'reason', 'refresh_token', 'success', 'username', 'user_id'].each do |k|
+        expect(new_synapse_user.send(k)).not_to be_nil
+      end
     end
 
     it 'returns an error if the params are bad' do
@@ -31,9 +30,7 @@ RSpec.describe Synapsis::User do
         ip_address: '8.8.8.8'
       }
 
-      new_synapse_user = Synapsis::User.create(user_params)
-
-      expect(new_synapse_user).to be_a_kind_of Synapsis::Error
+      expect { Synapsis::User.create(user_params) }.to raise_error(Synapsis::Error).with_message('Add full name to create an account')
     end
   end
 
@@ -47,7 +44,7 @@ RSpec.describe Synapsis::User do
 
       edited_user = Synapsis::User.edit(edit_user_attributes)
 
-      expect(edited_user.fullname).to eq edit_user_attributes['fullname']
+      expect(edited_user.user.fullname).to eq edit_user_attributes['fullname']
     end
 
     it 'returns an error if the update didnt work' do
@@ -57,42 +54,29 @@ RSpec.describe Synapsis::User do
         'oauth_consumer_key' => oauth_token
       }
 
-      response = Synapsis::User.edit(edit_user_attributes)
-
-      expect(response.reason).to be_a_kind_of String
+      expect { Synapsis::User.edit(edit_user_attributes) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')
     end
   end
 
-  describe '#view' do
-    it 'retrieves the user and returns their information in Struct form' do
-      oauth_token = 'c7eda20ff7b2554c0bed2ad596ac5dfeb33124e1'
-      response = Synapsis::User.view(oauth_token)
+  describe '.view' do
+    context 'happy path' do
+      it 'retrieves the user and returns their information in Struct form' do
+        oauth_token = 'c7eda20ff7b2554c0bed2ad596ac5dfeb33124e1'
+        response = Synapsis::User.view(oauth_token)
 
-      user_attributes = [:accept_gratuity, :balance, :email, :fullname, :has_avatar, :phone_number, :resource_uri, :seller_details, :user_id, :username, :visit_count, :visit_message]
+        user_attributes = [:accept_gratuity, :balance, :email, :fullname, :has_avatar, :phone_number, :seller_details, :user_id, :username, :visit_count, :visit_message]
 
-      user_attributes.each do |user_attribute|
-        expect(response.send(user_attribute)).not_to be_nil
+        user_attributes.each do |user_attribute|
+          expect(response.user.send(user_attribute)).not_to be_nil
+        end
       end
     end
-  end
-
-  describe 'infrastructure' do
-    it 'builds' do
-      result = '{"email":"test5@synapsepay.com","fullname":"Test Account","ip_address":"11.111.11.11","phonenumber":"123456789","client_id":"ce65d5ce9116ae4c77bb","client_secret":"41877da204b32dbee3095033069ed81bcf512154"}'
-
-      parsed_result = JSON.parse(result)
-
-      user_params = {
-        email: 'test5@synapsepay.com',
-        fullname: 'Test Account',
-        ip_address: '11.111.11.11',
-        phonenumber: '123456789'
-      }
 
-      built = JSON.parse(Synapsis::User.new(user_params).build_json_from_params)
+    context 'error' do
+      it ' raises an Error' do
+        oauth_token = 'WRONG!!!'
 
-      user_params.each do |k, v|
-        expect(built[k]).to eq(parsed_result[k])
+        expect { Synapsis::User.view(oauth_token) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')
       end
     end
   end

data/spec/synapsis/withdrawal_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+RSpec.describe Synapsis::Withdrawal do
+  context '#add' do
+    let!(:withdrawal_params) {{
+      amount: 100,
+      oauth_consumer_key: '3bdb5790692d06983d8cb0feb40365886631e52d',
+      bank_id: 2182
+    }}
+
+    context 'happy path' do
+      it 'constructs the correct Withdrawal object' do
+        withdrawal_response = Synapsis::Withdrawal.create(withdrawal_params)
+
+        WITHDRAWAL_SPECIFIC_PARAMS = ['amount', 'bank', 'date_created', 'fee', 'id', 'instant_credit', 'resource_uri', 'status', 'status_url', 'user_id']
+
+        (WITHDRAWAL_SPECIFIC_PARAMS - ['status_url']).each do |x|
+          expect(withdrawal_response.withdrawal.send(x.to_s.gsub('@', ''))).not_to be_nil
+        end
+      end
+    end
+
+    context 'errors' do
+      it 'create a Synapsis::Error object' do
+        # Missing amount
+        expect { Synapsis::Withdrawal.create(withdrawal_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('Missing amount')
+
+        # OAuth error
+        expect { Synapsis::Withdrawal.create(withdrawal_params.merge(oauth_consumer_key: 'WRONG!!!')) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')
+
+        # Wrong bank ID (user does not own bank_id 1)
+        expect{ Synapsis::Withdrawal.create(withdrawal_params.merge(bank_id: 1))}.to raise_error(Synapsis::Error).with_message('Bank account not associated with the user')
+      end
+    end
+  end
+
+  context '#view' do
+    context 'no ID' do
+      let!(:withdrawal_params) {{
+        oauth_consumer_key: '3bdb5790692d06983d8cb0feb40365886631e52d'
+      }}
+
+      context 'happy path' do
+        xit 'returns an array of the user\'s withdrawals' do
+          all_withdrawals = Synapsis::Withdrawal.view(withdrawal_params)
+        end
+      end
+    end
+
+    context 'with ID' do
+      let!(:withdrawal_params) {{
+        id: 354,
+        oauth_consumer_key: '3bdb5790692d06983d8cb0feb40365886631e52d'
+      }}
+
+      context 'happy path' do
+        xit 'returns an array of the user\'s withdrawals' do
+          pending
+        end
+      end
+    end
+  end
+end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synapsis
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Daryll Santos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-05 00:00:00.000000000 Z
+date: 2015-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -109,19 +109,30 @@ files:
 - README.md
 - Rakefile
 - lib/synapsis.rb
+- lib/synapsis/api_operations/create.rb
+- lib/synapsis/api_operations/edit.rb
+- lib/synapsis/api_operations/view.rb
+- lib/synapsis/api_resource.rb
 - lib/synapsis/authentication.rb
 - lib/synapsis/bank.rb
+- lib/synapsis/deposit.rb
 - lib/synapsis/error.rb
+- lib/synapsis/order.rb
 - lib/synapsis/user.rb
 - lib/synapsis/utilities.rb
 - lib/synapsis/version.rb
+- lib/synapsis/withdrawal.rb
 - spec/config.yml
 - spec/spec_helper.rb
 - spec/support/json_helpers.rb
+- spec/synapsis/api_resource_spec.rb
 - spec/synapsis/authentication_spec.rb
 - spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
+- spec/synapsis/deposit_spec.rb
+- spec/synapsis/order_spec.rb
 - spec/synapsis/user_spec.rb
+- spec/synapsis/withdrawal_spec.rb
 - synapsis.gemspec
 homepage: ''
 licenses:
@@ -151,7 +162,11 @@ test_files:
 - spec/config.yml
 - spec/spec_helper.rb
 - spec/support/json_helpers.rb
+- spec/synapsis/api_resource_spec.rb
 - spec/synapsis/authentication_spec.rb
 - spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
+- spec/synapsis/deposit_spec.rb
+- spec/synapsis/order_spec.rb
 - spec/synapsis/user_spec.rb
+- spec/synapsis/withdrawal_spec.rb