synapsis 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 39515f4c9f57097c0b5f9d4e097f07380e8b4bff
-  data.tar.gz: d4b8e0bc134bbdf006bf33a867bfd15476dcc1b9
+  metadata.gz: f053fe7ebb33a87d6481ae87b43a22afb95034cb
+  data.tar.gz: c56bb4477c91d0b0798e9973986a2bb33156e8ea
 SHA512:
-  metadata.gz: 29d082c48d52b647aad48c9e9a5ea6f5eb6e827fff3a6a15b0521393b83d7370ea5af39e220a1dd7417f9355e637eeea96c52a1546ddf3cd115606b736fe7543
-  data.tar.gz: 716e68aa24fd729df6e7855d05578c885595c11099438feb786fe21a7beab62a9c818e0ed90e15d702cbb9428d67e040c4353318cd0a9cdb41ab77b246c9d42d
+  metadata.gz: 4b4f36ac061188c9a2e1ce644c31dc2808d833ec9e63bce24c4510d29f2a54ef4b2201472bacd954f0b8456b9642409959555aef3f13a660e0c788ed468f5f3f
+  data.tar.gz: a85cbd37d511f08fff1c0116366ee9107649ff85610137248a4a96757b8758437b54513f09679a6db9c1cac8a634624af6a3e46b1a99ee447d70257e86c9ff1c

data/lib/synapsis/bank.rb

@@ -64,18 +64,33 @@ class Synapsis::Bank
       req.body = build_json_from_variable_hash
     end
 
-    @access_token = JSON.parse(partially_linked_bank.body)['response']['access_token']
+    parsed_partially_linked_bank = JSON.parse(partially_linked_bank.body)
 
-    new_bank =  Synapsis.connection.post do |req|
-      req.headers['Content-Type'] = 'application/json'
-      req.url "#{API_V2_PATH}bank/mfa/?is_dev=yes"
-      req.body = build_json_from_variable_hash
-    end
+    if parsed_partially_linked_bank['success']
+      if parsed_partially_linked_bank['banks'] # This happens if the added bank has no MFA
+        return Synapsis::RetrievedBank.new(partially_linked_bank)
+      end
 
-    if JSON.parse(new_bank.body)['success']
-      Synapsis::RetrievedBank.new(new_bank)
+      @access_token = parsed_partially_linked_bank['response']['access_token']
+
+      new_bank =  Synapsis.connection.post do |req|
+        req.headers['Content-Type'] = 'application/json'
+        req.url "#{API_V2_PATH}bank/mfa/?is_dev=yes"
+        req.body = build_json_from_variable_hash
+      end
+
+      if JSON.parse(new_bank.body)['banks']
+        Synapsis::RetrievedBank.new(new_bank)
+      else
+        Synapsis::Error.new({
+          "reason" => "Wrong MFA answer."
+        })
+      end
     else
-      Synapsis::Error.new(JSON.parse(new_bank.body))
+      # API response is different so we parse the API response to get the message we need
+      Synapsis::Error.new({
+        "reason" => JSON.parse(partially_linked_bank.body)['message']
+      })
     end
   end
 

data/lib/synapsis/version.rb

@@ -1,3 +1,3 @@
 module Synapsis
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/synapsis/bank_link_spec.rb

@@ -0,0 +1,252 @@
+require 'spec_helper'
+
+RSpec.describe Synapsis::Bank do
+  context '#link' do
+    let(:user_params) { {
+      email: Faker::Internet.email,
+      fullname: Faker::Name.name,
+      phonenumber: Faker::PhoneNumber.phone_number,
+      password: '5ourcep4d',
+      ip_address: '8.8.8.8'
+    }}
+
+    context 'question-based MFA' do
+      context 'happy path' do
+        it 'adds a bank account' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_good',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'PNC',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.name_on_account).to eq user_params[:fullname]
+          expect(new_bank.bank_name).to eq bank_params[:bank]
+        end
+      end
+
+      context 'errors' do
+        it 'bad username returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'WRONG USERNAME',
+            password: 'test1234',
+            pin: '1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Regions North Carolina',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad password returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_good',
+            password: 'WRONG PASSWORD',
+            pin: '1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'US Bank',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad mfa answer returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_good',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Regions Kentucky',
+            mfa: 'WRONG MFA ANSWER'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        xit 'bad PIN returns a SynapsisError--pending since trying test data with a wrong PIN still completes the linking process' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_good',
+            password: 'test1234',
+            pin: 'WRONG PIN',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'USAA',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+      end
+    end
+
+    context 'code-based MFA' do
+      it 'adds a bank account' do
+        new_user = Synapsis::User.create(user_params)
+
+        bank_params = {
+          username: 'synapse_code',
+          password: 'test1234',
+          oauth_consumer_key: new_user.access_token,
+          bank: 'Ally',
+          mfa: 'test_answer'
+        }
+
+        new_bank = Synapsis::Bank.link(bank_params)
+
+        expect(new_bank.name_on_account).to eq user_params[:fullname]
+        expect(new_bank.bank_name).to eq bank_params[:bank]
+      end
+
+      context 'errors' do
+        it 'bad username returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'WRONG USERNAME',
+            password: 'test1234',
+            pin: '1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Ally',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad password returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_code',
+            password: 'WRONG PASSWORD',
+            pin: '1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Ally',
+            mfa: 'test_answer'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad mfa answer returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_code',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Chase',
+            mfa: 'WRONG MFA ANSWER'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+      end
+    end
+
+    context 'no MFA' do
+      context 'happy path' do
+        it 'adds a bank account' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_nomfa',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Capital One 360'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.name_on_account).to eq user_params[:fullname]
+          expect(new_bank.bank_name).to eq bank_params[:bank]
+        end
+      end
+
+      context 'errors' do
+        it 'bad username returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'WRONG USERNAME',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Capital One 360'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad password returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapsenomfa',
+            password: 'test12345',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Capital One 360'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+
+        it 'bad mfa answer returns a SynapsisError' do
+          new_user = Synapsis::User.create(user_params)
+
+          bank_params = {
+            username: 'synapse_good',
+            password: 'test1234',
+            oauth_consumer_key: new_user.access_token,
+            bank: 'Regions Kentucky',
+            mfa: 'WRONG MFA ANSWER'
+          }
+
+          new_bank = Synapsis::Bank.link(bank_params)
+
+          expect(new_bank.class).to eq Synapsis::Error
+          expect(new_bank.reason).to be_a_kind_of String
+        end
+      end
+    end
+  end
+end

data/spec/synapsis/bank_spec.rb

@@ -36,7 +36,6 @@ RSpec.describe Synapsis::Bank do
 
       new_bank = Synapsis::Bank.add(bank_params)
 
-      expect(new_bank.is_active).to eq true
       expect(new_bank.name_on_account).to eq user_params[:fullname]
       expect(new_bank.nickname).to eq bank_params[:nickname]
     end
@@ -70,35 +69,6 @@ RSpec.describe Synapsis::Bank do
     end
   end
 
-  context '#link' do
-    it 'adds a bank account' do
-      user_params = {
-        email: Faker::Internet.email,
-        fullname: Faker::Name.name,
-        phonenumber: Faker::PhoneNumber.phone_number,
-        password: '5ourcep4d',
-        ip_address: '8.8.8.8'
-      }
-
-      new_user = Synapsis::User.create(user_params)
-
-      bank_params = {
-        username: 'synapse_good',
-        password: 'test1234',
-        pin: '1234',
-        oauth_consumer_key: new_user.access_token,
-        bank: 'Wells Fargo',
-        mfa: 'test_answer'
-      }
-
-      new_bank = Synapsis::Bank.link(bank_params)
-
-      expect(new_bank.is_active).to eq true
-      expect(new_bank.name_on_account).to eq user_params[:fullname]
-      expect(new_bank.bank_name).to eq bank_params[:bank]
-    end
-  end
-
   context '#remove' do
     it 'removes the bank' do
       user_params = {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synapsis
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Daryll Santos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-29 00:00:00.000000000 Z
+date: 2015-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -119,6 +119,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/json_helpers.rb
 - spec/synapsis/authentication_spec.rb
+- spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
 - spec/synapsis/user_spec.rb
 - synapsis.gemspec
@@ -151,5 +152,6 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/json_helpers.rb
 - spec/synapsis/authentication_spec.rb
+- spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
 - spec/synapsis/user_spec.rb