synapsis 0.0.10 → 0.0.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2d5b2bf26eef6d006fecce9cb62a93ea6eefd89a
-  data.tar.gz: 6b7f9dcfbc6811b14e3f0e0c4250bac5286fb136
+  metadata.gz: 88f25f31c347b1d5e1315a53f5f8b988bf36300d
+  data.tar.gz: e057d3fa66b160ec82b589cdc38375a1d5810d45
 SHA512:
-  metadata.gz: 56699c37e591ed8a71d3f12bfb8214ee5e1d5d3310590463085aa914ceb492d4533743ea8eb3f9dafb69824c805c23b089ae31734eb3b94fcce8b5504e1a80a0
-  data.tar.gz: 9829b32bdfa1e7f552730844e7967770bcc3ef9cccaa9452e9449192f573e561ca317a5fcfe02dc11b9abfd1974607d89eac7211fcabb693ebb97f72fb6d85ae
+  metadata.gz: d9236da172a713aa0c8aa9b70db0f711ef28230fa9d8ea2368010ade8239410534991af783c2dbac156db68d46b11dcee81b3ac2049e55eb1037d5012d982510
+  data.tar.gz: c85014c085f84d63811d1d286b9612f84077c7b92f696c11636f34b4350b435a053040bf3531eba70970b1cf093440de16a3fd4ac82f7d4c62e90646277bdda8

data/.gitignore

@@ -1,3 +1,4 @@
+.ruby-version
 /spec/config.yml
 /.bundle/
 /.yardoc

data/lib/synapsis/bank.rb

@@ -1,5 +1,4 @@
 class Synapsis::Bank < Synapsis::APIResource
-  include Synapsis::Utilities
   extend Synapsis::APIOperations::Create
   extend Synapsis::APIOperations::View
 
@@ -38,7 +37,6 @@ class Synapsis::Bank < Synapsis::APIResource
     return_response(added_bank)
   end
 
-
   def self.link(params)
     partially_linked_bank = request(:post, bank_link_url, params)
     parsed_partially_linked_bank = parse_as_synapse_resource(partially_linked_bank)
@@ -78,6 +76,18 @@ class Synapsis::Bank < Synapsis::APIResource
     return_response(response)
   end
 
+  # By default, the first added bank account is the primary one. If you add another bank it will not be set as the primary one unless it was deleted.
+  # When a bank account is deleted, if it was the primary bank account, the next bank account chronologically added will be set as the primary one.
+  def self.set_as_primary(bank_id:, oauth_consumer_key:)
+    params = {
+      bank_id: bank_id,
+      oauth_consumer_key: oauth_consumer_key
+    }
+
+    response = request(:post, set_bank_as_primary_url, params)
+    return_response(response)
+  end
+
   private
 
   def self.bank_link_url
@@ -88,7 +98,11 @@ class Synapsis::Bank < Synapsis::APIResource
     "#{API_V2_PATH}bank/mfa/?is_dev=yes"
   end
 
+  def self.set_bank_as_primary_url
+    "#{API_V2_PATH}bank/setprimary"
+  end
+
   def self.bank_delete_url
-    "#{API_V2_PATH}bank/delete/"
+    "#{API_V2_PATH}bank/delete"
   end
 end

data/lib/synapsis/deposit.rb

@@ -1,10 +1,10 @@
 class Synapsis::Deposit < Synapsis::APIResource
-  include Synapsis::Utilities
   extend Synapsis::APIOperations::Create
 
+  # amount, bank_id, oauth_consumer_key
+  # amount must be supplied using a string
   def self.create(params)
     response = create_request(params)
-
     return_response(response)
   end
 end

data/lib/synapsis/order.rb

@@ -1,5 +1,4 @@
 class Synapsis::Order < Synapsis::APIResource
-  include Synapsis::Utilities
   extend Synapsis::APIOperations::Create
 
   module Status

data/lib/synapsis/user.rb

@@ -1,5 +1,4 @@
 class Synapsis::User < Synapsis::APIResource
-  include Synapsis::Utilities
   extend Synapsis::APIOperations::Create
   extend Synapsis::APIOperations::Edit
   extend Synapsis::APIOperations::View
@@ -19,6 +18,11 @@ class Synapsis::User < Synapsis::APIResource
     return_response(response)
   end
 
+  def self.refresh(params)
+    response = request(:post, refresh_url, params.merge(client_credentials))
+    return_response(response)
+  end
+
   def self.view_linked_banks(oauth_token)
     Synapsis::Bank.view_linked_banks(oauth_token)
   end
@@ -35,5 +39,9 @@ class Synapsis::User < Synapsis::APIResource
   def self.create_url
     "#{API_V2_PATH}user/create/"
   end
+
+  def self.refresh_url
+    "#{API_V2_PATH}user/refresh"
+  end
 end
 

data/lib/synapsis/version.rb

@@ -1,3 +1,3 @@
 module Synapsis
-  VERSION = "0.0.10"
+  VERSION = "0.0.11"
 end

data/lib/synapsis/withdrawal.rb

@@ -1,5 +1,4 @@
 class Synapsis::Withdrawal < Synapsis::APIResource
-  include Synapsis::Utilities
   extend Synapsis::APIOperations::Create
   extend Synapsis::APIOperations::View
 

data/lib/synapsis.rb

@@ -9,12 +9,10 @@ end
 
 # Internal dependencies
 require "synapsis/version"
-require "synapsis/utilities"
 require "synapsis/api_resource"
 require "synapsis/api_operations/create"
 require "synapsis/api_operations/edit"
 require "synapsis/api_operations/view"
-require "synapsis/authentication"
 require "synapsis/user"
 require "synapsis/bank"
 require "synapsis/withdrawal"

data/spec/spec_helper.rb

@@ -19,5 +19,4 @@ end
 
 RSpec.configure do |config|
   config.order = 'random'
-  config.include JsonHelpers
 end

data/spec/support/routing_number_helpers.rb

@@ -0,0 +1,7 @@
+def get_random_routing_number
+  # Taken from: https://www.usbank.com/checking/aba-routing-number.html, we cannot just generate random numbers as the tests have a tendency to fail
+  sample_routing_numbers = ['122105155', '082000549', '121122676', '122235821', '102101645', '102000021', '123103729']
+
+  sample_routing_numbers.sample
+end
+

data/spec/synapsis/bank_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe Synapsis::Bank do
     end
   end
 
-  context '#add/ #remove' do
+  context '.add/#remove' do
     it 'adds and removes a bank account' do
       random_persons_access_token = 'dcd234d9d9fb55ad9711c4c41e254868ef3768d4'
 
@@ -61,4 +61,38 @@ RSpec.describe Synapsis::Bank do
       expect { Synapsis::Bank.add(bank_params) }.to raise_error(Synapsis::Error).with_message('Because of security reasons you can only add a bank account that belongs to you and is in your name.')
     end
   end
+
+  context '.set_primary' do
+    context 'happy path' do
+      it 'sets the bank as a primary bank' do
+        user_params = {
+          email: Faker::Internet.email,
+          fullname: Faker::Name.name,
+          phonenumber: Faker::PhoneNumber.phone_number,
+          password: '5ourcep4d',
+          ip_address: '8.8.8.8'
+        }
+
+        new_user_response = Synapsis::User.create(user_params)
+
+        bank_params = {
+          fullname: user_params[:fullname],
+          account_num: '1111111112',
+          routing_num: '121000358',
+          nickname: 'Sourcepad Bank',
+          oauth_consumer_key: new_user_response.access_token,
+          account_type: Synapsis::Bank::AccountType::CHECKING,
+          account_class: Synapsis::Bank::AccountClass::PERSONAL
+        }
+
+        first_bank_response = Synapsis::Bank.add(bank_params)
+        second_bank_response = Synapsis::Bank.add(bank_params)
+        third_bank_response = Synapsis::Bank.add(bank_params)
+
+        set_bank_primary_response = Synapsis::Bank.set_as_primary(bank_id: second_bank_response.bank.id, oauth_consumer_key: new_user_response.access_token)
+
+        expect(set_bank_primary_response.success).to be_truthy
+      end
+    end
+  end
 end

data/spec/synapsis/card_spec.rb

@@ -48,7 +48,7 @@ RSpec.describe Synapsis::Card do
       id: 483,
       legal_name: Faker::Name.name,
       account_number: "11111111#{rand(1..9)}#{rand(1..9)}",
-      routing_number: "1210003#{rand(1..9)}#{rand(1..9)}",
+      routing_number: get_random_routing_number,
       account_class: rand(1..2),
       account_type: rand(1..2)
     }}
@@ -76,7 +76,10 @@ RSpec.describe Synapsis::Card do
         expect { Synapsis::Card.edit(edit_card_params.merge(id: 5)) }.to raise_error(Synapsis::Error).with_message('Card not found')
 
         # Wrong account class
-        expect { Synapsis::Card.edit(edit_card_params.merge(account_class: 'WRONG')) }.to raise_error(Synapsis::Error).with_message('Sorry, this request could not be processed. Please try again later.')
+        expect { Synapsis::Card.edit(edit_card_params.merge(account_class: 'WRONG')) }.to raise_error(Synapsis::Error).with_message('account_class not supplied or incorrectly formatted')
+
+        # Wrong account type
+        expect { Synapsis::Card.edit(edit_card_params.merge(account_type: 'WRONG')) }.to raise_error(Synapsis::Error).with_message('account_type not supplied or incorrectly formatted')
       end
 
       xit 'doesn\'t raise errors on invalid account numbers and routing numbers' do

data/spec/synapsis/deposit_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 RSpec.describe Synapsis::Deposit do
   context '#add' do
     let!(:deposit_params) {{
-      amount: 100,
+      amount: "100",
       oauth_consumer_key: '3bdb5790692d06983d8cb0feb40365886631e52d',
       bank_id: 2182
     }}
@@ -29,7 +29,10 @@ RSpec.describe Synapsis::Deposit do
     context 'errors' do
       it 'create a Synapsis::Error object' do
         # Missing amount
-        expect { Synapsis::Deposit.create(deposit_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('Missing amount')
+        expect { Synapsis::Deposit.create(deposit_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('amount not supplied or incorrectly formatted')
+
+        # Missing amount
+        expect { Synapsis::Deposit.create(deposit_params.merge(amount: 0)) }.to raise_error(Synapsis::Error).with_message('amount not supplied or incorrectly formatted')
 
         # OAuth error
         expect { Synapsis::Deposit.create(deposit_params.merge(oauth_consumer_key: 'WRONG!!!')) }.to raise_error(Synapsis::Error).with_message('Error in OAuth Authentication.')

data/spec/synapsis/mass_pay_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Synapsis::MassPay do
       let!(:mass_pay_hash) {{
         legal_name: 'Test Person',
         account_number: '1111111112',
-        routing_number: '121000358',
+        routing_number: get_random_routing_number,
         amount: 1,
         trans_type: 0,
         account_class: 1,
@@ -18,7 +18,7 @@ RSpec.describe Synapsis::MassPay do
       let!(:mass_pay_hash2) {{
         legal_name: 'Test Person2',
         account_number: '1111111112',
-        routing_number: '121000359',
+        routing_number: get_random_routing_number,
         amount: 1,
         trans_type: 0,
         account_class: 1,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: synapsis
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Daryll Santos
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-19 00:00:00.000000000 Z
+date: 2015-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -113,7 +113,6 @@ files:
 - lib/synapsis/api_operations/edit.rb
 - lib/synapsis/api_operations/view.rb
 - lib/synapsis/api_resource.rb
-- lib/synapsis/authentication.rb
 - lib/synapsis/bank.rb
 - lib/synapsis/bank_status.rb
 - lib/synapsis/card.rb
@@ -122,14 +121,12 @@ files:
 - lib/synapsis/mass_pay.rb
 - lib/synapsis/order.rb
 - lib/synapsis/user.rb
-- lib/synapsis/utilities.rb
 - lib/synapsis/version.rb
 - lib/synapsis/withdrawal.rb
 - spec/config.yml
 - spec/spec_helper.rb
-- spec/support/json_helpers.rb
+- spec/support/routing_number_helpers.rb
 - spec/synapsis/api_resource_spec.rb
-- spec/synapsis/authentication_spec.rb
 - spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
 - spec/synapsis/bank_status_spec.rb
@@ -160,16 +157,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
 summary: Ruby wrapper to the SynapsePay API
 test_files:
 - spec/config.yml
 - spec/spec_helper.rb
-- spec/support/json_helpers.rb
+- spec/support/routing_number_helpers.rb
 - spec/synapsis/api_resource_spec.rb
-- spec/synapsis/authentication_spec.rb
 - spec/synapsis/bank_link_spec.rb
 - spec/synapsis/bank_spec.rb
 - spec/synapsis/bank_status_spec.rb

data/lib/synapsis/authentication.rb

@@ -1,25 +0,0 @@
-class Synapsis::Authentication
-  include Synapsis::Utilities
-
-  attr_accessor :username, :password, :grant_type, :scope
-
-  def self.login(params)
-    self.new(params).login
-  end
-
-  def initialize(params)
-    params.each do |k, v|
-      send("#{k}=", v)
-    end
-
-    @grant_type = 'password'
-    @scope = 'write'
-  end
-
-  def login
-    Synapsis.connection.post do |req|
-      req.url 'oauth2/access_token'
-      req.body = build_params_from_string
-    end
-  end
-end

data/lib/synapsis/utilities.rb

@@ -1,30 +0,0 @@
-require 'json'
-
-module Synapsis::Utilities
-  def build_json_from_params
-    JSON.generate(to_hash.merge(client_credentials))
-  end
-
-  def build_json_from_variable_hash
-    JSON.generate(to_hash)
-  end
-
-  def to_hash
-    instance_variables.map do |ivar|
-      [ivar[1..-1], instance_variable_get(ivar)]
-    end.to_h
-  end
-
-  def build_params_from_string
-    to_hash.merge(client_credentials).map { |k, v| "#{k}=#{v}" }.join("&")
-  end
-
-  private
-
-  def client_credentials
-    {
-      client_id: Synapsis.client_id,
-      client_secret: Synapsis.client_secret
-    }
-  end
-end

data/spec/support/json_helpers.rb

@@ -1,6 +0,0 @@
-module JsonHelpers
-  def json_response(response)
-    JSON.parse(response.body)
-  end
-end
-

data/spec/synapsis/authentication_spec.rb

@@ -1,15 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe Synapsis::Authentication do
-  it 'connects' do
-    authentication_params = {
-      username: 'b84b8c816c0541f09ea9fbd7c5d8e4',
-      password: '5ourcep4d'
-    }
-
-    response = Synapsis::Authentication.login(authentication_params)
-
-    expect(JSON.parse(response.body)['access_token']).to be_truthy
-    expect(JSON.parse(response.body)['token_type']).to eq 'Bearer'
-  end
-end