svg_conform 0.1.11 → 0.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9300ab0026e52b929e0707e14c19ce45394da831dfd5e44f4afad14e1a2237cd
-  data.tar.gz: b19b0d2dbce1397abb478105704c994a32f418972240c9c149d375d8be519e2c
+  metadata.gz: 162ed406493cfabb9a3cb94a3a6ba2ee3ed4ae95d3edf912034c17974d5cc496
+  data.tar.gz: 56cb8b2d5e94bcce3cc1e32b513a738ac2140f0e86848e6c101fc08ed16cfc7a
 SHA512:
-  metadata.gz: d413baac7ebb781837ff482103d751ce3222c170c613707b8411d5c6614dff71ac874802e0e5df14e276c0d56f537d32259787559359dfb954f6e3392088102d
-  data.tar.gz: ca1a62500f77534fca87d5b0e0136328ed81b9d9a7a81510e312a3760f31157e7a42af4934bacda3af2d6915b675bb9f4afdba2746332922cb23351bcc47fba2
+  metadata.gz: 1bcbdf1a7dbc43f044aa875d7a310b85064bcd47d5f227cf962303d1f3a0d024fe926b87ffc201fbf5256b0e150cfa71b5a8702e84b062b37d7935a50bc96b5b
+  data.tar.gz: 817c9ac5561b509c39e9f4d228b4165d3943a242bb83a88c77e8388bbce99c6746dc9c9df464a729ce44160c331b08ce9dfcc06e98c676c2944631eaf35346e5

data/.github/workflows/release.yml

@@ -5,6 +5,7 @@ name: release
 permissions:
   contents: write
   packages: write
+  id-token: write
 
 on:
   workflow_dispatch:

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-01-27 00:27:35 UTC using RuboCop version 1.82.1.
+# on 2026-04-04 08:57:24 UTC using RuboCop version 1.86.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,11 +8,9 @@
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/ArgumentAlignment:
+Gemspec/RequireMFA:
   Exclude:
-    - 'lib/svg_conform/requirements/invalid_id_references_requirement.rb'
+    - 'svg_conform.gemspec'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -24,28 +22,42 @@ Layout/BlockAlignment:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/HashAlignment:
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: leading, trailing
+Layout/LineContinuationLeadingSpace:
   Exclude:
-    - 'spec/svg_conform/validation_context_spec.rb'
+    - 'spec/svgcheck_compatibility_spec.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: aligned, indented
+Layout/LineEndStringConcatenationIndentation:
+  Exclude:
+    - 'lib/svg_conform/external_checkers/svgcheck/validation_pipeline.rb'
+    - 'spec/svgcheck_compatibility_spec.rb'
 
-# Offense count: 662
+# Offense count: 649
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Enabled: false
 
-# Offense count: 2
+# Offense count: 13
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
+Lint/AmbiguousOperatorPrecedence:
   Exclude:
-    - 'lib/svg_conform/requirements/invalid_id_references_requirement.rb'
-    - 'spec/svg_conform/validation_context_spec.rb'
+    - 'lib/svg_conform/compatibility_analyzer.rb'
+    - 'lib/svg_conform/semantic_comparator.rb'
+    - 'lib/svg_conform/validation_result.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: RequireParenthesesForMethodChains.
+Lint/AmbiguousRange:
+  Exclude:
+    - 'lib/svg_conform/compatibility/report_formatter.rb'
 
 # Offense count: 3
 # Configuration parameters: AllowedMethods.
@@ -73,10 +85,11 @@ Lint/DuplicateCaseCondition:
   Exclude:
     - 'lib/svg_conform/semantic_comparator.rb'
 
-# Offense count: 1
+# Offense count: 2
 Lint/DuplicateMethods:
   Exclude:
     - 'lib/svg_conform/sax_validation_handler.rb'
+    - 'spec/svg_conform/validation_context_spec.rb'
 
 # Offense count: 2
 Lint/HashCompareByIdentity:
@@ -92,11 +105,18 @@ Lint/MissingSuper:
     - 'lib/svg_conform/sax_validation_handler.rb'
 
 # Offense count: 1
-Lint/UnreachableCode:
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/RedundantDirGlobSort:
   Exclude:
-    - 'lib/svg_conform/commands/check.rb'
+    - 'lib/tasks/fixtures.rake'
 
-# Offense count: 146
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/SuppressedExceptionInNumberConversion:
+  Exclude:
+    - 'lib/svg_conform/remediations/viewbox_remediation.rb'
+
+# Offense count: 145
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Enabled: false
@@ -117,7 +137,7 @@ Metrics/BlockNesting:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Offense count: 259
+# Offense count: 256
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 154
@@ -132,6 +152,18 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Enabled: false
 
+# Offense count: 9
+# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
+# AllowedMethods: call
+# WaywardPredicates: infinite?, nonzero?
+Naming/PredicateMethod:
+  Exclude:
+    - 'lib/svg_conform/compatibility/file_processor.rb'
+    - 'lib/svg_conform/node_helpers.rb'
+    - 'lib/svg_conform/remediations/base_remediation.rb'
+    - 'lib/svg_conform/requirements/style_requirement.rb'
+    - 'lib/svg_conform/semantic_comparator.rb'
+
 # Offense count: 2
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
@@ -139,6 +171,12 @@ Performance/CollectionLiteralInLoop:
     - 'lib/svg_conform/batch_report.rb'
     - 'lib/svg_conform/compatibility/pattern_discovery.rb'
 
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/MapCompact:
+  Exclude:
+    - 'lib/svg_conform/remediations/viewbox_remediation.rb'
+
 # Offense count: 9
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
@@ -168,6 +206,11 @@ RSpec/LeakyConstantDeclaration:
   Exclude:
     - 'spec/svg_conform/profiles/svg_1_2_rfc_profile_spec.rb'
 
+# Offense count: 1
+RSpec/LeakyLocalVariable:
+  Exclude:
+    - 'spec/svgcheck_compatibility_spec.rb'
+
 # Offense count: 2
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
@@ -183,11 +226,22 @@ RSpec/MultipleDescribes:
 RSpec/MultipleExpectations:
   Max: 8
 
+# Offense count: 44
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/Output:
+  Enabled: false
+
 # Offense count: 1
 Rake/MethodDefinitionInTask:
   Exclude:
     - 'lib/tasks/svgcheck.rake'
 
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Style/ComparableClamp:
+  Exclude:
+    - 'lib/svg_conform/css_color.rb'
+
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, AllowComments.
@@ -205,9 +259,28 @@ Style/FormatStringToken:
   EnforcedStyle: unannotated
 
 # Offense count: 1
-Style/MissingRespondToMissing:
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowSplatArgument.
+Style/HashConversion:
+  Exclude:
+    - 'lib/svg_conform/sax_validation_handler.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/HashSlice:
   Exclude:
-    - 'lib/svg_conform/cli.rb'
+    - 'spec/svg_conform_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowedClasses.
+Style/OneClassPerFile:
+  Exclude:
+    - 'lib/svg_conform/compatibility/report_formatter.rb'
+
+# Offense count: 1
+Style/OpenStructUse:
+  Exclude:
+    - 'lib/svg_conform/validator.rb'
 
 # Offense count: 4
 # Configuration parameters: AllowedMethods.
@@ -216,10 +289,46 @@ Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/svg_conform/semantic_comparator.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/PartitionInsteadOfDoubleSelect:
+  Exclude:
+    - 'lib/svg_conform/requirements/style_requirement.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/ReduceToHash:
+  Exclude:
+    - 'lib/svg_conform/requirements/base_requirement.rb'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedMethods.
-# AllowedMethods: nonzero?
+# AllowedMethods: infinite?, nonzero?
 Style/RedundantCondition:
   Exclude:
     - 'lib/svg_conform/external_checkers/svgcheck/parser.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/RedundantFormat:
+  Exclude:
+    - 'lib/svg_conform/compatibility/report_formatter.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/SelectByKind:
+  Exclude:
+    - 'lib/svg_conform/sax_validation_handler.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/SelectByRegexp:
+  Exclude:
+    - 'lib/svg_conform/remediations/color_remediation.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/SuperArguments:
+  Exclude:
+    - 'lib/svg_conform/requirements/invalid_id_references_requirement.rb'

data/CLAUDE.md

@@ -0,0 +1,115 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Build/Test Commands
+
+```bash
+# Install dependencies
+bin/setup
+
+# Run tests
+rake spec
+
+# Run a single spec file
+bundle exec rspec spec/svg_conform/validator_spec.rb
+
+# Run tests with detailed output
+bundle exec rspec --format documentation
+
+# Run linting
+rake rubocop
+
+# Run both tests and linting
+rake
+
+# Run a specific test by line number
+bundle exec rspec spec/svg_conform/validator_spec.rb:42
+```
+
+## Architecture
+
+### Two-Mode Validation System
+
+SvgConform uses two distinct operating modes:
+
+1. **SAX Validation Mode** (always used for validation):
+   - Memory-safe streaming XML parser
+   - Constant memory regardless of file size
+   - Handles files of any size (tested with 100MB+)
+   - Read-only, cannot modify documents
+   - Implemented via `SaxDocument` and `SaxValidationHandler`
+
+2. **DOM Remediation Mode** (only when applying fixes):
+   - Full document tree loaded in memory
+   - XPath queries and tree modification
+   - Memory scales with file size
+   - Only activated when `fix: true` is specified
+
+### Core Classes
+
+- `Validator` - Main entry point; normalizes all inputs to SAX validation
+- `SaxDocument` - SAX-based document wrapper for memory-safe validation
+- `Document` - DOM-based document wrapper for modifications
+- `Profile` - Collection of requirements and remediations; loaded from YAML
+- `Profiles` - Factory for loading/retrieving profile instances
+- `ValidationContext` - Carries state during validation (errors, data collected)
+- `ValidationResult` - Holds validation outcomes after checking
+- `ConformanceReport` - Formats validation results for output
+
+### Requirements System
+
+Requirements validate SVG documents. All requirements must support SAX validation:
+
+- Requirements inherit from `BaseRequirement` in `lib/svg_conform/requirements/`
+- Must implement `validate_sax_element(element, context)` for immediate checks
+- Can optionally implement `collect_sax_data()` + `validate_sax_complete()` for deferred validation (e.g., cross-reference checks)
+- Use `context.data` hash for per-document state (not instance variables - they leak across validations)
+- Never attempt DOM operations in SAX callbacks
+
+Key requirement classes: `NamespaceRequirement`, `ViewboxRequiredRequirement`, `IdReferenceRequirement`, `ForbiddenContentRequirement`, `ColorRestrictionsRequirement`, etc.
+
+### Remediations System
+
+Remediations fix validation failures. They run in DOM mode:
+
+- Inherit from `BaseRemediation` in `lib/svg_conform/remediations/`
+- Linked to requirements via `targets` array in profile YAML
+- Only execute when `should_execute?(failed_requirements)` returns true
+
+### Profile Configuration
+
+Profiles are defined in YAML under `config/profiles/`:
+- `base.yml` - Common requirements shared by other profiles
+- `metanorma.yml`, `svg_1_2_rfc.yml`, etc. - Specific profile definitions
+- Profile class map is built dynamically from filesystem in `Profile.build_class_map`
+
+Profiles support `import` to inherit from other profiles (e.g., `metanorma` imports `base`).
+
+### CLI Structure
+
+- `lib/svg_conform/cli.rb` - Thor-based CLI entry point
+- `lib/svg_conform/commands/check.rb` - Main validation command
+- `lib/svg_conform/commands/profiles.rb` - Profile listing command
+- `lib/svg_conform/commands/svgcheck.rb` - SVGCheck compatibility subcommands
+
+### Input Handling
+
+The `Validator` accepts multiple input types and always uses SAX:
+- String (XML content) → parsed directly with SAX
+- Moxml/Nokogiri documents → serialized once, then SAX validated
+- Document/Element objects → same serialization approach
+
+This ensures memory safety for large files regardless of input type.
+
+### Key Files
+
+- `lib/svg_conform.rb` - Main require file with autoloads
+- `lib/svg_conform/element_proxy.rb` - Lightweight SAX element representation
+- `lib/svg_conform/validation_context.rb` - Validation state container
+- `lib/svg_conform/sax_document.rb` - SAX document wrapper
+- `lib/svg_conform/sax_validation_handler.rb` - SAX callback handler
+
+### Error Handling Pattern
+
+The CLI uses `exit 1` for error exits. When improving error handling, prefer raising proper Ruby exceptions (`ValidationError`, `ProfileError`, `ArgumentError`) rather than using `exit`/`abort` directly, as Thor provides mechanisms for displaying errors gracefully to users.

data/lib/svg_conform/cli.rb

@@ -11,6 +11,16 @@ require_relative "commands/profiles"
 module SvgConform
   # Thor-based CLI for SvgConform with svgcheck-like functionality
   class Cli < Thor
+    # Exit with non-zero status when a command raises an error
+    def self.exit_on_failure?
+      true
+    end
+
+    # Use strict mode to catch unknown options at parse time rather than runtime
+    def self.check_unknown_options?(*)
+      true
+    end
+
     def initialize(*args)
       super
     end
@@ -95,13 +105,10 @@ module SvgConform
       puts "SvgConform #{SvgConform::VERSION}"
     end
 
-    private
-
-    def method_missing(method_name, *_args)
-      puts Paint["Unknown command: #{method_name}", :red]
-      puts
-      help
-      exit 1
+    # Let Thor handle unknown commands - it raises Thor::UndefinedCommandError
+    # which provides helpful suggestions (e.g., "Did you mean?")
+    def self.handle_unknown_command?(*)
+      false
     end
   end
 end

data/lib/svg_conform/commands/check.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "thor"
 require "paint"
 require "table_tennis"
 require "fileutils"
@@ -9,6 +10,12 @@ module SvgConform
   module Commands
     # Check command for validating SVG files (single or batch)
     class Check
+      # User-facing errors should be Thor::Error for nice CLI display
+      class CheckError < Thor::Error; end
+      class FileNotFoundError < CheckError; end
+      class DirectoryNotFoundError < CheckError; end
+      class NoFilesFoundError < CheckError; end
+
       def initialize(files, options)
         @files = Array(files)
         @options = options
@@ -19,8 +26,7 @@ module SvgConform
         files_to_process = determine_files
 
         if files_to_process.empty?
-          puts Paint["Error: No SVG files found", :red]
-          exit 1
+          raise NoFilesFoundError, "No SVG files found"
         end
 
         # Single file mode vs batch mode
@@ -38,20 +44,17 @@ module SvgConform
           # Directory mode: recursive scan
           dir = @options[:directory]
           unless Dir.exist?(dir)
-            puts Paint["Error: Directory '#{dir}' not found", :red]
-            exit 1
+            raise DirectoryNotFoundError, "Directory '#{dir}' not found"
           end
-          Dir.glob(File.join(dir, "**/*.svg")).sort
+
+          Dir.glob(File.join(dir, "**/*.svg"))
         elsif @files.empty?
-          puts Paint["Error: No files or directory specified", :red]
-          exit 1
-          []
+          raise NoFilesFoundError, "No files or directory specified"
         else
           # File mode: validate each file exists
           @files.each do |file|
             unless File.exist?(file)
-              puts Paint["Error: File '#{file}' not found", :red]
-              exit 1
+              raise FileNotFoundError, "File '#{file}' not found"
             end
           end
           @files
@@ -61,38 +64,33 @@ module SvgConform
       def process_single_file(file)
         @file = file
 
-        begin
-          # Validate the file
-          validator = SvgConform::Validator.new
-          result = validator.validate_file(@file,
-                                           profile: @options[:profile].to_sym)
-
-          # Generate report
-          report = SvgConform::ConformanceReport.from_svg_conform_result(
-            File.basename(@file),
-            result,
-            profile: @options[:profile].to_sym,
-          )
-
-          # Output based on format
-          case @options[:format]
-          when "yaml"
-            output_yaml(report)
-          when "json"
-            output_json(report)
-          else
-            output_table(report)
-          end
+        # Validate the file
+        validator = SvgConform::Validator.new
+        result = validator.validate_file(@file,
+                                         profile: @options[:profile].to_sym)
+
+        # Generate report
+        report = SvgConform::ConformanceReport.from_svg_conform_result(
+          File.basename(@file),
+          result,
+          profile: @options[:profile].to_sym,
+        )
+
+        # Output based on format
+        case @options[:format]
+        when "yaml"
+          output_yaml(report)
+        when "json"
+          output_json(report)
+        else
+          output_table(report)
+        end
 
-          # Create remediated file if requested
-          create_remediated_file(result) if @options[:fix]
+        # Create remediated file if requested
+        create_remediated_file(result) if @options[:fix]
 
-          # Exit with appropriate code
-          exit(report.valid? ? 0 : 1)
-        rescue StandardError => e
-          puts Paint["Error: #{e.message}", :red]
-          exit 1
-        end
+        # Exit with appropriate code based on validation result
+        exit(report.valid? ? 0 : 1)
       end
 
       def output_table(report)
@@ -275,15 +273,13 @@ module SvgConform
 
         # Multiple files require output-dir
         if files.length > 1 && !@options[:output_dir]
-          puts Paint["Error: --output-dir required for multiple files with --fix",
-                     :red]
-          exit 1
+          raise CheckError,
+                "--output-dir required for multiple files with --fix"
         end
 
         # In-place requires force
         if @options[:in_place] && !@options[:force]
-          puts Paint["Error: --in-place requires --force flag for safety", :red]
-          exit 1
+          raise CheckError, "--in-place requires --force flag for safety"
         end
       end
 

data/lib/svg_conform/commands/profiles.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "thor"
 require "paint"
 require "table_tennis"
 
@@ -7,6 +8,8 @@ module SvgConform
   module Commands
     # Profiles command for listing available validation profiles
     class Profiles
+      class ProfilesError < Thor::Error; end
+
       def initialize(options)
         @options = options
         # Paint doesn't need initialization like Pastel
@@ -20,9 +23,6 @@ module SvgConform
         else
           display_profile_list(profiles)
         end
-      rescue StandardError => e
-        puts Paint["Error: #{e.message}", :red]
-        exit 1
       end
 
       private

data/lib/svg_conform/commands/svgcheck_compare.rb

@@ -6,6 +6,8 @@ module SvgConform
   module Commands
     # Compare command for comparing SvgConform validation with svgcheck reports
     class SvgcheckCompare
+      class CompareError < Thor::Error; end
+
       def initialize(file, options)
         @file = file
         @options = options
@@ -17,46 +19,36 @@ module SvgConform
         validation_file = determine_validation_file(@file)
 
         unless File.exist?(validation_file)
-          puts Paint["Error: File '#{validation_file}' not found", :red]
-          exit 1
+          raise CompareError, "File '#{validation_file}' not found"
         end
 
-        begin
-          # Find or use specified svgcheck report
-          svgcheck_report_path = find_svgcheck_report
-          unless svgcheck_report_path && File.exist?(svgcheck_report_path)
-            puts Paint["Error: svgcheck report not found", :red]
-            if svgcheck_report_path
-              puts Paint["Expected: #{svgcheck_report_path}",
-                         :dim]
-            end
-            exit 1
-          end
-
-          # Load svgcheck report using the new external checker parser
-          parser = SvgConform::ExternalCheckers::Svgcheck::Parser.new
-          error_content = File.read(svgcheck_report_path)
-          svgcheck_report = parser.parse(error_content, nil,
-                                         filename: File.basename(@file))
-
-          # Generate SvgConform report using the correct validation file
-          validator = SvgConform::Validator.new
-          result = validator.validate_file(validation_file,
-                                           profile: @options[:profile].to_sym)
-          svg_conform_report = SvgConform::ConformanceReport.from_svg_conform_result(
-            File.basename(@file),
-            result,
-            profile: @options[:profile].to_sym,
-          )
-
-          # Compare the reports
-          comparator = SvgConform::ReportComparator.new
-          comparator.compare_reports(svg_conform_report, svgcheck_report,
-                                     File.basename(@file))
-        rescue StandardError => e
-          puts Paint["Error: #{e.message}", :red]
-          exit 1
+        # Find or use specified svgcheck report
+        svgcheck_report_path = find_svgcheck_report
+        unless svgcheck_report_path && File.exist?(svgcheck_report_path)
+          raise CompareError,
+                "svgcheck report not found#{" - expected: #{svgcheck_report_path}" if svgcheck_report_path}"
         end
+
+        # Load svgcheck report using the new external checker parser
+        parser = SvgConform::ExternalCheckers::Svgcheck::Parser.new
+        error_content = File.read(svgcheck_report_path)
+        svgcheck_report = parser.parse(error_content, nil,
+                                       filename: File.basename(@file))
+
+        # Generate SvgConform report using the correct validation file
+        validator = SvgConform::Validator.new
+        result = validator.validate_file(validation_file,
+                                         profile: @options[:profile].to_sym)
+        svg_conform_report = SvgConform::ConformanceReport.from_svg_conform_result(
+          File.basename(@file),
+          result,
+          profile: @options[:profile].to_sym,
+        )
+
+        # Compare the reports
+        comparator = SvgConform::ReportComparator.new
+        comparator.compare_reports(svg_conform_report, svgcheck_report,
+                                   File.basename(@file))
       end
 
       private

data/lib/svg_conform/commands/svgcheck_compatibility.rb

@@ -1,11 +1,14 @@
 # frozen_string_literal: true
 
+require "thor"
 require_relative "../compatibility/compatibility_analyzer"
 
 module SvgConform
   module Commands
     # Command for comparing SvgConform with svgcheck compatibility
     class SvgcheckCompatibility
+      class CompatibilityError < Thor::Error; end
+
       def initialize(options = {})
         @options = options
       end
@@ -29,14 +32,16 @@ module SvgConform
 
       def validate_options
         mode = @options[:mode] || @options["mode"] || "check"
-        raise "Invalid mode: #{mode}. Must be 'check' or 'repair'" unless %w[
-          check repair
-        ].include?(mode)
+        unless %w[check repair].include?(mode)
+          raise CompatibilityError,
+                "Invalid mode: #{mode}. Must be 'check' or 'repair'"
+        end
 
         file = @options[:file] || @options["file"]
-        return unless file && !file.match?(/\.(svg|xml)$/i)
-
-        raise "File must have .svg or .xml extension: #{file}"
+        if file && !file.match?(/\.(svg|xml)$/i)
+          raise CompatibilityError,
+                "File must have .svg or .xml extension: #{file}"
+        end
       end
     end
   end

data/lib/svg_conform/requirements/base_requirement.rb

@@ -96,7 +96,7 @@ module SvgConform
       attribute :id, :string
       attribute :description, :string
       attribute :type, :string, polymorphic_class: true, default: -> {
-        self.class.name.split("::").last
+        self.class.name&.split("::")&.last
       }
 
       yaml do
@@ -161,8 +161,8 @@ module SvgConform
 
         attrs = node.attributes || []
         # Convert array of Moxml::Attribute objects to hash
-        attrs.each_with_object({}) do |attr, hash|
-          hash[attr.name] = attr.value
+        attrs.to_h do |attr|
+          [attr.name, attr.value]
         end
       end
 

data/lib/svg_conform/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SvgConform
-  VERSION = "0.1.11"
+  VERSION = "0.1.12"
 end

data/spec/svg_conform/commands/check_command_spec.rb

@@ -83,8 +83,8 @@ RSpec.describe SvgConform::Commands::Check do
 
       expect do
         command.execute
-      end.to output(/Error: File 'nonexistent.svg' not found/).to_stdout
-        .and raise_error(SystemExit)
+      end.to raise_error(SvgConform::Commands::Check::FileNotFoundError,
+                         /nonexistent.svg/)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: svg_conform
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
 platform: ruby
 authors:
 - Ribose
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-01-27 00:00:00.000000000 Z
+date: 2026-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lutaml-model
@@ -87,6 +87,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
+- CLAUDE.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - README.adoc