svelte-on-rails 4.1.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6bc7d0e438a56941c4f978515b0c5853f5313bdf5e68727317bb599d56e86c9a
-  data.tar.gz: 43f1cec2b584e9e57a7abb844baadf8b3f749514fafb74fe281b2c9dd121ae2d
+  metadata.gz: f1113ad80ad88261fdf387b8d033006e10cedcbb0bd4e941a5a6fd8d7c338e2e
+  data.tar.gz: de7a37961949e4ff3f99de2da8818e159b3afc552dd530f1373607101c2a50db
 SHA512:
-  metadata.gz: e3c4e576dfd67ae501f3b922535fb9d6cf8ab3fa0073850ecae36c052c69e62b87c4a8eb2ec6184b2162e19c6d614df181f2b619522b5a5a026b8445ea9dc3f7
-  data.tar.gz: '079d80f461e1083be3fbffac4dcf5c93d35d576d8964e749aaaf93379c1ca86ea08ee971d18d0dd8ccf882e92e256f98ca49165c889ef5d4995cb1fc480f8986'
+  metadata.gz: e173b7d27296c0a51f7ea6d35632fab227e34964353087354fcd10634efc004959140da5724094b486dbb0a009e10af7a65e809d152b5621ac82911d5efc5198
+  data.tar.gz: 0d8f6bc08236e2752c81c7f1353f36c41c67ea9e4937410658ead038351b1ff0a323992af634b8b084e36d017facb6775cc41b0efa3cabd2989f5cd47620d81d

data/README.md

@@ -300,6 +300,12 @@ the Svelte component is not visible for the first moment after rendering.
 Server-side rendering is unnecessary here. You can pass 'ssr: false' to the view helper.
 This relieves the server and reduces loading time.
 
+**Tip: Testing**
+
+Consider setting `ssr: false` for testing only for performance reasons.
+Yo can override this on a attribute on the view-helper for specific components.
+But, in normal cases it should not be neccessary testing ssr explicitly.
+
 ## Caching
 
 Caching only is relevant for `ssr`
@@ -314,26 +320,16 @@ This caches on a key like `svelte-on-rails:development:SvelteOnRailsHelloWorld.s
 - `cache_key` if given as argument to the view-helper
   - can be a array of active-record objects or strings or a single element instead of a array
 - hash of the last modification timestamp of the component (only when `watch_changes` is set to true)
-- hash of the given properties
-
-**Caching strategy (!)** 
-
-Everytime the properties are changing, which are the last two elements of the hash key, which means all after the last colon,
-Previous hash keys are cleared by, for example: `svelte-on-rails:development:SvelteOnRailsHelloWorld.svelte-1xq5tnu-User1:*`
-
-That means: Please be aware to set your `cache_key` precisely for not invalidating cache keys that should not be cleared.
-
-On the other hand, please be aware that generating lots of record dependent cache keys will consume your memory, dependent on your 
-redis configuration.
+- hash of the given attributes
 
-**Cache configuration**
+**Configuration**
 
 Like usually you can configure your cache store on your environment by something like:
 
 ```ruby
   config.cache_store = :redis_cache_store, { url: 'redis://localhost:6379/2',
                                              expires_in: 90.minutes,
-                                             namespace: 'arcdigital_demo_cache' }
+                                             namespace: 'my-example-app' }
 ```
 
 And you can override this by
@@ -345,7 +341,7 @@ redis_cache_store:
 
 on the svelte-on-rails config file.
 
-**Tip**
+**Check if it works**
 
 Pass `debug: true` to the helper and you will see on the logs how your configuration works.
 

data/lib/svelte_on_rails/lib/view_helper_support.rb

@@ -5,14 +5,14 @@ module SvelteOnRails
     class ViewHelperSupport
       attr_reader :filename, :helper_options, :html_options, :request, :conf
 
-      def initialize(file, props, request, caching = false)
+      def initialize(file, args, request, caching = false)
 
         @start_time = Time.now
         @filename = (file.match(/\.svelte$/) ? file[0..-8] : file)
+        @args_checksum = Zlib.crc32(args.to_json).to_s(36)
         @conf = SvelteOnRails::Configuration.instance
-        @all_arguments = props
-        @helper_options, @html_options, @props, @props_json = split_props(
-          props,
+        @helper_options, @html_options, @svelte_props = split_props(
+          args,
           %i[class id style],
           %i[ssr hydrate debug cache_key expires_in]
         )
@@ -36,8 +36,6 @@ module SvelteOnRails
           return
         end
 
-        return unless ssr?
-
         generate_cache_key
 
       end
@@ -98,7 +96,7 @@ module SvelteOnRails
 
       def render_ssr
         renderer = SvelteOnRails::Renderer.new(filename)
-        renderer.render(@props)
+        renderer.render(@svelte_props)
       end
 
       def custom_cache_key
@@ -163,14 +161,14 @@ module SvelteOnRails
 
         last_part = [
           (@conf.watch_changes? ? Zlib.crc32(mtime).to_s(36) : nil),
-          Zlib.crc32(@all_arguments.to_json).to_s(36)
+          @args_checksum
         ].compact.join('-')
 
         @cache_key = [@cache_key_primary, last_part].join(':')
 
       end
 
-      def split_props(props, html_options, helper_options)
+      def split_props(args, html_options, helper_options)
         prp = {}
         hlp_opts = {}
         ht_opts = {
@@ -180,7 +178,7 @@ module SvelteOnRails
           }
         }
 
-        props.each do |k, v|
+        args.each do |k, v|
           _k = k.to_sym
           if helper_options.include?(_k)
             hlp_opts[_k] = v
@@ -192,11 +190,10 @@ module SvelteOnRails
         end
 
         ht_opts[:class] = "#{ht_opts[:class]} svelte-component".strip
-        prp_js = prp.to_json
-        ht_opts[:data][:props] = prp_js
+        ht_opts[:data][:props] = prp.to_json
         ht_opts[:data][:svelte_status] = 'do-not-hydrate-me' if hlp_opts[:hydrate] == false
 
-        [hlp_opts, ht_opts, prp, prp_js]
+        [hlp_opts, ht_opts, prp]
       end
 
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: svelte-on-rails
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.1
 platform: ruby
 authors:
 - Christian Sedlmair