svelte-on-rails 3.0.6 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 92b3d22db7b1abbebb142ddce45b41e73e4055d3ba17143661526c9bd5c7821a
-  data.tar.gz: ed7a18aafcb2c8ae9a81981063bcaf2295084ca76e5fa1e15d631838a9fb0f3a
+  metadata.gz: 2851a32bc97ac4fc669189927f2493976a029b21ed724cd90b0f0832e90bb0b4
+  data.tar.gz: fecead1bb111cd3a5e504350c0123d689f08eacc452d6421d159e1e2a0c53685
 SHA512:
-  metadata.gz: e3c2746a25bfd7a09ae517ff44d0674995c75f4d0857cf4559941d26a46619c21f572b9fce88eca3efa3accf13a1aa6b43b72ee5ea67de6ce0c2870f188f81a4
-  data.tar.gz: 5ba58975c8402de9ddade64a3961c611c536d0c96bc195b984cbe43c8cc691df24632394530c0f1f7c7f5c074a5acea442be9bda18437f27587e2b172573eddd
+  metadata.gz: 610aa41d2d4a964a216db1459b42eb37fe57d20750777e3c6f811f0e8275df327b04690a3c70405c61729e11055bb5939c578ea28942f96ff143de3639039c38
+  data.tar.gz: 021dbaff2383180c544430c66f02759d05eeacf79c2d800e87201de212722aac3666458dab96d877b2768e5c49f3f543374d38ba641a2098cdaa1b8ae615f137

data/README.md

@@ -25,6 +25,8 @@ On every app there are parts where you want it to shine. This is where Svelte co
 - Super fast
 - **Compared to Stimulus**
   - No more writing double logic of the initial HTML state
+  - One Logic in one file!
+    - Render logic and script logic is in one file and, maybe, some css too.
   - Stimulus is great for rails views with some javascript, but, complex parts: You will love svelte.
 - **Compared to React**
   - No more shadow dom and all those packages that are supposed to improve performance (e.g. useCallback...)
@@ -75,7 +77,10 @@ If you have issues, please open one, and contributors are welcome!
 ## Requirements
 
 - actual node installed on the server
-- tested on ruby 3.2.2 and rails 7.1
+- tested on 
+  - ruby 3.2.2 and rails 7.1
+  - ruby 2.7.5 and rails 6.1
+  - vite@6 (v7 not supported, see issues)
 - vite_rails (the installer will install it by option --full or --vite)
 - svelte v5 (see: [how to install svelte on rails/vite](https://dev.to/chmich/setup-inertia-and-svelte-on-rails-7-3glk))
 - turbo (recommended / [how to install turbo on rails](https://github.com/hotwired/turbo-rails?tab=readme-ov-file#installation))
@@ -294,6 +299,28 @@ rails svelte_on_rails:add_hello_world
 rails svelte_on_rails:remove_hello_world
 ```
 
+## Deploy
+
+For example, by deploying with capistrano, you may add a step like 
+
+```ruby
+before 'deploy:assets:precompile', 'deploy:npm:install'
+namespace :deploy do
+  namespace :npm do
+    desc 'Install Node.js dependencies'
+    task :install do
+      on roles(:app) do
+        within release_path do
+          execute :npm, 'install'
+        end
+      end
+    end
+  end
+end
+```
+
+to `deploy.rb` for making sure the ssr compilation is working.
+
 ## Contributors Guide
 
 Contributors welcome!

data/lib/generators/svelte_on_rails/install/install_generator.rb

@@ -43,7 +43,7 @@ module SvelteOnRails
         puts '-' * 80
         puts '• INSTALLING VITE-RAILS'
         vite_i = SvelteOnRails::Installer::Vite
-        vite_i.install_vite
+        vite_i.install_vite(major_version: 6)
       end
 
       def svelte_on_rails

data/lib/svelte_on_rails/installer/npm.rb

@@ -2,19 +2,44 @@ module SvelteOnRails
   module Installer
     module Npm
 
-      def self.install_or_update_package(package_name, minimal_version: nil, update_to_latest: true, dev_dependency: false )
+      def self.install_or_update_package(package_name, minimal_version: nil, major_version: nil, update_to_latest: true, dev_dependency: false)
         pkg = inspect_package(package_name)
-        to_do = !check_version((pkg ? pkg[:version] : nil), minimal_version)
+        puts "#{package_name} already installed (#{pkg[:version].join('.')})" if pkg
+
+        to_do = if !pkg
+                  true
+                elsif major_version
+                  r = pkg[:version].first != major_version
+                  if r
+                    puts "updating to major version #{major_version}"
+                  else
+                    puts "nothing to do (major version #{major_version} OK)"
+                  end
+                  r
+                elsif minimal_version
+                  r = pkg[:version].first < minimal_version.first || pkg[:version].second < minimal_version.second
+                  puts "updating to minimal version #{minimal_version}" if r
+                  r
+                else
+                  puts 'nothing to do'
+                  false
+                end
+
         save_dev = (dev_dependency ? ' --save-dev' : '')
         if to_do
 
-          cmd = if update_to_latest
+          cmd = if major_version
+                  "npm install #{package_name}@#{major_version}#{save_dev}"
+                elsif update_to_latest
                   "npm install #{package_name}@latest#{save_dev}"
                 else
                   raise "ERROR: not implemented"
                 end
 
           stdout, stderr, status = Open3.capture3(cmd)
+
+          puts cmd
+
           if stderr.present?
             raise "ERROR #{cmd} => #{stderr}"
           end
@@ -52,7 +77,6 @@ module SvelteOnRails
         end
       end
 
-
       def self.inspect_package(package_name)
         pkg = nil
         version = nil
@@ -75,34 +99,33 @@ module SvelteOnRails
 
       end
 
-      def self.check_version(current_version, minimal_version)
-        if !current_version
-          return false
-        elsif !minimal_version.present?
-          return true
-        else
-          compare_version_arrays(current_version, minimal_version)
-        end
-      end
+      # def self.check_version(current_version, minimal_version)
+      #   if !current_version
+      #     return false
+      #   elsif !minimal_version.present?
+      #     return true
+      #   else
+      #     compare_version_arrays(current_version, minimal_version)
+      #   end
+      # end
 
       private
 
-      def self.compare_version_arrays(current_version, minimal_version)
-        raise "ERROR: current_version must be an array" unless current_version.is_a?(Array)
-        raise "ERROR: minimal_version must be an array" unless current_version.is_a?(Array)
-
-        current_version.each_with_index do |v, i|
-          raise "ERROR: current_version entries must be an integer" unless v.is_a?(Integer)
-
-          if minimal_version[i]
-            raise "ERROR: minimal_version entries must be an integer" unless minimal_version[i].is_a?(Integer)
-            if v < minimal_version[i]
-              return false
-            end
-          end
-        end
-        true
-      end
+      # def self.compare_version_arrays(current_version, minimal_version)
+      #   raise "ERROR: current_version must be an array" unless current_version.is_a?(Array)
+      #
+      #   current_version.each_with_index do |v, i|
+      #     raise "ERROR: current_version entries must be an integer" unless v.is_a?(Integer)
+      #
+      #     if minimal_version[i]
+      #       raise "ERROR: minimal_version entries must be an integer" unless minimal_version[i].is_a?(Integer)
+      #       if v < minimal_version[i]
+      #         return false
+      #       end
+      #     end
+      #   end
+      #   true
+      # end
 
     end
   end

data/lib/svelte_on_rails/installer/vite.rb

@@ -4,7 +4,7 @@ module SvelteOnRails
 
     module Vite
 
-      def self.install_vite
+      def self.install_vite(major_version: nil, minimal_version: nil)
         iu = SvelteOnRails::Installer::Utils
 
         puts '-' * 80
@@ -44,7 +44,7 @@ module SvelteOnRails
         # check npm package version
 
         ni = SvelteOnRails::Installer::Npm
-        ni.install_or_update_package('vite', minimal_version: [6, 1])
+        ni.install_or_update_package('vite', major_version: major_version, minimal_version: minimal_version)
 
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: svelte-on-rails
 version: !ruby/object:Gem::Version
-  version: 3.0.6
+  version: 3.1.0
 platform: ruby
 authors:
 - Christian Sedlmair