suspiciouss 0.1 → 0.1.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 5320a8d5092b9ddf367b0b82799b4e296d8c0f50
4
- data.tar.gz: 39b11fc1009e5d25b2538379d8081c8e7642c606
3
+ metadata.gz: 5ad99a1a9bb97808032ac33af846bd48457d6549
4
+ data.tar.gz: cd365d13b993fc2a46b8390e9e50badc4bca8d13
5
5
  SHA512:
6
- metadata.gz: 7ec8f4021e8d3e2e69a0ab4a0029fe1a4d6d58e8501000ecb449bb8277be9fbff54124c8137b4df4a7682ec06dc673c6d19b08518eca2b87a577660449983d9c
7
- data.tar.gz: 88624cfcb3b14ae0f1fd2e329bd6dfe40af099ef88ee64fce4992623523f8d1b498dc48ac4318791c358305550e82cb44f055cd6708ec7d63be324bb1d348e3d
6
+ metadata.gz: d07bb76a495bdcac3fd23dbf657331796991066415e76b5062a84150dcc35144093a7aacc42d2ff8da89bdbd96eee280e7753a8b19704221ffc14e2914f7b87a
7
+ data.tar.gz: 90ae255ceb47d362d6cbbc611a34d50e1d9f036fdc0f22575869a659919ffc0803be60b0d93b7c48a4e7d8723c403f47018ba935b4c0346fac0a3dc0466b0f4e
@@ -3,6 +3,7 @@ module Suspiciouss
3
3
  class CamelCase
4
4
 
5
5
  def parse(line)
6
+ return if line.include?(':')
6
7
  "Don't use camelCase" if line =~ /[a-z][A-Z]{1}/
7
8
  end
8
9
  end
@@ -3,6 +3,7 @@ module Suspiciouss
3
3
  class Overqualifying
4
4
 
5
5
  def parse(line)
6
+ return if line.include?(':')
6
7
  "Don't overqualify your selectors" if line =~ /(div|label|a|input|span)(#|\.)\w+[^\w]/
7
8
  end
8
9
  end
@@ -3,7 +3,8 @@ module Suspiciouss
3
3
  class StylingIds
4
4
 
5
5
  def parse(line)
6
- "Don't style IDs" if line =~ /#\w+[^\w]/
6
+ return if line.include?(':')
7
+ "Don't style IDs" if line =~ /#\w+/
7
8
  end
8
9
  end
9
10
  end
@@ -3,6 +3,7 @@ module Suspiciouss
3
3
  class StylingJsPrefix
4
4
 
5
5
  def parse(line)
6
+ return if line.include?(':')
6
7
  "Don't style js- prefixed selectors" if line =~ /(\.|\#)js-/
7
8
  end
8
9
  end
@@ -3,6 +3,7 @@ module Suspiciouss
3
3
  class Underscores
4
4
 
5
5
  def parse(line)
6
+ return if line.include?(':')
6
7
  "Don't use underscores when naming classes" if line =~ /_/
7
8
  end
8
9
  end
@@ -1,3 +1,3 @@
1
1
  module Suspiciouss
2
- VERSION = '0.1'
2
+ VERSION = '0.1.1'
3
3
  end
@@ -2,7 +2,9 @@
2
2
  +++ b/path/to/file.css
3
3
 
4
4
 
5
- + #please-dont {color: #FFF;}
5
+ + #please-dont {
6
+ + color: #FFF;
7
+ + }
6
8
 
7
9
 
8
10
  --- a/path/to/file.sass
@@ -35,5 +37,6 @@
35
37
  +++ b/path/to/file.txt
36
38
 
37
39
 
38
- + #undetectable {color: #000;}
39
-
40
+ + #undetectable {
41
+ + color: #000;
42
+ + }
@@ -1,6 +1,6 @@
1
1
  - Check file /path/to/file.css for:
2
2
  ```
3
- Don't style IDs: #please-dont {color: #FFF;}
3
+ Don't style IDs: #please-dont {
4
4
  ```
5
5
  - Check file /path/to/file.sass for:
6
6
  ```
@@ -1,5 +1,5 @@
1
1
  Check file /path/to/file.css for:
2
- Don't style IDs: #please-dont {color: #FFF;}
2
+ Don't style IDs: #please-dont {
3
3
  Check file /path/to/file.sass for:
4
4
  Don't use camelCase: #pleaseDont
5
5
  Don't style IDs: #pleaseDont
@@ -7,13 +7,13 @@ describe Suspiciouss::Suggestions::CamelCase do
7
7
  describe '#parse' do
8
8
 
9
9
  context 'invalid' do
10
- let(:line) { '.pleaseDont {color: #000;}' }
10
+ let(:line) { '.pleaseDont {' }
11
11
 
12
12
  it { should eq "Don't use camelCase" }
13
13
  end
14
14
 
15
15
  context 'valid' do
16
- let(:line) { '.valid-selector {color: #FFF;}' }
16
+ let(:line) { '.valid-selector {' }
17
17
 
18
18
  it { should be_nil }
19
19
  end
@@ -2,20 +2,15 @@ require 'spec_helper'
2
2
 
3
3
  describe Suspiciouss::Suggestions::StylingIds do
4
4
 
5
- subject { described_class.new.parse(line) }
6
-
7
5
  describe '#parse' do
8
6
 
9
7
  context 'invalid' do
10
- let(:line) { '#please-dont {}' }
11
-
12
- it { should eq "Don't style IDs" }
8
+ it { expect(subject.parse('#please-dont {')).to eq "Don't style IDs" }
9
+ it { expect(subject.parse('#please-dont')).to eq "Don't style IDs" }
13
10
  end
14
11
 
15
12
  context 'valid' do
16
- let(:line) { ' > thanks {}' }
17
-
18
- it { should be_nil }
13
+ it { expect(subject.parse('color: #abcdef')).to be_nil }
19
14
  end
20
15
  end
21
16
  end
metadata CHANGED
@@ -1,83 +1,83 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: suspiciouss
3
3
  version: !ruby/object:Gem::Version
4
- version: '0.1'
4
+ version: 0.1.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Daniel Cruz Horts
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2014-03-23 00:00:00.000000000 Z
11
+ date: 2014-06-01 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rspec
15
15
  requirement: !ruby/object:Gem::Requirement
16
16
  requirements:
17
- - - ~>
17
+ - - "~>"
18
18
  - !ruby/object:Gem::Version
19
19
  version: '2.12'
20
20
  type: :development
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
- - - ~>
24
+ - - "~>"
25
25
  - !ruby/object:Gem::Version
26
26
  version: '2.12'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: pry
29
29
  requirement: !ruby/object:Gem::Requirement
30
30
  requirements:
31
- - - '>='
31
+ - - ">="
32
32
  - !ruby/object:Gem::Version
33
33
  version: '0'
34
34
  type: :development
35
35
  prerelease: false
36
36
  version_requirements: !ruby/object:Gem::Requirement
37
37
  requirements:
38
- - - '>='
38
+ - - ">="
39
39
  - !ruby/object:Gem::Version
40
40
  version: '0'
41
41
  - !ruby/object:Gem::Dependency
42
42
  name: pry-debugger
43
43
  requirement: !ruby/object:Gem::Requirement
44
44
  requirements:
45
- - - '>='
45
+ - - ">="
46
46
  - !ruby/object:Gem::Version
47
47
  version: '0'
48
48
  type: :development
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
- - - '>='
52
+ - - ">="
53
53
  - !ruby/object:Gem::Version
54
54
  version: '0'
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: guard
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
- - - '>='
59
+ - - ">="
60
60
  - !ruby/object:Gem::Version
61
61
  version: '0'
62
62
  type: :development
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
- - - '>='
66
+ - - ">="
67
67
  - !ruby/object:Gem::Version
68
68
  version: '0'
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: guard-rspec
71
71
  requirement: !ruby/object:Gem::Requirement
72
72
  requirements:
73
- - - '>='
73
+ - - ">="
74
74
  - !ruby/object:Gem::Version
75
75
  version: '0'
76
76
  type: :development
77
77
  prerelease: false
78
78
  version_requirements: !ruby/object:Gem::Requirement
79
79
  requirements:
80
- - - '>='
80
+ - - ">="
81
81
  - !ruby/object:Gem::Version
82
82
  version: '0'
83
83
  description:
@@ -87,8 +87,8 @@ executables:
87
87
  extensions: []
88
88
  extra_rdoc_files: []
89
89
  files:
90
- - .gitignore
91
- - .rspec
90
+ - ".gitignore"
91
+ - ".rspec"
92
92
  - Gemfile
93
93
  - Guardfile
94
94
  - LICENSE
@@ -133,12 +133,12 @@ require_paths:
133
133
  - lib
134
134
  required_ruby_version: !ruby/object:Gem::Requirement
135
135
  requirements:
136
- - - '>='
136
+ - - ">="
137
137
  - !ruby/object:Gem::Version
138
138
  version: '0'
139
139
  required_rubygems_version: !ruby/object:Gem::Requirement
140
140
  requirements:
141
- - - '>='
141
+ - - ">="
142
142
  - !ruby/object:Gem::Version
143
143
  version: '0'
144
144
  requirements: []