suspiciouss 0.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 5320a8d5092b9ddf367b0b82799b4e296d8c0f50
+  data.tar.gz: 39b11fc1009e5d25b2538379d8081c8e7642c606
+SHA512:
+  metadata.gz: 7ec8f4021e8d3e2e69a0ab4a0029fe1a4d6d58e8501000ecb449bb8277be9fbff54124c8137b4df4a7682ec06dc673c6d19b08518eca2b87a577660449983d9c
+  data.tar.gz: 88624cfcb3b14ae0f1fd2e329bd6dfe40af099ef88ee64fce4992623523f8d1b498dc48ac4318791c358305550e82cb44f055cd6708ec7d63be324bb1d348e3d

data/.gitignore

@@ -0,0 +1,8 @@
+nbproject
+*sublime-*
+.bundle
+.DS_Store
+*orig
+pkg/
+tmp/
+Gemfile.lock

data/.rspec

@@ -0,0 +1 @@
+-c

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

data/Guardfile

@@ -0,0 +1,3 @@
+guard :rspec do
+  watch(/.*/) { 'spec' }
+end

data/LICENSE

@@ -0,0 +1,22 @@
+Copyright (c) 2014 Daniel Cruz Horts
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -0,0 +1,41 @@
+# suspiCiouSS
+
+Suspiciouss is a CSS/Sass/Less linter that will provide you a report of common minor errors in your CSS development.
+
+## Usage
+
+You can use it from the command line:
+
+```bash
+git diff | suspiciouss
+```
+
+Or you can use it in your Ruby code:
+
+```ruby
+require 'suspiciouss'
+Suspiciouss::Linter.new.process(your_git_diff_as_text)
+```
+
+## What is going to report?
+
+You will be warned about the following issues in your code:
+
+- camel case selectors
+- excessive indentation
+- overqualified element selectors
+- styling #id selectors
+- styling js prefixed selectors
+- underscores in selectors
+- property with units if value is 0
+
+The report will be as text or markdown, depending if you got provided a command line input or was used programatically.
+
+## Contribute
+
+- Fork it
+- Write your feature with a test
+- Issue a pull request
+- ...
+- Profit!
+

data/Rakefile

@@ -0,0 +1,5 @@
+require 'bundler/gem_tasks'
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new
+task :default => :spec

data/bin/suspiciouss

@@ -0,0 +1,5 @@
+#!/usr/bin/env ruby
+
+require 'suspiciouss'
+
+Suspiciouss::Linter.new.process

data/lib/suspiciouss/linter.rb

@@ -0,0 +1,85 @@
+require 'suspiciouss/suggestions/camel_case'
+require 'suspiciouss/suggestions/indentation'
+require 'suspiciouss/suggestions/overqualifying'
+require 'suspiciouss/suggestions/styling_ids'
+require 'suspiciouss/suggestions/styling_js_prefix'
+require 'suspiciouss/suggestions/underscores'
+require 'suspiciouss/suggestions/zero_units'
+require 'suspiciouss/result/markdown'
+require 'suspiciouss/result/plain_text'
+
+module Suspiciouss
+  class Linter
+
+    KNOWN_FILETYPES = /(css|sass|scss|less)$/
+    SUGGESTIONS = Suspiciouss::Suggestions
+
+    def initialize
+      @result = Hash.new { |hash, key| hash[key] = [] }
+    end
+
+    # Process a diff file and return the result.
+    # It will read the input sequentially from a string or standard input.
+    def process(input = nil)
+      if input.nil?
+        input = STDIN
+      end
+
+      input.each_line do |line|
+        detect_filename_in line
+        parse line if @filename
+      end
+
+      if input.is_a? IO
+        puts result_as(Suspiciouss::Result::PlainText)
+      else
+        result_as(Suspiciouss::Result::Markdown)
+      end
+    end
+
+    private
+
+    # Detects if the diff block references a known file type
+    def detect_filename_in(full_line)
+      line_might_contain_filename = full_line.scan(/^\+\+\+ b(.+)$/)
+
+      return if line_might_contain_filename.empty?
+      @filename = line_might_contain_filename.first.first
+
+      if @filename !~ KNOWN_FILETYPES
+        @filename = nil
+      end
+    end
+
+    # Parses a line with each of the known suggestions and adds the result
+    # to the final output.
+    def parse(full_line)
+      @line = strip_diff_syntax full_line
+
+      return unless full_line =~ /^\+ /
+
+      known_suggestions.each do |suggestion|
+        if result = suggestion.parse(@line)
+          @result[@filename] << "#{result}: #{@line}"
+        end
+      end
+    end
+
+    # Renders the result using the specified formatter
+    def result_as(formatter)
+      formatter.new(@result).format
+    end
+
+    # Memoizes available suggestions in an array
+    def known_suggestions
+      @known_suggestions ||= SUGGESTIONS.constants.map do |suggestion_class|
+        SUGGESTIONS.const_get(suggestion_class).new
+      end
+    end
+
+    # Returns a line without the "+ " added by diff
+    def strip_diff_syntax(line)
+      line[2..-1]
+    end
+  end
+end

data/lib/suspiciouss/result/formatter.rb

@@ -0,0 +1,22 @@
+module Suspiciouss
+  module Result
+    class Formatter
+
+      def initialize(result)
+        @result = result
+      end
+
+      def output
+        output = ''
+
+        @result.each do |filename, errors|
+          unless errors.empty?
+            output << yield(filename, errors)
+          end
+        end
+
+        output
+      end
+    end
+  end
+end

data/lib/suspiciouss/result/markdown.rb

@@ -0,0 +1,22 @@
+require 'suspiciouss/result/formatter'
+
+module Suspiciouss
+  module Result
+    class Markdown < Formatter
+
+      def format
+        output do |filename, errors|
+          ''.tap do |filename_errors|
+            filename_errors << " - Check file #{filename} for:\n"
+
+            filename_errors << "```\n"
+            errors.each do |error|
+              filename_errors << error
+            end
+            filename_errors << "```\n"
+          end
+        end
+      end
+    end
+  end
+end

data/lib/suspiciouss/result/plain_text.rb

@@ -0,0 +1,20 @@
+require 'suspiciouss/result/formatter'
+
+module Suspiciouss
+  module Result
+    class PlainText < Formatter
+
+      def format
+        output do |filename, errors|
+          filename_errors = "Check file #{filename} for:\n"
+
+          errors.each do |error|
+            filename_errors << " #{error.strip}\n"
+          end
+
+          filename_errors
+        end
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/camel_case.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class CamelCase
+
+      def parse(line)
+        "Don't use camelCase" if line =~ /[a-z][A-Z]{1}/
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/indentation.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class Indentation
+
+      def parse(line)
+        "Indentation is too damn high" if line =~ /^        /
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/overqualifying.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class Overqualifying
+
+      def parse(line)
+        "Don't overqualify your selectors" if line =~ /(div|label|a|input|span)(#|\.)\w+[^\w]/
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/styling_ids.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class StylingIds
+
+      def parse(line)
+        "Don't style IDs" if line =~ /#\w+[^\w]/
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/styling_js_prefix.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class StylingJsPrefix
+
+      def parse(line)
+        "Don't style js- prefixed selectors" if line =~ /(\.|\#)js-/
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/underscores.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class Underscores
+
+      def parse(line)
+        "Don't use underscores when naming classes" if line =~ /_/
+      end
+    end
+  end
+end

data/lib/suspiciouss/suggestions/zero_units.rb

@@ -0,0 +1,10 @@
+module Suspiciouss
+  module Suggestions
+    class ZeroUnits
+
+      def parse(line)
+        "Don't add the unit if zero" if line =~ / (0px|0em|0rem|0%)/
+      end
+    end
+  end
+end

data/lib/suspiciouss/version.rb

@@ -0,0 +1,3 @@
+module Suspiciouss
+  VERSION = '0.1'
+end

data/lib/suspiciouss.rb

@@ -0,0 +1,2 @@
+require 'suspiciouss/version'
+require 'suspiciouss/linter'

data/spec/fixtures/changeset.diff

@@ -0,0 +1,39 @@
+--- a/path/to/file.css
++++ b/path/to/file.css
+
+
++ #please-dont {color: #FFF;}
+
+
+--- a/path/to/file.sass
++++ b/path/to/file.sass
+
+
++ #pleaseDont
++   color: $black
+
+
+--- a/path/to/file.less
++++ b/path/to/file.less
+
+
++ #pleaseDont {
++   color: @black;
++ }
+
+
+--- a/path/to/file.scss
++++ b/path/to/file.scss
+
+
++ #pleaseDont {
++   color: $black;
++ }
+
+
+--- a/path/to/file.txt
++++ b/path/to/file.txt
+
+
++ #undetectable {color: #000;}
+

data/spec/fixtures/result.md

@@ -0,0 +1,19 @@
+ - Check file /path/to/file.css for:
+```
+Don't style IDs: #please-dont {color: #FFF;}
+```
+ - Check file /path/to/file.sass for:
+```
+Don't use camelCase: #pleaseDont
+Don't style IDs: #pleaseDont
+```
+ - Check file /path/to/file.less for:
+```
+Don't use camelCase: #pleaseDont {
+Don't style IDs: #pleaseDont {
+```
+ - Check file /path/to/file.scss for:
+```
+Don't use camelCase: #pleaseDont {
+Don't style IDs: #pleaseDont {
+```

data/spec/fixtures/result.txt

@@ -0,0 +1,11 @@
+Check file /path/to/file.css for:
+ Don't style IDs: #please-dont {color: #FFF;}
+Check file /path/to/file.sass for:
+ Don't use camelCase: #pleaseDont
+ Don't style IDs: #pleaseDont
+Check file /path/to/file.less for:
+ Don't use camelCase: #pleaseDont {
+ Don't style IDs: #pleaseDont {
+Check file /path/to/file.scss for:
+ Don't use camelCase: #pleaseDont {
+ Don't style IDs: #pleaseDont {

data/spec/linter_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe Suspiciouss::Linter do
+
+  let(:diff) { 'spec/fixtures/changeset.diff' }
+
+  describe '#process' do
+
+    context 'input as parameter' do
+
+      let(:input) { File.open(diff, 'r').read }
+      let(:output) { File.open('spec/fixtures/result.md', 'r').read }
+
+      subject { described_class.new.process(input) }
+
+      it { expect(subject).to eq output }
+    end
+
+    context 'input from standard input' do
+
+      let(:output) { File.open('spec/fixtures/result.txt', 'r').read }
+
+      subject { `cat #{diff} | bin/suspiciouss` }
+
+      it { expect(subject).to eq output }
+    end
+  end
+end

data/spec/result/markdown_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Suspiciouss::Result::Markdown do
+
+  let(:result) { {'filename.css' => ['error1']} }
+
+  subject { described_class.new(result).format }
+
+  describe '#format' do
+
+    it { expect(subject).to eq " - Check file filename.css for:\n```\nerror1```\n" }
+  end
+end

data/spec/result/plain_text_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Suspiciouss::Result::PlainText do
+
+  let(:result) { {'filename.css' => ['error1']} }
+
+  subject { described_class.new(result).format }
+
+  describe '#format' do
+
+    it { expect(subject).to eq "Check file filename.css for:\n error1\n" }
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,7 @@
+require 'rubygems'
+require 'bundler/setup'
+require 'pry-debugger'
+
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+require 'suspiciouss'

data/spec/suggestions/camel_case_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::CamelCase do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '.pleaseDont {color: #000;}' }
+
+      it { should eq "Don't use camelCase" }
+    end
+
+    context 'valid' do
+      let(:line) { '.valid-selector {color: #FFF;}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/spec/suggestions/indentation_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::Indentation do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '        .please-dont {}' }
+
+      it { should eq "Indentation is too damn high" }
+    end
+
+    context 'valid' do
+      let(:line) { '      .thank-you {}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/spec/suggestions/overqualifying_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::Overqualifying do
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:result) { "Don't overqualify your selectors" }
+
+      it { expect(subject.parse('div.nay {}')).to eq result }
+      it { expect(subject.parse('label.nay {}')).to eq result }
+      it { expect(subject.parse('a.nay {}')).to eq result }
+      it { expect(subject.parse('input.nay {}')).to eq result }
+      it { expect(subject.parse('span.nay {}')).to eq result }
+    end
+
+    context 'valid' do
+      let(:line) { '.yea {}' }
+
+      it { expect(subject.parse(line)).to be_nil }
+    end
+  end
+end

data/spec/suggestions/styling_ids_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::StylingIds do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '#please-dont {}' }
+
+      it { should eq "Don't style IDs" }
+    end
+
+    context 'valid' do
+      let(:line) { '  > thanks {}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/spec/suggestions/styling_js_prefix_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::StylingJsPrefix do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '.js-tight-coupling {}' }
+
+      it { should eq "Don't style js- prefixed selectors" }
+    end
+
+    context 'valid' do
+      let(:line) { '.selector {}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/spec/suggestions/underscores_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::Underscores do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '.please_dont {}' }
+
+      it { should eq "Don't use underscores when naming classes" }
+    end
+
+    context 'valid' do
+      let(:line) { '.valid-selector {}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/spec/suggestions/zero_units_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Suspiciouss::Suggestions::ZeroUnits do
+
+  subject { described_class.new.parse(line) }
+
+  describe '#parse' do
+
+    context 'invalid' do
+      let(:line) { '.selector {margin: 0px;}' }
+
+      it { should eq "Don't add the unit if zero" }
+    end
+
+    context 'valid' do
+      let(:line) { '.selector {margin: 0;}' }
+
+      it { should be_nil }
+    end
+  end
+end

data/suspiciouss.gemspec

@@ -0,0 +1,23 @@
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'suspiciouss/version'
+
+Gem::Specification.new do |gem|
+  gem.name          = 'suspiciouss'
+  gem.version       = Suspiciouss::VERSION
+  gem.authors       = ['Daniel Cruz Horts']
+  gem.summary       = 'Reports common CSS/Sass/Less errors'
+  gem.homepage      = 'https://github.com/dncrht/suspiciouss'
+  gem.license       = 'MIT'
+
+  gem.files         = `git ls-files`.split($/)
+  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
+  gem.require_paths = ['lib']
+
+  gem.add_development_dependency 'rspec', '~> 2.12'
+  gem.add_development_dependency 'pry'
+  gem.add_development_dependency 'pry-debugger'
+  gem.add_development_dependency 'guard'
+  gem.add_development_dependency 'guard-rspec'
+end

metadata

@@ -0,0 +1,164 @@
+--- !ruby/object:Gem::Specification
+name: suspiciouss
+version: !ruby/object:Gem::Version
+  version: '0.1'
+platform: ruby
+authors:
+- Daniel Cruz Horts
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2014-03-23 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.12'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-debugger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: 
+email: 
+executables:
+- suspiciouss
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- .rspec
+- Gemfile
+- Guardfile
+- LICENSE
+- README.md
+- Rakefile
+- bin/suspiciouss
+- lib/suspiciouss.rb
+- lib/suspiciouss/linter.rb
+- lib/suspiciouss/result/formatter.rb
+- lib/suspiciouss/result/markdown.rb
+- lib/suspiciouss/result/plain_text.rb
+- lib/suspiciouss/suggestions/camel_case.rb
+- lib/suspiciouss/suggestions/indentation.rb
+- lib/suspiciouss/suggestions/overqualifying.rb
+- lib/suspiciouss/suggestions/styling_ids.rb
+- lib/suspiciouss/suggestions/styling_js_prefix.rb
+- lib/suspiciouss/suggestions/underscores.rb
+- lib/suspiciouss/suggestions/zero_units.rb
+- lib/suspiciouss/version.rb
+- spec/fixtures/changeset.diff
+- spec/fixtures/result.md
+- spec/fixtures/result.txt
+- spec/linter_spec.rb
+- spec/result/markdown_spec.rb
+- spec/result/plain_text_spec.rb
+- spec/spec_helper.rb
+- spec/suggestions/camel_case_spec.rb
+- spec/suggestions/indentation_spec.rb
+- spec/suggestions/overqualifying_spec.rb
+- spec/suggestions/styling_ids_spec.rb
+- spec/suggestions/styling_js_prefix_spec.rb
+- spec/suggestions/underscores_spec.rb
+- spec/suggestions/zero_units_spec.rb
+- suspiciouss.gemspec
+homepage: https://github.com/dncrht/suspiciouss
+licenses:
+- MIT
+metadata: {}
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 2.0.2
+signing_key: 
+specification_version: 4
+summary: Reports common CSS/Sass/Less errors
+test_files:
+- spec/fixtures/changeset.diff
+- spec/fixtures/result.md
+- spec/fixtures/result.txt
+- spec/linter_spec.rb
+- spec/result/markdown_spec.rb
+- spec/result/plain_text_spec.rb
+- spec/spec_helper.rb
+- spec/suggestions/camel_case_spec.rb
+- spec/suggestions/indentation_spec.rb
+- spec/suggestions/overqualifying_spec.rb
+- spec/suggestions/styling_ids_spec.rb
+- spec/suggestions/styling_js_prefix_spec.rb
+- spec/suggestions/underscores_spec.rb
+- spec/suggestions/zero_units_spec.rb