suspenders 1.5.1 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0cf8c934b629cd1178398903fbefd834490bd26e
-  data.tar.gz: 4feb8c8d3aaef6e7a701a1379c6ec56cb2b77480
+  metadata.gz: 9143fdabbeb2429e35b159d7d05ebd723ca630f9
+  data.tar.gz: 3dda26b01f294506f39591fc5e9399fed50c3c4f
 SHA512:
-  metadata.gz: 0132c92a271cc4b7cf220118479ba742299167352cf479295c720c2e702407d596241c7bfe541ed2f5bffb11afc22b675332f47e8bc24f31ce5c632f65eeeec9
-  data.tar.gz: cf235a2266d97ded4b691c47f28c025c21a9f9352d853f9e1a70767610a0eb73853f9fe7a963191af7d8244d9a85f4f8b651b5d121409d554db73f019deb4c87
+  metadata.gz: 3728b65694bec8e195af833a2eaf0be99939c5e8d918e0d5f7eace2fa06ab5a435369542d5402d3d831e9b611f49888a8a5654476b6aa4f661a2865e91788338
+  data.tar.gz: 57fa6bab849dd3df3ee5af8c6173faeb0de308e12d65fc57dfdf15abab8b7031e41e49c6d05f7a087ca6da0cf4530c5d5b38e2808a7510a8f1b8d77201679a2a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    suspenders (1.5.1)
+    suspenders (1.6.0)
       bundler (~> 1.3)
       rails (= 4.0.0)
 
@@ -32,12 +32,12 @@ GEM
       multi_json (~> 1.3)
       thread_safe (~> 0.1)
       tzinfo (~> 0.3.37)
-    arel (4.0.0)
+    arel (4.0.1)
     aruba (0.5.3)
       childprocess (>= 0.3.6)
       cucumber (>= 1.1.1)
       rspec-expectations (>= 2.7.0)
-    atomic (1.1.13)
+    atomic (1.1.14)
     builder (3.1.4)
     childprocess (0.3.9)
       ffi (~> 1.0, >= 1.0.11)
@@ -60,7 +60,7 @@ GEM
     mail (2.5.4)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.25)
+    mime-types (1.25.1)
     minitest (4.7.5)
     multi_json (1.7.7)
     multi_test (0.0.1)
@@ -84,12 +84,12 @@ GEM
     rake (10.1.0)
     rspec-expectations (2.14.0)
       diff-lcs (>= 1.1.3, < 2.0)
-    sprockets (2.10.0)
+    sprockets (2.10.1)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.0.0)
+    sprockets-rails (2.0.1)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (~> 2.8)
@@ -100,7 +100,7 @@ GEM
     treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.37)
+    tzinfo (0.3.38)
 
 PLATFORMS
   ruby

data/NEWS.md

@@ -1,3 +1,13 @@
+1.6.0 (November 28, 2013)
+
+* Do not create `.rspec` file as the settings are not project-specific.
+* Generate RSpec binstub at `bin/rspec`.
+* Fix stylesheet error on 500, 404, and 422 static pages.
+* Add `--skip-git` option.
+* Disable jQuery animations in Rails integration tests that execute JavaScript.
+* Fix git remote bug.
+* Add `Rack::Timeout` to compress responses with Gzip.
+
 1.5.1 (September 10, 2013)
 
 * Remove Turbolinks.

data/README.md

@@ -15,8 +15,10 @@ Then run:
 
     suspenders projectname
 
-This will create a Rails 4.0 app in `projectname`. This script creates a
-new git repository. It is not meant to be used against an existing repo.
+This will create a Rails 4.0 app in `projectname`.
+
+By default this script creates a new git repository. See below if you
+want to use it against an existing repo.
 
 Gemfile
 -------
@@ -70,11 +72,15 @@ Other goodies
 
 Suspenders also comes with:
 
-* Override recipient emails in staging environment.
-* Rails' flashes set up and in application layout.
-* A few nice time formats set up for localization.
-* [Heroku-recommended
-  settings](https://devcenter.heroku.com/articles/rails4-getting-started).
+* The [`./bin/setup`][bin] convention for new developer setup
+* Rails' flashes set up and in application layout
+* A few nice time formats set up for localization
+* `Rack::Timeout` to [compress responses with Gzip][compress]
+* [Fast-failing factories][fast]
+
+[bin]: http://robots.thoughtbot.com/bin-setup
+[compress]: http://robots.thoughtbot.com/content-compression-with-rack-deflater/
+[fast]: http://robots.thoughtbot.com/testing-your-factories-first
 
 Heroku
 ------
@@ -83,15 +89,25 @@ You can optionally create Heroku staging and production apps:
 
     suspenders app --heroku true
 
-This has the same effect as running:
+This:
+
+* Creates a staging and production Heroku app
+* Sets them as `staging` and `production` Git remotes
+* Configures staging with `RACK_ENV` and `RAILS_ENV` environment variables set
+  to `staging`
+
+Git
+---
+
+This will initialize a new git repository for your Rails app. You can
+bypass this with the `--skip-git` option:
 
-    heroku create app-staging --remote staging
-    heroku create app-production --remote production
+    suspenders app --skip-git true
 
-Github
+GitHub
 ------
 
-You can optionally create a Github repository for the suspended Rails app. It
+You can optionally create a GitHub repository for the suspended Rails app. It
 requires that you have [Hub](https://github.com/github/hub) on your system:
 
     curl http://hub.github.com/standalone -sLo ~/bin/hub && chmod +x ~/bin/hub

data/lib/suspenders/actions.rb

@@ -1,10 +1,5 @@
 module Suspenders
   module Actions
-    def concat_file(source, destination)
-      contents = IO.read(find_in_source_paths(source))
-      append_file destination, contents
-    end
-
     def replace_in_file(relative_path, find, replace)
       path = File.join(destination_root, relative_path)
       contents = IO.read(path)

data/lib/suspenders/app_builder.rb

@@ -20,8 +20,17 @@ module Suspenders
     end
 
     def raise_on_unpermitted_parameters
-      configure_environment 'development',
-        'config.action_controller.action_on_unpermitted_parameters = :raise'
+      action_on_unpermitted_parameters = <<-RUBY
+
+  # Raise an ActionController::UnpermittedParameters exception when
+  # a parameter is not explcitly permitted but is passed anyway.
+  config.action_controller.action_on_unpermitted_parameters = :raise
+      RUBY
+      inject_into_file(
+        "config/environments/development.rb",
+        action_on_unpermitted_parameters,
+        before: "\nend"
+      )
     end
 
     def provide_setup_script
@@ -31,15 +40,15 @@ module Suspenders
 
     def configure_generators
       config = <<-RUBY
-  config.generators do |generate|
-    generate.helper false
-    generate.javascript_engine false
-    generate.request_specs false
-    generate.routing_specs false
-    generate.stylesheets false
-    generate.test_framework :rspec
-    generate.view_specs false
-  end
+    config.generators do |generate|
+      generate.helper false
+      generate.javascript_engine false
+      generate.request_specs false
+      generate.routing_specs false
+      generate.stylesheets false
+      generate.test_framework :rspec
+      generate.view_specs false
+    end
 
       RUBY
 
@@ -71,6 +80,17 @@ module Suspenders
         :after => 'config.action_mailer.raise_delivery_errors = false'
     end
 
+    def enable_rack_deflater
+      config = <<-RUBY
+
+  # Enable deflate / gzip compression of controller-generated responses
+  config.middleware.use Rack::Deflater
+      RUBY
+
+      inject_into_file 'config/environments/production.rb', config,
+        :after => "config.serve_static_assets = false\n"
+    end
+
     def setup_staging_environment
       run 'cp config/environments/production.rb config/environments/staging.rb'
 
@@ -130,12 +150,15 @@ module Suspenders
     end
 
     def configure_rspec
-      remove_file '.rspec'
-      copy_file 'rspec', '.rspec'
       remove_file 'spec/spec_helper.rb'
       copy_file 'spec_helper.rb', 'spec/spec_helper.rb'
     end
 
+    def use_rspec_binstub
+      run 'bundle binstub rspec-core'
+      run 'rm bin/autospec'
+    end
+
     def configure_background_jobs_for_rspec
       copy_file 'background_jobs_rspec.rb', 'spec/support/background_jobs.rb'
       run 'rails g delayed_job:active_record'
@@ -217,12 +240,14 @@ module Suspenders
     end
 
     def set_heroku_remotes
-      concat_file(
-        'templates/bin_setup',
-        "# Set up staging and production git remotes\r
-        git remote add staging git@heroku.com: #{app_name}-staging.git\r
-        git remote add production git@heroku.com: #{app_name}-production.git"
-      )
+      remotes = <<-RUBY
+
+# Set up staging and production git remotes
+git remote add staging git@heroku.com:#{app_name}-staging.git
+git remote add production git@heroku.com:#{app_name}-production.git
+      RUBY
+
+      append_file 'bin/setup', remotes
     end
 
     def create_github_repo(repo_name)
@@ -239,13 +264,9 @@ module Suspenders
   <meta charset='utf-8' />
   <meta name='ROBOTS' content='NOODP' />
       EOS
-      style_tags =<<-EOS
-<link href='/assets/application.css' media='all' rel='stylesheet' type='text/css' />
-      EOS
 
       %w(500 404 422).each do |page|
         inject_into_file "public/#{page}.html", meta_tags, :after => "<head>\n"
-        replace_in_file "public/#{page}.html", /<style.+>.+<\/style>/mi, style_tags.strip
         replace_in_file "public/#{page}.html", /<!--.+-->\n/, ''
       end
     end

data/lib/suspenders/generators/app_generator.rb

@@ -49,7 +49,7 @@ module Suspenders
     def customize_gemfile
       build :replace_gemfile
       build :set_ruby_to_version_being_used
-      bundle_command 'install --binstubs=bin/stubs'
+      bundle_command 'install'
     end
 
     def setup_database
@@ -76,6 +76,7 @@ module Suspenders
       build :test_factories_first
       build :generate_rspec
       build :configure_rspec
+      build :use_rspec_binstub
       build :configure_background_jobs_for_rspec
       build :enable_database_cleaner
       build :configure_capybara_webkit
@@ -84,6 +85,7 @@ module Suspenders
     def setup_production_environment
       say 'Setting up the production environment'
       build :configure_smtp
+      build :enable_rack_deflater
     end
 
     def setup_staging_environment
@@ -125,9 +127,11 @@ module Suspenders
     end
 
     def setup_git
-      say 'Initializing git'
-      invoke :setup_gitignore
-      invoke :init_git
+      if !options[:skip_git]
+        say 'Initializing git'
+        invoke :setup_gitignore
+        invoke :init_git
+      end
     end
 
     def create_heroku_apps
@@ -139,7 +143,7 @@ module Suspenders
     end
 
     def create_github_repo
-      if options[:github]
+      if !options[:skip_git] && options[:github]
         say 'Creating Github repo'
         build :create_github_repo, options[:github]
       end

data/lib/suspenders/version.rb

@@ -1,3 +1,3 @@
 module Suspenders
-  VERSION = '1.5.1'
+  VERSION = '1.6.0'
 end

data/templates/_javascript.html.erb

@@ -4,6 +4,7 @@
 
 <% if Rails.env.test? %>
   <%= javascript_tag do %>
+    $.fx.off = true;
     $.ajaxSetup({ async: false });
   <% end %>
 <% end %>

data/templates/suspenders_gitignore

@@ -4,7 +4,6 @@
 *.swp
 .bundle
 .sass-cache/
-bin/stubs
 coverage/*
 db/*.sqlite3
 db/schema.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspenders
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.6.0
 platform: ruby
 authors:
 - thoughtbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-10 00:00:00.000000000 Z
+date: 2013-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -120,7 +120,6 @@ files:
 - templates/javascripts/prefilled_input.js
 - templates/postgresql_database.yml.erb
 - templates/rack_timeout.rb
-- templates/rspec
 - templates/sample.env
 - templates/smtp.rb
 - templates/spec_helper.rb

data/templates/rspec

@@ -1,2 +0,0 @@
---colour
---profile