suspenders 1.40.0 → 1.41.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4bba79d54a04b9f85c062cf024f685e99826b40
-  data.tar.gz: e506439a76fcd20aa5f9dc010317efc20611f654
+  metadata.gz: 72448ddabb6379077f02f41bc65d4dc8a112d4f0
+  data.tar.gz: 3c56de92f55a3d7984a6dd8a011dd9001934ba10
 SHA512:
-  metadata.gz: 1ea9a3b8f9fabdfda4f14b92f221c9f21715f6f97909dbd78b310fdd3da0bd12cf9cc909806adc6290bca5dd4e196ccc386d5998412524af76268b902c086287
-  data.tar.gz: 8f57f5ef1b22a882e620274638cf04b89f7115880a84405e54efc1dd1a0da0157aec23d1f87e0f95f0668dc5e26e19402b7b07a3d84b1df55d92169027466e6b
+  metadata.gz: bbc752c4b28b8b6dd86270c3d2986c58574fa684b8750ce854c2f7a981c076f5c9104b4b903a5322d04179412c68dab4b498d4a9dcc26eba4c05af678a2b67c7
+  data.tar.gz: 48226bb6d42963e7b0c6bd6bb39e8ab732c9455a2c619fea3618a785aedfea2b3f5b76f4242fbc3ebd7f3687a1510d91887371ebe2fbb5b040043954ada8e1ac

data/NEWS.md

@@ -1,5 +1,12 @@
 master
 
+1.41.0 (July 1, 2016)
+
+* Update to Rails 5
+* Drop quiet_assets
+* Drop unneeded `suspenders` aliases: `--skip-test-unit`, `--skip-turbolinks`,
+  `--skip-bundle`. Drops `-G` that clashes with Rails’ `--skip-git` alias.
+
 1.40.0 (June 25, 2016)
 
 * Upgrade bourbon to 5.0.0.beta.6

data/README.md

@@ -74,8 +74,6 @@ And development gems like:
   pre-loading
 * [Web Console](https://github.com/rails/web-console) for better debugging via
   in-browser IRB consoles.
-* [Quiet Assets](https://github.com/evrone/quiet_assets) for muting assets
-  pipeline log messages
 
 And testing gems like:
 

data/RELEASING.md

@@ -4,7 +4,7 @@
 2. Update `NEWS.md` to reflect the changes since last release.
 3. Commit changes. There shouldn't be code changes, and thus CI doesn't need to
    run, you can then add `[ci skip]` to the commit message.
-4. Tag the release: `git tag vVERSION -a`. The tag message should contain the
+4. Tag the release: `git tag vVERSION -a -s`. The tag message should contain the
    appropriate `NEWS.md` subsection.
 5. Push changes: `git push --tags`
 6. Build and publish to rubygems:

data/lib/suspenders/adapters/heroku.rb

@@ -70,15 +70,6 @@ module Suspenders
         )
       end
 
-      def set_heroku_serve_static_files
-        %w(staging production).each do |environment|
-          run_toolbelt_command(
-            "config:add RAILS_SERVE_STATIC_FILES=true",
-            environment,
-          )
-        end
-      end
-
       def set_heroku_application_host
         %w(staging production).each do |environment|
           run_toolbelt_command(

data/lib/suspenders/app_builder.rb

@@ -13,8 +13,7 @@ module Suspenders
                    :create_review_apps_setup_script,
                    :set_heroku_rails_secrets,
                    :set_heroku_remotes,
-                   :set_heroku_application_host,
-                   :set_heroku_serve_static_files
+                   :set_heroku_application_host
 
     def readme
       template 'README.md.erb', 'README.md'
@@ -79,7 +78,7 @@ module Suspenders
 
     def configure_quiet_assets
       config = <<-RUBY
-    config.quiet_assets = true
+    config.assets.quiet = true
       RUBY
 
       inject_into_class "config/application.rb", "Application", config
@@ -315,8 +314,8 @@ Rack::Timeout.timeout = (ENV["RACK_TIMEOUT"] || 10).to_i
       generate 'rspec:install'
     end
 
-    def configure_puma
-      copy_file "puma.rb", "config/puma.rb"
+    def replace_default_puma_configuration
+      copy_file "puma.rb", "config/puma.rb", force: true
     end
 
     def set_up_forego

data/lib/suspenders/generators/app_generator.rb

@@ -14,18 +14,9 @@ module Suspenders
     class_option :heroku_flags, type: :string, default: "",
       desc: "Set extra Heroku flags"
 
-    class_option :github, type: :string, aliases: "-G", default: nil,
+    class_option :github, type: :string, default: nil,
       desc: "Create Github repository and add remote origin pointed to repo"
 
-    class_option :skip_test_unit, type: :boolean, aliases: "-T", default: true,
-      desc: "Skip Test::Unit files"
-
-    class_option :skip_turbolinks, type: :boolean, default: true,
-      desc: "Skip turbolinks gem"
-
-    class_option :skip_bundle, type: :boolean, aliases: "-B", default: true,
-      desc: "Don't run bundle install"
-
     class_option :version, type: :boolean, aliases: "-v", group: :suspenders,
       desc: "Show Suspenders version number and quit"
 
@@ -145,7 +136,7 @@ module Suspenders
       build :configure_active_job
       build :configure_time_formats
       build :setup_default_rake_task
-      build :configure_puma
+      build :replace_default_puma_configuration
       build :set_up_forego
       build :setup_rack_mini_profiler
     end
@@ -184,7 +175,6 @@ module Suspenders
       if options[:heroku]
         say "Creating Heroku apps"
         build :create_heroku_apps, options[:heroku_flags]
-        build :set_heroku_serve_static_files
         build :set_heroku_remotes
         build :set_heroku_rails_secrets
         build :set_heroku_application_host

data/lib/suspenders/version.rb

@@ -1,8 +1,8 @@
 module Suspenders
-  RAILS_VERSION = "~> 4.2.0".freeze
+  RAILS_VERSION = "~> 5.0.0".freeze
   RUBY_VERSION = IO.
     read("#{File.dirname(__FILE__)}/../../.ruby-version").
     strip.
     freeze
-  VERSION = "1.40.0".freeze
+  VERSION = "1.41.0".freeze
 end

data/spec/features/github_spec.rb

@@ -7,7 +7,7 @@ RSpec.describe "GitHub" do
   end
 
   it "suspends a project with --github option" do
-    repo_name = 'test'
+    repo_name = "test"
     run_suspenders("--github=#{repo_name}")
     setup_app_dependencies
 

data/spec/features/new_project_spec.rb

@@ -44,7 +44,8 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "loads secret_key_base from env" do
     secrets_file = IO.read("#{project_path}/config/secrets.yml")
 
-    expect(secrets_file).to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
+    expect(secrets_file).
+      to match(/secret_key_base: <%= ENV\["SECRET_KEY_BASE"\] %>/)
   end
 
   it "adds bin/setup file" do
@@ -110,22 +111,17 @@ RSpec.describe "Suspend a new project with default configuration" do
   it "adds explicit quiet_assets configuration" do
     result = IO.read("#{project_path}/config/application.rb")
 
-    expect(result).to match(
-      /^ +config.quiet_assets = true$/
-    )
+    expect(result).to match(/^ +config.assets.quiet = true$/)
   end
 
   it "configures static_cache_control in production" do
-    prod_env_file = IO.read("#{project_path}/config/environments/production.rb")
-    expect(prod_env_file).to match(
+    expect(production_config).to match(
       /config.static_cache_control = "public, max-age=.+"/,
     )
   end
 
   it "raises on missing translations in development and test" do
-    %w[development test].each do |environment|
-      environment_file =
-        IO.read("#{project_path}/config/environments/#{environment}.rb")
+    [development_config, test_config].each do |environment_file|
       expect(environment_file).to match(
         /^ +config.action_view.raise_on_missing_translations = true$/
       )
@@ -143,15 +139,13 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "configs :test email delivery method for development" do
-    dev_env_file = IO.read("#{project_path}/config/environments/development.rb")
-    expect(dev_env_file).
+    expect(development_config).
       to match(/^ +config.action_mailer.delivery_method = :file$/)
   end
 
   it "uses APPLICATION_HOST, not HOST in the production config" do
-    prod_env_file = IO.read("#{project_path}/config/environments/production.rb")
-    expect(prod_env_file).to match(/"APPLICATION_HOST"/)
-    expect(prod_env_file).not_to match(/"HOST"/)
+    expect(production_config).to match(/"APPLICATION_HOST"/)
+    expect(production_config).not_to match(/"HOST"/)
   end
 
   it "configures email interceptor in smtp config" do
@@ -168,7 +162,6 @@ RSpec.describe "Suspend a new project with default configuration" do
 
   it "configs active job queue adapter" do
     application_config = IO.read("#{project_path}/config/application.rb")
-    test_config = IO.read("#{project_path}/config/environments/test.rb")
 
     expect(application_config).to match(
       /^ +config.active_job.queue_adapter = :delayed_job$/
@@ -179,16 +172,12 @@ RSpec.describe "Suspend a new project with default configuration" do
   end
 
   it "configs bullet gem in development" do
-    test_config = IO.read("#{project_path}/config/environments/development.rb")
-
-    expect(test_config).to match /^ +Bullet.enable = true$/
-    expect(test_config).to match /^ +Bullet.bullet_logger = true$/
-    expect(test_config).to match /^ +Bullet.rails_logger = true$/
+    expect(development_config).to match /^ +Bullet.enable = true$/
+    expect(development_config).to match /^ +Bullet.bullet_logger = true$/
+    expect(development_config).to match /^ +Bullet.rails_logger = true$/
   end
 
   it "configs missing assets to raise in test" do
-    test_config = IO.read("#{project_path}/config/environments/test.rb")
-
     expect(test_config).to match(
       /^ +config.assets.raise_runtime_errors = true$/,
     )
@@ -207,9 +196,9 @@ RSpec.describe "Suspend a new project with default configuration" do
     config_files = [
       IO.read("#{project_path}/config/application.rb"),
       IO.read("#{project_path}/config/environment.rb"),
-      IO.read("#{project_path}/config/environments/development.rb"),
-      IO.read("#{project_path}/config/environments/production.rb"),
-      IO.read("#{project_path}/config/environments/test.rb"),
+      development_config,
+      test_config,
+      production_config,
     ]
 
     config_files.each do |file|
@@ -277,6 +266,20 @@ RSpec.describe "Suspend a new project with default configuration" do
     expect(app_css).to match(/normalize-rails.*bourbon.*neat.*base.*refills/m)
   end
 
+  def development_config
+    @_development_config ||=
+      read_project_file %w(config environments development.rb)
+  end
+
+  def test_config
+    @_test_config ||= read_project_file %w(config environments test.rb)
+  end
+
+  def production_config
+    @_production_config ||=
+      read_project_file %w(config environments production.rb)
+  end
+
   def analytics_partial
     IO.read("#{project_path}/app/views/application/_analytics.html.erb")
   end

data/templates/Gemfile.erb

@@ -23,7 +23,7 @@ gem "title"
 gem "uglifier"
 
 group :development do
-  gem "quiet_assets"
+  gem "listen"
   gem "spring"
   gem "spring-commands-rspec"
   gem "web-console"
@@ -37,7 +37,8 @@ group :development, :test do
   gem "factory_girl_rails"
   gem "pry-byebug"
   gem "pry-rails"
-  gem "rspec-rails", "~> 3.4.0"
+  gem "refills"
+  gem "rspec-rails", "~> 3.5.0.beta4"
 end
 
 group :development, :staging do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspenders
 version: !ruby/object:Gem::Version
-  version: 1.40.0
+  version: 1.41.0
 platform: ruby
 authors:
 - thoughtbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-25 00:00:00.000000000 Z
+date: 2016-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitters
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement