suspenders 1.23.0 → 1.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee470f34802ff56e8032e5725872fad57a194042
-  data.tar.gz: e338267ebc0642374ef45e0cb116d731a6212eee
+  metadata.gz: 82e9404c65c3c4824d2db3c7e102887e023e1692
+  data.tar.gz: b238f1099fbade65f4af8f56c2662c0e08aa0781
 SHA512:
-  metadata.gz: 102c9097b4426c642bdbcf77a9f80847f8cc64c7f2e960b194a566e689fb9c8002d48e3339d332dce4547e0004e02daad4bee341ac097fc60b6597872e9dc752
-  data.tar.gz: 458864e6ae2402201df699e16180e05f1d1b47ecd07f6cef2f0ebc7aa31772b156e978958b90652285e60f5288acc1141320389c3d090ec5b938ac79273fa65a
+  metadata.gz: fe08b5239f80727c9ce77dbf75a4267d23ced284224d60a2ac02a2059909105cc3e6d453560c8aba5cd780f6f8205c1b7ca98ca6eb849b72470d28b3296a4115
+  data.tar.gz: ad48f708d6073459abd9df2e88ddc0be91783f96f0aa8f0572b7d685e5c03cbeeb3a8e42cae98ade713cb51a12e2271f630b454959e132790185e0d2c2631762

data/CONTRIBUTING.md

@@ -1,7 +1,5 @@
 # Contributing
 
-We love pull requests. Here's a quick guide.
-
 Fork the repo:
 
     git clone git@github.com:thoughtbot/suspenders.git
@@ -14,23 +12,32 @@ Make sure the tests pass:
 
     rake
 
-Make your change. Add tests for your change. Make the tests pass:
+Make your change.
+Write tests.
+Follow our [style guide][style].
+Make the tests pass:
+
+[style]: https://github.com/thoughtbot/guides/tree/master/style
 
     rake
 
-Push to your fork and [submit a pull request][pr].
+Write a [good commit message][commit].
+Push to your fork.
+[Submit a pull request][pr].
 
+[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [pr]: https://github.com/thoughtbot/suspenders/compare/
 
-At this point you're waiting on us. We like to at least comment on pull requests
-within three business days (and, typically, one business day). We may suggest
-some changes or improvements or alternatives.
+If [Hound] catches style violations,
+fix them.
 
-Some things that will increase the chance that your pull request is accepted:
+[hound]: https://houndci.com
 
-* Write tests.
-* Follow our [style guide][style].
-* Write a [good commit message][commit].
+Wait for us.
+We try to at least comment on pull requests within one business day.
+We may suggest changes.
 
-[style]: https://github.com/thoughtbot/guides/tree/master/style
-[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+## Versions
+
+To update the Ruby version,
+change `.ruby-version` and `.travis.yml`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    suspenders (1.23.0)
+    suspenders (1.24.0)
       bitters (~> 0.10.0)
       bundler (~> 1.3)
       rails (= 4.2.0)
@@ -128,13 +128,13 @@ GEM
     rspec-expectations (2.99.0)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.99.0)
-    sass (3.4.10)
+    sass (3.4.11)
     sprockets (2.12.3)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.2)
+    sprockets-rails (2.2.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)

data/NEWS.md

@@ -1,3 +1,10 @@
+1.24.0 (February 3, 2015)
+
+* Remove things in Suspenders that Rails does for us now.
+* Document how to use the `title` view helper.
+* Improve speed of bundling in `bin/setup` script.
+* Set ENV variable to make out-of-the-box Heroku static asset experience better.
+
 1.23.0 (January 19, 2015)
 
 * Use Bourbon 4.1.0.

data/README.md

@@ -181,9 +181,7 @@ If you have problems, please create a
 
 ## Contributing
 
-To update Suspenders' Ruby version, change `.ruby-version` and `.travis.yml`.
-
-Please see [CONTRIBUTING.md](CONTRIBUTING.md) for further details.
+See [CONTRIBUTING.md](CONTRIBUTING.md).
 
 ## Credits
 

data/lib/suspenders/app_builder.rb

@@ -140,12 +140,6 @@ end
         force: true
     end
 
-    def remove_turbolinks
-      replace_in_file 'app/assets/javascripts/application.js',
-        /\/\/= require turbolinks\n/,
-        ''
-    end
-
     def use_postgres_config_template
       template 'postgresql_database.yml.erb', 'config/database.yml',
         force: true
@@ -215,14 +209,6 @@ end
       copy_file 'action_mailer.rb', 'spec/support/action_mailer.rb'
     end
 
-    def configure_time_zone
-      config = <<-RUBY
-    config.active_record.default_timezone = :utc
-      RUBY
-
-      inject_into_class 'config/application.rb', 'Application', config
-    end
-
     def configure_time_formats
       remove_file "config/locales/en.yml"
       template "config_locales_en.yml.erb", "config/locales/en.yml"
@@ -300,9 +286,13 @@ end
     end
 
     def create_heroku_apps(flags)
+      rack_env = "RACK_ENV=staging RAILS_ENV=staging"
+      rails_serve_static_files = "RAILS_SERVE_STATIC_FILES=true"
+      staging_config = "#{rack_env} #{rails_serve_static_files}"
       run_heroku "create #{app_name}-production #{flags}", "production"
       run_heroku "create #{app_name}-staging #{flags}", "staging"
-      run_heroku "config:add RACK_ENV=staging RAILS_ENV=staging", "staging"
+      run_heroku "config:add #{staging_config}", "staging"
+      run_heroku "config:add #{rails_serve_static_files}", "production"
     end
 
     def set_heroku_remotes
@@ -436,10 +426,6 @@ end
       run "#{path_addition} heroku #{command} --remote #{environment}"
     end
 
-    def factories_spec_rake_task
-      IO.read find_in_source_paths('factories_spec_rake_task.rb')
-    end
-
     def generate_secret
       SecureRandom.hex(64)
     end

data/lib/suspenders/generators/app_generator.rb

@@ -18,6 +18,9 @@ module Suspenders
     class_option :skip_test_unit, type: :boolean, aliases: "-T", default: true,
       desc: "Skip Test::Unit files"
 
+    class_option :skip_turbolinks, type: :boolean, default: true,
+      desc: "Skip turbolinks gem"
+
     def finish_template
       invoke :suspenders_customization
       super
@@ -31,7 +34,6 @@ module Suspenders
       invoke :setup_staging_environment
       invoke :setup_secret_token
       invoke :create_suspenders_views
-      invoke :setup_coffeescript
       invoke :configure_app
       invoke :setup_stylesheets
       invoke :install_bitters
@@ -119,15 +121,9 @@ module Suspenders
       build :create_application_layout
     end
 
-    def setup_coffeescript
-      say 'Setting up CoffeeScript defaults'
-      build :remove_turbolinks
-    end
-
     def configure_app
       say 'Configuring app'
       build :configure_action_mailer
-      build :configure_time_zone
       build :configure_time_formats
       build :configure_rack_timeout
       build :configure_simple_form

data/lib/suspenders/version.rb

@@ -1,5 +1,5 @@
 module Suspenders
   RAILS_VERSION = "4.2.0"
   RUBY_VERSION = IO.read("#{File.dirname(__FILE__)}/../../.ruby-version").strip
-  VERSION = "1.23.0"
+  VERSION = "1.24.0"
 end

data/templates/bin_setup.erb

@@ -7,8 +7,8 @@
 set -e
 
 # Set up Ruby dependencies via Bundler
-gem list bundler --installed > /dev/null || gem install bundler
-bundle install
+gem install bundler --conservative
+bundle check || bundle install
 
 # Set up configurable environment variables
 if [ ! -f .env ]; then

data/templates/suspenders_layout.html.erb.erb

@@ -4,6 +4,11 @@
   <meta charset="utf-8" />
   <meta name="ROBOTS" content="NOODP" />
   <meta name="viewport" content="initial-scale=1" />
+  <%%#
+    Configure default and controller-, and view-specific titles in
+    config/locales/en.yml. For more see:
+    https://github.com/calebthompson/title#usage
+  %>
   <title><%%= title %></title>
   <%%= stylesheet_link_tag :application, media: "all" %>
   <%%= csrf_meta_tags %>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspenders
 version: !ruby/object:Gem::Version
-  version: 1.23.0
+  version: 1.24.0
 platform: ruby
 authors:
 - thoughtbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-19 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitters