suspenders 1.16.0 → 1.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca9b05977b2bd1059a7d8f10ddfc7c797cdb6e54
-  data.tar.gz: 0854bdf533abed015ced2096ff37d44cf7830e8a
+  metadata.gz: d3d69233667fc34f1e795937ac85a02b7c5d6440
+  data.tar.gz: 23a405772fc9b1ae2d8e7fd5849161ace621bf44
 SHA512:
-  metadata.gz: d5677d15f7c00172890b334718abdb2c9f09e9ec4c7415032684dab5f4bee688b94b1dd245a82f33417bff3a7e3c5089d7011c239fe516c322d9b70cdf15e455
-  data.tar.gz: 5a564a4598fe4baafcd7168c3a5d3ce868d054f12a64a2d0bee140b84d0675dac8f5e418272567aabf677e430664f418582218367fa1cb67abd94af5cd4f8399
+  metadata.gz: cb7312ccc78cc42ea226c3ac331ec0d5b4637db8fe82fab1075a903913dc8f547cec70ab4437f3496459b8dbce6e5c646e220537b1c9797ababe6b5538302088
+  data.tar.gz: 0b5d280d14550eac765f1a3b11e8a28b6054fb249d34f60054dce920698b5795dd0511da66506b0cc1a04d12dd85006f13939b5e1920c9ade8d10da9f88a576b

data/Gemfile.lock

@@ -1,35 +1,35 @@
 PATH
   remote: .
   specs:
-    suspenders (1.16.0)
+    suspenders (1.17.0)
       bitters (~> 0.10.0)
       bundler (~> 1.3)
-      rails (= 4.1.4)
+      rails (= 4.1.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionmailer (4.1.4)
-      actionpack (= 4.1.4)
-      actionview (= 4.1.4)
-      mail (~> 2.5.4)
-    actionpack (4.1.4)
-      actionview (= 4.1.4)
-      activesupport (= 4.1.4)
+    actionmailer (4.1.6)
+      actionpack (= 4.1.6)
+      actionview (= 4.1.6)
+      mail (~> 2.5, >= 2.5.4)
+    actionpack (4.1.6)
+      actionview (= 4.1.6)
+      activesupport (= 4.1.6)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    actionview (4.1.4)
-      activesupport (= 4.1.4)
+    actionview (4.1.6)
+      activesupport (= 4.1.6)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activemodel (4.1.4)
-      activesupport (= 4.1.4)
+    activemodel (4.1.6)
+      activesupport (= 4.1.6)
       builder (~> 3.1)
-    activerecord (4.1.4)
-      activemodel (= 4.1.4)
-      activesupport (= 4.1.4)
+    activerecord (4.1.6)
+      activemodel (= 4.1.6)
+      activesupport (= 4.1.6)
       arel (~> 5.0.0)
-    activesupport (4.1.4)
+    activesupport (4.1.6)
       i18n (~> 0.6, >= 0.6.9)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -70,33 +70,31 @@ GEM
     hike (1.2.3)
     i18n (0.6.11)
     json (1.8.1)
-    mail (2.5.4)
-      mime-types (~> 1.16)
-      treetop (~> 1.4.8)
+    mail (2.6.1)
+      mime-types (>= 1.16, < 3)
     mime-types (1.25.1)
     mini_portile (0.6.0)
-    minitest (5.4.0)
+    minitest (5.4.2)
     multi_json (1.10.1)
     multi_test (0.1.1)
     nokogiri (1.6.2.1)
       mini_portile (= 0.6.0)
-    polyglot (0.3.5)
     rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    rails (4.1.4)
-      actionmailer (= 4.1.4)
-      actionpack (= 4.1.4)
-      actionview (= 4.1.4)
-      activemodel (= 4.1.4)
-      activerecord (= 4.1.4)
-      activesupport (= 4.1.4)
+    rails (4.1.6)
+      actionmailer (= 4.1.6)
+      actionpack (= 4.1.6)
+      actionview (= 4.1.6)
+      activemodel (= 4.1.6)
+      activerecord (= 4.1.6)
+      activesupport (= 4.1.6)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 4.1.4)
+      railties (= 4.1.6)
       sprockets-rails (~> 2.0)
-    railties (4.1.4)
-      actionpack (= 4.1.4)
-      activesupport (= 4.1.4)
+    railties (4.1.6)
+      actionpack (= 4.1.6)
+      activesupport (= 4.1.6)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.3.2)
@@ -108,22 +106,19 @@ GEM
     rspec-expectations (2.99.0)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.99.0)
-    sass (3.3.14)
-    sprockets (2.12.1)
+    sass (3.4.3)
+    sprockets (2.12.2)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.1.3)
+    sprockets-rails (2.1.4)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (~> 2.8)
     thor (0.19.1)
     thread_safe (0.3.4)
     tilt (1.4.1)
-    treetop (1.4.15)
-      polyglot
-      polyglot (>= 0.3.1)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
     xpath (2.0.0)

data/NEWS.md

@@ -1,3 +1,12 @@
+1.17.0 (September 30, 2014)
+
+* Use Rails 4.1.6.
+* Generate a `spec/rails_helper.rb` and `spec/spec_helper.rb` following
+  RSpec 3.x's example, but using our defaults.
+* Raise on missing i18n translations in test environment.
+* Raise on unpermitted parameters in test environment.
+* Provide example for using Title gem for internationalizing page title text.
+
 1.16.0 (August 16, 2014)
 
 * Use the 3.x series of RSpec.

data/lib/suspenders/app_builder.rb

@@ -12,17 +12,11 @@ module Suspenders
     end
 
     def raise_on_unpermitted_parameters
-      action_on_unpermitted_parameters = <<-RUBY
-
-  # Raise an ActionController::UnpermittedParameters exception when
-  # a parameter is not explicitly permitted but is passed anyway.
-  config.action_controller.action_on_unpermitted_parameters = :raise
+      config = <<-RUBY
+    config.action_controller.action_on_unpermitted_parameters = :raise
       RUBY
-      inject_into_file(
-        "config/environments/development.rb",
-        action_on_unpermitted_parameters,
-        before: "\nend"
-      )
+
+      inject_into_class "config/application.rb", "Application", config
     end
 
     def provide_setup_script
@@ -36,6 +30,7 @@ module Suspenders
 
     def configure_generators
       config = <<-RUBY
+
     config.generators do |generate|
       generate.helper false
       generate.javascript_engine false
@@ -175,16 +170,23 @@ end
     end
 
     def configure_rspec
-      remove_file 'spec/spec_helper.rb'
-      copy_file 'spec_helper.rb', 'spec/spec_helper.rb'
+      remove_file "spec/rails_helper.rb"
+      remove_file "spec/spec_helper.rb"
+      copy_file "rails_helper.rb", "spec/rails_helper.rb"
+      copy_file "spec_helper.rb", "spec/spec_helper.rb"
     end
 
     def configure_travis
       template 'travis.yml.erb', '.travis.yml'
     end
 
-    def configure_i18n_for_development_environment
+    def configure_i18n_for_test_environment
+      copy_file "i18n.rb", "spec/support/i18n.rb"
+    end
+
+    def configure_i18n_for_missing_translations
       raise_on_missing_translations_in("development")
+      raise_on_missing_translations_in("test")
     end
 
     def configure_i18n_tasks
@@ -204,8 +206,8 @@ end
     def configure_time_zone
       config = <<-RUBY
     config.active_record.default_timezone = :utc
-
       RUBY
+
       inject_into_class 'config/application.rb', 'Application', config
     end
 
@@ -228,8 +230,8 @@ end
     def fix_i18n_deprecation_warning
       config = <<-RUBY
     config.i18n.enforce_available_locales = true
-
       RUBY
+
       inject_into_class 'config/application.rb', 'Application', config
     end
 

data/lib/suspenders/generators/app_generator.rb

@@ -71,7 +71,7 @@ module Suspenders
       build :provide_setup_script
       build :provide_dev_prime_task
       build :configure_generators
-      build :configure_i18n_for_development_environment
+      build :configure_i18n_for_missing_translations
     end
 
     def setup_test_environment
@@ -83,6 +83,7 @@ module Suspenders
       build :enable_database_cleaner
       build :configure_spec_support_features
       build :configure_travis
+      build :configure_i18n_for_test_environment
       build :configure_i18n_tasks
       build :configure_action_mailer_in_specs
     end

data/lib/suspenders/version.rb

@@ -1,5 +1,5 @@
 module Suspenders
-  RAILS_VERSION = '4.1.4'
+  RAILS_VERSION = "4.1.6"
   RUBY_VERSION = IO.read("#{File.dirname(__FILE__)}/../../.ruby-version").strip
-  VERSION = '1.16.0'
+  VERSION = "1.17.0"
 end

data/spec/features/new_project_spec.rb

@@ -43,6 +43,12 @@ feature 'Suspend a new project with default configuration' do
     expect(File).to exist("#{project_path}/spec/support/action_mailer.rb")
   end
 
+  scenario "i18n support file is added" do
+    run_suspenders
+
+    expect(File).to exist("#{project_path}/spec/support/i18n.rb")
+  end
+
   scenario 'newrelic.yml reads NewRelic license from env' do
     run_suspenders
 
@@ -62,16 +68,28 @@ feature 'Suspend a new project with default configuration' do
       to include(%{window.analytics.load("<%= ENV["SEGMENT_IO_KEY"] %>");})
   end
 
-  scenario "raises on missing translations in development" do
+  scenario "raises on unpermitted parameters in all environments" do
     run_suspenders
 
-    environment_file =
-      IO.read("#{project_path}/config/environments/development.rb")
-    expect(environment_file).to match(
-      /^ +config.action_view.raise_on_missing_translations = true$/
+    result = IO.read("#{project_path}/config/application.rb")
+
+    expect(result).to match(
+      /^ +config.action_controller.action_on_unpermitted_parameters = :raise$/
     )
   end
 
+  scenario "raises on missing translations in development and test" do
+    run_suspenders
+
+    %w[development test].each do |environment|
+      environment_file =
+        IO.read("#{project_path}/config/environments/#{environment}.rb")
+      expect(environment_file).to match(
+        /^ +config.action_view.raise_on_missing_translations = true$/
+      )
+    end
+  end
+
   scenario "specs for missing or unused translations" do
     run_suspenders
 

data/templates/application.css.scss

@@ -1,5 +1,6 @@
 @charset 'utf-8';
 
+@import 'normalize-rails';
 @import 'bourbon';
 @import 'base/grid-settings';
 @import 'neat';

data/templates/bin_setup.erb

@@ -24,7 +24,7 @@ mkdir -p .git/safe
 echo "port: <%= config[:port_number] %>" > .foreman
 
 # Print warning if Foreman is not installed
-if ! command -v foreman &>/dev/null; then
+if ! command -v foreman > /dev/null; then
   echo "foreman is not installed."
   echo "See https://github.com/ddollar/foreman for install instructions."
 fi

data/templates/config_i18n_tasks.yml

@@ -10,3 +10,4 @@ ignore_unused:
   - date.*
   - simple_form.*
   - time.*
+  - titles.*

data/templates/config_locales_en.yml

@@ -14,3 +14,6 @@ en:
         "%b %-d, %Y"
       short:
         "%B %d"
+
+  titles:
+    application: <%= app_name.humanize %>

data/templates/rails_helper.rb

@@ -0,0 +1,23 @@
+ENV["RAILS_ENV"] = "test"
+
+require File.expand_path("../../config/environment", __FILE__)
+
+require "rspec/rails"
+require "shoulda/matchers"
+
+Dir[Rails.root.join("spec/support/**/*.rb")].each { |file| require file }
+
+module Features
+  # Extend this module in spec/support/features/*.rb
+  include Formulaic::Dsl
+end
+
+RSpec.configure do |config|
+  config.include Features, type: :feature
+  config.infer_base_class_for_anonymous_controllers = false
+  config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = false
+end
+
+ActiveRecord::Migration.maintain_test_schema!
+Capybara.javascript_driver = :webkit

data/templates/spec_helper.rb

@@ -1,30 +1,16 @@
-ENV["RAILS_ENV"] = "test"
-
-require File.expand_path("../../config/environment", __FILE__)
-
-require "rspec/rails"
-require "shoulda/matchers"
 require "webmock/rspec"
 
-Dir[Rails.root.join("spec/support/**/*.rb")].each { |file| require file }
-
-module Features
-  # Extend this module in spec/support/features/*.rb
-  include Formulaic::Dsl
-end
-
+# http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  config.expect_with :rspec do |c|
-    c.syntax = :expect
+  config.expect_with :rspec do |expectations|
+    expectations.syntax = :expect
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.syntax = :expect
   end
 
-  config.include Features, type: :feature
-  config.infer_base_class_for_anonymous_controllers = false
-  config.infer_spec_type_from_file_location!
-  config.order = "random"
-  config.use_transactional_fixtures = false
+  config.order = :random
 end
 
-ActiveRecord::Migration.maintain_test_schema!
-Capybara.javascript_driver = :webkit
 WebMock.disable_net_connect!(allow_localhost: true)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suspenders
 version: !ruby/object:Gem::Version
-  version: 1.16.0
+  version: 1.17.0
 platform: ruby
 authors:
 - thoughtbot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-16 00:00:00.000000000 Z
+date: 2014-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitters
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.1.4
+        version: 4.1.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.1.4
+        version: 4.1.6
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
@@ -176,6 +176,7 @@ files:
 - templates/newrelic.yml.erb
 - templates/postgresql_database.yml.erb
 - templates/rack_timeout.rb
+- templates/rails_helper.rb
 - templates/sample.env
 - templates/secrets.yml
 - templates/smtp.rb