surus 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3aff7e0e8b000df98229acb0c68f228f94ca85d
-  data.tar.gz: dec38237d5576383026aae08b756084686c0584b
+  metadata.gz: 3979b782fd1e13d2e96ba994192cacf5433c53d7
+  data.tar.gz: 8f030cf17f9d8fb30dace66d08edb1b224a192bf
 SHA512:
-  metadata.gz: e6ffb1bbac2326e6a07ab64340d94414c68f7b34fd921b2570091a02b83638092d26381590617b8b156a108a84f5256e1c938d64c516b0b8c640c03905a41251
-  data.tar.gz: a38ecc94ac49448b5039f8aac1c18f665575fa912ad3a44224ac4cefc7e209adac1fb70498d4a6a8952a013fe4f4eb88aaa81d1857c4085e9873a3ecf6504e1b
+  metadata.gz: aab88cce49c5e6582b04c14b43e38da23e7463fec01e5772650537d241fa23cf6e1fdf06a40a57e6e3d5e2a4663dc8700d9b7e95a01914b9196b494c91a55b58
+  data.tar.gz: c3da04f7796d29af7a73d1ffff121ef2f206613921f8f1b6456e52257ee4e31bfc74bd32e0c9d3f123c1eb49c588b40e588d2c3517d2212a0baa74e57058fb44

data/.rubocop.yml

@@ -0,0 +1,7 @@
+inherit_from: .rubocop_todo.yml
+
+AllCops:
+  Exclude:
+    - surus.gemspec
+    - Guardfile
+    - Rakefile

data/.rubocop_todo.yml

@@ -0,0 +1,339 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-03-24 13:49:46 -0500 using RuboCop version 0.38.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/DeprecatedClassMethods:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
+Lint/EndAlignment:
+  Enabled: false
+
+# Offense count: 1
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+
+# Offense count: 1
+Lint/UnderscorePrefixedVariableName:
+  Exclude:
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'bench/hstore_find.rb'
+
+# Offense count: 7
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+    - 'spec/json/json_spec.rb'
+
+# Offense count: 7
+Metrics/AbcSize:
+  Max: 30
+
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 245
+
+# Offense count: 4
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+# Offense count: 76
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 151
+
+# Offense count: 7
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 220
+
+# Offense count: 2
+Metrics/PerceivedComplexity:
+  Max: 12
+
+# Offense count: 1
+Performance/TimesMap:
+  Exclude:
+    - 'bench/hstore_find.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: outdent, indent
+Style/AccessModifierIndentation:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Style/AlignHash:
+  Exclude:
+    - 'bench/synchronous_commit.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: with_first_parameter, with_fixed_indentation
+Style/AlignParameters:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: percent_q, bare_percent
+Style/BarePercentLiterals:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# SupportedStyles: case, end
+Style/CaseIndentation:
+  Enabled: false
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: is_a?, kind_of?
+Style/ClassCheck:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SingleLineConditionsOnly.
+Style/ConditionalAssignment:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 22
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'bench/benchmark_helper.rb'
+    - 'lib/generators/surus/hstore/install_generator.rb'
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+    - 'lib/surus/array/scope.rb'
+    - 'lib/surus/hstore/scope.rb'
+    - 'lib/surus/hstore/serializer.rb'
+    - 'lib/surus/json/array_agg_query.rb'
+    - 'lib/surus/json/association_scope_builder.rb'
+    - 'lib/surus/json/belongs_to_scope_builder.rb'
+    - 'lib/surus/json/has_and_belongs_to_many_scope_builder.rb'
+    - 'lib/surus/json/has_many_scope_builder.rb'
+    - 'lib/surus/json/model.rb'
+    - 'lib/surus/json/query.rb'
+    - 'lib/surus/json/row_query.rb'
+    - 'lib/surus/synchronous_commit/connection.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/ElseAlignment:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/EmptyLines:
+  Exclude:
+    - 'bench/hstore_find.rb'
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundAccessModifier:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+    - 'lib/surus/array/scope.rb'
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundClassBody:
+  Exclude:
+    - 'lib/generators/surus/hstore/install_generator.rb'
+    - 'lib/surus/json/has_and_belongs_to_many_scope_builder.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundMethodBody:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
+  Exclude:
+    - 'spec/factories.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Exclude:
+    - 'lib/generators/surus/hstore/install_generator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: normal, rails
+Style/IndentationConsistency:
+  Exclude:
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: Width.
+Style/IndentationWidth:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'lib/surus/version.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/NilComparison:
+  Exclude:
+    - 'lib/surus/hstore/serializer.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  MinDigits: 6
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'spec/array/scope_spec.rb'
+    - 'spec/hstore/serializer_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/SpaceAfterComma:
+  Exclude:
+    - 'bench/benchmark_helper.rb'
+    - 'spec/hstore/serializer_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SpaceAroundKeyword:
+  Exclude:
+    - 'lib/generators/surus/hstore/templates/install_hstore.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceBeforeBlockBraces:
+  Enabled: false
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
+# SupportedStyles: space, no_space
+Style/SpaceInsideBlockBraces:
+  Enabled: false
+
+# Offense count: 74
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 272
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/Tab:
+  Exclude:
+    - 'lib/surus/json/query.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+  Exclude:
+    - 'spec/hstore/serializer_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
+Style/TrivialAccessors:
+  Exclude:
+    - 'bench/benchmark_helper.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Exclude:
+    - 'lib/surus/json/has_many_scope_builder.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  Enabled: false

data/.travis.yml

@@ -1,12 +1,18 @@
 language: ruby
 rvm:
-  - 2.2.0
-  - 2.1.5
-  - 2.0.0
+  - 2.3.1
+  - 2.2.5
+  - 2.1.9
+  - rbx
 gemfile:
   - gemfiles/4.0.gemfile
   - gemfiles/4.1.gemfile
   - gemfiles/4.2.gemfile
+  - gemfiles/5.0.gemfile
+
+matrix:
+  allow_failures:
+    - rvm: rbx
 
 addons:
   postgresql: "9.2"
@@ -15,3 +21,7 @@ before_script:
   - cp spec/database.yml.travis spec/database.yml
   - psql -U postgres -c 'create database surus_test;'
   - psql -U postgres -f spec/database_structure.sql surus_test
+
+script:
+  - bundle exec rake spec
+  - bundle exec rubocop

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.6.3 (May 14, 2016)
+
+* Gemspec allows Rails 5
+
 # 0.6.2 (November 19, 2015)
 
 * Prefix column name with table names in query conditions (Michał Krzyżanowski)

data/bench/benchmark_helper.rb

@@ -31,7 +31,7 @@ class EavMasterRecord < ActiveRecord::Base
   def persist_properties
     eav_detail_records.clear
     @properties.each do |k,v|
-      eav_detail_records.create! :key => k, :value => v
+      eav_detail_records.create! key: k, value: v
     end
   end
 end

data/bench/hstore_find.rb

@@ -45,7 +45,7 @@ if eav
   print "Creating EAV test data... "
   EavMasterRecord.transaction do
     num_records.times do |i|
-      EavMasterRecord.create! :properties => key_value_pairs[i]
+      EavMasterRecord.create! properties: key_value_pairs[i]
     end
   end
   puts "Done."
@@ -54,7 +54,7 @@ end
 print "Creating Surus test data... "
 SurusKeyValueRecord.transaction do
   num_records.times do |i|
-    SurusKeyValueRecord.create! :properties => key_value_pairs[i]
+    SurusKeyValueRecord.create! properties: key_value_pairs[i]
   end
 end
 puts "Done."
@@ -63,7 +63,7 @@ if yaml
   print "Creating YAML test data... "
   YamlKeyValueRecord.transaction do
     num_records.times do |i|
-      YamlKeyValueRecord.create! :properties => key_value_pairs[i]
+      YamlKeyValueRecord.create! properties: key_value_pairs[i]
     end
   end
   puts "Done."

data/bench/synchronous_commit.rb

@@ -20,22 +20,22 @@ puts "Done."
 random_io = StringIO.new(random_string)
 
 create_wide_record = lambda do
-  WideRecord.create! :a => random_io.read(wide_field_width),
-    :b => random_io.read(wide_field_width),
-    :c => random_io.read(wide_field_width),
-    :d => random_io.read(wide_field_width),
-    :e => random_io.read(wide_field_width),
-    :f => random_io.read(wide_field_width),
-    :g => random_io.read(wide_field_width),
-    :h => random_io.read(wide_field_width),
-    :i => random_io.read(wide_field_width),
-    :j => random_io.read(wide_field_width)
+  WideRecord.create! a: random_io.read(wide_field_width),
+    b: random_io.read(wide_field_width),
+    c: random_io.read(wide_field_width),
+    d: random_io.read(wide_field_width),
+    e: random_io.read(wide_field_width),
+    f: random_io.read(wide_field_width),
+    g: random_io.read(wide_field_width),
+    h: random_io.read(wide_field_width),
+    i: random_io.read(wide_field_width),
+    j: random_io.read(wide_field_width)
 end
 
 create_narrow_record = lambda do
-  NarrowRecord.create! :a => random_io.read(narrow_field_width),
-    :b => random_io.read(narrow_field_width),
-    :c => random_io.read(narrow_field_width)
+  NarrowRecord.create! a: random_io.read(narrow_field_width),
+    b: random_io.read(narrow_field_width),
+    c: random_io.read(narrow_field_width)
 end
 
 { "narrow" => create_narrow_record, "wide" => create_wide_record }.each do |text, create_record|
@@ -48,15 +48,15 @@ end
     WideRecord.synchronous_commit true
     x.report("enabled") do
       num_records.times { create_record.call }
-    end 
+    end
 
     clean_database
     random_io.rewind
     WideRecord.synchronous_commit false
     x.report("disabled") do
       num_records.times { create_record.call }
-    end   
-    
+    end
+
     clean_database
     random_io.rewind
     WideRecord.synchronous_commit true
@@ -68,7 +68,7 @@ end
         end
       end
     end
-    
+
     clean_database
     random_io.rewind
     WideRecord.synchronous_commit true
@@ -76,8 +76,8 @@ end
       WideRecord.transaction do
         num_records.times { create_record.call }
       end
-    end   
-    
+    end
+
     clean_database
     random_io.rewind
     WideRecord.synchronous_commit false
@@ -85,6 +85,6 @@ end
       WideRecord.transaction do
         num_records.times { create_record.call }
       end
-    end  
+    end
   end
 end

data/gemfiles/4.0.gemfile

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
 
-gem "activerecord", "4.0.0"
+gem "activerecord", "4.0.13"
 
 gemspec :path=>"../"

data/gemfiles/4.1.gemfile

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
 
-gem "activerecord", "~> 4.1.8"
+gem "activerecord", "~> 4.1.14"
 
 gemspec :path=>"../"

data/gemfiles/4.2.gemfile

@@ -1,5 +1,5 @@
 source "https://rubygems.org"
 
-gem "activerecord", "~> 4.2.0"
+gem "activerecord", "~> 4.2.5"
 
 gemspec :path=>"../"

data/gemfiles/5.0.gemfile

@@ -0,0 +1,5 @@
+source "https://rubygems.org"
+
+gem "activerecord", "~> 5.0.0.rc1"
+
+gemspec :path=>"../"

data/lib/surus.rb

@@ -5,11 +5,4 @@ require 'surus/hstore/scope'
 require 'surus/array/scope'
 require 'surus/synchronous_commit/connection'
 require 'surus/synchronous_commit/model'
-require 'surus/json/query'
-require 'surus/json/row_query'
-require 'surus/json/array_agg_query'
-require 'surus/json/model'
-require 'surus/json/association_scope_builder'
-require 'surus/json/belongs_to_scope_builder'
-require 'surus/json/has_many_scope_builder'
-require 'surus/json/has_and_belongs_to_many_scope_builder'
+require 'surus/json'

data/lib/surus/hstore/scope.rb

@@ -14,7 +14,7 @@ module Surus
       # Example:
       #   User.hstore_has_key(:properties, "favorite_color")
       def hstore_has_key(column, key)
-        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ? :key", :key => key)
+        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ? :key", key: key)
       end
 
       # Adds a where condition that requires column to contain all keys.
@@ -23,7 +23,7 @@ module Surus
       #    User.hstore_has_all_keys(:properties, "favorite_color", "favorite_song")
       #    User.hstore_has_all_keys(:properties, ["favorite_color", "favorite_song"])
       def hstore_has_all_keys(column, *keys)
-        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ?& ARRAY[:keys]", :keys => keys.flatten)
+        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ?& ARRAY[:keys]", keys: keys.flatten)
       end
 
       # Adds a where condition that requires column to contain any keys.
@@ -32,7 +32,7 @@ module Surus
       #    User.hstore_has_any_keys(:properties, "favorite_color", "favorite_song")
       #    User.hstore_has_any_keys(:properties, ["favorite_color", "favorite_song"])
       def hstore_has_any_keys(column, *keys)
-        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ?| ARRAY[:keys]", :keys => keys.flatten)
+        where("#{connection.quote_table_name(table_name)}.#{connection.quote_column_name(column)} ?| ARRAY[:keys]", keys: keys.flatten)
       end
     end
   end

data/lib/surus/json.rb

@@ -0,0 +1,8 @@
+require 'surus/json/query'
+require 'surus/json/row_query'
+require 'surus/json/array_agg_query'
+require 'surus/json/model'
+require 'surus/json/association_scope_builder'
+require 'surus/json/belongs_to_scope_builder'
+require 'surus/json/has_many_scope_builder'
+require 'surus/json/has_and_belongs_to_many_scope_builder'

data/lib/surus/synchronous_commit/connection.rb

@@ -12,14 +12,14 @@ module Surus
           self.synchronous_commit = value
         end
       end
-      
+
       # Changes current synchronous_commit state. If a transaction is currently
       # in progress the change will be reverted at the end of the transaction.
       #
       # Requires true or false to be passed exactly -- not merely truthy or falsy
       def synchronous_commit=(value)
         raise ArgumentError, "argument must be true or false" unless value == true || value == false
-        
+
         execute "SET #{'LOCAL' if open_transactions > 0} synchronous_commit TO #{value ? 'ON' : 'OFF'}"
       end
     end

data/lib/surus/synchronous_commit/model.rb

@@ -3,7 +3,7 @@ module Surus
     # synchronous_commit and synchronous_commit= are delegated to the underlying
     # connection object
     module Model
-      delegate :synchronous_commit, :synchronous_commit=, :to => :connection
+      delegate :synchronous_commit, :synchronous_commit=, to: :connection
     end
   end
 end

data/lib/surus/version.rb

@@ -1,3 +1,3 @@
 module Surus
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
 end

data/spec/array/scope_spec.rb

@@ -1,11 +1,11 @@
 require 'spec_helper'
 
 describe Surus::Array::Scope do
-  let!(:empty) { TextArrayRecord.create! :texts => [] }
+  let!(:empty) { TextArrayRecord.create! texts: [] }
 
   context "array_has" do
-    let!(:match) { TextArrayRecord.create! :texts => %w{a b} }
-    let!(:missing_element) { TextArrayRecord.create! :texts => %w{a} }
+    let!(:match) { TextArrayRecord.create! texts: %w{a b} }
+    let!(:missing_element) { TextArrayRecord.create! texts: %w{a} }
 
     def self.shared_examples
       it { should include(match) }
@@ -30,8 +30,8 @@ describe Surus::Array::Scope do
   end
 
   context "array_has_any" do
-    let!(:match) { TextArrayRecord.create! :texts => %w{a b} }
-    let!(:missing_element) { TextArrayRecord.create! :texts => %w{a} }
+    let!(:match) { TextArrayRecord.create! texts: %w{a b} }
+    let!(:missing_element) { TextArrayRecord.create! texts: %w{a} }
 
     def self.shared_examples
       it { should include(match) }
@@ -56,7 +56,7 @@ describe Surus::Array::Scope do
   end
 
   it "casts between varchar[] and text[]" do
-    record = VarcharArrayRecord.create! :varchars => %w{a b}
+    record = VarcharArrayRecord.create! varchars: %w{a b}
     expect(VarcharArrayRecord.array_has_any(:varchars, "a")).to include(record)
     expect(VarcharArrayRecord.array_has_any(:varchars, "c")).to_not include(record)
     expect(VarcharArrayRecord.array_has_any(:varchars, "b", "c")).to include(record)

data/spec/hstore/scope_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe Surus::Hstore::Scope do
-  let!(:empty) { HstoreRecord.create! :properties => {} }
+  let!(:empty) { HstoreRecord.create! properties: {} }
 
   context "hstore_has_pairs" do
-    let!(:match) { HstoreRecord.create! :properties => { "a" => "1", "b" => "2", "c" => "3" } }
-    let!(:missing_key) { HstoreRecord.create! :properties => { "a" => "1", "c" => "3" } }
-    let!(:wrong_value) { HstoreRecord.create! :properties => { "a" => "1", "b" => "5" } }
+    let!(:match) { HstoreRecord.create! properties: { "a" => "1", "b" => "2", "c" => "3" } }
+    let!(:missing_key) { HstoreRecord.create! properties: { "a" => "1", "c" => "3" } }
+    let!(:wrong_value) { HstoreRecord.create! properties: { "a" => "1", "b" => "5" } }
 
     subject { HstoreRecord.hstore_has_pairs(:properties, "a" => "1", "b" => "2") }
 
@@ -17,8 +17,8 @@ describe Surus::Hstore::Scope do
   end
 
   context "hstore_has_key" do
-    let!(:match) { HstoreRecord.create! :properties => { "a" => "1", "b" => "2" } }
-    let!(:missing_key) { HstoreRecord.create! :properties => { "a" => "1", "c" => "3" } }
+    let!(:match) { HstoreRecord.create! properties: { "a" => "1", "b" => "2" } }
+    let!(:missing_key) { HstoreRecord.create! properties: { "a" => "1", "c" => "3" } }
 
     subject { HstoreRecord.hstore_has_key(:properties, "b") }
 
@@ -28,9 +28,9 @@ describe Surus::Hstore::Scope do
   end
 
   context "hstore_has_all_keys" do
-    let!(:match) { HstoreRecord.create! :properties => { "a" => "1", "b" => "2", "c" => "3" } }
-    let!(:missing_one_key) { HstoreRecord.create! :properties => { "b" => "2", "c" => "3" } }
-    let!(:missing_all_keys) { HstoreRecord.create! :properties => { "f" => "1", "g" => "2" } }
+    let!(:match) { HstoreRecord.create! properties: { "a" => "1", "b" => "2", "c" => "3" } }
+    let!(:missing_one_key) { HstoreRecord.create! properties: { "b" => "2", "c" => "3" } }
+    let!(:missing_all_keys) { HstoreRecord.create! properties: { "f" => "1", "g" => "2" } }
 
     def self.shared_examples
       it { should include(match) }
@@ -51,9 +51,9 @@ describe Surus::Hstore::Scope do
   end
 
   context "hstore_has_any_key" do
-    let!(:match_1) { HstoreRecord.create! :properties => { "a" => "1", "c" => "3" } }
-    let!(:match_2) { HstoreRecord.create! :properties => { "b" => "2", "d" => "4" } }
-    let!(:missing_all_keys) { HstoreRecord.create! :properties => { "c" => "3", "d" => "4" } }
+    let!(:match_1) { HstoreRecord.create! properties: { "a" => "1", "c" => "3" } }
+    let!(:match_2) { HstoreRecord.create! properties: { "b" => "2", "d" => "4" } }
+    let!(:missing_all_keys) { HstoreRecord.create! properties: { "c" => "3", "d" => "4" } }
 
     def self.shared_examples
       it { should include(match_1) }

data/spec/hstore/serializer_spec.rb

@@ -58,9 +58,19 @@ describe Surus::Hstore::Serializer do
 
   round_trip_examples.each do |value, description|
     it "round trips when #{description}" do
-      r = HstoreRecord.create! :properties => value
+      r = HstoreRecord.create! properties: value
       r.reload
       expect(r.properties).to eq(value)
     end
   end
+
+  context 'Stringify' do
+    it 'should store the values as UTC for Date' do
+      date = ::Time.find_zone!('Melbourne').now.to_datetime
+      serializer = Surus::Hstore::Serializer.new
+      result = serializer.stringify date
+      expect(result).to eq([date.to_s(:db), "Date"])
+      expect(result).to_not eq([date.to_s, "Date"])
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -86,4 +86,3 @@ RSpec.configure do |config|
     c.syntax = :expect
   end
 end
-

data/spec/synchronous_commit/connection_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Surus::SynchronousCommit::Connection, :disable_transactions => true do
+describe Surus::SynchronousCommit::Connection, disable_transactions: true do
   let(:conn) { ActiveRecord::Base.connection }
   before { conn.execute "SET synchronous_commit TO ON;" }
   after { conn.execute "SET synchronous_commit TO ON;" }

data/surus.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # specify any dependencies here; for example:
-  s.add_dependency 'activerecord', "~> 4.0"
+  s.add_dependency 'activerecord', "> 4.0"
 
   s.add_development_dependency 'rspec', "~> 3.1.0"
   s.add_development_dependency 'guard', ">= 0.10.0"
@@ -36,4 +36,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'factory_girl', '~> 4.2.0'
   s.add_development_dependency 'faker', '~> 1.4.3'
   s.add_development_dependency 'rake'
+  s.add_development_dependency 'rubocop'
 end

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: surus
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Jack Christensen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-19 00:00:00.000000000 Z
+date: 2016-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
@@ -164,6 +164,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: "Surus accelerates ActiveRecord with PostgreSQL specific types and\n
   \                   functionality. It enables indexed searching of serialized arrays
   and hashes.\n                    It also can control PostgreSQL synchronous commit
@@ -177,6 +191,8 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -193,12 +209,14 @@ files:
 - gemfiles/4.0.gemfile
 - gemfiles/4.1.gemfile
 - gemfiles/4.2.gemfile
+- gemfiles/5.0.gemfile
 - lib/generators/surus/hstore/install_generator.rb
 - lib/generators/surus/hstore/templates/install_hstore.rb
 - lib/surus.rb
 - lib/surus/array/scope.rb
 - lib/surus/hstore/scope.rb
 - lib/surus/hstore/serializer.rb
+- lib/surus/json.rb
 - lib/surus/json/array_agg_query.rb
 - lib/surus/json/association_scope_builder.rb
 - lib/surus/json/belongs_to_scope_builder.rb
@@ -243,19 +261,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: ''
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: PostgreSQL Acceleration for ActiveRecord
-test_files:
-- spec/array/scope_spec.rb
-- spec/database.yml
-- spec/database.yml.travis
-- spec/database_structure.sql
-- spec/factories.rb
-- spec/hstore/scope_spec.rb
-- spec/hstore/serializer_spec.rb
-- spec/json/json_spec.rb
-- spec/spec_helper.rb
-- spec/synchronous_commit/connection_spec.rb
-- spec/synchronous_commit/model_spec.rb
+test_files: []