suretax 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 219c714ae131b08b8baf222151f95fa177096d3cdc382713e513b504e2a25ec4
-  data.tar.gz: e09da2a4482a0710b0b128148d6f69ae066e849bea49d92fae2cfccaf6873e1b
+  metadata.gz: 620a9d4fb40588a041c883da4f0ebeba65d78a03b1b215808c1ad92b8d5cd48d
+  data.tar.gz: 1070aa9064d87eddfa9e541e75cfd45413f95fb9baff06718ae4505b108a76a3
 SHA512:
-  metadata.gz: c802a77252ee299ffd0094ecceb7e23313d0bf69acb66b48ce55036b1d9d8f3fafa4ebd158a414ada32b8ab1dd29f97e6e95ff334729a48a29ef665e7faa3a33
-  data.tar.gz: c704deb4f9b7492aa0a742881b89c9409a896b4bc8c26b39942432336cf66559a754010b42bfa82ebb0151be7c46397e3719ec1cb6561c2611b8cb93dd23f57d
+  metadata.gz: 38ded09d6aa2104b5aa384669a6f5a51ee18178844b0a1e08909cefc9cb8ba549d6a46ce12d167786c872990bf83158e62b33d5274fd696e8bb0f1d977f4792d
+  data.tar.gz: c6931fb4060cb38e409f6b9adead8a81c5b8eb30c6f1af566c678afecb70008dd1ab96b7dce02be95107b481dfc5de8c18f287955cd371cb1e106e11662804e3

data/.circleci/config.yml

@@ -1,35 +1,44 @@
 version: 2
 jobs:
   build:
-    working_directory: ~/suretax
     docker:
-      - image: circleci/ruby:2.6.3
-        environment:
-          RAILS_ENV: test
-          RAKE_ENV: test
-          SURETAX_BASE_URL: "https://testapi.taxrating.net"
-          SURETAX_VALIDATION_KEY: "xxxxxxxxxx"
-          SURETAX_CLIENT_NUMBER: "000000000"
-          SURETAX_POST_PATH: "/Services/V01/SureTax.asmx/PostRequest"
-          SURETAX_CANCEL_PATH: "/Services/V01/SureTax.asmx/CancelPostRequest"
-
+      - image: circleci/ruby:2.7.0
+    environment:
+      RAILS_ENV: test
+      RAKE_ENV: test
+      SURETAX_BASE_URL: "https://testapi.taxrating.net"
+      SURETAX_VALIDATION_KEY: "xxxxxxxxxx"
+      SURETAX_CLIENT_NUMBER: "000000000"
+      SURETAX_POST_PATH: "/Services/V01/SureTax.asmx/PostRequest"
+      SURETAX_CANCEL_PATH: "/Services/V01/SureTax.asmx/CancelPostRequest"
+    working_directory: ~/suretax
     steps:
       - checkout
-
       - restore_cache:
           keys:
-            - suretax-{{ checksum "Gemfile.lock" }}
-      - run: bundle check --path vendor/bundle || bundle install --path=vendor/bundle --jobs 4 --retry 3
+          - v1-dependencies-{{ checksum "Gemfile.lock" }}
+          # fallback to using the latest cache if no exact match is found
+          - v1-dependencies-
+      - run:
+          name: install dependencies
+          command: |
+            bundle install --jobs=4 --retry=3 --path vendor/bundle
       - save_cache:
-          key: suretax-{{ checksum "Gemfile.lock" }}
-          paths: vendor/bundle
-
-      - type: shell
-        command: |
-          bundle exec rspec --color \
-            spec \
-            --out /tmp/test-results/rspec.xml \
-            --format progress
-
-      - type: store_test_results
-        path: /tmp/test-results
+          paths:
+            - ./vendor/bundle
+          key: v1-dependencies-{{ checksum "Gemfile.lock" }}
+      - run:
+          name: run tests
+          command: |
+            mkdir /tmp/test-results
+            TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)"
+            bundle exec rspec --format progress \
+                            --format RspecJunitFormatter \
+                            --out /tmp/test-results/rspec.xml \
+                            --format progress \
+                            $TEST_FILES
+      - store_test_results:
+          path: /tmp/test-results
+      - store_artifacts:
+          path: /tmp/test-results
+          destination: test-results

data/.env.test

@@ -0,0 +1,4 @@
+SURETAX_VALIDATION_KEY=885aa2c6-1a61-4ec6-9aa6-296120572b5e
+SURETAX_CLIENT_NUMBER=000000123
+SURETAX_BASE_URL=https://testapi.taxrating.net
+SURETAX_REQUEST_VERSION=02

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+2.7.0

data/Gemfile

@@ -1,13 +1,12 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in suretax.gemspec
 gemspec
 
 group :development, :test do
   gem "dotenv"
-  gem "pry-byebug", "~> 3.6.0"
-  gem "rspec", "~> 3.8.0"
-  gem "rspec-its", "~> 1.3"
-  gem "rspec_junit_formatter", "~> 0.4.1"
-  gem "webmock", "> 2.3"
+  gem "pry-byebug"
+  gem "rspec", "~> 3.9.0"
+  gem "rspec-its"
+  gem "rspec_junit_formatter"
+  gem "webmock"
 end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    suretax (1.1.1)
+    suretax (1.1.2)
       excon
       monetize
       money (~> 6.13)
@@ -9,51 +9,51 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.6.0)
-      public_suffix (>= 2.0.2, < 4.0)
-    byebug (10.0.2)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    byebug (11.1.3)
     coderay (1.1.2)
-    concurrent-ruby (1.1.5)
+    concurrent-ruby (1.1.6)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
-    dotenv (2.7.2)
-    excon (0.64.0)
-    hashdiff (0.4.0)
-    i18n (1.6.0)
+    dotenv (2.7.5)
+    excon (0.73.0)
+    hashdiff (1.0.1)
+    i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    method_source (0.9.2)
-    monetize (1.9.1)
+    method_source (1.0.0)
+    monetize (1.9.4)
       money (~> 6.12)
-    money (6.13.4)
+    money (6.13.7)
       i18n (>= 0.6.4, <= 2)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.6.0)
-      byebug (~> 10.0)
-      pry (~> 0.10)
-    public_suffix (3.1.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.1)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
+    public_suffix (4.0.5)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
+      rspec-support (~> 3.9.0)
     rspec-its (1.3.0)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.8.1)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
     safe_yaml (1.0.5)
-    webmock (3.6.0)
+    webmock (3.8.3)
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
@@ -63,12 +63,12 @@ PLATFORMS
 
 DEPENDENCIES
   dotenv
-  pry-byebug (~> 3.6.0)
-  rspec (~> 3.8.0)
-  rspec-its (~> 1.3)
-  rspec_junit_formatter (~> 0.4.1)
+  pry-byebug
+  rspec (~> 3.9.0)
+  rspec-its
+  rspec_junit_formatter
   suretax!
-  webmock (> 2.3)
+  webmock
 
 BUNDLED WITH
-   1.17.2
+   2.1.2

data/README.md

@@ -1,6 +1,5 @@
 # Suretax
-[![Code Climate](https://codeclimate.com/github/bqsoft/suretax.png)](https://codeclimate.com/github/bqsoft/suretax)
-
+[![Code Climate](https://codeclimate.com/github/hello-labs/suretax.png)](https://codeclimate.com/github/hello-labs/suretax)
 
 ## Synopsis
 
@@ -28,17 +27,14 @@ Suretax transactions.  The validation_key, client_number, and
 base_url may be overridden by supplying the key when instantiating
 a Suretax::Api::Request object.
 
-
-If not supplied, the base_url will default to the Suretax test 
+If not supplied, the base_url will default to the Suretax test
 host (https://testapi.taxrating.net) and the request version
 and cancel version will default to the latest versions available
 (currently V03 and V01 respectively).
 
-
 You can peek inside the tests for more examples and to see what data
 methods are available.
 
-
 ## Development Environment
 
 Suretax uses [dotenv] to easily switch between development/test environments

data/lib/suretax.rb

@@ -8,6 +8,8 @@ require "suretax/api"
 require "money"
 
 Money.locale_backend = :currency
+Money.default_currency = Money::Currency.new("USD")
+Money.rounding_mode = BigDecimal::ROUND_HALF_EVEN
 
 module Suretax
   class << self

data/lib/suretax/api/request.rb

@@ -1,6 +1,7 @@
 module Suretax
   module Api
     class ValidationError < StandardError; end
+    class ConnectionError < StandardError; end
 
     class Request
       include Suretax::Concerns::Validatable

data/lib/suretax/response.rb

@@ -27,6 +27,8 @@ module Suretax
       @status = map_response_code_to_http_status(api.status)
       log_response
       self
+    rescue JSON::ParserError => e
+      raise(Suretax::Api::ConnectionError, "Failed to parse response from SureTax: #{e.inspect}")
     end
 
     def invalid_request_response(sanitized_body)

data/lib/suretax/version.rb

@@ -1,3 +1,3 @@
 module Suretax
-  VERSION = "1.1.1".freeze
+  VERSION = "1.1.2".freeze
 end

data/spec/lib/suretax/response_spec.rb

@@ -129,4 +129,12 @@ describe Suretax::Response do
       expect(client_response).to_not be_success
     end
   end
+
+  context "when posting fails with a html error" do
+    let(:response_body) { suretax_wrap_response("html error") }
+
+    it "should raise connection error" do
+      expect { client_response }.to raise_error(Suretax::Api::ConnectionError)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,5 @@
-require "dotenv"  # First line of spec_helper
-Dotenv.load       # Second line of spec_helper
+require "dotenv"
+Dotenv.load(".env.test")
 
 require "pry"
 require "rspec"
@@ -15,8 +15,8 @@ end
 RSpec.configure do |config|
   config.before(:each) do
     Suretax.configure do |c|
-      c.validation_key  = ENV["SURETAX_VALIDATION_KEY"]
-      c.client_number   = ENV["SURETAX_CLIENT_NUMBER"]
+      c.validation_key = ENV["SURETAX_VALIDATION_KEY"]
+      c.client_number = ENV["SURETAX_CLIENT_NUMBER"]
     end
   end
 

data/spec/support/request_helper.rb

@@ -351,4 +351,22 @@ module RequestSpecHelper
       common_carrier: nil
     }
   end
+
+  def suretax_html_error
+    "<html xmlns='http://www.w3.org/1999/xhtml'>
+    <head>
+    <meta http-equiv='Content-Type' content='text/html; charset=iso-8859-1'/>
+    <title>502 - Web server received an invalid response while acting as a gateway or proxy server.</title>
+    </head>
+    <body>
+    <div id='header'><h1>Server Error</h1></div>
+    <div id='content'>
+     <div class='content-container'><fieldset>
+      <h2>502 - Web server received an invalid response while acting as a gateway or proxy server.</h2>
+      <h3>There is a problem with the page you are looking for, and it cannot be displayed. When the Web server (while acting as a gateway or proxy) contacted the upstream content server, it received an invalid response from the content server.</h3>
+     </fieldset></div>
+    </div>
+    </body>
+    </html>"
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suretax
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Damon Davison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-14 00:00:00.000000000 Z
+date: 2020-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -61,6 +61,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".env.example"
+- ".env.test"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -68,7 +69,6 @@ files:
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
-- NOTES.md
 - README.md
 - Rakefile
 - lib/suretax.rb
@@ -132,7 +132,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: This gem will allow Ruby developers to easily integrate SureTax into their

data/NOTES.md

@@ -1,3 +0,0 @@
-# Suretax gem notes
-
-- Deal with post failures and parse errors in Response.