suretax 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9df83893a6924ee165b25ebcffb94843365814d2
-  data.tar.gz: b4d9b8b63e316584ec0ac98e3cc0971ffeedd20d
+  metadata.gz: 83671004b396de48f5620725fe6b9a0018cb4db5
+  data.tar.gz: f49dedb91581325d9bd2db9ce02df9a29a63258c
 SHA512:
-  metadata.gz: 18573dca5b6d2b7e762f7346c7c629bd31bb20e821aef93afdf8427a61c6b7976a410ca452d0d7c919f76fd3a2617b13d052917559420eff2f4cb81fc06268e6
-  data.tar.gz: b6973ee2c900a148ba6f038810d229c936a6c589a7949dcb992174b35e07cf3047ac5be1b44f7742839f69f29218b44ceafae2cf040c585ef57b9c29d54a9f1b
+  metadata.gz: 096c0fa430c293ba148e5f3c7477aaf12ad5acb2dc4d101907e7b2b4ad73ade796f53b94c4abb06519e1c097b0ceb0bd82fd107d99db1b5ad730d3dd8657c847
+  data.tar.gz: 0896483b517fe68a1ce69fae78b5fd231e4fbe91e0b9b5a582998a774960c9e0084086f37cab04515090220b556cb73626b8150c726e636a143fde8e4fbbc0bd

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    suretax (0.1.2)
+    suretax (0.1.3)
       faraday
       monetize
       money (~> 6.5.1)
@@ -21,7 +21,7 @@ GEM
       multipart-post (>= 1.2, < 3)
     i18n (0.7.0)
     method_source (0.8.2)
-    monetize (1.1.0)
+    monetize (1.3.0)
       money (~> 6.5.0)
     money (6.5.1)
       i18n (>= 0.6.4, <= 0.7.0)

data/lib/suretax/api/response.rb

@@ -39,12 +39,8 @@ module Suretax
         end
 
         def build_item_messages(response_body)
-          @item_messages = if item_errors?
-            response_body.fetch('ItemMessages').map do |item_message|
-              ItemMessage.new(item_message)
-            end
-          else
-            []
+          @item_messages =  response_body.fetch('ItemMessages', []).map do |item_message|
+            ItemMessage.new(item_message)
           end
         end
     end

data/lib/suretax/response.rb

@@ -8,19 +8,12 @@ module Suretax
     def initialize(api_response)
       @response = api_response
       sanitized_body = remove_xml_brackets(api_response.body)
-      if sanitized_body == 'invalid request'
-        @body = sanitized_body
-        @status = 400
-        @api = nil
-        log_response
 
-        return self
+      if sanitized_body == 'invalid request' 
+        invalid_request_response(sanitized_body) 
+      else
+        valid_request_response(sanitized_body)
       end
-      @body = JSON.parse(sanitized_body)
-      @api = Api::Response.new(@body)
-      @status = map_response_code_to_http_status(api.status)
-
-      log_response
     end
 
     def success?
@@ -29,6 +22,22 @@ module Suretax
 
     private
 
+    def valid_request_response(sanitized_body)
+      @body = JSON.parse(sanitized_body)
+      @api = Api::Response.new(@body)
+      @status = map_response_code_to_http_status(api.status)
+      log_response
+      self
+    end
+
+    def invalid_request_response(sanitized_body)
+      @body = sanitized_body
+      @status = 400
+      @api = nil
+      log_response
+      self
+    end
+
     def extract_json_from_urlencoded_string_regex
       # http://rubular.com/r/0w73fy4Ldk
       /\A<\?xml.*<string[^>]+>(?<json_string>.+)<\/string>\z/m

data/lib/suretax/version.rb

@@ -1,3 +1,3 @@
 module Suretax
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: suretax
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Damon Davison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-25 00:00:00.000000000 Z
+date: 2015-06-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -256,7 +256,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: This gem will allow Ruby developers to easily integrate SureTax into their