superset 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b991d014f7094976acde768b112309443a38f741c2b4d2834ecc9575366ad1eb
-  data.tar.gz: 5701ba1956f94f51037b78f878cb6bb154c74509d4c86d9b0e2b71c83abc1af8
+  metadata.gz: a175ae90fbf33b12baafc49758b5c9b2e2869702a6be4f45849f66ac5a40afee
+  data.tar.gz: bc9938edda2fd5879b1f1824116b572638ea8685dd7b4115ca3fbfba08cf6a3f
 SHA512:
-  metadata.gz: aaa349b9a890fea6b8a45323d80aca1ed9b57d0a71a39defed7430b72ce2ab92a37671b8f91d745c178d55d3e28d2e14b35fbad01c22c38db517ea13cafa94e9
-  data.tar.gz: 305171e61d4c0ecb3d5cd9b4c7e828f57aa3002e2b089996356c41264046095677c012ed6a147e4baad51aa74110e0189002f7967984b12f6fff22b361e40527
+  metadata.gz: 07d9b38d89bc252ea2a64b0cb835e9b9eefde88182636b4e8f900ccb7800e4e41f46fa3d15251ce3ba959f2805747f44b482d3b6b93c989ecbcb064d5d50ada9
+  data.tar.gz: 77a8f91b04674504ec174ba04e166b30fd5e42e30ce0c7b9a5904944893108fd5a5ef8052c066082d476c79518dacd911c3660d246e9b6bd9bf9f11fafe6c9f7

data/CHANGELOG.md

@@ -1,4 +1,21 @@
-## Change Log
+## Changelog
+
+## 0.3.6 - 2026-02-26
+
+* add dry_run to dashboard bulk delete cascade #74
+* update to rubyzip 3.2.2 #73
+
+## 0.3.5 - 2026-02-24
+
+* allow for empty filter datasets #72
+
+## 0.3.4 - 2026-02-21
+
+* cascade ownership should also update datasets for filter only in #68
+* add owner filter #62
+* list dataset catalog db names #69
+* bump version to 0.3.4 #70
+* Adjust asset order for board cascade deletion #71
 
 ## 0.3.3 - 2025-12-11
 * Add databases method to Superset::Dashboard::Datasets::List

data/lib/superset/dashboard/bulk_delete_cascade.rb

@@ -9,10 +9,11 @@ module Superset
     class BulkDeleteCascade
       class InvalidParameterError < StandardError; end
 
-      attr_reader :dashboard_ids
+      attr_reader :dashboard_ids, :dry_run
 
-      def initialize(dashboard_ids: [])
+      def initialize(dashboard_ids: [], dry_run: true)
         @dashboard_ids = dashboard_ids
+        @dry_run = dry_run
       end
 
       def perform
@@ -20,9 +21,16 @@ module Superset
         raise InvalidParameterError, "dashboard_ids array must contain Integer only values" unless dashboard_ids.all? { |item| item.is_a?(Integer) }
 
         dashboard_ids.sort.each do |dashboard_id|
-          logger.info("Dashboard Id: #{dashboard_id.to_s} Attempting CASCADE delete of dashboard, charts, datasets")
-          delete_charts(dashboard_id)
-          delete_datasets(dashboard_id)
+          chart_ids = retrieve_chart_ids(dashboard_id)
+          dataset_ids = retrieve_dataset_ids(dashboard_id)
+
+          log_msg("------------------------- DRY RUN ONLY ---------------------------") if dry_run
+          log_msg("Dashboard Id: #{dashboard_id.to_s} Attempting CASCADE delete of dashboard, charts, datasets")
+          log_msg("  Charts: #{chart_ids.sort.join(', ')}")
+          log_msg("  Datasets: #{dataset_ids.sort.join(', ')}")
+
+          delete_charts(chart_ids)
+          delete_datasets(dataset_ids)
           delete_dashboard(dashboard_id)
         end
         true
@@ -30,18 +38,29 @@ module Superset
 
       private
 
-      def delete_datasets(dashboard_id)
-        datasets_to_delete = Superset::Dashboard::Datasets::List.new(dashboard_id: dashboard_id).datasets_details.map{|d| d[:id] }
-        Superset::Dataset::BulkDelete.new(dataset_ids: datasets_to_delete).perform if datasets_to_delete.any?
+      def delete_datasets(dataset_ids)
+        Superset::Dataset::BulkDelete.new(dataset_ids: dataset_ids).perform if dataset_ids.any? && !dry_run
       end
 
-      def delete_charts(dashboard_id)
-        charts_to_delete = Superset::Dashboard::Charts::List.new(dashboard_id).chart_ids
-        Superset::Chart::BulkDelete.new(chart_ids: charts_to_delete).perform if charts_to_delete.any?
+      def delete_charts(chart_ids)
+        Superset::Chart::BulkDelete.new(chart_ids: chart_ids).perform if chart_ids.any? && !dry_run
       end
 
       def delete_dashboard(dashboard_id)
-        Superset::Dashboard::Delete.new(dashboard_id: dashboard_id, confirm_zero_charts: true).perform
+        Superset::Dashboard::Delete.new(dashboard_id: dashboard_id, confirm_zero_charts: true).perform if !dry_run
+      end
+
+      def retrieve_chart_ids(dashboard_id)
+        Superset::Dashboard::Charts::List.new(dashboard_id).chart_ids
+      end
+
+      def retrieve_dataset_ids(dashboard_id)
+        Superset::Dashboard::Datasets::List.new(dashboard_id: dashboard_id).ids
+      end
+
+      def log_msg(message)
+        puts message
+        logger.info(message)
       end
 
       def logger

data/lib/superset/dashboard/export.rb

@@ -3,8 +3,12 @@
 # Will then unzip and copy the files into the destination_path with the dashboard_id as a subfolder
 #
 # Usage
-# Superset::Dashboard::Export.new(dashboard_id: 15, destination_path: '/tmp/superset_dashboard_backups/').perform
-#
+=begin
+  Superset::Dashboard::Export.new(
+    dashboard_id: 15,
+    destination_path: '/superset_dashboard_backups/'
+  ).perform
+=end
 
 require 'superset/file_utilities'
 
@@ -13,7 +17,7 @@ module Superset
     class Export < Request
       include FileUtilities
 
-      TMP_SUPERSET_DASHBOARD_PATH = '/tmp/superset_dashboard_exports'
+      TMP_SUPERSET_DASHBOARD_PATH = '/tmp/superset_dashboard_exports'.freeze
 
       attr_reader :dashboard_id, :destination_path
 
@@ -125,21 +129,6 @@ module Superset
       def datestamp
         @datestamp ||= Time.now.strftime('%Y%m%d')
       end
-
-      def unzip_file(zip_path, destination)
-        extracted_files = []
-        Zip::File.open(zip_path) do |zip_file|
-          zip_file.each do |entry|
-            entry_path = File.join(destination, entry.name)
-            FileUtils.mkdir_p(File.dirname(entry_path))
-            zip_file.extract(entry, entry_path) unless File.exist?(entry_path)
-            extracted_files << entry_path
-          end
-        end
-        extracted_files
-      rescue => e
-        raise
-      end
     end
 
     def logger

data/lib/superset/dashboard/import.rb

@@ -78,7 +78,7 @@ module Superset
       def source_zip_file
         return source if zip?
 
-        Zip::File.open(new_zip_file, Zip::File::CREATE) do |zipfile|
+        Zip::File.open(new_zip_file, create: true) do |zipfile|
           Dir[File.join(source, "**", "**")].each do |file|
             next unless File.file?(file)
 

data/lib/superset/dataset/bulk_delete.rb

@@ -16,10 +16,10 @@ module Superset
       end
 
       def perform
-        raise InvalidParameterError, "dataset_ids array of integers expected" unless dataset_ids.is_a?(Array)
+        raise InvalidParameterError, "dataset_ids array of integers expected" unless dataset_ids.is_a?(Array) && dataset_ids.any?
         raise InvalidParameterError, "dataset_ids array must contain Integer only values" unless dataset_ids.all? { |item| item.is_a?(Integer) }
 
-        logger.info("Deleting datasets with id: #{dataset_ids.join(', ')}")
+        logger.info("Deleting datasets with id: #{dataset_ids&.sort&.join(',')}")
         response
       end
 
@@ -30,7 +30,8 @@ module Superset
       private
 
       def params
-        { q: "!(#{dataset_ids.join(',')})" }
+        dataset_ids_str = dataset_ids&.sort&.join(',')
+        { q: "!(#{dataset_ids_str})" }
       end
 
       def route

data/lib/superset/file_utilities.rb

@@ -6,11 +6,15 @@ module Superset
       entries = []
       Zip::File.open(zip_file) do |zip|
         zip.each do |entry|
+          next if entry.name.empty?
+
           entry_path = File.join(destination, entry.name)
           entries << entry_path
           FileUtils.mkdir_p(File.dirname(entry_path))
 
-          zip.extract(entry, entry_path) unless File.exist?(entry_path)
+          zip.extract(entry, entry.name, destination_directory: destination) { true }
+        rescue => e
+          raise "Error extracting file #{entry.name}: #{e.message}"
         end
       end
 

data/lib/superset/services/import_dashboard_across_environment.rb

@@ -87,7 +87,7 @@ module Superset
       end
 
       def create_new_dashboard_zip
-        Zip::File.open(new_zip_file, Zip::File::CREATE) do |zipfile|
+        Zip::File.open(new_zip_file, create: true) do |zipfile|
           Dir[File.join(dashboard_export_root_path, '**', '**')].each do |file|
             zipfile.add(file.sub(dashboard_export_root_path + '/', File.basename(dashboard_export_root_path) + '/' ), file) if File.file?(file)
           end

data/lib/superset/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Superset
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end

data/superset.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "json", ">= 2.0"
   spec.add_dependency "terminal-table", "~> 4.0"
   spec.add_dependency "require_all", ">= 3.0"
-  spec.add_dependency "rubyzip", ">= 1.3"
+  spec.add_dependency "rubyzip", ">= 3.0"
   spec.add_dependency "faraday", "~> 1.0"
   spec.add_dependency "faraday-multipart", "~> 1.0"
   spec.add_dependency "enumerate_it", ">= 1.7"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: superset
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - jbat
@@ -57,14 +57,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement