superbolt 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e553aac5d606b63183b802cb08a07c43e2a04e9d
-  data.tar.gz: 06a774880b8b0f9164defd612b5212d28655adaa
+  metadata.gz: b5538787ae4effae010bb8945665a50e62475742
+  data.tar.gz: def383a9340e518b5474ee2683a296523605a2df
 SHA512:
-  metadata.gz: 7de9c9e6a98e5609d9157e23edc4c542d81c6bf533f6dc79d2b7cd54f2c7875c6650edd05344b682e7f3f7fa9d607010a1e1211da81004ff38dd355ff4b1d7d1
-  data.tar.gz: 1f8f67313fa1b123a73de0975e1f090467bd610f8dcf56f02b2c66d35efe45d2a5f6abc09fe50798b42618aadc4befbc3ed543f2d6c4b9b096976c4a739a3875
+  metadata.gz: a9d58771dec607c6388428b5178ea5d611d045b2372bf5dbbfbcbb25651afda4331e0cfcedd32c2d36b299e56ca1e4a9bdaad9b6e87d2cb59f561f57431535a4
+  data.tar.gz: 9d53728ce7cd8b8efa63f4e9ad709560658bf95cee5c76e60179a3de36e0686c90ada4425ca490e1646021141e146664af9f365d33a71ec2f11810066eb9bdb8

data/lib/superbolt/spec_helpers.rb

@@ -2,7 +2,7 @@ module Superbolt
   module SpecHelpers
     def superbolt_message
       superbolt_message = messenger_class.new
-      superbolt_message.stub(:send!) do |args|
+      allow(superbolt_message).to receive(:send!) do |args|
         superbolt_message.data(args)
         superbolt_messages << superbolt_message
       end
@@ -19,7 +19,7 @@ module Superbolt
     end
 
     def stub_superbolt_messenger
-      Superbolt.stub(:message) { |args| superbolt_message }
+      allow(Superbolt).to receive(:message) { |args| superbolt_message }
     end
 
     def messenger_class

data/lib/superbolt/version.rb

@@ -1,3 +1,3 @@
 module Superbolt
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/spec/app_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::App do
   let(:app) {
@@ -36,11 +36,11 @@ describe Superbolt::App do
         end
       end
 
-      messages.size.should == 2
-      messages.should == [
+      expect(messages.size).to eq(2)
+      expect(messages).to eq([
         {'first' => 1},
         {'last' => 2}
-      ]
+      ])
     end
 
     it 'removes messages from the queue on successful completion' do
@@ -54,7 +54,7 @@ describe Superbolt::App do
           app.quit
         end
       end
-      queue.size.should == 0
+      expect(queue.size).to eq(0)
     end
 
     it "passes a logger to the block" do
@@ -62,7 +62,7 @@ describe Superbolt::App do
       app.logger = mock_logger
 
       message_received = false
-      mock_logger.stub(:info) do |m|
+      allow(mock_logger).to receive(:info) do |m|
         if m == {'write' => 'out'}
           message_received = true
         end
@@ -75,7 +75,7 @@ describe Superbolt::App do
         app.quit
       end
 
-      message_received.should eq true
+      expect(message_received).to eq(true)
     end
 
     context 'notifying errors' do
@@ -87,8 +87,8 @@ describe Superbolt::App do
         after  { Superbolt.error_notifier = nil }
 
         it 'uses ErrorNotifiers::Airbrake' do
-          app.error_notifier.should be_an_instance_of(Superbolt::ErrorNotifier::Airbrake)
-          app.error_notifier.should_receive(:error!).with(the_error, message)
+          expect(app.error_notifier).to be_an_instance_of(Superbolt::ErrorNotifier::Airbrake)
+          expect(app.error_notifier).to receive(:error!).with(the_error, message)
           messages = []
 
           queue.push(message)
@@ -103,8 +103,8 @@ describe Superbolt::App do
 
       context 'default' do
         it 'does not fail' do
-          app.error_notifier.should be_an_instance_of(Superbolt::ErrorNotifier::None)
-          app.error_notifier.should_receive(:error!).with(the_error, message)
+          expect(app.error_notifier).to be_an_instance_of(Superbolt::ErrorNotifier::None)
+          expect(app.error_notifier).to receive(:error!).with(the_error, message)
           messages = []
 
           queue.push(message)

data/spec/config_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::Config do
   let(:config) {
@@ -18,11 +18,11 @@ describe Superbolt::Config do
     }
 
     it "should make the app name available" do
-      expect(config.app_name).to eq 'my_great_app'
+      expect(config.app_name).to eq('my_great_app')
     end
 
     it "should make the env available" do
-      config.env.should == 'staging'
+      expect(config.env).to eq('staging')
     end
   end
 
@@ -42,7 +42,7 @@ describe Superbolt::Config do
         end
 
         it "returns the RABBITMQ_URL" do
-          config.connection_params.should == url
+          expect(config.connection_params).to eq(url)
         end
       end
 
@@ -65,7 +65,7 @@ describe Superbolt::Config do
         end
 
         it "returns the url specified in the env" do
-          config.connection_params.should == url
+          expect(config.connection_params).to eq(url)
         end
       end
     end
@@ -73,9 +73,9 @@ describe Superbolt::Config do
     context 'no environmental variables' do
       context 'default' do
         it "uses the default url" do
-          config.connection_params.should == {
+          expect(config.connection_params).to eq({
             :host => '127.0.0.1'
-          }
+          })
         end
       end
 
@@ -89,7 +89,7 @@ describe Superbolt::Config do
         }
 
         it "uses what it is given" do
-          config.connection_params.should == options[:connection_params]
+          expect(config.connection_params).to eq(options[:connection_params])
         end
       end
     end

data/spec/connection_spec.rb

@@ -1,21 +1,21 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::Adapter::Bunny do
   let(:connection) { Superbolt::Adapter::Bunny.new }
 
   it "has an underlying open connection via Bunny" do
-    connection.socket.should be_a Bunny::Session
-    connection.socket.should be_open
-    connection.should be_open
+    expect(connection.socket).to be_a Bunny::Session
+    expect(connection.socket).to be_open
+    expect(connection).to be_open
   end
 
   it "has a channel" do
-    connection.channel.should be_a Bunny::Channel
+    expect(connection.channel).to be_a Bunny::Channel
   end
 
   it "delegates queue creation to the channel" do
     queue = connection.queue('changelica')
-    queue.should be_a Bunny::Queue
-    connection.queues.keys.should include('changelica')
+    expect(queue).to be_a Bunny::Queue
+    expect(connection.queues.keys).to include('changelica')
   end
 end

data/spec/incoming_message_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::IncomingMessage do
   let(:message){ Superbolt::IncomingMessage.new(delivery_info, payload, channel) }
@@ -11,26 +11,26 @@ describe Superbolt::IncomingMessage do
       let(:payload) { 'foo' }
 
       it 'just returns the payload' do
-        message.parse.should == payload
+        expect(message.parse).to eq(payload)
       end
     end
 
     context 'payload is json' do
       it "parses it to a hash" do
-        message.parse.should == {'some' => 'message'}
+        expect(message.parse).to eq({'some' => 'message'})
       end
     end
   end
 
   describe '#reject' do
     it "calls reject on the channel with the appropritate data and options" do
-      channel.should_receive(:reject).with('tag', true)
+      expect(channel).to receive(:reject).with('tag', true)
 
       message.reject
     end
 
     it "can reject without requeuing" do
-      channel.should_receive(:reject).with('tag', false)
+      expect(channel).to receive(:reject).with('tag', false)
 
       message.reject(false)
     end
@@ -38,7 +38,7 @@ describe Superbolt::IncomingMessage do
 
   describe "#ack" do
     it "calls acknowledge on the channel" do
-      channel.should_receive(:acknowledge).with('tag')
+      expect(channel).to receive(:acknowledge).with('tag')
 
       message.ack
     end

data/spec/lib/superbolt/error_notifier/airbrake_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 require 'stringio'
 
 describe Superbolt::ErrorNotifier::Airbrake do

data/spec/lib/superbolt/error_notifier/none_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::ErrorNotifier::None do
   subject(:notifier) { described_class.new(double(:Logger)) }

data/spec/lib/superbolt/runner/pg_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 module ActiveRecord
   class Base

data/spec/messenger_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::Messenger do
   let(:env) { 'test' }
@@ -16,19 +16,19 @@ describe Superbolt::Messenger do
   describe 'queue generation' do
     it "can be instantiated with a queue destination" do
       m = Superbolt::Messenger.new(to: name)
-      m.name.should == name
-      m.queue.name.should == "#{name}_#{env}"
+      expect(m.name).to eq(name)
+      expect(m.queue.name).to eq("#{name}_#{env}")
     end
 
     it "destination queue can be set via #from" do
       messenger.to('activator')
-      messenger.queue.name.should == "activator_#{env}"
+      expect(messenger.queue.name).to eq("activator_#{env}")
     end
 
     it "raises an error if the name is nil" do
       expect {
         messenger.queue
-      }.to raise_error
+      }.to raise_error(RuntimeError)
     end
   end
 
@@ -37,41 +37,41 @@ describe Superbolt::Messenger do
 
     context 'writing' do
       it "starts its life with no interesting values" do
-        message[:origin].should == nil
-        message[:event].should == 'default'
-        message[:arguments].should == {}
+        expect(message[:origin]).to eq(nil)
+        expect(message[:event]).to eq('default')
+        expect(message[:arguments]).to eq({})
       end
 
       it "calls to #from, set the origin on the message" do
         messenger.from('linkticounter')
-        message[:origin].should == 'linkticounter'
+        expect(message[:origin]).to eq('linkticounter')
       end
 
       it "passes event data to the message" do
         messenger.re('zap')
-        message[:event].should == 'zap'
+        expect(message[:event]).to eq('zap')
       end
     end
 
     context 'reading' do
       it '#to returns the name' do
         messenger.to('transducer')
-        expect(messenger.to).to eq 'transducer'
+        expect(messenger.to).to eq('transducer')
       end
 
       it '#from returns the origin' do
         messenger.from('activator')
-        messenger.from.should == 'activator'
+        expect(messenger.from).to eq('activator')
       end
 
       it '#re returns the event' do
         messenger.re('save')
-        messenger.re.should == 'save'
+        expect(messenger.re).to eq('save')
       end
 
       it '#data return the arguments' do
         messenger.data({foo: 'bar'})
-        messenger.data.should == {foo: 'bar'}
+        expect(messenger.data).to eq({foo: 'bar'})
       end
     end
   end
@@ -86,11 +86,11 @@ describe Superbolt::Messenger do
 
     it "returns a hash that gets sent to the right queue" do
       messenger.send!('none')
-      queue.pop.should == {
+      expect(queue.pop).to eq({
         'origin' => 'me',
         'event' => 'love',
         'arguments' => 'none'
-      }
+      })
     end
   end
 end

data/spec/queue_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe 'Superbolt::Queue' do
   let(:name) { 'superbolt_test' }
@@ -11,13 +11,13 @@ describe 'Superbolt::Queue' do
   end
 
   it "has the right name" do
-    queue.name.should == name
+    expect(queue.name).to eq(name)
   end
 
   it "is setup with the right defaults" do
-    queue.exclusive?.should eq false
-    queue.durable?.should eq true
-    queue.auto_delete?.should eq false
+    expect(queue.exclusive?).to eq(false)
+    expect(queue.durable?).to eq(true)
+    expect(queue.auto_delete?).to eq(false)
   end
 
   describe 'queue/array operations' do
@@ -32,31 +32,31 @@ describe 'Superbolt::Queue' do
 
       it "writes to the queue" do
         queue.push(message)
-        queue.size.should == 1
+        expect(queue.size).to eq(1)
       end
     end
 
     describe '#peek' do
       it "returns the message but leaves it in the queue" do
         queue.push(message)
-        queue.peek.should == decoded
-        queue.size.should == 1
+        expect(queue.peek).to eq(decoded)
+        expect(queue.size).to eq(1)
       end
     end
 
     describe '#pop' do
       it "returns the message and deletes it from the queue" do
         queue.push(message)
-        queue.pop.should == decoded
-        queue.size.should == 0
+        expect(queue.pop).to eq(decoded)
+        expect(queue.size).to eq(0)
       end
 
       it "leaves all other messages in the queue" do
         queue.push(message)
         queue.push(message_two)
         queue.pop
-        queue.size.should == 1
-        queue.all.should include(decoded_two)
+        expect(queue.size).to eq(1)
+        expect(queue.all).to include(decoded_two)
       end
     end
 
@@ -69,12 +69,12 @@ describe 'Superbolt::Queue' do
 
       it "returns all the messages on the queue" do
         messages = queue.all
-        messages.size.should == 3
-        messages.uniq.should == [decoded]
+        expect(messages.size).to eq(3)
+        expect(messages.uniq).to eq([decoded])
       end
 
       it "does not consume the messages" do
-        queue.size.should == 3
+        expect(queue.size).to eq(3)
       end
     end
 
@@ -87,13 +87,13 @@ describe 'Superbolt::Queue' do
 
       it "returns a set of messages determined by the offset and the number requested" do
         messages = queue.slice(1,3)
-        messages.size.should == 3
-        messages.map{|json| json['i']}.should == [1,2,3]
+        expect(messages.size).to eq(3)
+        expect(messages.map{|json| json['i']}).to eq([1,2,3])
       end
 
       it "does not consume messages" do
         queue.slice(1,3)
-        queue.size.should == 10
+        expect(queue.size).to eq(10)
       end
     end
 
@@ -106,7 +106,7 @@ describe 'Superbolt::Queue' do
 
       it "return the message at the i-th position without removing it from the queue" do
         json = queue[3]
-        json['i'].should == 3
+        expect(json['i']).to eq(3)
       end
     end
 
@@ -119,12 +119,12 @@ describe 'Superbolt::Queue' do
 
       it "returns all messages where the block is true" do
         messages = queue.delete{|json| json['i'] > 2 && json['i'] != 6 && json['i'] < 8 }
-        messages.map{|json| json['i']}.should == [3,4,5,7]
+        expect(messages.map{|json| json['i']}).to eq([3,4,5,7])
       end
 
       it "removes those messages from the queue" do
         queue.delete{|json| json['i'] > 2 && json['i'] != 6 && json['i'] < 8 }
-        queue.size.should == 6
+        expect(queue.size).to eq(6)
       end
     end
   end
@@ -138,7 +138,7 @@ describe 'Superbolt::Queue' do
 
     it "should store messages to a queue, even when writing before declaring the queue" do
       new_queue.push({my: 'message'})
-      new_queue.size.should == 1
+      expect(new_queue.size).to eq(1)
     end
   end
 end

data/spec/router_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt::Router do
   let(:router) { Superbolt::Router.new(message, logger) }
@@ -26,8 +26,8 @@ describe Superbolt::Router do
     }
 
     it "performs the event handler" do
-      MessageHandler.should_receive(:new).with({yes: 'we can'}, logger).and_return(handler)
-      handler.should_receive(:perform)
+      expect(MessageHandler).to receive(:new).with({yes: 'we can'}, logger).and_return(handler)
+      expect(handler).to receive(:perform)
 
       router.perform
     end
@@ -44,7 +44,7 @@ describe Superbolt::Router do
     }
 
     it "logs a warning" do
-      logger.should_receive(:warn).with("No Superbolt route for event: 'no_one_home'")
+      expect(logger).to receive(:warn).with("No Superbolt route for event: 'no_one_home'")
 
       router.perform
     end

data/spec/superbolt_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Superbolt, 'the facade' do
   before do
@@ -20,16 +20,16 @@ describe Superbolt, 'the facade' do
     after { Superbolt.error_notifier = nil }
 
     it "should retain the configuration information" do
-      Superbolt.config.app_name.should == 'bossanova'
-      Superbolt.config.env.should == 'production'
-      Superbolt.config.env_connection_key.should == 'SOME_RABBITMQ_URL'
-      Superbolt.config.error_notifier.should == :airbrake
+      expect(Superbolt.config.app_name).to eq('bossanova')
+      expect(Superbolt.config.env).to eq('production')
+      expect(Superbolt.config.env_connection_key).to eq('SOME_RABBITMQ_URL')
+      expect(Superbolt.config.error_notifier).to eq(:airbrake)
     end
   end
 
   describe '.config' do
     it "has a default" do
-      Superbolt.config.should == Superbolt::Config.new({})
+      expect(Superbolt.config).to eq(Superbolt::Config.new({}))
     end
 
     it "can be customized" do
@@ -37,17 +37,17 @@ describe Superbolt, 'the facade' do
         connection_key: 'SOME_RABBITMQ_URL'
       }
 
-      Superbolt.config.env_connection_key.should == 'SOME_RABBITMQ_URL'
+      expect(Superbolt.config.env_connection_key).to eq('SOME_RABBITMQ_URL')
     end
   end
 
   describe '.queue' do
     it "creates a queue with the default config" do
       queue = double('queue')
-      Superbolt::Queue.should_receive(:new)
+      expect(Superbolt::Queue).to receive(:new)
         .with('queue_name', Superbolt.config)
         .and_return(queue)
-      Superbolt.queue('queue_name').should == queue
+      expect(Superbolt.queue('queue_name')).to eq(queue)
     end
   end
 
@@ -63,13 +63,13 @@ describe Superbolt, 'the facade' do
         .re('update')
         .send!({class: 'Advocate'})
 
-      queue.pop.should == {
+      expect(queue.pop).to eq({
         'origin' => 'bossanova',
         'event' => 'update',
         'arguments' => {
           'class' => 'Advocate'
         }
-      }
+      })
     end
   end
 end

data/superbolt.gemspec

@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "= 2.14.1"
+  spec.add_development_dependency "rspec"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: superbolt
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - socialchorus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-24 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -98,16 +98,16 @@ dependencies:
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: '0'
 description: Superbolt is comprised of a standalone app, and a queue-like queue for
   sending messages between services and applications.
 email:
@@ -159,8 +159,8 @@ files:
 - spec/lib/superbolt/runner/pg_spec.rb
 - spec/messenger_spec.rb
 - spec/queue_spec.rb
+- spec/rails_helper.rb
 - spec/router_spec.rb
-- spec/spec_helper.rb
 - spec/superbolt_spec.rb
 - spec/support/em_mocking.rb
 - spec/support/queue_helpers.rb
@@ -185,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Superbolt is a gem that makes SOA intra-app communication easy, via RabbitMQ
@@ -199,8 +199,8 @@ test_files:
 - spec/lib/superbolt/runner/pg_spec.rb
 - spec/messenger_spec.rb
 - spec/queue_spec.rb
+- spec/rails_helper.rb
 - spec/router_spec.rb
-- spec/spec_helper.rb
 - spec/superbolt_spec.rb
 - spec/support/em_mocking.rb
 - spec/support/queue_helpers.rb