super_settings 2.1.2 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecd3fc92a5668536f7d1300641505730c603b2c539dc069469e8559b1fbda7c2
-  data.tar.gz: c654d8ff805fda401c43b2df65a4f853330f5182398f7462f3d8954af4ae47e0
+  metadata.gz: 967d15a431f463f295d1585a1db0f7891e1eca3e16096890d829559b232d3870
+  data.tar.gz: 241ee0184528a02900ed05f2d21ac734bbfd635411fbe398bf694392d057cb08
 SHA512:
-  metadata.gz: b97bc579ecce698c0080dab893456d36d5c3a7144695f07a13a03df1c1fb23df182c61155001066befc03922cbc945e35b43198d1d6e8fb0636faedc540bd2ce
-  data.tar.gz: 690abe15783bb18ca0e71494140c9d554f6ae532542a734d3027911fe771e4e93b1fde67dde18558872885e5e9b9edca96bda6587ca351847674d725e544b3c7
+  metadata.gz: 682426a9592f6aa9bc2694dc38de649f4f31a714866298b59930c0ae81f1381eeafcd7faeb81e22288c71a0ba5edca4eb660c1f2bd04dd87cb872c5e434be0d3
+  data.tar.gz: ac71245f56b5b4694906a8d8d36528a9b814b2af15ac544a11f8a009636d62aa1c235b22700bfdb1f73283fa9cdaad3bcd335e590ddbac228669794f7267e61c

data/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 2.2.0
+
+### Changed
+
+- After save callbacks are now called only after the transaction is committed and settings have been persisted to the data store. When updating multiple records the callbacks will be called after all changes have been persisted rather than immediatly after calling `save!` on each record.
+
 ## 2.1.2
 
 ### Fixed

data/VERSION

@@ -1 +1 @@
-2.1.2
+2.2.0

data/lib/super_settings/setting.rb

@@ -164,7 +164,7 @@ module SuperSettings
         all_valid, settings = update_settings(params, changed_by)
         if all_valid
           storage.with_connection do
-            storage.transaction do
+            transaction do |_changes|
               settings.each do |setting|
                 setting.save!
               end
@@ -202,6 +202,38 @@ module SuperSettings
         cache&.delete(Setting::LAST_UPDATED_CACHE_KEY)
       end
 
+      # Wrap a block of code in a transaction.
+      #
+      # @api private
+      def transaction(&block)
+        changes = Thread.current[:super_settings_transaction]
+        return yield if changes
+
+        changes = []
+        Thread.current[:super_settings_transaction] = changes
+
+        begin
+          @storage.transaction(&block)
+
+          clear_last_updated_cache
+
+          changes.each do |setting|
+            setting.send(:call_after_save_callbacks)
+            setting.send(:clear_changes)
+          end
+        ensure
+          Thread.current[:super_settings_transaction] = nil
+        end
+      end
+
+      # Add a record to the current transaction.
+      #
+      # @api private
+      def add_record_to_transaction(record)
+        changes = Thread.current[:super_settings_transaction]
+        changes << record if changes
+      end
+
       private
 
       # Updates settings in memory from an array of parameters.
@@ -454,17 +486,13 @@ module SuperSettings
       self.created_at ||= timestamp
       self.updated_at = timestamp if updated_at.nil? || !changed?(:updated_at)
 
+      return if @changes.empty?
+
       self.class.storage.with_connection do
-        self.class.storage.transaction do
+        self.class.transaction do
           record_value_change
           @record.save!
-        end
-
-        begin
-          self.class.clear_last_updated_cache
-          call_after_save_callbacks
-        ensure
-          clear_changes
+          self.class.add_record_to_transaction(self)
         end
       end
       nil

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_settings
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.2.0
 platform: ruby
 authors:
 - Brian Durand
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-03 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler