super_good-solidus_taxjar 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16f78fd5b5f06f886e1155ac73da728cafe195ccbf6680cad6399ce8048fcb96
-  data.tar.gz: dd18d3f4cf47e6eda8a2d537cbfac8ef82d15bb49e4042122f18f40e7ba14975
+  metadata.gz: 383b1f52471f45dc1f4d51c3bcf7c3b6063313202997858a59bc3107444939ee
+  data.tar.gz: 348d9b9942e4def84a74ba612124f337438d0d1260408593058eca9867f821c3
 SHA512:
-  metadata.gz: bca92e9d73c6cbb601f551aef6ba99a19a0780aa351c82fab1281b6cf27c75c6cc931802e537dcff84012b92697b4510a2e0b02297c3a55ee2dff32bac8ee8cf
-  data.tar.gz: 75097f4c136e756add39300058309c7253f889006f52c781aa8b39514310906eaa1bdacf85c7f4d55585ceb1e1bb4e4f069c20e66a8a5150157a197a25823ab1
+  metadata.gz: a0afc95de0aa4073290d7c6c8a5a8c7bb21988c96811eecc4a9be55f0b66339d632861123d814927d1adfa09126cb54d4014d39bde08fe0b16b5a90cebe05057
+  data.tar.gz: f9ae6f8fb17e5f806aafd5e88adc6b31024814d7182823190a20b4ed46c6e43d0a5e4d36b80d83af7898199e72ee8b99bddf53d7420737b0f524ada22585e6a6

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+## v0.12.0
+
+- Report no tax collected on order and line items when order total zeroed out.
+
 ## v0.11.1
 
 - Avoid sending negative amounts for order totals.

data/lib/super_good/solidus_taxjar/api_params.rb

@@ -30,7 +30,7 @@ module SuperGood
               transaction_date: order.completed_at.to_formatted_s(:iso8601),
               amount: [order.total - order.additional_tax_total, 0].max,
               shipping: shipping(order),
-              sales_tax: order.additional_tax_total
+              sales_tax: sales_tax(order)
             )
         end
 
@@ -85,7 +85,7 @@ module SuperGood
                 product_tax_code: line_item.tax_category&.tax_code,
                 unit_price: line_item.price,
                 discount: discount(line_item),
-                sales_tax: line_item.additional_tax_total
+                sales_tax: line_item_sales_tax(line_item)
               }
             end
           }
@@ -106,6 +106,18 @@ module SuperGood
         def shipping(order)
           SuperGood::SolidusTaxJar.shipping_calculator.(order)
         end
+
+        def sales_tax(order)
+          return 0 if order.total.zero?
+
+          order.additional_tax_total
+        end
+
+        def line_item_sales_tax(line_item)
+          return 0 if line_item.order.total.zero?
+
+          line_item.additional_tax_total
+        end
       end
     end
   end

data/lib/super_good/solidus_taxjar/version.rb

@@ -1,5 +1,5 @@
 module SuperGood
   module SolidusTaxJar
-    VERSION = "0.11.1"
+    VERSION = "0.12.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-11 00:00:00.000000000 Z
+date: 2019-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core
@@ -194,7 +194,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Support for using TaxJar to handle tax calculations in Solidus