super_good-solidus_taxjar 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 80be38145d2165c2206c5bdd3277603644addb503a53407371e6bfadc88b02d2
-  data.tar.gz: ba2a05e2396e17515bcb0979291f3e1c6997c8d8d0dc2455eaeab1cb868d2ded
+  metadata.gz: d5c894c77b9759569d51ee5f1e8812e87141354365db29a5dc7d901b1daf7bd5
+  data.tar.gz: 523521443feeb3ce517fda157af541e9b08d2d1c0c2c458066e7fd761dea3bf7
 SHA512:
-  metadata.gz: 616500538680d8caa58649021782d96994ed79528cd51084a872965d57a388424d0c7ec3ea20a78becc8d1c730c43b97251f1d9629913d6d8f11a49eccc399cd
-  data.tar.gz: 9ca2bbc6c923180b1ee060fc8823a243c61c94181a5802e403da64100ef0cc286d37186665b925fa66ba2cb0fcf0528ba6ca6e0bb76d4dc7c7efc83fc5838354
+  metadata.gz: 1cf54bcbf49aec4cf143d1353d6025d1acd2350b3432fd071d5a27ac309f366e634a84cc6774f35172638afba8fd2e04c77494dbdcca511dc2894d78f8f03a39
+  data.tar.gz: 359013164861393434349aaee5c02632f1c5d10665402222572921cf5fa22d1a67b455d78502cd79183bc83e8f4f7d2fb2d94c163e82c6e966bc8646f6d4d536

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master
 
+## v0.11.0
+
+- Avoid sending 0 quantity line items. TaxJar doesn't like them.
+
 ## v0.10.0
 
 - Make shipping amounts configurable to make it easier to support order-level adjustments.

data/lib/super_good/solidus_taxjar/api_params.rb

@@ -63,7 +63,7 @@ module SuperGood
 
         def line_items_params(line_items)
           {
-            line_items: line_items.map do |line_item|
+            line_items: valid_line_items(line_items).map do |line_item|
               {
                 id: line_item.id,
                 quantity: line_item.quantity,
@@ -77,7 +77,7 @@ module SuperGood
 
         def transaction_line_items_params(line_items)
           {
-            line_items: line_items.map do |line_item|
+            line_items: valid_line_items(line_items).map do |line_item|
               {
                 id: line_item.id,
                 quantity: line_item.quantity,
@@ -91,6 +91,14 @@ module SuperGood
           }
         end
 
+        def valid_line_items(line_items)
+          # The API appears to error when sent line items with no quantity...
+          # but why would you do that anyway.
+          line_items.reject do |line_item|
+            line_item.quantity.zero?
+          end
+        end
+
         def discount(line_item)
           ::SuperGood::SolidusTaxJar.discount_calculator.new(line_item).discount
         end

data/lib/super_good/solidus_taxjar/version.rb

@@ -1,5 +1,5 @@
 module SuperGood
   module SolidusTaxJar
-    VERSION = "0.10.0"
+    VERSION = "0.11.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: super_good-solidus_taxjar
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Jared Norman
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-05 00:00:00.000000000 Z
+date: 2019-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: solidus_core