super_callbacks 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 8f2916d0d7aafdfe6d62022e295eb35f19fe4366fe584adcefbdd7a856154853
-  data.tar.gz: 48e8b72a7e2dfbdc4109804062e60d62374dbcbcef42a42192991c7bb1a0a09b
+SHA1:
+  metadata.gz: 39773c4b3169e56de61be4f51296349b7a984ced
+  data.tar.gz: c4584d56aec09b2057bda2da51f68faaddaf3d32
 SHA512:
-  metadata.gz: e381891c442fdf4f6fed1bee814a9fe20314880a05e1f8003da8df4f8b67be6b97c38b20a95c07acec4ed9faf706896e4de854f0665c8894adbd2ffceaa4d701
-  data.tar.gz: 8658ee29da8b6943a72c374c9df4efc9ebc81ba9ca023a7ff718644054c6b0a5c0b9b650c4efba9f590a9b783568676e8a127dfe8c86b494961a915ab6e317fd
+  metadata.gz: 3c05e4fac9fc819123b51ec67c36808d85246b2ee737fbab8e446a954d8150cca36f463bca7f87f4a36385b6e6dcc2b554d5bed9f4d43e022d1947d7c4129fd5
+  data.tar.gz: 05090fb64e346e02f89109c907f3aefb2ccc6bf97e2a705b2f10d19d47fe080b57656d0da981e200338a046b80399a66193a381f00ebff1ccdbf0b2b74a526c2

data/.ruby-version

@@ -0,0 +1 @@
+2.2.4

data/.travis.yml

@@ -8,4 +8,4 @@ rvm:
   - 2.3.4
   - 2.4.1
   - 2.5.5
-before_install: gem install bundler -v 2.0.2
+before_install: gem install bundler -v 1.16.4

data/README.md

@@ -6,7 +6,7 @@
 * Supports both class and instance level callbacks
 * Supports conditional callbacks
 * Supports inherited callbacks; hence named "Super", get it? :D haha!
-
+---
 * Focuses on performance and flexibility as intended primarily for game development, and event-driven apps
 * Standalone; no other gem dependencies
 * `super_callbacks` is the upgraded version of my other repo [`dragon_ruby_callbacks`](https://github.com/jrpolidario/dragonruby_callbacks)
@@ -316,12 +316,12 @@ foo.bar
 
 sub_foo = SubFoo.new
 sub_foo.bar
-# => 'SubFoo: bar'
 # => 'Foo: before bar 1!'
+# => 'SubFoo: bar'
 # => 'bar!'
 ```
 
-*Notice above `sub_foo` calls both `before` callbacks defined in `Foo` and `SubFoo`, because SubFoo inherits from Foo. Callbacks are called in order of ancestors ascending; meaning it starts calling the instance's class (SubFoo) callbacks first, then the superclass's callbacks, and the remaining ancestor classes, etc...*
+*Notice above `sub_foo` calls both `before` callbacks defined in `Foo` and `SubFoo`, because SubFoo inherits from Foo. Callbacks are called in order of ancestors descending; meaning it starts calling the top-level ancestor superclass callbacks, and then calling its subclass callbacks, until it reaches the instance's class callbacks*
 *Above uses `before`, but works similarly with `after`*
 
 
@@ -344,8 +344,8 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Changelog
 
-* 1.0.0 (2019-08-12)
-    * Cleaner code without explicitly calling `run_callbacks` anymore; done now because of ruby upgrade from 1.9 to 2.0+ which already supports `prepend` 
+* 1.0.1 (2019-08-12)
+    * Cleaner code without explicitly calling `run_callbacks` anymore; done now because of ruby upgrade from 1.9 to 2.0+ which already supports `prepend`
     * Supported both class and instance level callbacks
     * Supported inherited callbacks
 * v0.2.1 (2019-08-09) *From `dragonruby_callbacks`*

data/lib/super_callbacks/version.rb

@@ -1,3 +1,3 @@
 module SuperCallbacks
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/super_callbacks.rb

@@ -6,13 +6,13 @@ module SuperCallbacks
   VALID_OPTION_KEYS = [:if].freeze
 
   def self.included(base)
-    base.singleton_class.attr_accessor :before_callbacks, :after_callbacks
-    base.attr_accessor :before_callbacks, :after_callbacks
+    base.singleton_class.send :attr_accessor, *[:before_callbacks, :after_callbacks]
+    base.send :attr_accessor, *[:before_callbacks, :after_callbacks]
     base.extend ClassMethods
-    base.include InstanceMethods
+    base.send :include, InstanceMethods
     base.extend ClassAndInstanceMethods
-    base.include ClassAndInstanceMethods
-    base.prepend Prepended.new
+    base.send :include, ClassAndInstanceMethods
+    base.send :prepend, Prepended.new
   end
 
   class Prepended < Module
@@ -88,8 +88,8 @@ module SuperCallbacks
       _callbacks_prepended_module_instance = callbacks_prepended_module_instance
 
       # dont redefine, to save cpu cycles
-      unless callbacks_prepended_module_instance.method_defined? method_name
-        callbacks_prepended_module_instance.define_method method_name do |*args|
+      unless _callbacks_prepended_module_instance.method_defined? method_name
+        _callbacks_prepended_module_instance.send(:define_method, method_name) do |*args|
           run_before_callbacks(method_name, *args)
           super_value = super(*args)
           run_after_callbacks(method_name, *args)
@@ -120,7 +120,7 @@ module SuperCallbacks
 
       # dont redefine, to save cpu cycles
       unless _callbacks_prepended_module_instance.method_defined? method_name
-        _callbacks_prepended_module_instance.define_method method_name do |*args|
+        _callbacks_prepended_module_instance.send(:define_method, method_name) do |*args|
           run_before_callbacks(method_name, *args)
           super_value = super(*args)
           run_after_callbacks(method_name, *args)
@@ -147,7 +147,7 @@ module SuperCallbacks
     # TODO: optimize by instead of dynamically getting all_ancestral_after_callbacks on runtime
     # set them immediately when `include` is called on Base class
     def run_before_callbacks(method_name, *args)
-      all_ancestral_before_callbacks = self.class.ancestors.each_with_object({}) do |ancestor, hash|
+      all_ancestral_before_callbacks = self.class.ancestors.reverse.each_with_object({}) do |ancestor, hash|
         SuperCallbacks::Helpers.deep_merge_hashes_and_combine_arrays!(
           hash,
           ancestor.instance_variable_get(:@before_callbacks) || {}
@@ -183,7 +183,7 @@ module SuperCallbacks
     # TODO: optimize by instead of dynamically getting all_ancestral_after_callbacks on runtime
     # set them immediately when `include` is called on Base class
     def run_after_callbacks(method_name, *args)
-      all_ancestral_after_callbacks = self.class.ancestors.each_with_object({}) do |ancestor, hash|
+      all_ancestral_after_callbacks = self.class.ancestors.reverse.each_with_object({}) do |ancestor, hash|
         SuperCallbacks::Helpers.deep_merge_hashes_and_combine_arrays!(
           hash,
           ancestor.instance_variable_get(:@after_callbacks) || {}

data/super_callbacks.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'byebug', '~> 9.0'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: super_callbacks
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jules Roman B. Polidario
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -78,9 +78,9 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Allows `before` and `after` callbacks to any Class. Supports both class and

data/Gemfile.lock

@@ -1,37 +0,0 @@
-PATH
-  remote: .
-  specs:
-    super_callbacks (1.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    byebug (9.1.0)
-    diff-lcs (1.3)
-    rake (10.5.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 2.0)
-  byebug (~> 9.0)
-  rake (~> 10.0)
-  rspec (~> 3.0)
-  super_callbacks!
-
-BUNDLED WITH
-   2.0.2