sucker_punch 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 993f07c48fd24506ec4f6233b141142a3d4584bf
-  data.tar.gz: 19e5a661fabd7053db509438cd49980d7260e75b
+  metadata.gz: 3176eeae888f0de8b24a633fd09eb3bd1a903b75
+  data.tar.gz: 6ed863474d1d0efdb0009a40a440b424f6e6656e
 SHA512:
-  metadata.gz: e8bad658a733babb44d0fb0e8e680bc7b7e23e5e70a1dd2d37c0d23d0d5f3f81d79f7be7cdef5babffe51ac80171a87079aaa64942cbbf1c4499aad07b8142f4
-  data.tar.gz: 967146bea4c03054314035ebb06e0eb0a70a355c4042fed10c0d276942172e52670183fffa2c41106a7faf6fe591e2a0056b2cabad91d48b198b129c8e32b1e6
+  metadata.gz: deb547d6b67c54576d1f2398abec30356dfa9f324e793190396b67e47f460048accdf1160810201505366b3ad7a76a3c3429afb71a5b234f0d0fd4a1d173cdb7
+  data.tar.gz: 0ca6cddc806a3a6cffbfb58b2f0254b68875a08a703717cc173e622677f865d95b32540ba3710bb5ef1a3af37e059ea9a9fa6f4e41eda22fb8b89ec3313e6d05

data/.travis.yml

@@ -2,5 +2,9 @@ language: ruby
 rvm:
   - 1.9.3
   - jruby-19mode
-  - rbx-19mode
+  - rbx
   - 2.0.0
+matrix:
+  allow_failures:
+    - rvm: jruby-19mode
+    - rvm: rbx

data/README.md

@@ -86,8 +86,7 @@ class AwesomeJob
 end
 ```
 
-The number of workers that get created can be set from the Job using the `workers` method:
-
+The number of workers can be set from the Job using the `workers` method:
 
 ```Ruby
 class LogJob
@@ -100,16 +99,41 @@ class LogJob
 end
 ```
 
-If the `workers` method is not set, it is by default set to 2.
+If the `workers` method is not set, the default is `2`.
+
+## Perform In
+
+Many background processing libraries have methods to perform operations after a
+certain amount of time. Fortunately, timers are built-in to Celluloid, so you
+can take advantage of them with the `after` method:
+
+``` ruby
+class Job
+  include SuckerPunch::Job
+
+  def perform(data)
+    sleep 2
+    puts data
+  end
+
+  def later(sec, data)
+    after(sec) { perform(data) }
+  end
+end
+
+Job.new.async.perform("asdf")
+Job.new.async.later(60, "asdf") # `perform` will be excuted 60 sec. later
+```
 
 ## Logger
 
 ```Ruby
-SuckerPunch.logger = Logger.new('sucker_punch')
+SuckerPunch.logger = Logger.new('sucker_punch.log')
 SuckerPunch.logger # => #<Logger:0x007fa1f28b83f0>
 ```
 
-If Sucker Punch is being used within a Rails application, Sucker Punch's logger is set to Rails.logger by default.
+_Note: If Sucker Punch is being used within a Rails application, Sucker Punch's logger
+is set to Rails.logger by default._
 
 ## Testing
 
@@ -128,15 +152,17 @@ Log.new.async.perform("login") # => Will be synchronous and block until job is f
 
 ### Initializers for forking servers (Unicorn, Passenger, etc.)
 
-Previously, Sucker Punch required an initializer and that posed problems for Unicorn and Passenger and other servers that fork.
-Version 1 was rewritten to not require any special code to be executed after forking occurs. Please remove all of that if you're
-using version `>= 1.0.0`
+Previously, Sucker Punch required an initializer and that posed problems for
+Unicorn and Passenger and other servers that fork.  Version 1 was rewritten to
+not require any special code to be executed after forking occurs. Please remove
+ if you're using version `>= 1.0.0`
 
 ### Class naming
 
-Job classes are ultimately Celluloid Actor classes. As a result, class names are susceptible to being clobbered by Celluloid's internal classes.
-To ensure the intended application class is loaded, preface classes with `::`, or use names like `NotificationsMailer` or
-`UserMailer`. Example:
+Job classes are ultimately Celluloid Actor classes. As a result, class names
+are susceptible to being clobbered by Celluloid's internal classes.  To ensure
+the intended application class is loaded, preface classes with `::`, or use
+names like `NotificationsMailer` or `UserMailer`. Example:
 
 ```Ruby
 class EmailJob
@@ -151,7 +177,7 @@ end
 
 ### Cleaning test data transactions
 
-If you're running tests in transactions (using Database Cleaner or a native solution), Sucker Punch jobs may have trouble finding database records that were created during test setup because the job class is running in a separate thread and the Transaction operates on a different thread so it clears out the data before the jojob can do its business. The best thing to do is cleanup data created for tests jobs through a truncation strategy by tagging the rspec tests as jobs and then specifying the strategy in `spec_helper` like below:
+If you're running tests in transactions (using Database Cleaner or a native solution), Sucker Punch jobs may have trouble finding database records that were created during test setup because the job class is running in a separate thread and the Transaction operates on a different thread so it clears out the data before the job can do its business. The best thing to do is cleanup data created for tests jobs through a truncation strategy by tagging the rspec tests as jobs and then specifying the strategy in `spec_helper` like below:
 
 ```Ruby
 # spec/spec_helper.rb
@@ -161,7 +187,7 @@ RSpec.configure do |config|
   end
 
   # Clean up all jobs specs with truncation
-  config.before(:each, :job => true) do
+  config.before(:each, job: true) do
     DatabaseCleaner.strategy = :truncation
   end
 
@@ -172,6 +198,7 @@ RSpec.configure do |config|
   config.after(:each) do
     DatabaseCleaner.clean
   end
+end
 
 # spec/jobs/email_job_spec.rb
 require 'spec_helper'
@@ -192,7 +219,9 @@ end
 
 ## Gem Name
 
-...is awesome. But I can't take credit for it. Thanks to [@jmazzi](https://twitter.com/jmazzi) for his superior naming skills. If you're looking for a name for something, he is the one to go to.
+...is awesome. But I can't take credit for it. Thanks to
+[@jmazzi](https://twitter.com/jmazzi) for his superior naming skills. If you're
+looking for a name for something, he is the one to go to.
 
 ## Contributing
 
@@ -201,3 +230,4 @@ end
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+

data/lib/sucker_punch/queue.rb

@@ -29,14 +29,13 @@ module SuckerPunch
         unless registered?
           initialize_celluloid_pool(num_workers)
           register_celluloid_pool
-          register_queue_with_master_list
         end
       }
       self.class.find(klass)
     end
 
     def registered?
-      SuckerPunch::Queues.all.include?(name)
+      Celluloid::Actor.registered.include?(name.to_sym)
     end
 
     def name
@@ -52,10 +51,6 @@ module SuckerPunch
     def register_celluloid_pool
       Celluloid::Actor[name] = pool
     end
-
-    def register_queue_with_master_list
-      SuckerPunch::Queues.register(name)
-    end
   end
 end
 

data/lib/sucker_punch/railtie.rb

@@ -2,6 +2,10 @@ module SuckerPunch
   class Railtie < ::Rails::Railtie
     initializer "sucker_punch.logger" do
       SuckerPunch.logger = Rails.logger
+
+      ActionDispatch::Reloader.to_prepare do
+        Celluloid::Actor.clear_registry
+      end
     end
   end
 end

data/lib/sucker_punch/version.rb

@@ -1,3 +1,3 @@
 module SuckerPunch
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/spec/sucker_punch/queue_spec.rb

@@ -11,6 +11,10 @@ describe SuckerPunch::Queue do
     end
   end
 
+  after :each do
+    Celluloid::Actor.clear_registry
+  end
+
   describe "#find" do
     it "returns the Celluloid Actor from the registry" do
       SuckerPunch::Queue.new(FakeJob).register
@@ -33,17 +37,11 @@ describe SuckerPunch::Queue do
       expect(Celluloid::Actor[:fake_job]).to eq(pool)
     end
 
-    it "registers the pool with Celluloid" do
+    it "registers the pool with Celluloid and 3 workers" do
       pool = queue.register(3)
       expect(Celluloid::Actor[:fake_job].size).to eq(3)
     end
 
-    it "registers with master list of queues" do
-      queue.register
-      queues = SuckerPunch::Queues.all
-      expect(queues.size).to be(1)
-    end
-
     context "when too many workers are specified" do
       it "raises a MaxWorkersExceeded exception" do
         expect{ queue.register(101) }.to raise_error(SuckerPunch::Queue::MaxWorkersExceeded)

data/sucker_punch.gemspec

@@ -21,5 +21,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rake"
   gem.add_development_dependency "pry"
 
-  gem.add_dependency "celluloid", "~> 0.15.1"
+  gem.add_dependency "celluloid", "~> 0.15.2"
 end

metadata

@@ -1,71 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: sucker_punch
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Brandon Hilkert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-06 00:00:00.000000000 Z
+date: 2014-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: celluloid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 0.15.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.15.1
+        version: 0.15.2
 description: Asynchronous processing library for Ruby
 email:
 - brandonhilkert@gmail.com
@@ -73,8 +73,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGES.md
 - Gemfile
 - LICENSE.txt
@@ -150,17 +150,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Sucker Punch is a Ruby asynchronous processing using Celluloid, heavily influenced