sucker_punch 1.0.0.beta2 → 1.0.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f9d68b7c7b9b1609f465227f56920578ca0cd037
-  data.tar.gz: 561bf68629e9c4fc95b3156d29c168e081f85bcf
+  metadata.gz: a6a250f32e588a9b931f776dd670522ca0ec3ff7
+  data.tar.gz: 7be73d1af367060749480ea2eed8ad637beb8ea7
 SHA512:
-  metadata.gz: 04688497fae792eb3bedd54c34261848632e18b956e2fe3fb539e4c9fee229a2c062745eede2f99359c3723b00eded0f065d4965597609a750125151f46d534a
-  data.tar.gz: 7b579b1302292f6d36848f7a805dbe47d4b0521892b8b892d8821b2cdf7d46497b5a42450dfdb9c07459fdd9db90ddeb63a2a622c00bc8bf4ab591055d900404
+  metadata.gz: 43ca879a7efc7732acb5d2dedcea87fa25408e5982ad9d457bece8793b6474a03e2253aa44043350e8ed60c5f3686d0978a749eb788c84e530fab7eea83e1cd1
+  data.tar.gz: 8cdd511604d7422b883fc71f2a840f217ef881f3ec65cde8916bd916b76383008043ef87f4c4dc28f4357b6ee8195380bce181009dc3e62be4680c42f88bd971

data/CHANGES.md

@@ -1,3 +1,8 @@
+1.0.0.beta3
+--------
+
+- Constrain workers when creating a queue to raise more helpful exceptions
+
 1.0.0.beta2
 --------
 

data/lib/sucker_punch/queue.rb

@@ -6,6 +6,8 @@ module SuckerPunch
     attr_accessor :pool
 
     DEFAULT_OPTIONS = { workers: 2 }
+    class MaxWorkersExceeded < StandardError; end
+    class NotEnoughWorkers < StandardError; end
 
     def self.find(klass)
       queue = self.new(klass)
@@ -19,6 +21,9 @@ module SuckerPunch
     end
 
     def register(workers = DEFAULT_OPTIONS[:workers] )
+      raise MaxWorkersExceeded if workers > 100
+      raise NotEnoughWorkers if workers < 1
+
       @mutex.synchronize {
         unless registered?
           initialize_celluloid_pool(workers)

data/lib/sucker_punch/version.rb

@@ -1,3 +1,3 @@
 module SuckerPunch
-  VERSION = "1.0.0.beta2"
+  VERSION = "1.0.0.beta3"
 end

data/spec/sucker_punch/queue_spec.rb

@@ -43,6 +43,18 @@ describe SuckerPunch::Queue do
       queues = SuckerPunch::Queues.all
       expect(queues.size).to be(1)
     end
+
+    context "when too many workers are specified" do
+      it "raises a MaxWorkersExceeded exception" do
+        expect{ queue.register(101) }.to raise_error(SuckerPunch::Queue::MaxWorkersExceeded)
+      end
+    end
+
+    context "when too few workers are specified" do
+      it "raises a NotEnoughWorkers exception" do
+        expect{ queue.register(0) }.to raise_error(SuckerPunch::Queue::NotEnoughWorkers)
+      end
+    end
   end
 
   describe "#registered?" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sucker_punch
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta2
+  version: 1.0.0.beta3
 platform: ruby
 authors:
 - Brandon Hilkert