sucker_punch 0.4 → 0.4.1

data/CHANGES.md

@@ -1,3 +1,9 @@
+0.4.1
+--------
+
+- Remove `size` option when defining a queue, prefer `workers`
+- Update Celluloid dependency
+
 0.4
 -----------
 - Prefer `workers` stat method over `size`

data/README.md

@@ -110,21 +110,21 @@ SuckerPunch::Queue[:log_queue].busy_size # => 4
 SuckerPunch::Queue[:log_queue].idle_size # => 3
 ```
 
-## Testing
+## Testing (Only 0.3.1+)
 
 ```Ruby
 # spec/spec_helper.rb
 require 'sucker_punch/testing'
 ```
 
-Requiring this library completely stubs out the internals of Sucker Puncker, but will provide the necessary tools to confirm your jobs are being enqueucompletely stubs out the internals of Sucker Puncker, but will provide the necessary tools to confirm your jobs are being enqueued.
+Requiring this library completely stubs out the internals of Sucker Punch, but will provide the necessary tools to confirm your jobs are being enqueud.
 
 ```Ruby
 # spec/spec_helper.rb
 require 'sucker_punch/testing'
 
 RSpec.configure do |config|
-  config.after(:before) do
+  config.after do
     SuckerPunch.reset! # => Resets the queues and jobs in the queues before each test
   end
 end
@@ -134,7 +134,7 @@ SuckerPunch.config do
   queue name: :email, worker: EmailWorker, workers: 2
 end
 
-# config/workers/email_worker.rb
+# app/workers/email_worker.rb
 class EmailWorker
   include SuckerPunch::Worker
 
@@ -151,9 +151,6 @@ class User < ActiveRecord::Base
   end
 end
 
-# spec/spec_helper.rb
-require 'sucker_punch/testing'
-
 # spec/models/user_spec.rb
 require 'spec_helper'
 
@@ -180,6 +177,45 @@ SuckerPunch::Queue[:log_queue].async.perform("login")
 
 ## Troubleshooting
 
+If you're running tests in transactions (using DatabaseCleaner or a native solution), Sucker Punch workers may have trouble finding database records that were created during test setup because the worker class is running in a separate thread and the Transaction operates on a different thread so it clears out the data before the worker can do its business. The best thing to do is cleanup data created for tests workers through a truncation strategy by tagging the rspec tests as workers and then specifying the strategy in `spec_helper` like below:
+
+```Ruby
+# spec/spec_helper.rb
+RSpec.configure do |config|
+  config.before(:each) do
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  # Clean up all worker specs with truncation
+  config.before(:each, :worker => true) do
+    DatabaseCleaner.strategy = :truncation
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+
+# spec/workers/email_worker_spec.rb
+require 'spec_helper'
+
+# Tag the spec as a worker spec so data is persisted long enough for the test
+describe EmailWorker, worker: true do
+  describe "#perform" do
+    let(:user) { FactoryGirl.create(:user) }
+
+    it "delivers an email" do
+      expect {
+        EmailWorker.new.perform(user.id)
+      }.to change{ ActionMailer::Base.deliveries.size }.by(1)
+    end
+  end
+end
+```
+
 When using Passenger or Unicorn, you should configure the queues within a block that runs after the child process is forked.
 
 ```Ruby

data/lib/sucker_punch.rb

@@ -18,7 +18,6 @@ module SuckerPunch
     klass = options.fetch(:worker)
     registry_name = options.fetch(:name)
     workers = options.fetch(:workers, nil)
-    workers ||= options.fetch(:size, nil)
 
     q = Queue.new(registry_name)
     q.register(klass, workers)

data/lib/sucker_punch/exceptions.rb

@@ -2,5 +2,4 @@ module SuckerPunch
   class Error < StandardError; end
   class MissingQueueName < Error; end
   class MissingWorkerName < Error; end
-
-end
+end

data/lib/sucker_punch/version.rb

@@ -1,3 +1,3 @@
 module SuckerPunch
-  VERSION = "0.4"
+  VERSION = "0.4.1"
 end

data/spec/sucker_punch_spec.rb

@@ -15,14 +15,6 @@ describe SuckerPunch do
           queue name: :crazy_queue, worker: FakeWorker, workers: 3
         end
       end
-
-      it "supports size for workers count" do
-        SuckerPunch::Queue.any_instance.should_receive(:register).with(FakeWorker, 3)
-
-        SuckerPunch.config do
-          queue name: :crazy_queue, worker: FakeWorker, size: 3
-        end
-      end
     end
 
     context "with no queue name" do

data/sucker_punch.gemspec

@@ -20,5 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rspec"
   gem.add_development_dependency "rake"
 
-  gem.add_dependency "celluloid", "> 0.11"
+  gem.add_dependency "celluloid", "~> 0.13.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sucker_punch
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-24 00:00:00.000000000 Z
+date: 2013-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -48,17 +48,17 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: 0.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>'
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: 0.13.0
 description: Asynchronous processing library for Ruby
 email:
 - brandonhilkert@gmail.com