sucker 0.6.5 → 0.6.6

data/README.md

@@ -42,26 +42,23 @@ Hit Amazon again.
 
 Check the integration specs for more examples.
 
-Testing
--------
+Stubbing
+--------
 
-To fake web requests, create `spec/support/sucker.rb` and:
+To stub web requests in your specs, create `spec/support/sucker_helper.rb`:
 
     require "sucker/stub"
+    
     Sucker.fixtures_path = File.dirname(__FILE__) + "/../fixtures"
 
-Then, in your spec, stub the worker:
+In your spec, you can now stub the worker:
 
     @worker = Sucker.new(some_hash)
     Sucker.stub(@worker)
 
-The first time you run the spec, Sucker will perform the actual web request and cache the response. Then, it will stub subsequent requests with the cached response.
-
-Notes
------
-
-* The unit specs should run out of the box after you `bundle install`, but the integration specs require you to create [an amazon.yml file with valid credentials](http://github.com/papercavalier/sucker/blob/master/spec/support/amazon.yml.example) in `spec/support`.
+The first time you run the spec, Sucker will perform the actual request. Following requests will use a cached response.
 
-* Version 0.6.0 now has Active Support's Nokogiri-based `to_hash` under the hood. After some meddling, it does what it's supposed to do and is blazing fast. Fix up your code accordingly.
+Compatibility
+-------------
 
-* To test specs against all rubies on your system , run `./rake_rubies.sh spec:progress`.
+Specs pass against Ruby 1.8.7, 1.9.1, 1.9.2, and REE.

data/lib/sucker/response.rb

@@ -11,8 +11,7 @@ module Sucker
     end
 
     def to_h
-      doc = Nokogiri::XML(body)
-      content_to_string(doc.to_hash)
+      @hash ||= content_to_string(Nokogiri::XML(body).to_hash)
     end
 
     alias :to_hash :to_h

data/lib/sucker/stub.rb

@@ -14,7 +14,13 @@ module Sucker
     def stub(request)
       request.instance_eval do
         self.class.send :define_method, :fixture do
-          filename = Digest::MD5.hexdigest(host + parameters.values.flatten.join)
+          values = parameters.
+            reject{ |k, v| %w{AWSAccessKeyId Service}.
+            include? k }.
+            values.
+            flatten.
+            join
+          filename = Digest::MD5.hexdigest(host + values)
           "#{Sucker.fixtures_path}/#{filename}.xml"
         end
 

data/spec/unit/sucker/response_spec.rb

@@ -39,6 +39,11 @@ module Sucker
         @response.to_hash.should eql @response.to_h
       end
 
+      it "caches hash" do
+        hash = @response.to_h
+        @response.instance_variable_get(:@hash).should eql hash
+      end
+
       it "renders French" do
         @response.body = "<Title>L'archéologie du savoir</Title>"
         @response.to_h["Title"].should eql "L'archéologie du savoir"

data/spec/unit/sucker/stub_spec.rb

@@ -39,25 +39,29 @@ module Sucker
 
         @worker.get.body.should eql "bar"
       end
+    end
 
-      context "defines:" do
-        context "#fixture" do
-          it "generates a path for the fixture" do
-            @worker.fixture.should match /.*\/[0-9a-f]{32}\.xml$/
-          end
+    context "#fixture" do
+      it "generates a path for the fixture" do
+        @worker.fixture.should match /.*\/[0-9a-f]{32}\.xml$/
+      end
 
-          it "generates unique fixtures across venues" do
-            first_fixture = @worker.fixture
-            @worker.locale = "fr"
-            @worker.fixture.should_not eql first_fixture
-          end
+      it "generates unique fixtures across venues" do
+        first_fixture = @worker.fixture
+        @worker.locale = "fr"
+        @worker.fixture.should_not eql first_fixture
+      end
+
+      it "generates the same fixture regardless of signature" do
+        first_fixture = @worker.fixture
+        @worker.stub!(:timestamp).and_return({ "Timestamp" => "foo" })
+        @worker.fixture.should eql first_fixture
+      end
 
-          it "reuses fixture regardless of signature" do
-            first_fixture = @worker.fixture
-            @worker.stub!(:timestamp).and_return({ "Timestamp" => "foo" })
-            @worker.fixture.should eql first_fixture
-          end
-        end
+      it "generates the same fixture regardless of key" do
+        first_fixture = @worker.fixture
+        @worker.key = "foo"
+        @worker.fixture.should eql first_fixture
       end
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 11
   prerelease: false
   segments: 
   - 0
   - 6
-  - 5
-  version: 0.6.5
+  - 6
+  version: 0.6.6
 platform: ruby
 authors: 
 - Hakan Ensari
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-08-04 00:00:00 +01:00
+date: 2010-08-05 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency