sucker 0.2.0 → 0.2.1

data/README.md

@@ -1,9 +1,9 @@
 Sucker
 ======
 
-![Sucker](http://upload.wikimedia.org/wikipedia/en/7/71/Vacuum_cleaner_1910.JPG)
+Sucker is a thin Ruby wrapper to the Amazon Product Advertising API. It runs on Curb and Crack.
 
-Sucker is a light-weight Ruby wrapper to the Amazon Product Advertising API. It runs on Curb and Crack.
+![Sucker](http://upload.wikimedia.org/wikipedia/en/7/71/Vacuum_cleaner_1910.JPG)
 
 Examples
 --------

data/lib/sucker/request.rb

@@ -46,8 +46,6 @@ module Sucker
     # Makes a request to Amazon and returns the response as a hash
     # Todo: Handle errors
     def get
-      raise ArgumentError, 'Set key, secret, and valid locale' if !valid?
-
       curl.url = uri.to_s
       curl.perform
 
@@ -105,10 +103,5 @@ module Sucker
     def timestamp_parameters
       self.parameters["Timestamp"] = Time.now.utc.strftime('%Y-%m-%dT%H:%M:%SZ')
     end
-
-    # Returns true if request has key, secret, and a valid locale set
-    def valid?
-      !!locale && !!HOSTS[locale.to_sym] && !!secret && !!parameters["AWSAccessKeyId"]
-    end
   end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,7 @@
-require "rspec"
+unless defined?(Bundler)
+  require "rubygems"
+  require "bundler/setup"
+end
 
 require File.expand_path("../../lib/sucker", __FILE__)
 

data/spec/unit/sucker/request_spec.rb

@@ -6,63 +6,55 @@ module Sucker
       @worker = Sucker.new
     end
 
-    context "public" do
-      context ".new" do
-        it "sets default parameters" do
-          default_parameters = {
-            "Service" => "AWSECommerceService",
-            "Version" => Sucker::AMAZON_API_VERSION }
-          @worker.parameters.should eql default_parameters
-        end
+    context ".new" do
+      it "sets default parameters" do
+        default_parameters = {
+          "Service" => "AWSECommerceService",
+          "Version" => Sucker::AMAZON_API_VERSION }
+        @worker.parameters.should eql default_parameters
       end
+    end
 
-      context "#<<" do
-        it "merges a hash into the parameters" do
-          @worker << { "foo" => "bar" }
-          @worker.parameters["foo"].should eql "bar"
-        end
+    context "#<<" do
+      it "merges a hash into the parameters" do
+        @worker << { "foo" => "bar" }
+        @worker.parameters["foo"].should eql "bar"
       end
+    end
 
-      context "#curl" do
-        it "returns a cURL object" do
-          @worker.curl.should be_an_instance_of Curl::Easy
-        end
-
-        it "configures the cURL object" do
-          @worker.curl.interface.should be_nil
+    context "#curl" do
+      it "returns a cURL object" do
+        @worker.curl.should be_an_instance_of Curl::Easy
+      end
 
-          @worker.curl do |curl|
-            curl.interface = "eth1"
-          end
+      it "configures the cURL object" do
+        @worker.curl.interface.should be_nil
 
-          @worker.curl.interface.should eql "eth1"
+        @worker.curl do |curl|
+          curl.interface = "eth1"
         end
-      end
 
-      context "#get" do
-        before do
-          @worker.locale = "us"
-          @worker.key = "key"
-          @worker.secret = "secret"
+        @worker.curl.interface.should eql "eth1"
+      end
+    end
 
-          # Stub curl
-          curl = @worker.curl
-          curl.stub(:get).and_return(nil)
-          curl.stub!(:body_str).and_return(fixture("single_item_lookup.us"))
-        end
+    context "#get" do
+      before do
+        @worker.locale = "us"
+        @worker.secret = "secret"
 
-        it "returns a hash" do
-          @worker.get.should be_an_instance_of Hash
-        end
+        # Stub curl
+        curl = @worker.curl
+        curl.stub(:get).and_return(nil)
+        curl.stub!(:body_str).and_return(fixture("single_item_lookup.us"))
+      end
 
-        it "raises an ArgumentError if valid? returns false" do
-          @worker.stub!(:valid?).and_return(false)
-          lambda{ @worker.get }.should raise_error ArgumentError
-        end  
+      it "returns a hash" do
+        @worker.get.should be_an_instance_of Hash
       end
     end
 
-    context "private" do
+    context "private methods" do
       context "#build_query" do
         it "canonicalizes parameters" do
           query = @worker.send(:build_query)
@@ -132,40 +124,6 @@ module Sucker
           @worker.send(:uri).should be_an_instance_of URI::HTTP
         end
       end
-
-      context "valid?" do
-        it "returns true if key, secret, and a valid locale are set" do
-          @worker.key    = "key"
-          @worker.locale = "us"
-          @worker.secret = "secret"
-          @worker.send(:valid?).should be_true
-        end
-
-        it "returns false if key is not set" do
-          @worker.locale = "us"
-          @worker.secret = "secret"
-          @worker.send(:valid?).should be_false
-        end
-
-        it "returns false if secret is not set" do
-          @worker.locale = "us"
-          @worker.key    = "key"
-          @worker.send(:valid?).should be_false
-        end
-
-        it "returns false if locale is not set" do
-          @worker.key    = "key"
-          @worker.secret = "secret"
-          @worker.send(:valid?).should be_false
-        end
-
-        it "returns false if locale is not valid" do
-          @worker.key    = "key"
-          @worker.locale = "US"
-          @worker.secret = "secret"
-          @worker.send(:valid?).should be_false
-        end
-      end
     end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: sucker
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Hakan Ensari