subtitulos_downloader 0.6.0 → 0.6.1

data/lib/subtitulos_downloader/provider/subtitulos_es.rb

@@ -57,31 +57,37 @@ module SubtitulosDownloader
 
     def get_subtitles(language, episode_table, show_sub)
       @provider_link = (episode_table/"td.NewsTitle/a").first.attributes['href']
+      translation_unfinished = false
       (episode_table/"tr/td.language").each do |lang|
         language_sub = lang.inner_html.strip.force_encoding('utf-8')
         if language_sub =~ /#{language}/i
-            # puts "Language #{language} found"
-            if not lang.next_sibling.inner_html =~ /[0-9]+\.?[0-9]*% Completado/i
-              # puts "Translation for language #{language} completed"
-              subtitle_a = lang.parent.search("a").at(0)
-              subtitle_url = subtitle_a.attributes['href']
-              # puts "Fetching #{language} subtitle file"
-              @provider_language = language_sub
-              @direct_link = subtitle_url
-              # @provider_link = "#{@base_uri}/show/#{show_sub[:id_show]}"
-              open(subtitle_url, 
-                "User-Agent" => @user_agent,
-                "Referer" => "#{@base_uri}/show/#{show_sub[:id_show]}") { |f|
-                  # Save the response body
-                  subs= f.read
-                  return subs
-              }
-            else
-              raise TranslationNotFinished, "[#{@provider_name}] #{language} translation not finished for #{show_sub[:show_episode].full_name}"              
-            end
+          # puts "Language #{language} found"
+          if not lang.next_sibling.inner_html =~ /[0-9]+\.?[0-9]*% Completado/i
+            # puts "Translation for language #{language} completed"
+            subtitle_a = lang.parent.search("a").at(0)
+            subtitle_url = subtitle_a.attributes['href']
+            # puts "Fetching #{language} subtitle file"
+            @provider_language = language_sub
+            @direct_link = subtitle_url
+            # @provider_link = "#{@base_uri}/show/#{show_sub[:id_show]}"
+            translation_unfinished = false              
+            open(subtitle_url, 
+              "User-Agent" => @user_agent,
+              "Referer" => "#{@base_uri}/show/#{show_sub[:id_show]}") { |f|
+                # Save the response body
+                subs= f.read
+                return subs
+            }
+          else
+            translation_unfinished = true              
+          end
         end
       end
-      raise LanguageNotFound, "[#{@provider_name}] #{language} not found for #{show_sub[:show_episode].full_name}"
+      if translation_unfinished
+        raise TranslationNotFinished, "[#{@provider_name}] #{language} translation not finished for #{show_sub[:show_episode].full_name}" 
+      else
+        raise LanguageNotFound, "[#{@provider_name}] #{language} not found for #{show_sub[:show_episode].full_name}"
+      end
     end
 
 
@@ -98,6 +104,7 @@ module SubtitulosDownloader
         show_url = show_subs.attributes['href']
         show = { :show_episode => show_episode, :url => show_url, :id_show => show_url.split('/show/')[1].to_i }
         if (show_name == show_episode.show_name)
+          shows = []
           shows << show
           break
         elsif show_name =~ /^#{show_episode.show_name}/i and (show_name != 'Scrubs Interns' and show_name != 'true blood minisodes')

data/lib/subtitulos_downloader/version.rb

@@ -1,3 +1,3 @@
 module SubtitulosDownloader
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/spec/show_episode_spec.rb

@@ -33,7 +33,7 @@ describe SubtitulosDownloader::ShowEpisode do
 
     it 'should show the subtitle given a language' do
       episode = SubtitulosDownloader::ShowEpisode.new('fake show', 3, 3)
-      subtitle = SubtitulosDownloader::Subtitle.new('subs', 'es', episode,  'direct_link', 'provider_link', 'provider', 'provider_language')
+      subtitle = SubtitulosDownloader::Subtitle.new('subs', 'es', episode, 'direct_link', 'provider_link', 'provider', 'provider_language')
       sub = episode.subtitle_language 'es'
       sub.should == subtitle
       sub.subtitles.should =='subs'

data/spec/subtitulos_es_spec.rb

@@ -52,6 +52,14 @@ describe SubtitulosDownloader::SubtitulosEs do
       subs = (subtitle.subtitles =~ /Quello che conta e' che sono nei guai./) > 1
       subs.should == true
     end
+
+    it 'should fetch second español if first is not completed' do
+      episode = SubtitulosDownloader::ShowEpisode.new('Hustle', 7, 3)
+      subtitle = @provider.fetch(episode, 'es')
+      subtitle.language.should == 'es'
+      subtitle.show_episode.should == episode
+      subs = (subtitle.subtitles =~ /el reverendo R.G. Wendell/) > 1
+    end
   end
 
   context "Rasing Exceptions" do 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: subtitulos_downloader
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
   prerelease: 
 platform: ruby
 authors:
@@ -115,7 +115,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1144419666492793032
+      hash: 2243448483779133464
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -124,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1144419666492793032
+      hash: 2243448483779133464
 requirements: []
 rubyforge_project: subtitulos_downloader
 rubygems_version: 1.8.24