subroutine 4.0.1 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c838c235e50f88722d2f39f19560fa5208a1e18f7cd0ee8edeeeea568e47166c
-  data.tar.gz: 4bb808af75863ee0785ef8989b6ffc3423838dae84bb7a481d18aa759325c5be
+  metadata.gz: 5b099aef955fc06d44e4a9c628f261e15300fe1dca247c4f8ee042be538037a8
+  data.tar.gz: 3879046fc03f34b01c243f8a1cc1630c30075f6c186593509935b4ae1b62d6a9
 SHA512:
-  metadata.gz: a008be5744be667696675df24ba4edf19a39716f27074ec192500ed30ba750d11974f1c3892144b13ff693631899cd0aa0931c5995b823ebe112073646fb5363
-  data.tar.gz: f45212abc2f417d85c73db00ee83b9359ddc80d46fd77f78a45c802efe51a7374dcc978c0d7ded73ddd67c6637f252516c86abdf0f6f0ab309ef763476c17113
+  metadata.gz: 60327bcf9acf93b74b5ff94b45d18c7765830f2c2456481585274b75348b316dca245597f332fe95c54b47d6a91f21de7876c96bdcfb3418d213a38d45f1fbdb
+  data.tar.gz: aa61977d8dec95499096f58d9590a059796d0cfe211f604237cb53ab69bc72ad634515c621ad76b128dea11bfba6acb1d6c82b607c22c8fe3fae74364353a3cc

data/CHANGELOG.MD

@@ -1,3 +1,16 @@
+## Subroutine 4.1.0
+
+A field can no opt out of the natural assignment behavior of ActiveSupport::HashWithIndifferentAccess. Top level param groups are still accessible via indifferent access but if a field sets the `bypass_indifferent_assignment` option to `true` the HashWithIndifferentAccess assignment behavior will be bypassed in favor of direct Hash-like assignment.
+
+```ruby
+class MyOp < Subroutine::Op
+
+  object :some_hash
+  object :some_other_hash, bypass_indifferent_assignment: true
+
+end
+```
+
 ## Subroutine 4.0.1
 
 Association fields can now use `find_by()` instead of `find_by!()` by passing a `raise_on_miss: false` option. This places the responsibility on the op to manage nil cases rather than handling RecordNotFound errors.

data/lib/subroutine/fields/configuration.rb

@@ -76,6 +76,10 @@ module Subroutine
         config[:field_reader] != false
       end
 
+      def bypass_indifferent_assignment?
+        config[:bypass_indifferent_assignment] == true
+      end
+
       def groups
         config[:groups] || NO_GROUPS
       end

data/lib/subroutine/fields.rb

@@ -186,7 +186,14 @@ module Subroutine
     end
 
     def set_param_group_value(name, key, value)
-      get_param_group(name)[key.to_sym] = value
+      config = get_field_config(key)
+      group = get_param_group(name)
+
+      if config&.bypass_indifferent_assignment?
+        group.regular_writer(group.send(:convert_key, key), value)
+      else
+        group[key.to_sym] = value
+      end
     end
 
     def original_params

data/lib/subroutine/version.rb

@@ -3,8 +3,8 @@
 module Subroutine
 
   MAJOR = 4
-  MINOR = 0
-  PATCH = 1
+  MINOR = 1
+  PATCH = 0
   PRE   = nil
 
   VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join(".")

data/test/subroutine/type_caster_test.rb

@@ -175,6 +175,34 @@ module Subroutine
 
       op.object_input = { 'foo' => { 'bar' => :baz } }
       assert_equal({ 'foo' => { 'bar' => :baz } }, op.object_input)
+
+      op.object_input = { foo: "bar" }
+      assert op.object_input.is_a?(ActiveSupport::HashWithIndifferentAccess)
+    end
+
+    def test_hash_inputs_can_opt_out_of_indifferent_access_behavior
+      op.no_indifferent_object_input = nil
+      assert_nil op.no_indifferent_object_input
+
+      op.no_indifferent_object_input = ''
+      assert_equal({}, op.no_indifferent_object_input)
+
+      op.no_indifferent_object_input = [[:a, :b]]
+      assert_equal({ a: :b }, op.no_indifferent_object_input)
+
+      op.no_indifferent_object_input = { foo: "bar" }
+      assert_equal({ foo: "bar" }, op.no_indifferent_object_input)
+      assert op.no_indifferent_object_input.key?(:foo)
+      refute op.no_indifferent_object_input.key?("foo")
+      refute op.no_indifferent_object_input.is_a?(ActiveSupport::HashWithIndifferentAccess)
+      assert op.no_indifferent_object_input.is_a?(Hash)
+
+      op.no_indifferent_object_input = { "foo" => "bar" }
+      assert_equal({ "foo" => "bar" }, op.no_indifferent_object_input)
+      assert op.no_indifferent_object_input.key?("foo")
+      refute op.no_indifferent_object_input.key?(:foo)
+      refute op.no_indifferent_object_input.is_a?(ActiveSupport::HashWithIndifferentAccess)
+      assert op.no_indifferent_object_input.is_a?(Hash)
     end
 
     def test_array_inputs

data/test/support/ops.rb

@@ -176,6 +176,7 @@ class TypeCastOp < ::Subroutine::Op
   iso_date :iso_date_input
   iso_time :iso_time_input
   object :object_input
+  object :no_indifferent_object_input, bypass_indifferent_assignment: true
   array :array_input, default: "foo"
   array :type_array_input, of: :integer
   file :file_input

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subroutine
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.1.0
 platform: ruby
 authors:
 - Mike Nelson
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-17 00:00:00.000000000 Z
+date: 2024-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel