subroutine 0.10.0.beta7 → 0.10.0.beta8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27287a4d05110ba46ae806e8e3b38f4598c0bb8f69fbdb97f41a53eea025e955
-  data.tar.gz: 22da96f1411d3887a41f42a2a7ca493587ed404aa5760da45447c7ba443dd6ef
+  metadata.gz: 4c5dff0a8ab49afebd76be4189b3128c27f6f79786a4745fb01a9b18b023ea44
+  data.tar.gz: 1329a8feaedde19122bb3afbca4eda13818dcb720b9edc0b01cd58e3422c4463
 SHA512:
-  metadata.gz: 8cef15bcb25e9792eee2a0073f9d428784cda0370aa40c49881db5e124821b9c0036e83cdfc173233f4a4a76ea8be1ce842a0b309bdd02023f7e1333219f19a6
-  data.tar.gz: e0797ab6a5153718d02ef4bb9d7dbeed5f793a8ef574d504627c2c109ff8147a8ed290cc555c08a5dd62cb5f226998d40faec1d8a6f14a10163d93b6974d1892
+  metadata.gz: 2acf6bdb0f20e14dbf24155a3e4d80db6715d7eb9ab6869d0ef2b07a7cf7efd2ef9b4287827fcf25d0877c5910e979885e8fa5fe84256d16479bc47340b7cd04
+  data.tar.gz: b0c826a03266eeafd1db07597c0c70c43065b73780137182129310238e0e74c04505d83a207dc1357ba20c5b00cfd1107c3d9d92152213961c7256ec4fb10fee

data/lib/subroutine/outputs.rb

@@ -36,15 +36,26 @@ module Subroutine
     end
 
     def setup_outputs
-      @outputs = {}.with_indifferent_access
+      @outputs = {} # don't do with_indifferent_access because it will turn provided objects into with_indifferent_access objects, which may not be the desired behavior
+    end
+
+    def output_provided?(name)
+      name = name.to_sym
+
+      unless output_configurations.key?(name)
+        raise ::Subroutine::Outputs::UnknownOutputError, name
+      end
+
+      outputs.key?(name)
     end
 
     def output(name, value)
-      unless output_configurations.key?(name.to_sym)
+      name = name.to_sym
+      unless output_configurations.key?(name)
         raise ::Subroutine::Outputs::UnknownOutputError, name
       end
 
-      outputs[name.to_sym] = value
+      outputs[name] = value
     end
 
     def get_output(name)
@@ -56,7 +67,7 @@ module Subroutine
 
     def validate_outputs!
       output_configurations.each_pair do |name, config|
-        if config.required? && !outputs.key?(name)
+        if config.required? && !output_provided?(name)
           raise ::Subroutine::Outputs::OutputNotSetError, name
         end
       end

data/lib/subroutine/version.rb

@@ -5,7 +5,7 @@ module Subroutine
   MAJOR = 0
   MINOR = 10
   PATCH = 0
-  PRE   = "beta7"
+  PRE   = "beta8"
 
   VERSION = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
 

data/test/subroutine/base_test.rb

@@ -228,6 +228,16 @@ module Subroutine
       assert_equal "foo@bar.com", u.email_address
     end
 
+    # Hash#with_indifferent_access was changing output objects
+    def test_outputs_are_not_mutated
+      out = { "foo" => "bar" }
+      op = ::SignupOp.new
+      op.send :output, :perform_called, out
+      value = op.perform_called
+      assert_equal out, value
+      assert_equal Hash, value.class
+    end
+
     def test_it_raises_an_error_if_an_output_is_not_defined_but_is_set
       op = ::MissingOutputOp.new
       assert_raises ::Subroutine::Outputs::UnknownOutputError do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subroutine
 version: !ruby/object:Gem::Version
-  version: 0.10.0.beta7
+  version: 0.10.0.beta8
 platform: ruby
 authors:
 - Mike Nelson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-25 00:00:00.000000000 Z
+date: 2020-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel