subprocess 1.5.4 → 1.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 03feecd6b5ca0a66f4c795071be9ed48d4801ac8735e69660ff7e87b05f1e47d
-  data.tar.gz: 0dad63e1568ca3a477471b98b912ee0528963d80d1ee8646813b2efa7429d429
+  metadata.gz: ca7ff75142ac9cdc919053f61071f8ff54d21193754239da85b810d0dce7886d
+  data.tar.gz: ae5ec4dedac5fd3042e6006ae798bf286c5705b6aca0da37c398fbd52b16d100
 SHA512:
-  metadata.gz: 0d5cc41f0a7d716cb87c6e70c25b4892905b12d2c55727e29af281bc8e66f46be68a6a76fc263ac1ed1a8fd709288b3101dcd0d2ed19aac36c94d9de133ea171
-  data.tar.gz: 25b247b27b30ce8dc4cf98670adb415f82bc4e4ce64ba5e410307ba194efd516c13af19ded736568a2e95ab88bacda16a46b626230be45f2a948db7e7876ad7e
+  metadata.gz: d0e375e45a5ed1089690a90abe9bf3fcc83754a4bd490047465ff0b83bd82966a5cb73fcd6738cb215c6351784582b90a341ba7ad7315738ef426f532215ed9b
+  data.tar.gz: 87b16802e5534b86c4f2d0ab7b7f5bd0cd885b9375af520341a936c017e5c23a8a33a76bcd7a50566cb9a2631e77fc8c9797779e78e03c0e75afe916d680efb1

data/README.md

@@ -1,4 +1,4 @@
-# Subprocess [![Build Status](https://travis-ci.org/stripe/subprocess.svg?branch=master)](https://travis-ci.org/stripe/subprocess) [![Yard Docs](http://img.shields.io/badge/yard-docs-blue.svg)](http://rubydoc.info/github/stripe/subprocess/Subprocess)
+# Subprocess ![Ruby](https://github.com/stripe/subprocess/workflows/Ruby/badge.svg) [![Yard Docs](http://img.shields.io/badge/yard-docs-blue.svg)](http://rubydoc.info/github/stripe/subprocess/Subprocess)
 
 ![Jacques Cousteau Submarine](http://i.imgur.com/lmej24F.jpg)
 
@@ -65,6 +65,31 @@ differences, but if we have missed something, please file an issue.
 [python]: http://docs.python.org/library/subprocess.html
 [rubydoc]: http://rubydoc.info/github/stripe/subprocess/Subprocess
 
+Maintenance
+-----------
+
+Steps to release a new version:
+
+```bash
+# Work directly on master
+git checkout master
+
+# -- edit version in lib/subprocess/version.rb --
+
+# Update RBI files
+bundle exec rake sord
+
+# Subsequent commands reference the version
+VERSION=1.5.5
+git commit -am "Bump version to $VERSION"
+git tag "v$VERSION"
+git push origin master --tags
+bundle exec rake publish
+```
+
+If you get errors, ask someone to add you to `bindings/rubygems-api-key` in
+Vault or ask someone who already has permissions. See <http://go/password-vault>
+
 Acknowledgements
 ----------------
 

data/lib/subprocess.rb

@@ -221,8 +221,8 @@ module Subprocess
     # @return [Integer] The process ID of the spawned process.
     attr_reader :pid
 
-    # @return [::Process::Status] The exit status code of the process. Only
-    #   set after the process has exited.
+    # @return [::Process::Status, nil] The exit status code of the process.
+    #   Only set after the process has exited.
     attr_reader :status
 
     # Create a new process.
@@ -430,7 +430,10 @@ module Subprocess
 
       stdout, stderr = "", ""
 
-      input = input.dup unless input.nil?
+      # NB: Always force encoding to binary so we handle unicode or binary input
+      # correctly across multiple write_nonblock calls, since we manually slice
+      # the input depending on how many bytes were written
+      input = input.dup.force_encoding('BINARY') unless input.nil?
 
       @stdin.close if (input.nil? || input.empty?) && !@stdin.nil?
 

data/lib/subprocess/version.rb

@@ -1,3 +1,3 @@
 module Subprocess
-  VERSION = '1.5.4'
+  VERSION = '1.5.5'
 end

data/rbi/subprocess.rbi

@@ -11,7 +11,7 @@
 module ::Subprocess
   PIPE = T.let(-1, T.untyped)
   STDOUT = T.let(-2, T.untyped)
-  VERSION = T.let('1.5.4', T.untyped)
+  VERSION = T.let('1.5.5', T.untyped)
 
   # An alias for `Process.new`. Mostly here to better emulate the Python API.
   #
@@ -304,9 +304,9 @@ module ::Subprocess
     sig { returns(Integer) }
     attr_reader :pid
 
-    # _@return_ — The exit status code of the process. Only
-    # set after the process has exited.
-    sig { returns(::Process::Status) }
+    # _@return_ — The exit status code of the process.
+    # Only set after the process has exited.
+    sig { returns(T.nilable(::Process::Status)) }
     attr_reader :status
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: subprocess
 version: !ruby/object:Gem::Version
-  version: 1.5.4
+  version: 1.5.5
 platform: ruby
 authors:
 - Carl Jackson
@@ -9,10 +9,10 @@ authors:
 - Nelson Elhage
 - Andy Brody
 - Andreas Fuchs
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-13 00:00:00.000000000 Z
+date: 2021-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -89,7 +89,7 @@ homepage: https://github.com/stripe/subprocess
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key:
+signing_key: 
 specification_version: 4
 summary: A port of Python's subprocess module to Ruby
 test_files: []