subordinate 0.6.2 → 0.7.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YmNjYmE1MjYzMTFhYWJmMmRiNGZlNTY3ZTA3YzNjNzJlYTlmZjBlMw==
-  data.tar.gz: !binary |-
-    Y2EwZGZiM2QwMTVlZmIxN2MwMGQ2ZmQxZTEyZDYzNmU5MDg1ZTEyMg==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    MTExMzMxNjYwNzkxMzM1ZDQ0YzJhYmNjYWVmNTYzNzlhZDI0YjE4YTgwOWVh
-    OGM5NWUxZTZhYzFkNjRmNDAwOGIyNzhhZjhhYWU5MWQxYjcxOTAxMzRlZTFl
-    YmIyOTBhNjg1MmE3N2RjZDA1ZTk1M2U3MjRiY2Q2ODhjZjYwZWM=
-  data.tar.gz: !binary |-
-    ZTJiMzcwOWE2NDJhMjg4ZDRkNTU4ZGRmOGU4OGI1YzQ4NTE3N2NkODRhNDk4
-    MjU2MTUwMjViOWYwY2E2MTlhYzk3MDBmYTlhMThhOGY3Y2MwYmNmMWYyZGE4
-    M2Q3MGMzM2RkMTkwOWE1NzBmODljNTU4OGYyNzRlMjIxODljNmI=
+SHA1:
+  metadata.gz: 2fcc3f8225a4165734cf15cd4991414242ed0780
+  data.tar.gz: 59259f7cc29b1938f48740b25097a6a0bc47ece3
+SHA512:
+  metadata.gz: c2f5738a31937943c7852ff24a6ee68176ee91cc72c3d622e44f5dcf394aff5262cbdef5b5a6d09c2c7e262062a83f9df2f1eff63d137eae564babb4371b945a
+  data.tar.gz: f440f7ae37de8c3e93adb8024111cc45f3477fc4d284eaccde6079538ed2c2cd40689eb66003a6aa70e481df6893bb04fc40e1568a3df9a15441e61368b73973

data/lib/subordinate/authentication.rb

@@ -1,22 +1,8 @@
 # Authentication Module
 module Subordinate
   module Authentication
-    def authentication
-      if username && api_token
-        { :username => username, :api_token => api_token}
-      else
-        {}
-      end
-    end
-
     def authenticated?
-      !authentication.empty?
-    end
-
-    def username_and_token(username = "", api_token = "")
-      return if username.nil? || api_token.nil?
-      self.username   = username
-      self.api_token  = api_token
+      !!(username && api_token)
     end
   end
-end
+end

data/lib/subordinate/client.rb

@@ -2,15 +2,7 @@
 require "subordinate/authentication"
 require "subordinate/connection"
 require "subordinate/request"
-
-require "subordinate/client/job"
-require "subordinate/client/system"
-require "subordinate/client/build"
-require "subordinate/client/queue"
-require "subordinate/client/load"
-require "subordinate/client/people"
-require "subordinate/client/view"
-require "subordinate/client/executor"
+Dir[File.expand_path("../client/*.rb", __FILE__)].each {|f| require f }
 
 module Subordinate
   class Client
@@ -22,23 +14,13 @@ module Subordinate
       Configuration::VALID_OPTIONS_KEYS.each do |key|
         send("#{key}=", options[key])
       end
-
-      username_and_token(options[:username], options[:api_token])
-      build_endpoint
     end
 
     # Builds the api endpoint to reach the Jenkins Server
     #
-    # @return [String] Endpoint
-    #
-    # @author Jason Truluck
-    def build_endpoint
-      endpoint = ssl ? "https://" : "http://"
-      endpoint << "#{self.username}:#{self.api_token}@" if self.authenticated?
-      endpoint << "#{self.subdomain}."                  if self.subdomain
-      endpoint << "#{self.domain}"                      if self.domain
-      endpoint << ":#{self.port}"                       if self.port
-      self.api_endpoint = endpoint
+    # @return [String] Endpoint - the api endpoint to the server
+    def api_endpoint
+      build_endpoint
     end
 
     include Subordinate::Authentication
@@ -53,5 +35,14 @@ module Subordinate
     include Subordinate::Client::People
     include Subordinate::Client::View
     include Subordinate::Client::Executor
+
+    private
+    def build_endpoint
+      endpoint = ssl ? "https://" : "http://"
+      endpoint << "#{self.subdomain}."              if self.subdomain
+      endpoint << "#{self.domain}"                  if self.domain
+      endpoint << ":#{self.port}"                   if self.port
+      endpoint
+    end
   end
-end
+end

data/lib/subordinate/client/job.rb

@@ -34,7 +34,7 @@ module Subordinate
       #
       # @author Jason Truluck
       def build_job(job, options = {})
-        post("job/#{job}/build", options).status
+        post("job/#{job}/build", options)
       end
 
       # Builds the job specified on the Jenkins server with specified parameters
@@ -51,7 +51,7 @@ module Subordinate
       #
       # @author Jason Truluck
       def build_job_with_params(job, options = {})
-        post("job/#{job}/buildWithParameters", options).status
+        post("job/#{job}/buildWithParameters", options)
       end
 
       # Disables the specified job on the Jenkins Server
@@ -67,7 +67,7 @@ module Subordinate
       #
       # @author Jason Truluck
       def disable_job(job, options = {})
-        post("job/#{job}/disable", options).status
+        post("job/#{job}/disable", options)
       end
 
       # Enables the specified job on the Jenkins Server
@@ -83,7 +83,7 @@ module Subordinate
       #
       # @author Jason Truluck
       def enable_job(job, options = {})
-        post("job/#{job}/enable", options).status
+        post("job/#{job}/enable", options)
       end
 
       # Deletes the specified job on the Jenkins Server
@@ -99,7 +99,7 @@ module Subordinate
       #
       # @author Jason Truluck
       def delete_job(job, options = {})
-        post("job/#{job}/delete", options).status
+        post("job/#{job}/delete", options)
       end
     end
   end

data/lib/subordinate/client/system.rb

@@ -15,8 +15,6 @@ module Subordinate
       #
       # @example Get the root api response
       #   Subordinate::Client.root
-      #
-      # @author Jason Truluck
       def root(options = {})
         get('/api/json', options)
       end
@@ -29,10 +27,8 @@ module Subordinate
       #
       # @example Send a quiet down request to the Jenkins server
       #   Subordinate::Client.quiet_down
-      #
-      # @author Jason Truluck
       def quiet_down(options = {})
-        post('/quietDown', options).status
+        post('/quietDown', options)
       end
 
       # Cancel a shut down request to the Jenkins Server
@@ -43,10 +39,8 @@ module Subordinate
       #
       # @example Send a quiet down request to the Jenkins server
       #   Subordinate::Client.cancel_quiet_down
-      #
-      # @author Jason Truluck
       def cancel_quiet_down(options = {})
-        post('/cancelQuietDown', options).status
+        post('/cancelQuietDown', options)
       end
 
       # Restarts the jenkins server, will not wait for jobs to finish
@@ -57,10 +51,8 @@ module Subordinate
       #
       # @example Sends a force restart request to the Jenkins server
       #   Subordinate::Client.restart(true)
-      #
-      # @author Jason Truluck
       def restart(options = {})
-        post("restart", options).status
+        post("restart", options)
       end
 
       # Safely Restarts the jenkins server, will wait for jobs to finish
@@ -71,11 +63,9 @@ module Subordinate
       #
       # @example Sends a restart request to the Jenkins server (defaults to no force)
       #   Subordinate::Client.restart
-      #
-      # @author Jason Truluck
       def safe_restart(options = {})
-        post("safeRestart", options).status
+        post("safeRestart", options)
       end
     end
   end
-end
+end

data/lib/subordinate/client/view.rb

@@ -54,7 +54,6 @@ module Subordinate
       # @author Jason Truluck
       def add_job_to_view(view_name, job, options = {})
         options.merge!(
-          :with_query_params => true,
           :name => job
         )
         post("view/#{view_name}/addJobToView", options)
@@ -75,11 +74,10 @@ module Subordinate
       # @author Jason Truluck
       def remove_job_from_view(view_name, job, options = {})
         options.merge!(
-          :with_query_params => true,
-          :name => job
+         :name => job
         )
         post("view/#{view_name}/removeJobFromView", options)
       end
     end
   end
-end
+end

data/lib/subordinate/configuration.rb

@@ -22,12 +22,9 @@ module Subordinate
     end
 
     def reset!
-      self.username            = nil
-      self.api_token           = nil
-      self.domain              = nil
-      self.subdomain           = nil
-      self.port                = nil
-      self.ssl                 = true
+      VALID_OPTIONS_KEYS.each {|key| instance_variable_set("@#{key}".to_sym, nil) }
+      self.ssl = true
+      self
     end
   end
 end

data/lib/subordinate/connection.rb

@@ -1,5 +1,7 @@
 # Connection
+require "json"
 require "faraday_middleware"
+require "subordinate/error"
 
 module Subordinate
   module Connection
@@ -9,12 +11,31 @@ module Subordinate
       }.merge(options)
 
       connection = Faraday.new(options) do |build|
-        build.use FaradayMiddleware::Mashify
-        build.use FaradayMiddleware::ParseJson, :content_type => /\bjson$/
+        build.request :url_encoded
+        if authenticated?
+          build.request :basic_auth, self.username, self.api_token
+        end
+        build.response :mashify
+        build.response :json, :content_type => /\bjson$/
+        build.use ErrorMiddleware
         build.adapter  Faraday.default_adapter
       end
 
       connection
     end
+    # Middleware for responding to Errors returned from the api
+    class ErrorMiddleware < Faraday::Middleware
+      def initialize(app)
+        @app = app
+      end
+
+      def call(env)
+        @app.call(env).on_complete do |env|
+          if error = Subordinate::Error.from(env[:response])
+            raise error
+          end
+        end
+      end
+    end
   end
-end
+end

data/lib/subordinate/error.rb

@@ -0,0 +1,45 @@
+# lib/subordinate/error.rb
+module Subordinate
+  class Error < StandardError
+    attr_accessor :response
+
+    def self.from(response)
+      status  = response.status
+
+      if klass = case status
+                 when 400 then Subordinate::BadRequest
+                 when 401 then Subordinate::Unauthorized
+                 when 404 then Subordinate::NotFound
+                 when 422 then Subordinate::UnprocessableEntity
+                 when 500 then Subordinate::InternalServerError
+                 end
+
+        klass.new(response)
+      end
+    end
+
+    def initialize(response)
+      @response = response
+      super(error_message)
+    end
+
+    private
+    def error_message
+      message =  "#{response.env[:method].upcase} "
+      message << "#{response.env[:url].to_s} | "
+      message << "#{response.status} "
+      message
+    end
+  end
+
+  # Raised when Jenkins REST Api returns a 400 HTTP status code
+  class BadRequest < Error; end
+  # Raised when Jenkins REST Api returns a 401 HTTP status code
+  class Unauthorized < Error; end
+  # Raised when Jenkins REST Api returns a 404 HTTP status code
+  class NotFound < Error; end
+  # Raised when Jenkins REST Api returns a 422 HTTP status code
+  class UnprocessableEntity < Error; end
+  # Raised when Jenkins REST Api returns a 500 HTTP status code
+  class InternalServerError < Error; end
+end

data/lib/subordinate/request.rb

@@ -1,40 +1,40 @@
-require 'multi_json'
-
+# lib/subordinate/request.rb
 module Subordinate
   module Request
     def get(path, options = {})
-      response = request(:get, path, options)
-      response.body
+      request(:get, path, options)
     end
 
     def post(path, options = {})
-      response = request(:post, path, options)
-      response
+      request(:post, path, options)
+    end
+
+    def put(path, options = {})
+      request(:put, path, options)
+    end
+
+    def delete(path, options = {})
+      request(:delete, path, options)
+    end
+
+    def last_response
+      @last_response
     end
 
     private
     def request(method, path, options = {})
-      url = options.delete(:endpoint) || api_endpoint
+      url = options.delete(:api_endpoint) || api_endpoint
 
       connection_options = {
         :url => url
       }
 
       response = connection(connection_options).send(method) do |request|
-        case method
-        when :get
-          request.url(path, options)
-        when :post
-          with_query_params = options.delete(:with_query_params) || false
-          if with_query_params
-            request.url(path, options)
-          else
-            request.path = path
-            request.body = MultiJson.dump(options) unless options.empty?
-          end
-        end
+        request.url(path, options)
       end
-      response
+
+      @last_response = response
+      response.body
     end
   end
-end
+end

data/lib/subordinate/version.rb

@@ -1,3 +1,3 @@
 module Subordinate
-  VERSION = "0.6.2"
+  VERSION = "0.7.0"
 end

data/spec/spec_helper.rb

@@ -1,22 +1,20 @@
 require 'rubygems'
 require 'coveralls'
+require "pry"
 Coveralls.wear!
 
 ENV["RAILS_ENV"] ||= 'test'
-
-if ENV['RAILS_ENV'] == 'test'
-  require 'simplecov'
-  SimpleCov.start 'rails'
-  class SimpleCov::Formatter::QualityFormatter
-    def format(result)
-      SimpleCov::Formatter::HTMLFormatter.new.format(result)
-      File.open("coverage/covered_percent", "w") do |f|
-        f.puts result.source_files.covered_percent.to_f
-      end
+require 'simplecov'
+SimpleCov.start 'rails'
+class SimpleCov::Formatter::QualityFormatter
+  def format(result)
+    SimpleCov::Formatter::HTMLFormatter.new.format(result)
+    File.open("coverage/covered_percent", "w") do |f|
+      f.puts result.source_files.covered_percent.to_f
     end
   end
-  SimpleCov.formatter = SimpleCov::Formatter::QualityFormatter
 end
+SimpleCov.formatter = SimpleCov::Formatter::QualityFormatter
 
 require 'subordinate'
 require "webmock/rspec"
@@ -25,12 +23,15 @@ Dir[File.expand_path("spec/support/**/*.rb", __FILE__)].each {|f| require f}
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.color_enabled = true
   config.order                                           = "random"
 end
 
 def stub_jenkins(http_method = :any, endpoint = "/", status = 200, content_type = "application/json", response)
   stub_request(http_method, "http://someusername:sometoken@jenkins.example.com:8080#{endpoint}").
-  to_return(:status => status, 
+  to_return(
+    :status => status,
     :body => File.read(File.expand_path("../support/mocks/#{response}", __FILE__)),
-    :headers =>{'Accept' => content_type, 'Content-type' => content_type})
+    :headers =>{'Accept' => content_type, 'Content-type' => content_type}
+  )
 end

data/spec/subordinate/client/job_spec.rb

@@ -138,7 +138,8 @@ describe Subordinate::Client do
     it "builds the job specified" do
       stub_jenkins(:post, "/job/Some-Job/build", 302, "empty.json")
 
-      subordinate.build_job("Some-Job").should  == 302
+      subordinate.build_job("Some-Job")
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
@@ -146,7 +147,8 @@ describe Subordinate::Client do
     it "builds the job specified with the parameters specified" do
       stub_jenkins(:post, "/job/Some-Job/buildWithParameters", 302, "empty.json")
 
-      subordinate.build_job_with_params("Some-Job").should  == 302
+      subordinate.build_job_with_params("Some-Job")
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
@@ -154,7 +156,8 @@ describe Subordinate::Client do
     it "disables the specified job" do
       stub_jenkins(:post, "/job/Some-Job/disable", 302, "empty.json")
 
-      subordinate.disable_job("Some-Job").should == 302
+      subordinate.disable_job("Some-Job")
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
@@ -162,7 +165,8 @@ describe Subordinate::Client do
     it "enables the specified job" do
       stub_jenkins(:post, "/job/Some-Job/enable", 302, "empty.json")
 
-      subordinate.enable_job("Some-Job").should == 302
+      subordinate.enable_job("Some-Job")
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
@@ -170,7 +174,8 @@ describe Subordinate::Client do
     it "deletes the specified job" do
       stub_jenkins(:post, "/job/Some-Job/delete", 302, "empty.json")
 
-      subordinate.delete_job("Some-Job").should == 302
+      subordinate.delete_job("Some-Job")
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 end

data/spec/subordinate/client/system_spec.rb

@@ -88,19 +88,19 @@ describe Subordinate::Client do
 
   describe "#quiet_down" do
     it "will shut down the server" do
-      stub_request(:post, "#{subordinate.api_endpoint}/quietDown").
-      to_return(:status => 302, :body => "", :headers => {})
+      stub_jenkins(:post, "/quietDown", 302, "empty.json")
 
-      subordinate.quiet_down.should == 302
+      subordinate.quiet_down
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
   describe "#cancel_quiet_down" do
     it "will cancel a shut down request to the server" do
-      stub_request(:post, "#{subordinate.api_endpoint}/cancelQuietDown").
-      to_return(:status => 302, :body => "", :headers => {})
+      stub_jenkins(:post, "/cancelQuietDown", 302, "empty.json")
 
-      subordinate.cancel_quiet_down.should == 302
+      subordinate.cancel_quiet_down
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
@@ -108,19 +108,19 @@ describe Subordinate::Client do
   # commented out since random order is used.
   describe "#restart" do
     it "will force restart the jenkins server" do
-      stub_request(:post, "#{subordinate.api_endpoint}/restart").
-      to_return(:status => 302, :body => "", :headers => {})
+      stub_jenkins(:post, "/restart", 302, "empty.json")
 
-      subordinate.restart.should == 302
+      subordinate.restart
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 
   describe "#safe_restart" do
     it "will restart the jenkins server" do
-      stub_request(:post, "#{subordinate.api_endpoint}/safeRestart").
-      to_return(:status => 302, :body => "", :headers => {})
+      stub_jenkins(:post, "/safeRestart", 302, "empty.json")
 
-      subordinate.safe_restart.should == 302
+      subordinate.safe_restart
+      expect(subordinate.last_response.status).to eq(302)
     end
   end
 end

data/spec/subordinate/client/view_spec.rb

@@ -16,7 +16,7 @@ describe Subordinate::Client do
 
   describe "#view" do
     before(:each) { stub_jenkins(:get, "/view/someview/api/json", "view.json") }
-    
+
     let(:current_response) { subordinate.view("someview") }
 
     it "returns the view response" do
@@ -80,21 +80,8 @@ describe Subordinate::Client do
     it "responds with a success" do
       stub_jenkins(:post, "/view/someview/addJobToView?name=somejob", 200, "empty.json")
 
-      subordinate.add_job_to_view("someview", "somejob").status.should == 200
-    end
-
-    context "error" do
-      it "returns 404 when not found" do
-        stub_jenkins(:post, "/view/someview/addJobToView?name=somejob", 404, "empty.json")
-
-        subordinate.add_job_to_view("someview", "somejob").status.should == 404
-      end
-      
-      it "returns 500 when server error" do
-        stub_jenkins(:post, "/view/someview/addJobToView?name=somejob", 500, "empty.json")
-
-        subordinate.add_job_to_view("someview", "somejob").status.should == 500
-      end
+      subordinate.add_job_to_view("someview", "somejob")
+      expect(subordinate.last_response.status).to eq(200)
     end
   end
 
@@ -102,21 +89,8 @@ describe Subordinate::Client do
     it "responds with a success" do
       stub_jenkins(:post, "/view/someview/removeJobFromView?name=somejob", 200, "empty.json")
 
-      subordinate.remove_job_from_view("someview", "somejob").status.should == 200
-    end
-    
-    context "error" do
-      it "returns 404 when not found" do
-        stub_jenkins(:post, "/view/someview/removeJobFromView?name=somejob", 404, "empty.json")
-
-        subordinate.remove_job_from_view("someview", "somejob").status.should == 404
-      end
-      
-      it "returns 500 when server error" do
-        stub_jenkins(:post, "/view/someview/removeJobFromView?name=somejob", 500, "empty.json")
-
-        subordinate.remove_job_from_view("someview", "somejob").status.should == 500
-      end
+      subordinate.remove_job_from_view("someview", "somejob")
+      expect(subordinate.last_response.status).to eq(200)
     end
   end
 end

data/spec/subordinate/configuration_spec.rb

@@ -2,118 +2,50 @@
 require "spec_helper"
 
 describe Subordinate::Client do
-  before do
-    Subordinate.reset!
-
-    Subordinate.configure do |c|
-      c.subdomain = "jenkins"
-      c.domain    = "example.com"
-      c.port      = 8080
-      c.ssl       = false
-    end
-  end
-
   describe "configuration" do
     let(:domain)    { "woofound.com" }
     let(:subdomain) { "awesome" }
     let(:port)      { 2000 }
     let(:ssl)       { false }
 
-    describe "with a domain" do
-      before do
-        Subordinate.reset!
-        Subordinate.configure do |c|
-          c.domain = domain
-        end
-      end
-
-      let(:client) { Subordinate.new }
-
-      it "sets the domain for the client" do
-        client.domain.should == domain
-      end
+    before(:each){
+      Subordinate.reset!
+    }
 
+    describe "with a domain" do
       it "builds an endpoint with the domain" do
-        client.api_endpoint.should include(domain)
+        Subordinate.reset!
+        client = Subordinate.new(domain: domain)
+        client.api_endpoint.should eq("https://#{domain}")
       end
     end
 
     # SUBDOMAIN
     describe "with a subdomain" do
-      before do
-        Subordinate.reset!
-        Subordinate.configure do |c|
-          c.subdomain = subdomain
-        end
-      end
-
-      let(:client) { Subordinate.new }
-
-      it "sets the subdomain for the client" do
-        client.subdomain.should == subdomain
-      end
-
       it "builds an endpoint with the subdomain" do
-        client.api_endpoint.should include(subdomain)
-      end
-    end
-
-    describe "without a subdomain" do
-      it "builds an endpoint without a subdomain" do
-        client = Subordinate.new(:subdomain => nil)
-        client.api_endpoint.should == "http://example.com:8080"
+        client = Subordinate.new(domain: domain, subdomain: subdomain)
+        client.api_endpoint.should eq("https://#{subdomain}.#{domain}")
       end
     end
 
     # PORT
     describe "with a port" do
-      before do
-        Subordinate.reset!
-        Subordinate.configure do |c|
-          c.port = port
-        end
-      end
-
-      let(:client) { Subordinate.new }
-
-      it "sets the port for the client" do
-        client.port.should == port
-      end
-
       it "builds an endpoint with the port" do
-        client.api_endpoint.should include("#{port}")
-      end
-    end
-
-    describe "without a port" do
-      it "builds an endpoint without a port" do
-        client = Subordinate.new(:port => nil)
-        client.api_endpoint.should == "http://jenkins.example.com"
+        client = Subordinate.new(domain: domain, port: port)
+        client.api_endpoint.should eq("https://#{domain}:#{port}")
       end
     end
 
     # SSL
     describe "with a ssl" do
-      before do
-        Subordinate.reset!
-        Subordinate.configure do |c|
-          c.ssl = ssl
-        end
-      end
-
-      let(:client) { Subordinate.new }
-
-      it "sets the ssl for the client" do
-        client.ssl.should == ssl
-      end
-
       it "builds an endpoint with the ssl set to false" do
-        client.api_endpoint.should include("http://")
+        client = Subordinate.new(domain: domain, ssl: false)
+        client.api_endpoint.should eq("http://#{domain}")
       end
 
       it "builds an endpoint with the ssl set to true" do
-        client = Subordinate.new(:ssl => true)
-        client.api_endpoint.should include("https://")
+        client = Subordinate.new(domain: domain, ssl: true)
+        client.api_endpoint.should eq("https://#{domain}")
       end
     end
   end

data/spec/subordinate/error_spec.rb

@@ -0,0 +1,58 @@
+# spec/subordinate/error.rb
+require "spec_helper"
+
+describe Subordinate::Error do
+  before do
+    Subordinate.reset!
+    Subordinate.configure do |c|
+      c.subdomain = "jenkins"
+      c.domain    = "example.com"
+      c.port      = 8080
+      c.ssl       = false
+    end
+  end
+
+  let(:client) { Subordinate::Client.new(:username => "someusername", :api_token => "sometoken") }
+
+  describe "#from" do
+    describe "400 Error" do
+      it "raises a Subordinate::BadRequest error" do
+        stub_jenkins(:get, "/api/json", 400, "application/json", "base.json")
+
+        expect{ client.root }.to raise_error(Subordinate::BadRequest)
+      end
+    end
+
+    describe "401 Error" do
+      it "raises a Subordinate::Unauthorized error" do
+        stub_jenkins(:get, "/api/json", 401, "base.json")
+
+        expect{ client.root }.to raise_error(Subordinate::Unauthorized)
+      end
+    end
+
+    describe "404 Error" do
+      it "raises a Subordinate::NotFound error" do
+        stub_jenkins(:get, "/api/json", 404, "base.json")
+
+        expect{ client.root }.to raise_error(Subordinate::NotFound)
+      end
+    end
+
+    describe "422 Error" do
+      it "raises a Subordinate::UnprocessableEntity error" do
+        stub_jenkins(:get, "/api/json", 422, "base.json")
+
+        expect{ client.root }.to raise_error(Subordinate::UnprocessableEntity)
+      end
+    end
+
+    describe "500 Error" do
+      it "raises a Subordinate::InternalServerError error" do
+        stub_jenkins(:get, "/api/json", 500, "base.json")
+
+        expect{ client.root }.to raise_error(Subordinate::InternalServerError)
+      end
+    end
+  end
+end

data/subordinate.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency "rspec", "~> 2.14.0"
   gem.add_development_dependency "rake", "~> 10.1.0"
   gem.add_development_dependency "webmock", "~> 1.13.0"
+  gem.add_development_dependency "pry"
   gem.add_development_dependency "simplecov", "~> 0.7.0"
   gem.add_development_dependency "coveralls", "~> 0.7.0"
   gem.add_development_dependency "yard", "~> 0.8.0.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: subordinate
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - Jason Truluck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-23 00:00:00.000000000 Z
+date: 2013-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -108,6 +108,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.13.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -190,6 +204,7 @@ files:
 - lib/subordinate/client/view.rb
 - lib/subordinate/configuration.rb
 - lib/subordinate/connection.rb
+- lib/subordinate/error.rb
 - lib/subordinate/request.rb
 - lib/subordinate/version.rb
 - spec/spec_helper.rb
@@ -203,6 +218,7 @@ files:
 - spec/subordinate/client/view_spec.rb
 - spec/subordinate/client_spec.rb
 - spec/subordinate/configuration_spec.rb
+- spec/subordinate/error_spec.rb
 - spec/support/mocks/base.json
 - spec/support/mocks/build.json
 - spec/support/mocks/build_timestamp.txt
@@ -229,17 +245,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: Jenkins API wrapper
@@ -255,6 +271,7 @@ test_files:
 - spec/subordinate/client/view_spec.rb
 - spec/subordinate/client_spec.rb
 - spec/subordinate/configuration_spec.rb
+- spec/subordinate/error_spec.rb
 - spec/support/mocks/base.json
 - spec/support/mocks/build.json
 - spec/support/mocks/build_timestamp.txt