subdomainbox 0.5.0 → 0.5.1

data/README.md

@@ -54,24 +54,35 @@ There is no need to adjust your routes or your path / url helpers. Subdomainbox
 Installation
 ============
 
-Add subdomainbox to your gemfile and bundle install.
+1. Add subdomainbox to your gemfile and bundle install
+1. Run the generator (for generating the CSRF token secret):
 
-Run the generator (for generating the CSRF token secret):
+        $ rails generate subdomainbox
 
-    $ rails generate subdomainbox
+1. Make sure the root domain of your application has a wildcard SSL certificate
+1. Set the domain of your session cookie to the root domain
 
-Make sure your application has a wildcard SSL certificate.
+        if Rails.env.development?
+          cookie_domain = 'lvh.me'
+        elsif Rails.env.production?
+          cookie_domain = 'mydomain.com'
+        end
+        MyApp::Application.config.session_store :cookie_store, key: '_myapp_session', :domain => cookie_domain
 
+Development
+===========
+
+Use lvh.me:3000 instead of localhost:3000 since localhost doesn't support subdomains
 
 Testing
 =======
 
-In controller specs:
+In controller specs, we don't want to worry about subdomain-boxing, so stub it out:
 
     controller.stub(:subdomainbox)
 
 
-To make request/feature/integration specs work:
+Request/feature/integration specs are vital when using subdomain boxing. Non-javascript Capybara + Rack should work out of the box, but Capybara + Selenium/Webkit javascript driver requires modification of the test machine in order for it to work with subdomains:
 
     brew install dnsmasq
     mkdir -pv $(brew --prefix)/etc/

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/lib/subdomainbox/subdomainbox.rb

@@ -41,7 +41,8 @@ module ActionController
     private
 
     def subdomainbox_no_subdomain_match!(box_definitions)
-      if request.format == 'text/html' && request.get?
+      format = request.format
+      if (format == 'text/html' || format == '*/*') && request.get?
         flash[:alert] = flash.now[:alert]
         flash[:notice] = flash.now[:notice]
         flash[:info] = flash.now[:info]

data/spec/subdomainbox_spec.rb

@@ -58,6 +58,24 @@ describe ActionController::Base do
 
     end
 
+
+    context "when the accept header is */*" do
+      before(:each) do
+        request.stub(:format).and_return('*/*')
+
+        request.stub(:subdomain).and_return('www')
+        request.stub(:protocol).and_return('https://')
+        request.stub(:port_string).and_return(':8080')
+        request.stub(:fullpath).and_return('/pets')
+        request.stub(:get?).and_return(true)
+      end
+
+      it "should treat it the same as text/html" do
+        controller.should_receive(:redirect_to).with('https://pets.peanuts.com:8080/pets')
+        controller.subdomainbox('pets')
+      end
+    end
+
     context "when the requested format is html" do
       before(:each) do
         request.stub(:format).and_return('text/html')
@@ -193,6 +211,7 @@ describe ActionController::Base do
               controller.subdomainbox('pets')
             end
           end
+
         end
 
         context "when this is not a GET request" do

data/subdomainbox.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "subdomainbox"
-  s.version = "0.5.0"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Daniel Nelson"]
-  s.date = "2013-03-23"
+  s.date = "2013-03-25"
   s.description = "use subdomains to prevent XSS from accessing your entire application if it should happen to be injected into some page in your app"
   s.email = "dnelson@centresource.com"
   s.extra_rdoc_files = [

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: subdomainbox
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-23 00:00:00.000000000 Z
+date: 2013-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uuidtools
-  requirement: &2160194360 !ruby/object:Gem::Requirement
+  requirement: &2152059740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2160194360
+  version_requirements: *2152059740
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2160212440 !ruby/object:Gem::Requirement
+  requirement: &2152058780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -32,10 +32,10 @@ dependencies:
         version: 2.10.0
   type: :development
   prerelease: false
-  version_requirements: *2160212440
+  version_requirements: *2152058780
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2160210200 !ruby/object:Gem::Requirement
+  requirement: &2152112060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.8.4
   type: :development
   prerelease: false
-  version_requirements: *2160210200
+  version_requirements: *2152112060
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &2160208380 !ruby/object:Gem::Requirement
+  requirement: &2152110740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160208380
+  version_requirements: *2152110740
 - !ruby/object:Gem::Dependency
   name: pry-nav
-  requirement: &2160207140 !ruby/object:Gem::Requirement
+  requirement: &2152108660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160207140
+  version_requirements: *2152108660
 - !ruby/object:Gem::Dependency
   name: pry-stack_explorer
-  requirement: &2160221580 !ruby/object:Gem::Requirement
+  requirement: &2152107320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2160221580
+  version_requirements: *2152107320
 description: use subdomains to prevent XSS from accessing your entire application
   if it should happen to be injected into some page in your app
 email: dnelson@centresource.com
@@ -118,7 +118,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3040467631251113131
+      hash: -1018777487133078925
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: