stylr 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2b6c5c561144b3451f609f05fa568125170b5e10
-  data.tar.gz: f6ddc8e22a2febd98984ebefef01a730edbd1368
+  metadata.gz: b46b97f10222c83aae520b8c1d91ca2385770241
+  data.tar.gz: f27f477e52eea0efb2d9d8a4a8f8186c6cd9b388
 SHA512:
-  metadata.gz: e5ea60e64c2ee010d37e88af1e12243025e878f165826a810a208252412afcba9b9b57a771a50fee8a0c61b3742cf52db7575be242dd95e3f86d3a06751fae1d
-  data.tar.gz: 8a86db0eed7d016c89e7d846f9a582348b7fe408e82b5c2be08b9c3554b50bda8a365caa4ba18339cec243a722426cc5c63d5e3be874645df3e647933eb4d5fd
+  metadata.gz: aebf27289b35eb6841a27f1014ed901310adb1bbb7ef8cdd997b31f22883c911029c427a97cf6b1196af1c409f0176eb078923b502f862226e39a48afd467fdc
+  data.tar.gz: 0e8044fa0a5e26be038c74bac517faec4a4b873fb8ffe7a53c982e018e0425675672a23a1956469cb50fb2f819d0d4aaa15c002550d62bc28aba65fe406a875d

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    stylr (0.0.13)
+    stylr (0.0.14)
       main (~> 5.2, >= 5.2.0)
 
 GEM

data/README.md

@@ -30,6 +30,8 @@ Optionally checks for some metaprogramming, which you might not want in a large,
 * <code>module_eval</code>
 * <code>define_method</code>
 * <code>send</code>
+* <code>def method_missing</code>
+* <code>def respond_to_missing?</code>
 
 All of these things are configurable via yml.  See "stylr.yml" in the repo.  Whatever directory you run stylr from will look for stylr.yml.
 

data/lib/stylr/lint.rb

@@ -89,7 +89,9 @@ class Lint
       /===/                         => :triple_equals,
       /[^\s]\+/                     => :no_operator_spaces,
       /\+[^\s=]/                    => :no_operator_spaces,
-      /[^\s]-/                      => :no_operator_spaces
+      /[^\s]-/                      => :no_operator_spaces,
+      /![^\S\n]/                    => :space_after_bang,
+      /\s\?\s.*\s\?\s/              => :nested_ternary
     }.delete_if { |_, v| !@config[v.to_s] }
 
     @exception_violations = {
@@ -134,7 +136,9 @@ class Lint
       :comma_spacing                => "No space after a comma.",
       :no_soft_tabs                 => "Used tab characters; please use soft tabs.",
       :triple_equals                => "Use of triple-equals.",
-      :no_operator_spaces           => "Please use spaces around operators."
+      :no_operator_spaces           => "Please use spaces around operators.",
+      :space_after_bang             => "Space after !.",
+      :nested_ternary               => "Nested ternary expressions."
     }
   end
 

data/lib/stylr/version.rb

@@ -1,3 +1,3 @@
 module Stylr
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/spec/lint_spec.rb

@@ -101,6 +101,22 @@ module Stylr
         end
       end
 
+      context "no space after !" do
+        it "space after ! is bad" do
+          l.violation?("if ! condition").should be_true
+        end
+
+        it "line ending with ! is fine" do
+          l.violation?("shitty_rails_object.save!").should be_false
+        end
+      end
+
+      context "nested ternaries" do
+        it "do not nest ternaries for chrissake" do
+          l.violation?("x = y ? (x < 2 ? 5 : 2) : 55").should be_true
+        end
+      end
+
       context "soft tabs" do
         it "don't use actual tabs" do
           l.violation?("\t").should be_true

data/stylr.yml

@@ -22,3 +22,5 @@ used_method_missing: true
 used_respond_to_missing: true
 dynamic_invocation: true
 triple_equals: true
+space_after_bang: true
+nested_ternary: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stylr
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Mark Billie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: main