stylesheet 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d61c5fd85f824f45f5418d740d9bdb79f7025a18d6cf271fe85bda02598e1efa
-  data.tar.gz: 1743549221b9794d3abfd0cc34c3247136ada918797a9c06567d06e3ca2171b0
+  metadata.gz: d8731f136d13c2aafa5686bc348ed721890e8d8186ccf7b3d07b04b5e4b1d286
+  data.tar.gz: 5e1a9e9c982d43c12c2e7bed8c43703b7fae491282d1c17e24f25567bbbec08a
 SHA512:
-  metadata.gz: e6e3aac46073dfe973a59da7480e80effb4e323f63d3e93ed5a0b3c0e53cf539f8660294a681f38df40935df963e6085993dd0fb2347bf9a9e5250b7c25ed36c
-  data.tar.gz: 379b785b6f417d1c8486cf28575703c525947897a9af735c9a134bda5fc41476d46554657851b37a4945c1a3aaf6bc6462b088cb9059343c5cedfb3b600c4191
+  metadata.gz: 73c42acfa16d26fe5c48dffaaf738cf21452dcdc8e1c2be9ae050663a70be53eaab99a87cb9cce8f7096b04bd52b828e0704f15b70ec74cb0edf93323bc4bc42
+  data.tar.gz: 696f793a09c89575152c2a31730909e76d0328bb095c540c7c405347b6bc53f3e414619e86e956bee3e51d3a10f7ce47c4bfbcc34be627f2d6f3fb8b8354e8f5

data/lib/stylesheet/css_style_sheet.rb

@@ -49,7 +49,7 @@ module Stylesheet
     end
 
     def content=(content)
-      @content = content if content != ""
+      @content = content if content
     end
 
     def content

data/lib/stylesheet/location.rb

@@ -47,7 +47,7 @@ module Stylesheet
     end
 
     def valid?
-       valid_protocol? && valid_host?
+      !!(valid_protocol? && valid_host?)
     end
     
     def expand_paths_from_parent
@@ -74,19 +74,19 @@ module Stylesheet
     def valid_protocol?
       protocol && protocol != ":"
     end
-    
+
     def valid_host?
       host && host != ""
     end
-    
+
     def valid_port?
       port && port != ""
     end
-    
+
     def standard_port?
       port_80? || port_443?
     end
-    
+
     def port_80?
       uri && uri.port == 80 && uri.scheme == "http"
     end
@@ -100,14 +100,13 @@ module Stylesheet
         URI.parse(url.strip)
       rescue URI::InvalidURIError
         URI.parse(URI.escape(url.strip))
-      end      
+      end
 
     # re-raise external library errors in our namespace
     rescue URI::InvalidURIError => error
       raise Stylesheet::InvalidLocationError.new(
         "#{error.class}: #{error.message}")
     end
-    
+
   end
 end
-

data/lib/stylesheet/version.rb

@@ -1,3 +1,3 @@
 module Stylesheet
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/css_charset_rule_spec.rb

@@ -23,17 +23,17 @@ describe CssCharsetRule do
   describe ".matches_rule?" do 
     it "should match text starting with @charset" do 
       matches = CssCharsetRule.matches_rule?(css_text)
-      expect(matches).to be_true
+      expect(matches).to eq true
     end
     
     it "should not match text without at-rule" do 
       matches = CssCharsetRule.matches_rule?("a:link { color: #357ad1; }")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
 
     it "should not match text without charset" do 
       matches = CssCharsetRule.matches_rule?("@import url(\"import1.css\");")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end    
   end
-end
+end

data/spec/css_font_face_rule_spec.rb

@@ -31,17 +31,17 @@ describe CssFontFaceRule do
   describe ".matches_rule?" do 
     it "should match text starting with @font-face" do 
       matches = CssFontFaceRule.matches_rule?(css_text)
-      expect(matches).to be_true
+      expect(matches).to eq true
     end
     
     it "should not match text without at-rule" do 
       matches = CssFontFaceRule.matches_rule?("a:link { color: #357ad1; }")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
 
     it "should not match text without font-face" do 
       matches = CssFontFaceRule.matches_rule?("@import url(\"import1.css\");")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
   end
-end
+end

data/spec/css_import_rule_spec.rb

@@ -162,17 +162,17 @@ describe CssImportRule do
   describe ".matches_rule?" do 
     it "should match text starting with @import" do 
       matches = CssImportRule.matches_rule?(css_text)
-      expect(matches).to be_true
+      expect(matches).to eq true
     end
     
     it "should not match text without at-rule" do 
       matches = CssImportRule.matches_rule?("a:link { color: #357ad1; }")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
 
     it "should not match text without import" do 
       matches = CssImportRule.matches_rule?("@charset \"UTF-8\";")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
   end
-end
+end

data/spec/css_media_rule_spec.rb

@@ -41,17 +41,17 @@ describe CssMediaRule do
   describe ".matches_rule?" do 
     it "should match text starting with @media" do 
       matches = CssMediaRule.matches_rule?(css_text)
-      expect(matches).to be_true
+      expect(matches).to eq true
     end
 
     it "should not match text without at-rule" do 
       matches = CssMediaRule.matches_rule?("a:link { color: #357ad1; }")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
 
     it "should not match text without media" do 
       matches = CssMediaRule.matches_rule?("@charset \"UTF-8\";")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
   end
-end
+end

data/spec/css_style_rule_spec.rb

@@ -42,12 +42,12 @@ describe CssStyleRule do
   describe ".matches_rule?" do 
     it "should match text that doesn't begin with an at-rule" do 
       matches = CssStyleRule.matches_rule?(css_text)
-      expect(matches).to be_true
+      expect(matches).to eq true
     end
     
     it "should not match rules starting with at-rule" do 
       matches = CssStyleRule.matches_rule?("@import url(\"import1.css\");")
-      expect(matches).to be_false
+      expect(matches).to eq false
     end
   end
-end
+end

data/spec/css_style_sheet_spec.rb

@@ -8,10 +8,10 @@ describe CssStyleSheet do
   describe "#disabled" do 
     it "shows if style sheet is disabled" do 
       sheet = CssStyleSheet.new("http://example.com/css/stylesheets/screen.css")
-      expect(sheet.disabled?).to be_false
+      expect(sheet.disabled?).to eq false
 
       sheet.disabled = true
-      expect(sheet.disabled?).to be_true
+      expect(sheet.disabled?).to eq true
     end
   end
 
@@ -127,7 +127,18 @@ describe CssStyleSheet do
       expect(sheet.type).to eq "text/css"
     end
   end
-  
+
+  describe "#content" do
+    it "doesn't fetch for empty inline styles" do
+      sheet = CssStyleSheet.new(content: "")
+
+      expect {
+        sheet.css_rules.map {|r| r.content }
+      }.not_to raise_error
+    end
+
+  end
+
   describe "#css_rules" do 
     it "returns a list of css rules found in the style sheet" do 
       sheet = CssStyleSheet.new("http://example.com/css/stylesheets/screen.css")
@@ -207,4 +218,4 @@ describe CssStyleSheet do
       
     end
   end
-end
+end

data/spec/location_spec.rb

@@ -8,18 +8,14 @@ describe Location do
       location = Location.new(url)
       expect(location.host).to eq "initvisual.com"
     end
-    
+
     it "should accept relative urls" do 
       location = Location.new("/some/path.html")
       expect(location.to_s).to eq "/some/path.html"
     end
-    
-    it "should throw error for invalid host" do 
-      expect { Location.new("http://") }.to raise_error(InvalidLocationError)
-    end
   end
-  
-  
+
+
   describe "#new with parent" do 
     it "should not expand a full url" do 
       parent   = Location.new("http://example.com/css/url.html")
@@ -31,7 +27,7 @@ describe Location do
     it "should expand a relative path into a full path given the parent" do 
       parent   = Location.new("http://example.com/css/relative.html")
       location = Location.new("stylesheets/screen.css", parent)
-      
+
       expect(location.to_s).to eq "http://example.com/css/stylesheets/screen.css"
     end
 
@@ -40,9 +36,9 @@ describe Location do
       location = Location.new("/css/stylesheets/screen.css", parent)
 
       expect(location.to_s).to eq "http://example.com/css/stylesheets/screen.css"
-    end    
+    end
   end
-  
+
 
   describe "#host" do 
     it "should parse out the url host" do 
@@ -50,27 +46,27 @@ describe Location do
       expect(location.host).to eq "initvisual.com"
     end
   end
-  
-  describe "#host=" do 
-    it "should assign host to url" do 
+
+  describe "#host=" do
+    it "should assign host to url" do
       location = Location.new(url)
-      
+
       location.host = "derekdevries.com"
       expect(location.host).to eq "derekdevries.com"
     end
   end
-  
+
   describe "#hostname" do 
     it "should parse out the url hostname" do 
       location = Location.new(url)
       expect(location.hostname).to eq "initvisual.com"
     end
   end
-  
+
   describe "#hostname=" do 
     it "should assign hostname to url" do 
       location = Location.new(url)
-      
+
       location.hostname = "derekdevries.com"
       expect(location.hostname).to eq "derekdevries.com"
     end
@@ -86,14 +82,14 @@ describe Location do
   describe "#pathname=" do 
     it "should assign path to url" do 
       location = Location.new(url)
-      
+
       location.pathname = "/work"
       expect(location.pathname).to eq "/work"
     end
 
     it "add initial forward-slash if not given" do 
       location = Location.new(url)
-      
+
       location.pathname = "work"
       expect(location.pathname).to eq "/work"
     end
@@ -243,18 +239,23 @@ describe Location do
   describe "#valid?" do 
     it "should be true with a valid host and protocol" do 
       location = Location.new("http://initvisual.com")
-      expect(location.valid?).to be_true
+      expect(location.valid?).to eq true 
     end
 
-    it "should be false for an invalid host" do 
+    it "should be false for an invalid host" do
       location = Location.new("/asdf")
-      expect(location.valid?).to be_false      
+      expect(location.valid?).to eq false
+    end
+
+    it "should be false for a missing host" do
+      location = Location.new("http://")
+      expect(location.valid?).to eq false
     end
 
-    it "should be false for an invalid protocol" do 
+    it "should be false for an invalid protocol" do
       location = Location.new("foo.com/asdf")
-      expect(location.valid?).to be_false
+      expect(location.valid?).to eq false
     end
   end
   
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stylesheet
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Derek DeVries
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-23 00:00:00.000000000 Z
+date: 2020-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb