studio-engine 0.74.8 → 0.74.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8073dcfcec3579f3a3fa810e5b851ac3eb38a99e38bb184183b4d6a13d8da6e
-  data.tar.gz: 3f7bc2747c4101c7785b3f3c22b673f80467e600b88af943900d1c3a4c79fdbd
+  metadata.gz: 54ff8e7d4414fba9258118e2e467a259121eaab850d8ec8cfb574b95acdf8b22
+  data.tar.gz: fdac442335eaa412bc6084ca82b9bc3b9bd7a89eb110a3857d528f89109835dd
 SHA512:
-  metadata.gz: d57ba1e14f875f76dd2cc2e5d75c5db00decb0f5235222dfabec4501c9ae3f6b821720188f6c84aca67b68d3b2abb99d0a9022eaa8da205955820029d2e9a19b
-  data.tar.gz: 1165eedf5e6bce8f56d60c83f0cdf96cd87bdd0c297c48906c88f782d20bbb8af102913272cf3663b73972cfd6d76474452e6900489ab2035dfee98d777673ca
+  metadata.gz: 5c1619cd191b89affc30ca2182e1cd2f09963afd2c822a9ef335fe67baa8064c21420451dcd046f5fb26258cc14caca45d5cab9e4800e2e64ba74682e8afc311
+  data.tar.gz: 24a428027cc14be60d49771a2721bc31b974ab456fd6c553d97c78463d23de1effa6aa2f56eb4231b4df0b6cff73ca0bc2c171d21f702f42e29de1e9375413a3

data/CHANGELOG.md

@@ -1,9 +1,23 @@
 # Changelog
 
-The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html) — `MAJOR.MINOR.PATCH`. Consumer Rails apps install the released RubyGems package and pin the floor each one needs — the pins differ on purpose, and every consumer records why beside its own. Bumping the gem version and updating consumer lockfiles is a release; `bin/release prepare` allocates the version and does both (see [`docs/RELEASE.md`](./docs/RELEASE.md)). `prepare` does NOT roll this file: renaming `## Unreleased` to the allocated version and opening a fresh empty one is a manual conductor step (see [`docs/RELEASE.md`](./docs/RELEASE.md), *Rolling `Unreleased` into a version*), guarded by `test/docs/changelog_structure_test.rb`.
+The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html) — `MAJOR.MINOR.PATCH`. Consumer Rails apps install the released RubyGems package and pin the floor each one needs — the pins differ on purpose, and every consumer records why beside its own. Bumping the gem version and updating consumer lockfiles is a release; `bin/release prepare` allocates the version and does both (see [`docs/RELEASE.md`](./docs/RELEASE.md)). Write entries under `## Unreleased` and never write a version heading: when `prepare` allocates a version it rolls this file in the same commit, moving everything under `## Unreleased` beneath a new `## <version> — <date>` heading (written even when the bucket is empty) and leaving `## Unreleased` first and empty. It refuses the sweep, with nothing published, when the roll would lie or it cannot read this file; when it skips allocation, nothing rolls. [`docs/RELEASE.md`](./docs/RELEASE.md), *Rolling `Unreleased` into a version*, says when each happens and what to do by hand. `test/docs/changelog_structure_test.rb` guards the shape.
 
 ## Unreleased
 
+### Fixed
+
+- **The auth resend footer's error line failed WCAG AA in both themes; it now
+  uses the danger ink.** `studio/modals/auth/_resend_footer` painted its
+  `role="alert"` paragraph with the static `text-red-400`, which Tailwind v4
+  compiles to about `#FF6467`: 3.86:1 on the dark modal card and 2.89:1 on the
+  light one, both under the 4.5:1 that 12px text needs. It is now
+  `text-danger-ink`, the red `Studio::ThemeResolver` derives per theme to clear
+  4.5:1 on every surface: 4.50:1 dark and 5.76:1 light on the default modal
+  card. The resend spinner stays the engine's `.spinner`, tuned to
+  turf-monster's currentColor ring (`--spinner-track: currentColor;
+  --spinner-color: transparent`), so a host that drops its fork sees no change.
+  Guarded by `test/views/resend_footer_error_contrast_test.rb`.
+
 ### Docs
 
 - **Thirty-five minor versions of shipped entries left `## Unreleased` and moved
@@ -32,8 +46,29 @@ The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This pro
   fails loudly rather than passing vacuously, and — the one that would have caught
   this in week one — `Studio::VERSION` no more than two minor versions ahead of the
   newest heading. Against the pre-change file it reports "35 minor versions of
-  entries are still filed under `## Unreleased`". Automating the roll inside
-  `bin/release prepare` (mcritchie-studio) is the real fix and is not done.
+  entries are still filed under `## Unreleased`". ~~Automating the roll inside
+  `bin/release prepare` (mcritchie-studio) is the real fix and is not done.~~ —
+  **superseded after 0.74.8:** mcritchie-studio#1344 made `prepare` roll this
+  file whenever it allocates a version, so "it never touches this file" above
+  describes the tooling as of 0.74.8. See the entry on the automatic roll below.
+
+- **The docs called the `## Unreleased` roll a manual conductor step; `bin/release
+  prepare` does it now, and the docs say exactly when it does not.**
+  mcritchie-studio#1344 made prepare roll this file into the allocated version in
+  the commit that sets `lib/studio/version.rb` and `Gemfile.lock`, and REFUSE the
+  sweep, with nothing published, when the roll would lie. `docs/RELEASE.md`
+  (*Rolling `Unreleased` into a version*), this file's preamble and the README's
+  release paragraph still said the roll was yours, by hand. They now name the
+  three outcomes (ALLOCATE rolls, SKIP rolls nothing, REFUSE aborts), each
+  refusal and its fix, and the reach limit: a SKIP (a version set by hand, or a
+  re-run after an abort before the tag) rolls nothing. They also settle three
+  conventions. An entry-less release still gets its heading; a heading never
+  lands before its version does, because `accepted` lags `release`; and a merge
+  that crosses a roll gets checked, because git can merge a new bullet CLEAN
+  under a version that shipped without it. The manual procedure stays, as the
+  remedy for those cases. No runtime code changed;
+  `test/docs/changelog_structure_test.rb` changed only its comments and its
+  failure message.
 
 ## 0.74.3 — 2026-09-08
 

data/README.md

@@ -240,35 +240,78 @@ the block:
 
 #### Writing a modal's content partial — two rules the host imposes
 
-Both of these fail SILENTLY. Nothing raises, nothing logs, and the card renders;
-it just does less than it looks like it does.
-
-**1. SINGLE ROOT.** A content partial's outer `<div>` is the host's required
-root. Alpine's `<template x-if>` clones only the FIRST root element of its
-content, so a second top-level sibling — a stray `<span>`, a trailing `<style>`
-block, a comment-turned-node — is dropped on the floor. Bake anything extra
-inside the wrapping `<div>`.
-
-**2. NO DOUBLE QUOTE INSIDE `x-data`.** The attribute is double-quoted, so an
-inner double quote CLOSES it. Alpine then mounts a component whose expression is
-truncated mid-statement: every element still renders and every handler does
-nothing. Single-quote everything inside `x-data`.
+Both rules let the card render and then do less than it looks like it does.
+They differ in whether anything reaches the CONSOLE, which is the first thing
+to check when a registered partial misbehaves.
+
+**1. SINGLE ROOT — fails in total silence.** A content partial's outer `<div>`
+is the host's required root. Alpine's `<template x-if>` clones only the FIRST
+root element of its content, so a second top-level sibling — a stray `<span>`,
+a trailing `<style>` block, a comment-turned-node — is dropped on the floor.
+Nothing raises and nothing logs: `x-if` takes `.firstElementChild` and asks no
+questions. (Alpine DOES warn on a multi-root `x-for` template — *"x-for
+templates require a single root element, additional elements will be ignored"*
+— which is exactly why this one catches people out. The modal host is `x-if`,
+and `x-if` ships no such check.) Bake anything extra inside the wrapping
+`<div>`.
+
+**2. NO DOUBLE QUOTE INSIDE `x-data` — this one LOGS.** The attribute is
+double-quoted, so an inner double quote CLOSES it. Alpine then mounts a
+component whose expression is truncated mid-statement: every element still
+renders and every handler does nothing. It is NOT silent. The truncation
+leaves a JavaScript syntax error, Alpine's evaluator catches it, and the
+default handler prints `Alpine Expression Error: …` together with the
+offending expression — a `console.warn`, followed by an async rethrow. That
+warning is the best clue this rule was broken, so send a debugging engineer to
+the console rather than to the markup. Single-quote everything inside
+`x-data`.
+
+Interpolated values are the same rule arriving from the server, and Rails
+already guards the ordinary case: `<%= value %>` inside `x-data` renders a
+double quote as `&quot;`, and the HTML tokenizer never reads a character
+reference as the closing quote — it decodes it straight into the value — so
+the attribute survives. The vector is a value that SKIPS that escaping —
+`raw`, `.html_safe`, or a helper returning a SafeBuffer — which puts a bare
+`"` into the attribute and closes it exactly as a typed one would.
+`escape_javascript` (`j`) is NOT the guard here: it escapes for a JavaScript
+string literal (`\"`) and PRESERVES the html_safe flag, so the raw quote still
+reaches the attribute. Let Rails escape it.
+
+That settles the ATTRIBUTE, not the JavaScript inside it. A value spliced into
+a single-quoted JS string — the shape rule 2 steers you to — has a second way
+out: a `'`. ERB escapes it to `&#39;`, the parser decodes that straight back
+into the value, and the bare `'` ends the string: the same
+`Alpine Expression Error`. Route such a value through
+`Studio::JsLiteral.in_attribute(value)`, which runs both escapers in the order
+that works; `lib/studio/js_literal.rb` carries the full contract, identifier
+position (`Studio::JsIdentifier`) included.
 
 These are properties of the HOST, not of any one card, and they apply to every
-consumer partial an app registers — not only to the specimens in this gem. They
-are recorded here because they used to be recorded only in the style guide's
-specimen headers, which made them deletable by a change that removed a specimen:
-retiring the `style/modals/_network_guard` and `_wallet_deposit` mirrors on
-2026-09-09 would otherwise have taken the single-root rule out of both this repo
-and the app that inherited those cards.
-
-**Wallet modals moved to `solana-studio`.** The Connect Wallet picker, the Web3
-step-up card and the Phantom deep link used to ship here as
-`studio/modals/wallet_connect`, `studio/modals/web3_step_up` and
-`studio/solana/phantom_deeplink`. They now live in the **solana-studio** gem as
-`solana_studio/modals/wallet_connect`, `solana_studio/modals/web3_step_up` and
-`solana_studio/phantom_deeplink`; render them from those paths and read that
-gem's README for their locals and hooks.
+consumer partial an app registers — not only to the specimens in this gem.
+
+They are recorded HERE because this is the host's CONTRACT, and nothing else
+in the repo is. Plenty of files state one or both rules, but each of them is
+describing ITSELF — a specimen header explaining its own markup, an asset
+partial explaining its own root. Someone writing a NEW partial has no specimen
+to read; they read the host's documentation, so that is where the rules have
+to live.
+
+And a specimen could not carry rule 1 even in principle, which is what settles
+it: the style guide wraps EVERY registration's partial in a `<div>` of its own
+— `<template x-if="…"><div><%= render … %></div></template>` — and that
+wrapper supplies the single root the rule is about. A specimen that broke the
+rule would still render correctly in the guide, so the specimens cannot
+demonstrate the failure they would be documenting. Pinned by
+`test/docs/modal_host_contract_docs_test.rb`.
+
+#### Wallet modals moved to `solana-studio`
+
+The Connect Wallet picker, the Web3 step-up card and the Phantom deep link used
+to ship here as `studio/modals/wallet_connect`, `studio/modals/web3_step_up`
+and `studio/solana/phantom_deeplink`. They now live in the **solana-studio**
+gem as `solana_studio/modals/wallet_connect`, `solana_studio/modals/web3_step_up`
+and `solana_studio/phantom_deeplink`; render them from those paths and read
+that gem's README for their locals and hooks.
 
 This is the two-template split: **BASE** is studio-engine + mcritchie-studio,
 **WEB3 ADD** is solana-studio + turf-monster. The engine has no business
@@ -815,11 +858,14 @@ let it allocate the version — it derives the bump, commits `lib/studio/version
 with its `Gemfile.lock` onto **`origin/release`**, then publishes, tags, and bumps
 each consumer's lock. **Do not set the version by hand.** A hand-set number makes
 the allocation read the current version as already past the last tag and skip, so
-the hand number silently wins over the derived one. **`prepare` does not touch
-[`CHANGELOG.md`](./CHANGELOG.md)** — renaming `## Unreleased` to the allocated
-version and opening a fresh empty one is a manual last step, and skipping it is
-how thirty-five minor versions of entries ended up filed as pending. Details and the
-exact commands are in [`docs/RELEASE.md`](./docs/RELEASE.md).
+the hand number silently wins over the derived one, and the skip rolls no
+changelog. **When it allocates, `prepare` also rolls
+[`CHANGELOG.md`](./CHANGELOG.md)** in the same commit: everything under
+`## Unreleased` moves beneath the new version's heading, written even when the
+bucket is empty, and `## Unreleased` stays first and empty. It refuses the sweep,
+with nothing published, when the roll would lie or it cannot read the file.
+[`docs/RELEASE.md`](./docs/RELEASE.md), *Rolling `Unreleased` into a version*,
+says exactly when it rolls, refuses or skips, and what to do by hand.
 
 **Semver guide** — the release *derives* the bump from its members (a `breaking`
 risk tag → major, a `feature` → minor, otherwise patch), so this is what those

data/app/assets/tailwind/studio_engine/engine-motion.css

@@ -191,6 +191,13 @@
    Usage:  <span class="spinner"></span>
            <span class="spinner" style="--spinner-size: 2rem"></span>
            on a colored button:  <span class="spinner" style="--spinner-color: currentColor"></span>
+           the currentColor RING the engine's own CTA blocks use, matching the
+           ring turf-monster's host-only .cta-spinner draws:
+             <span class="spinner" style="--spinner-track: currentColor; --spinner-color: transparent; opacity: 0.85"></span>
+           Mind the mapping, it reads backwards: --spinner-track paints the
+           WHOLE ring and --spinner-color only the leading segment. Untuned on a
+           .btn-primary, the head is --color-cta, the button's own fill, so the
+           spinner shows nothing but its faint track.
    Tune:   --spinner-size / --spinner-thickness / --spinner-track /
            --spinner-color / --spinner-speed
    ========================================================================== */

data/app/views/studio/modals/_host.html.erb

@@ -32,7 +32,11 @@
   IMPOSES on the content partials registered in its block: a SINGLE ROOT
   element (a template x-if clones only the first one; later siblings are
   dropped) and NO double quote inside x-data (it closes the attribute and
-  Alpine mounts a silent no-op). Both fail without raising.
+  Alpine mounts a no-op). NEITHER STOPS THE RENDER, BUT ONLY ONE IS SILENT:
+  the single-root miss logs nothing at all, while the truncated x-data prints
+  "Alpine Expression Error" to the console (and rethrows it async). That
+  warning is the clue rule one never gives you, so check the console before
+  you re-read the markup.
 %>
 <style>
   /* Scroll lock applied by $store.modals._sync() when the stack is non-empty.

data/app/views/studio/modals/_scoped_host.html.erb

@@ -41,11 +41,12 @@
   chaining (`current()?.id`): the outer template unmounts one tick AFTER the
   stack empties, so a bare `.id` throws on every close.
 
-  THE CONTENT PARTIALS OBEY THE SAME TWO RULES AS THE SHARED HOST'S, and both
-  fail silently: a SINGLE ROOT element (a template x-if clones only the first
-  one) and NO double quote inside x-data (it closes the attribute and Alpine
-  mounts a component that renders everything and does nothing). Stated in full
-  in the gem README's "Modal host" section.
+  THE CONTENT PARTIALS OBEY THE SAME TWO RULES AS THE SHARED HOST'S, and they
+  fail DIFFERENTLY: a SINGLE ROOT element (a template x-if clones only the
+  first one, logging nothing) and NO double quote inside x-data (it closes the
+  attribute and Alpine mounts a component that renders everything and does
+  nothing -- but LOGS "Alpine Expression Error" on the way). Stated in full in
+  the gem README's "Modal host" section.
 
   AND EVERY ID REGISTERED HERE MUST BE REACHABLE, both ways round. A card that
   opens an id no template registers shows an EMPTY panel; a template no card

data/app/views/studio/modals/auth/_resend_footer.html.erb

@@ -10,6 +10,29 @@
 
   Locals:
     modal_store — Alpine store name backing close(). Default "modals".
+
+  ERROR INK, not a static red. The error paragraph is text-danger-ink, the
+  per-theme red Studio::ThemeResolver derives to a 4.5:1 target. It replaced
+  text-red-400. Measured through the resolver on turf-monster's real palette
+  (primary 4BAF50), on the modal card, which is bg-surface: danger-ink is 4.50
+  on the dark card 3C3853 and 5.76 on the light card ffffff, clearing AA on
+  both; text-red-400 was 3.86 and 2.89, failing both. Those are Tailwind v4's
+  red-400, about FF6467, which is what these apps compile; the v3 hex F87171
+  gives 4.03 and 2.77 and fails the same way. No STATIC red clears AA
+  on BOTH themes — theme_resolver.rb carries the measured table and derives
+  --color-danger-ink precisely to be the text red. --color-danger is the brand
+  FILL and is free to be vivid; it is not this. Guarded, executably, by
+  test/views/resend_footer_error_contrast_test.rb.
+
+  SPINNER, tuned rather than re-named. This is the engine's canonical .spinner
+  primitive (engine-motion.css), tuned through its OWN documented custom
+  properties to the currentColor ring turf-monster paints with its host-only
+  .cta-spinner — so the block looks unchanged once turf renders it, and the
+  engine names no class it cannot define. Read the mapping carefully, because
+  it looks backwards: --spinner-track colours the WHOLE ring and
+  --spinner-color colours only the leading segment. A currentColor ring with a
+  transparent gap is therefore track currentColor plus color transparent, NOT
+  the reverse, which would draw a lone quarter-arc instead.
 %>
 <%
   # IDENTIFIER position ($store.<name>) — VALIDATED, never escaped: Studio::JsIdentifier.
@@ -19,9 +42,10 @@
 <button @click="resendMagicLink()" :disabled="props.submitting === 'magic-link' || (props.resendCooldown || 0) > 0"
         class="block mx-auto text-sm text-primary hover:text-primary-300 underline underline-offset-2 disabled:opacity-50 disabled:no-underline">
   <span class="inline-flex items-center justify-center gap-1.5">
-    <span x-show="props.submitting === 'magic-link'" class="spinner" aria-hidden="true"></span>
+    <span x-show="props.submitting === 'magic-link'" class="spinner" aria-hidden="true"
+          style="--spinner-track: currentColor; --spinner-color: transparent; opacity: 0.85"></span>
     <span x-text="props.submitting === 'magic-link' ? 'Resending…' : ((props.resendCooldown || 0) > 0 ? ('Resend available in ' + props.resendCooldown + 's') : 'Resend link')"></span>
   </span>
 </button>
-<p role="alert" x-show="props.resendError" x-cloak class="text-xs text-red-400 mt-3 text-center" x-text="props.resendError"></p>
+<p role="alert" x-show="props.resendError" x-cloak class="text-xs text-danger-ink mt-3 text-center" x-text="props.resendError"></p>
 <button @click="$store.<%= modal_store %>.close()" class="block mx-auto mt-3 text-sm text-secondary hover:text-heading transition">Close</button>

data/app/views/studio/modals/blocks/_birthday.html.erb

@@ -131,7 +131,7 @@
             :disabled="!complete || submitting">
       <span x-show="!submitting">Confirm &amp; Continue</span>
       <span x-show="submitting" class="inline-flex items-center justify-center gap-2" style="display: none;">
-        <span class="cta-spinner" aria-hidden="true"></span>
+        <span class="spinner" aria-hidden="true" style="--spinner-track: currentColor; --spinner-color: transparent; opacity: 0.85"></span>
         Verifying…
       </span>
     </button>

data/app/views/studio/modals/blocks/_leveling_activity.html.erb

@@ -168,7 +168,7 @@
           <button type="submit" class="btn btn-primary btn-lg w-full" :disabled="saving || !changed">
             <span x-show="!saving" x-text="changed ? '<%= j cta_label %>' : '<%= j saved_label %>'"><%= cta_label %></span>
             <span x-show="saving" class="inline-flex items-center justify-center gap-2" style="display: none;">
-              <span class="cta-spinner" aria-hidden="true"></span>
+              <span class="spinner" aria-hidden="true" style="--spinner-track: currentColor; --spinner-color: transparent; opacity: 0.85"></span>
               <span x-text="progressLabel || '<%= j saving_label %>'"><%= saving_label %></span>
             </span>
           </button>

data/app/views/studio/modals/onboarding/_first_name.html.erb

@@ -377,7 +377,7 @@
     </template>
     <button type="submit" :disabled="submitting"
             class="btn btn-primary btn-lg w-full gap-2 disabled:cursor-wait">
-      <span x-show="submitting" class="cta-spinner" aria-hidden="true"></span>
+      <span x-show="submitting" class="spinner" aria-hidden="true" style="--spinner-track: currentColor; --spinner-color: transparent; opacity: 0.85"></span>
       <span x-text="submitting ? 'Saving…' : 'Save and continue'"></span>
     </button>
   </form>

data/lib/studio/version.rb

@@ -1,3 +1,3 @@
 module Studio
-  VERSION = "0.74.8"
+  VERSION = "0.74.9"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: studio-engine
 version: !ruby/object:Gem::Version
-  version: 0.74.8
+  version: 0.74.9
 platform: ruby
 authors:
 - Alex McRitchie