studio-engine 0.47.0 → 0.47.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1da7736255e9cf6690f07488e8758227bd6231e08502d123dcbefbdd6f6c685
-  data.tar.gz: a8e2e861599996fdb22203bb9ed42feae6f5343232a1c0578c73fd95f28b8b81
+  metadata.gz: 90659c9a1e1cd62a432e47529501574cca5f7a217f48b6f0eaf0990198150636
+  data.tar.gz: 23435ace6999ecb78b5ad57c2a7c90cf8da64cee0415feb1d5a2fd82f65d4470
 SHA512:
-  metadata.gz: 6f1effe6341c220633e267f9382cf5dc2ca68565565489b95feceb744003aceaca151663a0cdba25c7c11753f99ac78369c4c4327232436628f55b30c40afcf1
-  data.tar.gz: 33526cb24c80fc6e26ada46d15fbbd5701f5681af7cd4a9feaab2bfcea6c92e8283b7d50d1408cc8f160c2624ed5038968509fbb37ae3783ae003f0381ef1500
+  metadata.gz: 5c964c5081845ae99315fe62fe98fde0969255d779537524aeb0abbde5b8ceb5fab3ee98c5771471c992b3628021e35e6b42a5f91dc5909bbb3601fd9dabbe1d
+  data.tar.gz: 8c1e90e63006085ef8745ba6a5d1e06b004e09e4c74c523780be2ae9f7e024b3b426aa228dc22eeea683459820a3a9a079720d27e8c8905e90c4796999595d2d

data/db/migrate/20260813220000_add_standard_user_profile_columns.rb

@@ -34,8 +34,37 @@
 # belong to Studio::IpLocations — the column is just where it lands. It holds
 # IP-derived location data, which is personal data in most jurisdictions; the
 # 50-entry cap there bounds it, and no app writes to it until it opts in.
+# ON THE DOWN: this migration REFUSES to reverse, deliberately.
+#
+# `up` is idempotent by design — every add is `if_not_exists`, precisely so it can
+# run against apps that already disagree. That guard is what makes it safe going
+# in, and it is exactly what makes an honest `down` impossible: the migration
+# records NOTHING about which columns it actually created on this host.
+#
+# So a `down` cannot tell "I added this" from "the host has had it since 2024":
+#
+#   - mcritchie-studio owned `users.first_name` BEFORE this ran.
+#   - turf-monster owned `users.first_name` AND `users.birth_year`.
+#   - mcritchie-industries owned none of the five.
+#
+# The two apps the `up` was careful not to touch are the two a `DROP COLUMN`
+# would rob. Rails' auto-inverse does precisely that: `INVERT_METHODS` maps
+# `add_column` to `remove_column` and passes the same options through, and
+# `remove_column` honours only `if_exists`. A stray `if_not_exists:` there is
+# silently DISCARDED rather than raising.
+#
+# `if_exists` is NOT the fix, and it is worth saying why since it is the reflex:
+# it asks "does this column exist?" — and on those two apps it does. That is the
+# whole hazard. `if_exists` only protects a SECOND rollback, after the data is
+# already gone.
+#
+# Refusing turns silent data loss into a loud, actionable error. An operator who
+# genuinely wants these columns gone can drop the ones they know they own, by
+# hand, with the schema in front of them.
 class AddStandardUserProfileColumns < ActiveRecord::Migration[7.2]
-  def change
+  COLUMNS = %i[first_name birth_day birth_month birth_year ip_locations].freeze
+
+  def up
     # An app that has no users table (the engine's dummy, and any future
     # consumer that names its accounts something else) is simply skipped.
     return unless table_exists?(:users)
@@ -48,4 +77,22 @@ class AddStandardUserProfileColumns < ActiveRecord::Migration[7.2]
 
     add_column :users, :ip_locations, :jsonb, default: [], null: false, if_not_exists: true
   end
+
+  def down
+    # Nothing was added, so nothing is owed — an app without `users` never ran
+    # the `up` body either, and reversing that is genuinely a no-op.
+    return unless table_exists?(:users)
+
+    raise ActiveRecord::IrreversibleMigration, <<~MSG
+      AddStandardUserProfileColumns cannot be reversed safely.
+
+      Its `up` adds #{COLUMNS.join(", ")} with `if_not_exists`, so it does not
+      know which of them it created on this host and which the host already
+      owned. Dropping them all would destroy host-owned data (mcritchie-studio
+      owned first_name; turf-monster owned first_name and birth_year).
+
+      If you truly want a column gone, drop the ones you know this app did not
+      own before the migration, by hand, in their own migration.
+    MSG
+  end
 end

data/lib/studio/version.rb

@@ -1,3 +1,3 @@
 module Studio
-  VERSION = "0.47.0"
+  VERSION = "0.47.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: studio-engine
 version: !ruby/object:Gem::Version
-  version: 0.47.0
+  version: 0.47.1
 platform: ruby
 authors:
 - Alex McRitchie
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-13 00:00:00.000000000 Z
+date: 2026-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails