studio-engine 0.141.1 → 0.141.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3ccc2c2e35d236c2709dc7a7918d2a1357d81e23e4a4ed31ae1e6a8a3fee555
-  data.tar.gz: 9af1f5d8ab55210882a7c1ad7e0ff8cc871e3938f853de749307c07ce8bfd9bd
+  metadata.gz: e37b982954e7699c21010d1269c9f8bb50e3f4b900b580216ab2a61907000cbb
+  data.tar.gz: 2288aaaee5f9f64ed85893a1ea3d5c6f2027316fc00e1da2ef1370e597037994
 SHA512:
-  metadata.gz: 1c7fc9c56b2bd6bc48d4e1f595a2aa4f884b7c18cd3f61a9170164d1d24f19873810026a91a4ab1b8d022ac1c0e1d4965a042b4fc5194782d70d011c5604215c
-  data.tar.gz: 8e2724c527406edbc340d96783a3f2194acc3a6008fd530f12f2f4c7c585eba56516fa76d105b1aee2cccf8c0a7c0c6477229691b09f7640052d8a6b35516ec9
+  metadata.gz: 9ba01f6b9d3ca61b788e4076c04e1e9699fa602214d026267cf82e0839ea4a2b89f93d66e2ec7b532475bbd32fb77481ae6d4680594ea075c6c0c189f19bcc20
+  data.tar.gz: f6f06cecfe7ef957aef4b61ecc586f972b264f9e13e2ca7502154b947fdcbc9a63a3d138b8c3903bace7f4200be6046ec4dcc41b89d863c70e8e438d30d80e38

data/CHANGELOG.md

@@ -4,6 +4,13 @@ The format is [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). This pro
 
 ## Unreleased
 
+## 0.141.2 — 2026-11-09
+
+### Fixed
+
+- **The link-preview card shows text typed before its controller loads.** The `link-preview-card` controller is registered lazily, so an operator could type in /admin/link_preview before it listened, and the card kept the saved title. `connect()` now paints the card from the fields as they stand (`paintAll` in `studio/link_preview_card`). No host change.
+- **An in-page jump ends at the browser's scrollend, not at a quiet spell.** `studio/in_page_links` ended a smooth jump after 150 ms with no scroll event, even in a browser that fires `scrollend`. On a slow main thread (a phone, or CI at 8x CPU) a smooth scroll's frames come further apart than that, so the jump ended at its first frame: the tab highlight followed the passing sections, and a target that moved on the way (a lazy feed above it) was not aimed at again. Now only `scrollend` ends a scroll that moved, where the browser has it; the quiet spell stays for a browser without it, and the 400 ms cap still ends a scroll that never starts. Nothing for a consumer to do.
+
 ## 0.141.1 — 2026-11-09
 
 ### Fixed

data/app/javascript/studio/controllers/link_preview_card_controller.js

@@ -7,8 +7,13 @@
 //
 // The repaint is studio/link_preview_card. One listener on the root takes the
 // `input` of every [data-link-preview-input] inside it.
+//
+// The controller is registered lazily, so its module arrives after the page has
+// loaded and an operator can type before connect() listens. That input event is
+// gone, so connect() also paints the card from the fields as they stand
+// (e2e/site_identity.spec.js holds the module back to prove it).
 import { Controller } from "@hotwired/stimulus"
-import { paintCard } from "studio/link_preview_card"
+import { paintCard, paintAll } from "studio/link_preview_card"
 
 export default class extends Controller {
   connect() {
@@ -17,6 +22,7 @@ export default class extends Controller {
       if (input && input.matches && input.matches("[data-link-preview-input]")) paintCard(this.element, input)
     }
     this.element.addEventListener("input", this.repaint)
+    paintAll(this.element)
   }
 
   disconnect() {

data/app/javascript/studio/in_page_links.js

@@ -36,7 +36,10 @@ export const SCROLL_END_EVENT = "studio:in-page-scroll-end"
 export const STATE_KEY = "studioInPage"
 // The mark on a target that took tabindex=-1 for focus here; engine.css draws no ring on it.
 export const FOCUS_MARK = "data-in-page-focus"
-// No scroll for this long ends the scroll, where the browser has no scrollend event.
+// No scroll for this long ends the scroll, where the browser has no scrollend event. Where it
+// has one, only scrollend ends a scroll that moved: on a slow main thread (a phone, or CI at
+// 8x CPU) a smooth scroll's frames come further apart than this, and a quiet spell ended the
+// jump at its first frame. Then the target moved and nothing aimed again.
 export const SETTLE_MS = 150
 // A scroll the reader never sees move still ends: the cap for a scroll that never starts.
 export const START_CAP_MS = 400
@@ -188,9 +191,11 @@ export function installInPageLinks(doc) {
   // target was at the start. Content that grows on the way (a lazy frame the scroll passes,
   // the navbar's collapse) moves the target, so the scroll aims again, up to MAX_AIMS times,
   // until the reader takes over (a wheel, a touch, a key, a press). The end is the browser's
-  // scrollend where it has one, a quiet spell where not; then the end event, once.
+  // scrollend where it has one, a quiet spell where not; then the end event, once. A scroll
+  // that never starts ends at the cap either way.
   const jump = (target, behavior) => {
     if (settling) settling()
+    const hasScrollend = "onscrollend" in win
     let quiet = null
     let cap = null
     let aims = 0
@@ -226,7 +231,9 @@ export function installInPageLinks(doc) {
     const onScroll = () => {
       win.clearTimeout(cap)
       reaim()
-      wait(SETTLE_MS)
+      // The scroll has started: with scrollend, it alone ends it (an aim's cap is spent too).
+      if (hasScrollend) win.clearTimeout(quiet)
+      else wait(SETTLE_MS)
     }
     const stop = () => {
       reader = true
@@ -234,7 +241,7 @@ export function installInPageLinks(doc) {
     }
     settling = stop
     win.addEventListener("scroll", onScroll, { passive: true })
-    if ("onscrollend" in win) win.addEventListener("scrollend", end)
+    if (hasScrollend) win.addEventListener("scrollend", end)
     for (const name of INPUTS) win.addEventListener(name, takeOver, { capture: true, passive: true })
     cap = win.setTimeout(end, START_CAP_MS)
     scrollTo(target, behavior)

data/app/javascript/studio/link_preview_card.js

@@ -32,3 +32,11 @@ export function paintCard(page, input) {
   target.textContent = text
   return text
 }
+
+// Repaints the card from every [data-link-preview-input] on the page, as each
+// field stands now. The controller calls it on connect: it is registered
+// lazily, so an operator can type before it listens, and that input event is
+// gone.
+export function paintAll(page) {
+  page.querySelectorAll("[data-link-preview-input]").forEach((input) => paintCard(page, input))
+}

data/lib/studio/version.rb

@@ -1,3 +1,3 @@
 module Studio
-  VERSION = "0.141.1"
+  VERSION = "0.141.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: studio-engine
 version: !ruby/object:Gem::Version
-  version: 0.141.1
+  version: 0.141.2
 platform: ruby
 authors:
 - Alex McRitchie