strum-esb 0.3.3 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5eed53438b480b0f9f2faae4b2662dfb7005441bd74f62b15986d4eefeefbe7e
-  data.tar.gz: c8f52bbfc3955ca0735d1536e99fc07238ef6a823b84e602a242fad9b690646c
+  metadata.gz: ec01fbb52f6e4bbf0ae78e81b2c6c0d427b6724efc6e8a93283a595a21b512de
+  data.tar.gz: 57bd11fdbbd47f201d9d962893a160df528ab94c48410904df86c938bdcafc8d
 SHA512:
-  metadata.gz: c4eb4852df47c231e43218243178582e860f3dc553b06f5f8f32165b27c4a7d2448f01ac690b59617b4e724927db4224b9311791df77a8aff3a70ada43b3f9a0
-  data.tar.gz: c0a6ce6875f528459031905df09bdcccc1cc1fa34e6ed6eecfa5863647b8d711b38879f8c13afb1ff915c7ce642a92637bfc7bc559df40921cd30761baab2c53
+  metadata.gz: 97c3b7ebbe683fb790b66ac59abf913af645025a72b94cabbd5e0d8c114c8ef3c4cbd7c31b87c1c212e00f07499c807f71e2af1db8265856856693e8649cff9f
+  data.tar.gz: d7483cb8f561e2b07f11c5cc7a177af1fc9a6b9a01347b5458d76624fff02462d898ed7ec84ba61f8c6aa435814d058b7bd3e99e6dead29d336c4d97734c50ab

data/Gemfile

@@ -6,9 +6,9 @@ source "https://rubygems.org"
 gemspec
 
 gem "bundler", "~> 2.1.4"
-gem "rspec", "~> 3"
-gem "rubocop", "~> 1.15"
-gem "rubocop-rspec", "~> 2.3.0"
+gem "rspec", "~> 3.11.0"
+gem "rubocop", "~> 1.36.0"
+gem "rubocop-rspec", "~> 2.12.1"
 
 gem "debase", "~> 0.2.5.beta2"
 gem "ruby-debug-ide", "~> 0.7.2"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    strum-esb (0.3.3)
+    strum-esb (0.4.0)
       bunny (~> 2.15)
       connection_pool (~> 2.2.2)
       dry-configurable (~> 0.12.1)
@@ -26,17 +26,17 @@ GEM
     dry-configurable (0.12.1)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.5, >= 0.5.0)
-    dry-core (0.7.1)
+    dry-core (0.8.1)
       concurrent-ruby (~> 1.0)
     dry-inflector (0.2.1)
     json (2.6.2)
     parallel (1.22.1)
-    parser (3.1.1.0)
+    parser (3.1.2.1)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (12.3.3)
     rbtree (0.4.5)
-    regexp_parser (2.2.1)
+    regexp_parser (2.5.0)
     rexml (3.2.5)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
@@ -51,26 +51,26 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
-    rubocop (1.26.1)
+    rubocop (1.36.0)
+      json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.0.0)
+      parser (>= 3.1.2.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.16.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.20.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.16.0)
+    rubocop-ast (1.21.0)
       parser (>= 3.1.1.0)
-    rubocop-rspec (2.3.0)
-      rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.12.1)
+      rubocop (~> 1.31)
     ruby-debug-ide (0.7.3)
       rake (>= 0.8.1)
     ruby-progressbar (1.11.0)
     serverengine (2.1.1)
       sigdump (~> 0.2.2)
-    set (1.0.2)
+    set (1.0.3)
     sigdump (0.2.4)
     sneakers (2.12.0)
       bunny (~> 2.14)
@@ -82,7 +82,7 @@ GEM
       rbtree
       set (~> 1.0)
     thor (1.2.1)
-    unicode-display_width (2.1.0)
+    unicode-display_width (2.2.0)
 
 PLATFORMS
   ruby
@@ -91,9 +91,9 @@ DEPENDENCIES
   bundler (~> 2.1.4)
   debase (~> 0.2.5.beta2)
   dry-inflector (~> 0.2.1)
-  rspec (~> 3)
-  rubocop (~> 1.15)
-  rubocop-rspec (~> 2.3.0)
+  rspec (~> 3.11.0)
+  rubocop (~> 1.36.0)
+  rubocop-rspec (~> 2.12.1)
   ruby-debug-ide (~> 0.7.2)
   strum-esb!
 

data/README.md

@@ -106,8 +106,9 @@ module Queues
   class Resource
     include Strum::Esb::Handler
 
-    json false
-    protobuf_service Test::Router::Service
+    enable_json          false
+    enable_protobuf      true
+    use_protobuf_service Test::Router::Service
     from_queue "resource-queue",
                bindings: {
                  events: %w[user/create user/update],
@@ -125,12 +126,24 @@ Your rpc action must have the same name as your method in queue class, for examp
 
 3. Pass content type as additional param when you send Strum::Esb message:
 ```ruby
-Strum::Esb::Action.call("payload", "action", "resource", content_type: "application/x-protobuf")
+message = { id: 10 }
+args = {
+  content_type: "application/x-protobuf",
+  message_class: Messages::ActionGetUser
+}
+Strum::Esb::Action.call(message, "action", "resource", **args)
 ```
-or add it as before_publish_hook:
+
+4. Configure proto serialization/deserialization:
 ```ruby
-Strum::Esb.config.before_publish_hooks << lambda { |_body, properties|
-  properties[:content_type] = "application/x-protobuf"
+Strum::Esb.config.serializer_conf = {
+  to_proto: proc do |message_class, payload|
+              ::CustomSerializer.to_protobuf(message_class, payload).to_proto
+            end,
+  from_proto: proc do |message_class, encoded_payload|
+                rpc_instance = message_class.decode(encoded_payload)
+                ::CustomSerializer.from_protobuf(rpc_instance)
+              end
 }
 ```
 

data/lib/strum/esb/handler.rb

@@ -12,6 +12,7 @@ module Strum
           include Sneakers::Worker
         end
         base.extend ClassMethods
+        base.use_application_config
       end
 
       module ClassMethods
@@ -22,16 +23,16 @@ module Strum
             yield(bindings)
           else
             bindings[message_type] ||= []
-            bindings[message_type] << message_binding  
+            bindings[message_type] << message_binding
           end
 
           from_queue queue, bindings: bindings
-          handlers[handler_key(message_type, message_binding)] = handler.to_s if handler          
+          handlers[handler_key(message_type, message_binding)] = handler.to_s if handler
         end
 
         def handler_key(message_type, message_binding)
           _, *msg = Strum::Esb::Functions.public_send("#{message_type}_explain", message_binding)
-          params = msg.map{ |param| param&.to_s.gsub(/[^a-zA-Z0-9]/, "_")&.downcase }
+          params = msg.map { |param| param&.to_s&.gsub(/[^a-zA-Z0-9]/, "_")&.downcase }
           ([message_type] + params).join("-")
         end
 
@@ -39,12 +40,47 @@ module Strum
           @handlers ||= {}
         end
 
-        def protobuf_service(service)
-          Strum::Esb.config.protobuf_service = service
+        def enable_json(switcher)
+          @json_mode = switcher
         end
 
-        def json(switcher)
-          Strum::Esb.config.json = switcher
+        def json_enabled?
+          @json_mode
+        end
+
+        def enable_protobuf(switcher)
+          @protobuf_mode = switcher
+        end
+
+        def protobuf_enabled?
+          @protobuf_mode
+        end
+
+        def content_type_enabled?(content_type)
+          case content_type
+          when "application/json"
+            json_enabled?
+          when "application/x-protobuf"
+            protobuf_enabled?
+          else
+            false
+          end
+        end
+
+        def use_protobuf_service(service)
+          raise ArgumentError, "#{service} must be a grpc service" unless service.respond_to?(:rpc_descs)
+
+          @protobuf_service = service
+          enable_protobuf(true)
+        end
+
+        def protobuf_service
+          @protobuf_service
+        end
+
+        def use_application_config
+          enable_json(Strum::Esb.config.enable_json)
+          enable_protobuf(Strum::Esb.config.enable_protobuf)
         end
       end
 
@@ -85,12 +121,14 @@ module Strum
 
         content_type = metadata[:content_type] || "application/json"
 
-        unless Strum::Esb.config.serializer.enabled?(content_type)
+        unless self.class.content_type_enabled?(content_type)
           logger.error "Content type #{content_type} is disabled by handler. Message rejected #{metadata[:headers]} with payload #{deserialized_msg}"
           return reject!
         end
 
-        payload, valid_payload = Strum::Esb.config.serializer.deserialize(deserialized_msg, content_type, method_name)
+        args = { queue_method_name: method_name, grpc_service: self.class.protobuf_service, content_type: content_type }
+
+        payload, valid_payload = Strum::Esb.config.serializer.deserialize(deserialized_msg, args: args)
 
         unless valid_payload
           logger.error "Payload was unable to be parsed with #{content_type} content type. Message rejected #{metadata[:headers]} with payload #{payload}"
@@ -153,7 +191,7 @@ module Strum
           result << "notice_#{notice}"
           result << "notice_handler"
           result
-        end        
+        end
     end
   end
 end

data/lib/strum/esb/message.rb

@@ -5,26 +5,26 @@ module Strum
     # Strum Message
     class Message
       class << self
-        def publish(exchange:, headers:, payload:, content_type: "application/json")
-          rabbit_exchange ||= Strum::Esb.config.rabbit_channel_pool.with { |rabbit_channel| rabbit_channel.headers(exchange, durable: true) }
-          properties = {
-            headers: headers,
-            content_type: content_type
-          }
+        def publish(exchange:, headers:, payload:, **args)
+          rabbit_exchange ||= Strum::Esb.config.rabbit_channel_pool.with do |rabbit_channel|
+            rabbit_channel.headers(exchange, durable: true)
+          end
+
+          properties = { headers: headers, content_type: args.fetch(:content_type, "application/json") }
 
           Strum::Esb.config.before_publish_hooks.each { |hook| hook.call(payload, properties) }
+          args.merge!(properties)
+
+          payload, valid_payload = Strum::Esb.config.serializer.serialize(payload, args: args)
+          return unless valid_payload
+
+          rabbit_exchange.publish(payload, **properties)
+        end
 
+        def extend_headers(properties)
           properties[:headers] = {} unless properties[:headers].is_a?(Hash)
           properties[:headers]["pipeline"] ||= Thread.current[:pipeline] if Thread.current[:pipeline]
           properties[:headers]["pipeline-id"] ||= Thread.current[:pipeline_id] if Thread.current[:pipeline_id]
-
-          payload, valid_payload = Strum::Esb.config.serializer.serialize(payload, properties[:content_type])
-          unless valid_payload
-            Sneakers.logger.error "Content type is invalid. Message rejected #{properties[:headers]} with payload #{payload}"
-            return
-          end
-
-          rabbit_exchange.publish(payload, **properties)
         end
       end
     end

data/lib/strum/esb/serializer.rb

@@ -7,28 +7,20 @@ module Strum
       CONTENT_TYPES = %w[application/json application/x-protobuf].freeze
 
       %i[serialize deserialize].each do |base_method|
-        define_method base_method do |payload, content_type, queue_method_name = nil|
-          return [payload, false] unless valid_content_type?(content_type)
+        define_method base_method do |payload, args: {}|
+          content_type = args.fetch(:content_type)
+          raise ArgumentError, "invalid content_type" unless valid_content_type?(content_type)
 
           perform_method_name = content_type_method_name(base_method, content_type)
-          payload = send(*[perform_method_name, payload, queue_method_name].compact)
+          payload = send(perform_method_name, payload, args: args)
           [payload, true]
-        rescue StandardError
+        rescue StandardError => e
+          Sneakers.logger.error(e.inspect)
+          Sneakers.logger.error "Content type is invalid. Message rejected #{args[:headers]} with payload #{payload}"
           [payload, false]
         end
       end
 
-      def enabled?(content_type)
-        case data_type(content_type)
-        when "json"
-          Strum::Esb.config.json
-        when "protobuf"
-          Strum::Esb.config.protobuf_service
-        else
-          false
-        end
-      end
-
       private
 
         def valid_content_type?(content_type)
@@ -43,22 +35,24 @@ module Strum
           content_type.gsub("-", "/").split("/").last
         end
 
-        def deserialize_json(payload, _queue_method_name)
+        def deserialize_json(payload, args: {}) # rubocop:disable Lint/UnusedMethodArgument
           JSON.parse(payload)
         end
 
-        def deserialize_protobuf(payload, queue_method_name)
-          action_name = inflector.camelize(queue_method_name)
-          rpc_struct = Strum::Esb.config.protobuf_service.rpc_descs[action_name.to_sym]
-          rpc_struct.input.decode(payload)
+        def deserialize_protobuf(payload, args: {})
+          action_name = inflector.camelize(args.fetch(:queue_method_name))
+          message_class = args.fetch(:grpc_service).rpc_descs[action_name.to_sym].input
+
+          Strum::Esb.config.serializer_conf[:from_proto].call(message_class, payload)
         end
 
-        def serialize_json(payload)
+        def serialize_json(payload, args: {}) # rubocop:disable Lint/UnusedMethodArgument
           payload.to_json
         end
 
-        def serialize_protobuf(payload)
-          payload
+        def serialize_protobuf(payload, args: {})
+          message_class = args.fetch(:message_class)
+          Strum::Esb.config.serializer_conf[:to_proto].call(message_class, payload)
         end
 
         def inflector

data/lib/strum/esb/version.rb

@@ -2,6 +2,6 @@
 
 module Strum
   module Esb
-    VERSION = "0.3.3"
+    VERSION = "0.4.0"
   end
 end

data/lib/strum/esb.rb

@@ -40,9 +40,18 @@ module Strum
     setting :before_publish_hooks, []
     setting :before_handler_hooks, []
     setting :after_handler_hooks, []
+
     setting :serializer, Serializer.new
-    setting :protobuf_service, false
-    setting :json, true
+    setting :enable_json, true
+    setting :enable_protobuf, false
+    setting :serializer_conf, {
+      to_proto: proc do |message_class, payload|
+                  message_class.new(payload).to_proto
+                end,
+      from_proto: proc do |message_class, encoded_payload|
+                    message_class.decode(encoded_payload).to_h
+                  end
+    }
 
     Strum::Esb.config.before_fork_hooks << proc { DB.disconnect } if defined?(DB)
 
@@ -56,12 +65,12 @@ module Strum
         @app = app
         @args = args
       end
-    
+
       def call(deserialized_msg, delivery_info, metadata, handler)
-        Thread.current.keys.each{ |key| Thread.current[key] = nil }
+        Thread.current.keys.each { |key| Thread.current[key] = nil }
         @app.call(deserialized_msg, delivery_info, metadata, handler)
       end
-    end    
+    end
 
     Sneakers.configure(
       log: $stdout,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strum-esb
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors:
 - Serhiy Nazarov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-18 00:00:00.000000000 Z
+date: 2022-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny