strongmind-platform-sdk 3.19.30 → 3.19.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 99cb6793a19a83ca3efad9083a259ccf17b15fe1d64f3ac4a824964ac5e0bcc1
-  data.tar.gz: 9765e4699c62939e57e328bebd72316a0eb26102cd3a994f92af7d1ebef253bc
+  metadata.gz: 743bf8f25edcef7c341af1d9598f40ac368e986cb93392f84f03b6424543c256
+  data.tar.gz: 502e70faec7680e7dcb701c1db36e1d5f9be1327b3c672adb7d517538074ce09
 SHA512:
-  metadata.gz: a6490fd12ee607dcad600c9e5098da6561c757a50b9d0ab83be81d112c6d8865d638d8ea32faea512a5bd924b192efa1cdd87a66702acce4e3d8d86275dc9c9f
-  data.tar.gz: 969ac7c437f12e2d91a8e4c5bdbae2a9dc01f2e15f40177d69110c8214cb574edf6dd1992750e955d44affc8aba0f37dee73907d1091720ca9ce14586e42b4d2
+  metadata.gz: a78544838ee3e0f0af687a97c39e200fe931e54199fa338bdaa0fbebbf3893e0caf64f21fa37c39b7b27473eb6a17dd2eedf3a69fd43658485ad6c97bc328f75
+  data.tar.gz: 6342ec70213b1416ed58134d5c6049064e58f6780dfc7cffeb5b8c6d3cdf0479e66e07caba4d630a3569baae6e8f71d9a920a3ce70628ba491292494b88db6ae

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    strongmind-platform-sdk (3.19.30)
+    strongmind-platform-sdk (3.19.31)
       activesupport (~> 7.1)
       asset_sync
       aws-sdk-secretsmanager (~> 1.66)
@@ -103,14 +103,14 @@ GEM
       unf
     ast (2.4.2)
     aws-eventstream (1.3.0)
-    aws-partitions (1.962.0)
+    aws-partitions (1.968.0)
     aws-sdk-cloudwatch (1.97.0)
       aws-sdk-core (~> 3, >= 3.201.0)
       aws-sigv4 (~> 1.5)
-    aws-sdk-core (3.201.3)
+    aws-sdk-core (3.201.5)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.651.0)
-      aws-sigv4 (~> 1.8)
+      aws-sigv4 (~> 1.9)
       jmespath (~> 1, >= 1.6.1)
     aws-sdk-secretsmanager (1.102.0)
       aws-sdk-core (~> 3, >= 3.201.0)
@@ -192,7 +192,7 @@ GEM
     method_source (1.1.0)
     mime-types (3.5.2)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2024.0806)
+    mime-types-data (3.2024.0820)
     mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.24.1)
@@ -314,7 +314,7 @@ GEM
     sentry-ruby (5.18.2)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
-    sidekiq (7.3.0)
+    sidekiq (7.3.1)
       concurrent-ruby (< 2)
       connection_pool (>= 2.3.0)
       logger
@@ -341,9 +341,7 @@ GEM
       ethon (>= 0.9.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unf (0.1.4)
-      unf_ext
-    unf_ext (0.0.9.1)
+    unf (0.2.0)
     unicode-display_width (2.5.0)
     uri (0.13.0)
     webmock (3.23.1)

data/lib/platform_sdk/active_record/data_pipelineable.rb

@@ -9,7 +9,7 @@ module PlatformSdk
       included do
         after_create :send_pipeline_create
         before_destroy :send_pipeline_destroy
-        after_update :send_pipeline_update
+        after_update :send_pipeline_update, if: -> { saved_changes? }
       end
 
       def send_pipeline_create
@@ -55,9 +55,9 @@ module PlatformSdk
 
       def pipeline_data(action)
         attributes.symbolize_keys
-          .merge(pipeline_additional_attributes)
-          .except(*pipeline_excluded_attributes)
-          .merge(action:)
+                  .merge(pipeline_additional_attributes)
+                  .except(*pipeline_excluded_attributes)
+                  .merge(action:)
       end
 
       def pipeline_additional_attributes

data/lib/platform_sdk/spec_support/shared_examples/data_pipelineable_examples.rb

@@ -1,6 +1,7 @@
 module PlatformSdk
   module SpecSupport
-    RSpec.shared_examples "DataPipelineable" do
+    RSpec.shared_examples 'DataPipelineable' do |params = {}|
+      let(:shared_params) { params }
       let(:record) { build(described_class.to_s.underscore.to_sym) }
       let(:data_pipeline_client) { double(PlatformSdk::DataPipeline::Client) }
 
@@ -12,41 +13,76 @@ module PlatformSdk
 
       after { Timecop.return }
 
-      context 'after_create callbacks' do
-        before { allow(record).to receive(:send_pipeline_create) }
+      context 'create' do
 
-        it "defines an after_create callback" do
+        it 'posts a copy of our data to the data pipeline' do
           record.save!
-          expect(record).to have_received(:send_pipeline_create)
+          expect(data_pipeline_client).to have_received(:post).once.with(hash_including(
+                                                                           noun: described_class.pipeline_noun,
+                                                                           data: record.pipeline_data('created'),
+                                                                           meta: described_class.pipeline_meta,
+                                                                           envelope_version: '1.0.0',
+                                                                           message_timestamp: Time.current.utc.iso8601,
+                                                                           identifiers: { id: record.id },
+                                                                         ))
         end
       end
 
-      context 'before_destroy callbacks' do
-        before do
-          allow(record).to receive(:send_pipeline_create)
-          allow(record).to receive(:send_pipeline_destroy)
-        end
+      context 'destroy' do
 
-        it "defines an after_destroy callback" do
+        it 'posts a copy of our data to the data pipeline' do
           record.save!
           record.destroy
 
-          expect(record).to have_received(:send_pipeline_create)
-          expect(record).to have_received(:send_pipeline_destroy)
+          expect(data_pipeline_client).to have_received(:post).once.with(hash_including(
+                                                                           noun: described_class.pipeline_noun,
+                                                                           data: record.pipeline_data('destroyed'),
+                                                                           meta: described_class.pipeline_meta,
+                                                                           envelope_version: '1.0.0',
+                                                                           message_timestamp: Time.current.utc.iso8601,
+                                                                           identifiers: { id: record.id }
+                                                                         ))
         end
       end
 
-      context 'after_update callbacks' do
+      context 'update' do
         before do
-          allow(record).to receive(:send_pipeline_update)
           record.save!
         end
 
-        it "defines an after_update callback" do
-          column = column_to_update(record)
-          unless column.nil?
+        context 'after an update' do
+          it 'posts a copy of our data to the data pipeline' do
+            column = column_to_update(record)
+            unless column.nil?
+              update_record(record, column)
+              expect(data_pipeline_client).to have_received(:post).once.with(hash_including(
+                                                                               noun: described_class.pipeline_noun,
+                                                                               data: record.pipeline_data('modified'),
+                                                                               meta: described_class.pipeline_meta,
+                                                                               envelope_version: '1.0.0',
+                                                                               message_timestamp: Time.current.utc.iso8601,
+                                                                               identifiers: { id: record.id },
+                                                                             ))
+            end
+          end
+        end
+
+        context 'after an update that does not change data' do
+          let(:action) { 'modified' }
+
+          it 'does not post to the data pipeline' do
+            record.save!
+            column = column_to_update(record)
             update_record(record, column)
-            expect(record).to have_received(:send_pipeline_update)
+            record.save!
+            expect(data_pipeline_client).to have_received(:post).once.with(hash_including(
+                                                                             noun: described_class.pipeline_noun,
+                                                                             data: record.pipeline_data('modified'),
+                                                                             meta: described_class.pipeline_meta,
+                                                                             envelope_version: '1.0.0',
+                                                                             message_timestamp: Time.current.utc.iso8601,
+                                                                             identifiers: { id: record.id }
+                                                                           ))
           end
         end
       end
@@ -60,13 +96,18 @@ module PlatformSdk
       end
 
       def update_record(record, column)
+        if shared_params[:update_method]
+          send(shared_params[:update_method], record)
+          return
+        end
         new_record = build(described_class.to_s.underscore.to_sym)
 
-        column_class = record[column]
-        case column_class
-        when Integer
+        column_value = record[column]
+        column_class = column_value.class
+        case column_class.to_s
+        when 'Integer'
           record.update!(column => 69)
-        when [true, false].include?(column_class)
+        when 'TrueClass', 'FalseClass'
           record.update!(column => !record[column])
         else
           record.update!(column => new_record[column])
@@ -90,9 +131,9 @@ module PlatformSdk
 
             let(:data) do
               record.attributes.symbolize_keys
-                .merge(record.pipeline_additional_attributes)
-                .except(*record.pipeline_excluded_attributes)
-                .merge(action:)
+                    .merge(record.pipeline_additional_attributes)
+                    .except(*record.pipeline_excluded_attributes)
+                    .merge(action:)
             end
 
             it 'returns the expected payload' do

data/lib/platform_sdk/spec_support/shared_examples/one_roster_data_pipelineable_examples.rb

@@ -2,10 +2,10 @@
 
 module PlatformSdk
   module SpecSupport
-    RSpec.shared_examples "OneRosterDataPipelineable" do |record_keys|
+    RSpec.shared_examples 'OneRosterDataPipelineable' do |record_keys|
       let(:data) do
         record_keys.each_with_object({}) do |key, hash|
-          if key == "_type"
+          if key == '_type'
             hash[:type] = record.try(key)
             next
           end
@@ -17,11 +17,11 @@ module PlatformSdk
           "noun": "StrongMind.Platform.OneRoster.#{record.one_roster_data_type.capitalize}",
           "identifiers": { "sourcedId": record.roster_id },
           "meta": {
-            "version": "3",
-            "source": "Central OneRoster API"
+            "version": '3',
+            "source": 'Central OneRoster API'
           },
           "data": one_roster_common_data.merge!(data),
-          "envelope_version": "1.0.0",
+          "envelope_version": '1.0.0',
           "message_timestamp": Time.current.utc.iso8601
         }
       end
@@ -39,27 +39,27 @@ module PlatformSdk
       before do
         allow(PlatformSdk::DataPipeline::Client).to receive(:new).and_return(data_pipeline_client)
         allow(data_pipeline_client).to receive(:post)
-        Timecop.freeze(DateTime.parse("2024-06-09 04:20:00"))
+        Timecop.freeze(DateTime.parse('2024-06-09 04:20:00'))
       end
 
       after do
         Timecop.return
       end
 
-      context "after_create callbacks" do
-        let(:action) { "created" }
+      context 'create' do
+        let(:action) { 'created' }
 
-        it "defines an after_create callback" do
+        it 'posts to the data pipeline' do
           record.save!
           expect(data_pipeline_client).to have_received(:post).with(pipeline_payload)
         end
       end
 
-      context "before_destroy callbacks" do
-        let(:action) { "destroyed" }
+      context 'destroy' do
+        let(:action) { 'destroyed' }
         let(:one_roster_common_data_deleted) do
           one_roster_common_data.merge(
-            "status": "tobedeleted"
+            "status": 'tobedeleted'
           )
         end
 
@@ -67,7 +67,7 @@ module PlatformSdk
           pipeline_payload.merge("data": one_roster_common_data_deleted)
         end
 
-        it "defines an after_destroy callback" do
+        it 'posts to the data pipeline' do
           record.save!
           record.destroy
           expect(data_pipeline_client).to have_received(:post).with(pipeline_payload)
@@ -75,18 +75,33 @@ module PlatformSdk
         end
       end
 
-      context "after_update callbacks" do
-        let(:action) { "modified" }
+      context 'update' do
+        let(:action) { 'modified' }
 
         before do
-          allow(record).to receive(:send_pipeline_create)
           record.save!
         end
 
-        it "defines an after_update callback" do
-          column = column_to_update(record)
-          update_record(record, column)
-          expect(data_pipeline_client).to have_received(:post).with(pipeline_payload)
+        context 'after an update' do
+
+          it 'posts a copy of our data to the data pipeline' do
+            column = column_to_update(record)
+            update_record(record, column)
+            expect(data_pipeline_client).to have_received(:post).with(pipeline_payload)
+          end
+
+        end
+
+        context 'after an update that does not change data' do
+          let(:action) { 'modified' }
+
+          it 'does not post to the data pipeline' do
+            record.save!
+            column = column_to_update(record)
+            update_record(record, column)
+            record.save!
+            expect(data_pipeline_client).to have_received(:post).once.with(pipeline_payload)
+          end
         end
       end
 
@@ -100,11 +115,12 @@ module PlatformSdk
       def update_record(record, column)
         new_record = build(described_class.to_s.underscore.to_sym)
 
-        column_class = record[column]
-        case column_class
-        when Integer
+        column_value = record[column]
+        column_class = column_value.class
+        case column_class.to_s
+        when 'Integer'
           record.update!(column => 69)
-        when [true, false].include?(column_class)
+        when 'TrueClass', 'FalseClass'
           record.update!(column => !record[column])
         else
           record.update!(column => new_record[column])

data/lib/platform_sdk/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PlatformSdk
-  VERSION = '3.19.30'
+  VERSION = '3.19.31'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strongmind-platform-sdk
 version: !ruby/object:Gem::Version
-  version: 3.19.30
+  version: 3.19.31
 platform: ruby
 authors:
 - Platform Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-08-07 00:00:00.000000000 Z
+date: 2024-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday