stronger_parameters 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93d2fdbe9f0ef6a466cd4bf9b767378b372db899
-  data.tar.gz: a49cd1dbb65c4f3f2f889c99ebdf1920f0d7b4e8
+  metadata.gz: 008fefe30dfbd3ec1f72923ca934d2e13bbf2d16
+  data.tar.gz: 217fcf6bcf4d7a9e5267578340aadb8c1e5f5c25
 SHA512:
-  metadata.gz: 1c55ade72ce711a2a3414c794bb573446f6beb5459b1d3cf9938b49305d611d44ee5cc05618b378dab28767fd978af51ec387c1295807c52b1ebf6783630c0f8
-  data.tar.gz: fc4e1f91e3ecf5a151277cab998377dae87838e2d7f6ea0b5d3e1abf53dcd04305127e91df44987a91eaacfa329000a0a23ecabec128fbd9e2a9c4d31f4d6887
+  metadata.gz: 77063ef7951b0164cae2a152294078aa6c8de1d0e14ef4274cdf2a5fc75a2ff59e1e3f499903c3bf2c91d453478e659cf4c17a5567d0ea545bb4c2f2c3314cf2
+  data.tar.gz: 89a19943e2d3155b69801d5ce08bfb3decf81e3bc94ab63db815a06b2879586068543eb7b71a56d5803500780bb1fce526e00625e5d56620c09ee1600899f21c

data/README.md

@@ -1,4 +1,5 @@
 # stronger_parameters
+[![Build Status](https://travis-ci.org/zendesk/stronger_parameters.svg?branch=master)](https://travis-ci.org/zendesk/stronger_parameters)
 
 This is an extension of `strong_parameters` with added type checking.
 

data/lib/stronger_parameters/constraints/hash_constraint.rb

@@ -5,11 +5,12 @@ module StrongerParameters
     attr_reader :constraints
 
     def initialize(constraints)
-      @constraints = constraints.with_indifferent_access
+      @constraints = constraints.with_indifferent_access unless constraints.nil?
     end
 
     def value(v)
       if v.is_a?(Hash)
+        return ActionController::Parameters.new(v).permit! if constraints.nil?
         return ActionController::Parameters.new(v).permit(constraints)
       end
 

data/lib/stronger_parameters/constraints/{fixnum_constraint.rb → integer_constraint.rb}

@@ -1,9 +1,9 @@
 require 'stronger_parameters/constraints'
 
 module StrongerParameters
-  class FixnumConstraint < Constraint
+  class IntegerConstraint < Constraint
     def value(v)
-      if v.is_a?(Fixnum)
+      if v.is_a?(Fixnum) || v.is_a?(Bignum)
         return v
       elsif v.is_a?(String) && v =~ /\A-?\d+\Z/
         return v.to_i

data/lib/stronger_parameters/constraints.rb

@@ -76,7 +76,7 @@ module StrongerParameters
 end
 
 require 'stronger_parameters/constraints/string_constraint'
-require 'stronger_parameters/constraints/fixnum_constraint'
+require 'stronger_parameters/constraints/integer_constraint'
 require 'stronger_parameters/constraints/boolean_constraint'
 require 'stronger_parameters/constraints/array_constraint'
 require 'stronger_parameters/constraints/hash_constraint'

data/lib/stronger_parameters/parameters.rb

@@ -28,7 +28,7 @@ module StrongerParameters
       end
 
       def integer
-        @integer ||= FixnumConstraint.new
+        @integer ||= IntegerConstraint.new
       end
 
       def lt(limit)
@@ -76,7 +76,7 @@ module StrongerParameters
         ArrayConstraint.new(item_constraint)
       end
 
-      def map(constraints)
+      def map(constraints = nil)
         HashConstraint.new(constraints)
       end
     end

data/lib/stronger_parameters/version.rb

@@ -1,3 +1,3 @@
 module StrongerParameters
-  VERSION = '1.0.2'
+  VERSION = '1.1.0'
 end

metadata

@@ -1,127 +1,127 @@
 --- !ruby/object:Gem::Specification
 name: stronger_parameters
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Mick Staugaard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-08 00:00:00.000000000 Z
+date: 2015-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.7.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.7.5
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: wwtd
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
 description: 
 email:
 - mick@zendesk.com
@@ -129,30 +129,20 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- README.md
+- lib/stronger_parameters.rb
+- lib/stronger_parameters/constraints.rb
 - lib/stronger_parameters/constraints/array_constraint.rb
 - lib/stronger_parameters/constraints/boolean_constraint.rb
 - lib/stronger_parameters/constraints/comparison_constraints.rb
 - lib/stronger_parameters/constraints/enumeration_constraint.rb
-- lib/stronger_parameters/constraints/fixnum_constraint.rb
 - lib/stronger_parameters/constraints/hash_constraint.rb
+- lib/stronger_parameters/constraints/integer_constraint.rb
 - lib/stronger_parameters/constraints/string_constraint.rb
-- lib/stronger_parameters/constraints.rb
 - lib/stronger_parameters/errors.rb
 - lib/stronger_parameters/parameters.rb
 - lib/stronger_parameters/railtie.rb
 - lib/stronger_parameters/version.rb
-- lib/stronger_parameters.rb
-- test/array_contraints_test.rb
-- test/boolean_constraints_test.rb
-- test/comparison_constraints_test.rb
-- test/controller_test.rb
-- test/enum_constraints_test.rb
-- test/fixnum_constraints_test.rb
-- test/hash_constraint_test.rb
-- test/operator_constraints_test.rb
-- test/string_constraints_test.rb
-- test/test_helper.rb
-- README.md
 homepage: https://github.com/zendesk/stronger_parameters
 licenses:
 - Apache License Version 2.0
@@ -163,28 +153,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Type checking and type casting of parameters for Action Pack
-test_files:
-- test/array_contraints_test.rb
-- test/boolean_constraints_test.rb
-- test/comparison_constraints_test.rb
-- test/controller_test.rb
-- test/enum_constraints_test.rb
-- test/fixnum_constraints_test.rb
-- test/hash_constraint_test.rb
-- test/operator_constraints_test.rb
-- test/string_constraints_test.rb
-- test/test_helper.rb
+test_files: []

data/test/array_contraints_test.rb

@@ -1,12 +0,0 @@
-require_relative 'test_helper'
-
-describe 'array parameter constraints' do
-  subject { ActionController::Parameters.array(ActionController::Parameters.string) }
-
-  permits ['a', 'b']
-
-  rejects 'abc'
-  rejects 123
-  rejects [123, 456]
-  rejects ['abc', 123]
-end

data/test/boolean_constraints_test.rb

@@ -1,17 +0,0 @@
-require_relative 'test_helper'
-
-describe 'boolean parameter constraints' do
-  subject { ActionController::Parameters.boolean }
-
-  permits true,   :as => true
-  permits 'true', :as => true
-  permits 1,      :as => true
-  permits '1',    :as => true
-
-  permits false,   :as => false
-  permits 'false', :as => false
-  permits 0,       :as => false
-  permits '0',     :as => false
-
-  rejects 'foo'
-end

data/test/comparison_constraints_test.rb

@@ -1,35 +0,0 @@
-require_relative 'test_helper'
-
-describe 'comparison parameter constraints' do
-  describe 'less-than types' do
-    subject { ActionController::Parameters.lt(2) }
-
-    permits 1
-    rejects 2
-    rejects 3
-  end
-
-  describe 'less-than-or-equal types' do
-    subject { ActionController::Parameters.lte(2) }
-
-    permits 1
-    permits 2
-    rejects 3
-  end
-
-  describe 'greater-than types' do
-    subject { ActionController::Parameters.gt(2) }
-
-    rejects 1
-    rejects 2
-    permits 3
-  end
-
-  describe 'greater-than-or-equal types' do
-    subject { ActionController::Parameters.gte(2) }
-
-    rejects 1
-    permits 2
-    permits 3
-  end
-end

data/test/controller_test.rb

@@ -1,26 +0,0 @@
-require_relative 'test_helper'
-
-class BooksController < ActionController::Base
-  def create
-    params.require(:book).permit(:id => Parameters.integer)
-
-    head :ok
-  end
-end
-
-describe BooksController do
-  it 'rejects invalid params' do
-    post :create, { :magazine => { :name => 'Mjallo!' } }
-    assert_response :bad_request
-    response.body.must_equal 'Required parameter missing: book'
-
-    post :create, { :book => { :id => 'Mjallo!' } }
-    assert_response :bad_request
-    response.body.must_equal 'Invalid parameter: id must be an integer'
-  end
-
-  it 'permits valid params' do
-    post :create, { :book => { :id => '123' } }
-    assert_response :ok
-  end
-end

data/test/enum_constraints_test.rb

@@ -1,12 +0,0 @@
-require_relative 'test_helper'
-
-describe 'enum parameter constraints' do
-  subject { ActionController::Parameters.enumeration('abc', 123) }
-
-  permits 'abc'
-  permits 123
-
-  rejects 'abcd'
-  rejects '123'
-  rejects 1234
-end

data/test/fixnum_constraints_test.rb

@@ -1,14 +0,0 @@
-require_relative 'test_helper'
-
-describe 'integer parameter constraints' do
-  subject { ActionController::Parameters.integer }
-
-  permits 123
-  permits '123', :as => 123
-  permits '-123', :as => -123
-
-  rejects 'abc'
-  rejects Date.today
-  rejects Time.now
-
-end

data/test/hash_constraint_test.rb

@@ -1,28 +0,0 @@
-require_relative 'test_helper'
-
-describe 'array parameter constraints' do
-  subject do
-    ActionController::Parameters.map(
-      :id => ActionController::Parameters.integer,
-      :name => ActionController::Parameters.string
-    )
-  end
-
-  def self.permits(value, options = {})
-    options[:as] ||= value
-    options[:as] = options[:as].with_indifferent_access
-
-    super(value, options)
-  end
-
-  permits(:id => 1, :name => 'Mick')
-  permits({:id => '1', :name => 'Mick'}, :as => {:id => 1, :name => 'Mick'})
-  permits(:id => 1)
-  permits({:id => '1'}, :as => {:id => 1})
-  permits(:name => 'Mick')
-
-  rejects(:id => 1, :name => 123)
-  rejects(:id => 'Mick', :name => 'Mick')
-  rejects(123)
-  rejects('abc')
-end

data/test/operator_constraints_test.rb

@@ -1,22 +0,0 @@
-require_relative 'test_helper'
-
-describe 'operator parameter constraints' do
-  describe 'OR types' do
-    subject { ActionController::Parameters.integer | ActionController::Parameters.string }
-
-    permits 'abc'
-    permits '123', :as => 123
-
-    rejects Date.today
-    rejects Time.now
-  end
-
-  describe 'AND types' do
-    subject { ActionController::Parameters.string & ActionController::Parameters.integer }
-
-    permits '123', :as => 123
-
-    rejects 123
-    rejects 'abc'
-  end
-end

data/test/string_constraints_test.rb

@@ -1,15 +0,0 @@
-require_relative 'test_helper'
-
-describe 'string parameter constraints' do
-  subject { ActionController::Parameters.string }
-
-  permits 'abc'
-
-  rejects 123
-  rejects Date.today
-  rejects Time.now
-
-  it 'rejects strings that are too long' do
-    assert_rejects(:value) { params(:value => '123').permit(:value => ActionController::Parameters.string(:max_length => 2)) }
-  end
-end

data/test/test_helper.rb

@@ -1,74 +0,0 @@
-ENV["RAILS_ENV"] = "test"
-
-require 'test/unit'
-require 'rails'
-require 'action_controller'
-require 'rails/test_help'
-
-class FakeApplication < Rails::Application; end
-
-Rails.application = FakeApplication
-Rails.configuration.action_controller = ActiveSupport::OrderedOptions.new
-Rails.configuration.secret_key_base = 'secret_key_base'
-
-require 'action_pack'
-require 'strong_parameters' if ActionPack::VERSION::MAJOR == 3
-
-module ActionController
-  SharedTestRoutes = ActionDispatch::Routing::RouteSet.new
-  SharedTestRoutes.draw do
-    get ':controller(/:action)'
-    post ':controller(/:action)'
-    put ':controller(/:action)'
-    delete ':controller(/:action)'
-  end
-
-  class Base
-    include ActionController::Testing
-    include SharedTestRoutes.url_helpers
-
-    rescue_from(ActionController::ParameterMissing) do |e|
-      render :text => "Required parameter missing: #{e.param}", :status => :bad_request
-    end
-  end
-
-  class ActionController::TestCase
-    setup do
-      @routes = SharedTestRoutes
-    end
-  end
-end
-
-require 'stronger_parameters'
-require 'minitest/rails'
-require 'minitest/autorun'
-
-ActionController::Parameters.action_on_invalid_parameters = :raise
-
-class MiniTest::Spec
-  def params(hash)
-    ActionController::Parameters.new(hash)
-  end
-
-  def assert_rejects(key, &block)
-    err = block.must_raise StrongerParameters::InvalidParameter
-    err.key.must_equal key.to_s
-  end
-
-  def self.permits(value, options = {})
-    type_casted = options.fetch(:as, value)
-
-    it "permits #{value.inspect} as #{type_casted.inspect}" do
-      permitted = params(:value => value).permit(:value => subject)
-      permitted[:value].must_equal type_casted
-    end
-  end
-
-  def self.rejects(value, options = {})
-    key = options.fetch(:key, :value)
-
-    it "rejects #{value.inspect}" do
-      assert_rejects(key) { params(:value => value).permit(:value => subject) }
-    end
-  end
-end