strong_password 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1db75b147a9e2bc0833c5de0a098fd8b7584d3b5
-  data.tar.gz: 6046844808e8bcf7636cb1865e0218198739a0c1
+  metadata.gz: 21b8b80e1e1a71360c0227964a49eb4157ae65e6
+  data.tar.gz: b5165bce41a88de6ae57ba044c58e09b50059813
 SHA512:
-  metadata.gz: 0b7544150289fbe379361be135494cc78bdf8d063dffe68f9f9384c82b50dafacb37a3f0ea6c3dcac41ead516595eeea99ecb1b748abb6884a2af8d4a3f6316e
-  data.tar.gz: 121dbd08326dccbfb8eacac4378d0db274b0eadd716ae773c009ff3f626811030d59be998470c834cec21fa6244f3cff93e1401b7ef4eb2b0cfd84b45c6aab9e
+  metadata.gz: 139743a7ca79896208779198592a532430f3f13aa62c47e6b5e29e62fa1a370d9fb47881aeed74fe29c71979c5b429220668b9e70b6069db9e9c9cb0d7d9029b
+  data.tar.gz: 0aaa1da057d4174f92d0456581d5bc883fca921db535d11a134e6f64ad247f7f9ace21fc91c1fa7ddb94ab661b8410b522aff74f3e5250ea447d55df7ada10cb

data/README.md

@@ -15,7 +15,7 @@ NOTE: StrongPassword requires the use of Ruby 2.0.  Upgrade if you haven't alrea
 
 Add this line to your application's Gemfile:
 
-    gem 'strong_password'
+    gem 'strong_password', '~> 0.0.2'
 
 And then execute:
 
@@ -38,7 +38,7 @@ model, it simply has to be an object that includes `ActiveModel::Validations`.
 ```ruby
 class User
   include ActiveModel::Validations
-  
+
   # Basic usage.  Defaults to minimum entropy of 18 and no dictionary checking
   validates :password, password_strength: true
   # Minimum entropy can be specified as min_entropy
@@ -53,7 +53,7 @@ class User
   validates :password, password_strength: {extra_dictionary_words: :my_extra_words, use_dictionary: true}
   # Alternative way to request password strength validation on a field
   validates_password_strength :password
-  
+
   # Return an array of words to add to the dictionary we check against.
   def my_extra_words
     ['extra', 'words', 'here', 'too']
@@ -79,15 +79,15 @@ password is strong or not. You can also directly access the entropy calculations
 
 ```text
 2.0.0p0 :001 > checker = StrongPassword::StrengthChecker.new('password')
- => #<StrongPassword::StrengthChecker:0x007fcd7c939b48 @base_password="password"> 
+ => #<StrongPassword::StrengthChecker:0x007fcd7c939b48 @base_password="password">
 2.0.0p0 :002 > checker.is_strong?
- => false 
+ => false
 2.0.0p0 :003 > checker.is_weak?
- => true 
+ => true
 2.0.0p0 :004 > checker.is_strong?(min_entropy: 2)
- => true 
+ => true
 2.0.0p0 :005 > checker.calculate_entropy
- => 15.5 
+ => 15.5
 2.0.0p0 :006 > checker.calculate_entropy(use_dictionary: true)
  => 2
 ```
@@ -145,7 +145,7 @@ disallowed by the strength checker.
    the 500 most common passwords.  That also means it's not a true "dictionary" check...
 2. Add a common password adjuster that basically works like the existing DictionaryAdjuster but does
    not stop at the first found word.  Stopping at the first word make sense if you have a 300,000 word
-   dictionary of the English language but not so much when you're only talking about the 500 most 
+   dictionary of the English language but not so much when you're only talking about the 500 most
    common passwords.
 
 ## Contributing

data/lib/strong_password/dictionary_adjuster.rb

@@ -46,23 +46,23 @@ module StrongPassword
       "blondes","enjoy","girl","apollo","parker","qwert","time","sydney","women","voodoo","magnum",
       "juice","abgrtyu","777777","dreams","maxwell","music","rush2112","russia","scorpion","rebecca",
       "tester","mistress","phantom","billy","6666","albert"]
-    
+
     attr_reader :base_password
-    
+
     def initialize(password)
       @base_password = password.dup.downcase
     end
-    
+
     def is_strong?(min_entropy: 18, min_word_length: 4, extra_dictionary_words: [])
       adjusted_entropy(entropy_threshhold: min_entropy,
                        min_word_length: min_word_length,
                        extra_dictionary_words: extra_dictionary_words) >= min_entropy
     end
-    
+
     def is_weak?(min_entropy: 18, min_word_length: 4, extra_dictionary_words: [])
       !is_strong?(min_entropy: min_entropy, min_word_length: min_word_length, extra_dictionary_words: extra_dictionary_words)
     end
-    
+
     # Returns the minimum entropy for the passwords dictionary adjustments.
     # If a threshhold is specified we will bail early to avoid unnecessary
     # processing.
@@ -82,13 +82,13 @@ module StrongPassword
             x2 =  next_non_word ? next_non_word : variant.length + 1
             found = false
             while !found && (x2 - x >= min_word_length)
-              word = variant[x, min_word_length]
+              word = Regexp.quote(variant[x, min_word_length])
               word += variant[(x + min_word_length)..x2].reverse.chars.inject('') {|memo, c| "(#{Regexp.quote(c)}#{memo})?"} if (x + min_word_length) <= y
               results = dictionary_words.grep(/\b#{word}\b/)
               if results.empty?
                 x = x + 1
                 numbits = EntropyCalculator.calculate('*' * x)
-                # If we have enough entropy at this length on a fully masked password with 
+                # If we have enough entropy at this length on a fully masked password with
                 # duplicates weakened then we can just bail on this variant
                 found = true if entropy_threshhold >= 0 && numbits >= entropy_threshhold
               else

data/lib/strong_password/version.rb

@@ -1,3 +1,3 @@
 module StrongPassword
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/strong_password/dictionary_adjuster_spec.rb

@@ -9,13 +9,13 @@ module StrongPassword
         subject.stub(adjusted_entropy: 18)
         expect(subject.is_strong?).to be_true
       end
-      
+
       it 'returns false if the calculated entropy is < the minimum' do
         subject.stub(adjusted_entropy: 17)
         expect(subject.is_strong?).to be_false
       end
     end
-    
+
     describe '#is_weak?' do
       let(:subject) { DictionaryAdjuster.new('password') }
 
@@ -24,17 +24,17 @@ module StrongPassword
         expect(subject.is_weak?).to be_false
       end
     end
-    
+
     describe '#adjusted_entropy' do
       before(:each) { NistBonusBits.stub(bonus_bits: 0)}
-      
+
       it 'checks against all variants of a given password' do
         password = 'password'
         adjuster = DictionaryAdjuster.new(password)
         PasswordVariants.should_receive(:all_variants).with(password).and_return([])
         adjuster.adjusted_entropy
       end
-      
+
       {
         'bnm,./' => 14, # Qwerty string should not get adjusted by dictionary adjuster
         'h#e0zbPas' => 19.5, # Random string should not get adjusted by dictionary adjuster
@@ -42,19 +42,21 @@ module StrongPassword
         'E_!3password' => 11.5, # Adjusts common dictionary words regardless of placement
         'h#e0zbPas 32e2i81 password' => 31.3125, # Even if there are multiple words
         '123456' => 4, # Even if they are also qwerty strings
-        'password123456' => 16 # But only drops the first matched word
+        'password123456' => 16, # But only drops the first matched word
+        'asdf)asdf' => 14, # Doesn't break with parens
+        'asdf[]asdf' => 16 # Doesn't break with []s
       }.each do |password, bits|
         it "returns #{bits} for '#{password}'" do
           expect(DictionaryAdjuster.new(password).adjusted_entropy).to eq(bits)
         end
       end
-      
+
       it 'allows extra words to be provided as an array' do
         password = 'mcmanus'
         base_entropy = EntropyCalculator.calculate(password)
         expect(DictionaryAdjuster.new(password).adjusted_entropy(extra_dictionary_words: ['mcmanus'])).not_to eq(base_entropy)
       end
-      
+
       it 'allows minimum word length to be adjusted' do
         password = '6969'
         base_entropy = DictionaryAdjuster.new(password).adjusted_entropy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: strong_password
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Brian McManus
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-11 00:00:00.000000000 Z
+date: 2013-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -105,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: StrongPassword adds a class to check password strength and a validator for