strong_migrations 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e155e036c26788c7c9fa7f513131422b784b895fe1cbfdfc8052ad1f5233cd6c
-  data.tar.gz: 5fe21cada2e29c433313c686332d96c67e2c55d057fd6c68839fe1993307c0f8
+  metadata.gz: a78b56711a718210a3d14c82a4c30734c0b653827c1a2bdcc7617c27a7eed0e5
+  data.tar.gz: 9ef73e9cd8783a34d330c3517d98df50266427bd10bd92656cc528753aceb045
 SHA512:
-  metadata.gz: 7f40abaf84f10ce6ce7255d083b3ec0940c2f7380705857767b0cde56b23802dcf844c27251c634006559dfb4489b799ab3758bf9928b6cb57b6bceb1bf051ec
-  data.tar.gz: c283b8b93715a4aabd2c0e8dc15b022e45ebfbe3bb52fccc037b9c95d3b2279d6002b78354cab8600cf2972f96a6966af0fd80aa9b58cde53343b5035d8bc59c
+  metadata.gz: 0ece935c993dad2d316d183be938db27a9595cac2d0880f5fcd3f516965440bda73da9e8ad5239269451b991b04a897de03b8f0ed11b30400074daf30fa353b7
+  data.tar.gz: c8a18a098a6356daae4bf6bb827fa7f11c0a37e8b88712083af88f4eeb0f8dcda7f893491f1a044cc2399afc8147c31c3b07bf46a2155b972c78bb2aebbd479e

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 2.2.1 (2025-03-21)
+
+- Added support for `change_column_null` with default value with `safe_by_default` option
+- Improved backfill instructions
+- Fixed `safe_by_default` applying to migrations before `start_after`
+
 ## 2.2.0 (2025-02-01)
 
 - Fixed constraint name for long table and column names with `change_column_null`

data/README.md

@@ -377,8 +377,8 @@ class BackfillSomeColumn < ActiveRecord::Migration[8.0]
   disable_ddl_transaction!
 
   def up
-    User.unscoped.in_batches do |relation|
-      relation.update_all some_column: "default_value"
+    User.unscoped.in_batches(of: 10000) do |relation|
+      relation.where(some_column: nil).update_all some_column: "default_value"
       sleep(0.01) # throttle
     end
   end

data/lib/strong_migrations/checks.rb

@@ -251,7 +251,7 @@ module StrongMigrations
             remove_args = [table, {name: constraint_name}]
 
             if StrongMigrations.safe_by_default
-              safe_change_column_null(add_args, validate_args, change_args, remove_args, default, constraints)
+              safe_change_column_null(add_args, validate_args, change_args, remove_args, table, column, default, constraints)
               throw :safe
             end
 
@@ -444,9 +444,9 @@ module StrongMigrations
       if function
         # update_all(column: Arel.sql(default)) also works in newer versions of Active Record
         update_expr = "#{quote_column_if_needed(column)} = #{default}"
-        "#{model}.unscoped.in_batches do |relation| \n      relation.where(#{column}: nil).update_all(#{update_expr.inspect})\n      sleep(0.01)\n    end"
+        "#{model}.unscoped.in_batches(of: 10000) do |relation| \n      relation.where(#{column}: nil).update_all(#{update_expr.inspect})\n      sleep(0.01)\n    end"
       else
-        "#{model}.unscoped.in_batches do |relation| \n      relation.update_all #{column}: #{default.inspect}\n      sleep(0.01)\n    end"
+        "#{model}.unscoped.in_batches(of: 10000) do |relation| \n      relation.where(#{column}: nil).update_all #{column}: #{default.inspect}\n      sleep(0.01)\n    end"
       end
     end
 

data/lib/strong_migrations/safe_methods.rb

@@ -1,7 +1,7 @@
 module StrongMigrations
   module SafeMethods
     def safe_by_default_method?(method)
-      StrongMigrations.safe_by_default && [:add_index, :add_belongs_to, :add_reference, :remove_index, :add_foreign_key, :add_check_constraint, :change_column_null].include?(method)
+      StrongMigrations.safe_by_default && !version_safe? && [:add_index, :add_belongs_to, :add_reference, :remove_index, :add_foreign_key, :add_check_constraint, :change_column_null].include?(method)
     end
 
     def safe_add_index(*args, **options)
@@ -76,11 +76,38 @@ module StrongMigrations
       end
     end
 
-    def safe_change_column_null(add_args, validate_args, change_args, remove_args, default, constraints)
+    def safe_change_column_null(add_args, validate_args, change_args, remove_args, table, column, default, constraints)
       @migration.reversible do |dir|
         dir.up do
           unless default.nil?
-            raise Error, "default value not supported yet with safe_by_default"
+            # TODO search for parent model if needed
+            if connection.pool != ActiveRecord::Base.connection_pool
+              raise_error :change_column_null,
+                code: backfill_code(table, column, default)
+            end
+
+            model =
+              Class.new(ActiveRecord::Base) do
+                self.table_name = table
+
+                def self.to_s
+                  "Backfill"
+                end
+              end
+
+            update_sql =
+              model.connection_pool.with_connection do |c|
+                quoted_column = c.quote_column_name(column)
+                quoted_default = c.quote_default_expression(default, c.send(:column_for, table, column))
+                "#{quoted_column} = #{quoted_default}"
+              end
+
+            @migration.say("Backfilling default")
+            disable_transaction
+            model.unscoped.in_batches(of: 10000) do |relation|
+              relation.where(column => nil).update_all(update_sql)
+              sleep(0.01)
+            end
           end
 
           add_options = add_args.extract_options!

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "2.2.0"
+  VERSION = "2.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Andrew Kane
@@ -9,7 +9,7 @@ authors:
 - David Waller
 bindir: bin
 cert_chain: []
-date: 2025-02-01 00:00:00.000000000 Z
+date: 2025-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord