strong_migrations 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fac153e8505e25b50796c4033952d7e3a0b50db1f0a1fadfd3d3c19e72ac669b
-  data.tar.gz: fc7823c9b58f8598f7a5fee9bc9886e6a7cf444cf853da26fb9b6bc960a09dc9
+  metadata.gz: 4c0ea5c8cf3e904b89b8c4ab2f28ff60031515e40edf5b0c617ca4b8f8249650
+  data.tar.gz: 5cb0fd63058bf618595cd929ef90de3cf90f02963f0adca21182c578f41c3320
 SHA512:
-  metadata.gz: 4cfb16530dce0d416b54ab87b333926299eaccd84a059d270809fb98a576a489f6d250fe7cb008f9471b0f992819cc6bc9efa90c337c78bd7bb53282cc4758e8
-  data.tar.gz: d1aa24bb732b617a4208ac95eafa206c4e3af1782793a7007a89c57894fc2e6a38abccf9e6289f53be1ceda436392bdce08e3cc52be7c70c3b942ea896aaec21
+  metadata.gz: 50db9d240d49b60b75d97c76765b8f5e3b252c2cc826bd5e50e9b57311082dfea2c9cc5790fd905a2eac45a3eb6afb2784c7ed7962dcaf0172157548e1c8d233
+  data.tar.gz: 2f2e5311cad061b712ee9dfb69a41b5e81f31be8db257bd095cbd8124bc461551afebb305d95b0bb090d6f7ef85c61618d61e64e9b73f266338a0aa7f5101b53

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.2.0 (2022-06-10)
+
+- Added check for index corruption with Postgres 14.0 to 14.3
+
 ## 1.1.0 (2022-06-08)
 
 - Added check for `force` option with `create_join_table`

data/lib/strong_migrations/adapters/postgresql_adapter.rb

@@ -13,11 +13,10 @@ module StrongMigrations
         @version ||= begin
           target_version(StrongMigrations.target_postgresql_version) do
             version = select_all("SHOW server_version_num").first["server_version_num"].to_i
+            # major and minor version
             if version >= 100000
-              # major version for 10+
-              "#{version / 10000}"
+              "#{version / 10000}.#{(version % 10000)}"
             else
-              # major and minor version for < 10
               "#{version / 10000}.#{(version % 10000) / 100}"
             end
           end
@@ -160,6 +159,13 @@ module StrongMigrations
         select_all(query.squish).any?
       end
 
+      # only check in non-developer environments (where actual server version is used)
+      def index_corruption?
+        server_version >= Gem::Version.new("14.0") &&
+          server_version < Gem::Version.new("14.4") &&
+          !StrongMigrations.developer_env?
+      end
+
       private
 
       def set_timeout(setting, timeout)

data/lib/strong_migrations/checks.rb

@@ -98,6 +98,11 @@ Then add the NOT NULL constraint in separate migrations."
         raise_error :add_index_columns, header: "Best practice"
       end
 
+      # safe_by_default goes through this path as well
+      if postgresql? && options[:algorithm] == :concurrently && adapter.index_corruption?
+        raise_error :add_index_corruption
+      end
+
       # safe to add non-concurrently to new tables (even after inserting data)
       # since the table won't be in use by the application
       if postgresql? && options[:algorithm] != :concurrently && !new_table?(table)

data/lib/strong_migrations/error_messages.rb

@@ -128,6 +128,11 @@ end",
 "Adding a non-unique index with more than three columns rarely improves performance.
 Instead, start an index with columns that narrow down the results the most.",
 
+    add_index_corruption:
+"Adding an index concurrently can cause silent data corruption in Postgres 14.0 to 14.3.
+Upgrade Postgres before adding new indexes, or wrap this step in a safety_assured { ... } block
+to accept the risk.",
+
     change_table:
 "Strong Migrations does not support inspecting what happens inside a
 change_table block, so cannot help you here. Please make really sure that what

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Andrew Kane
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-06-09 00:00:00.000000000 Z
+date: 2022-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord