strong_migrations 0.7.3 → 0.7.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '008201c52e7ae0bc2f0614b7b820b2dcb4c99c2ba1d270bd1cd4876bfa7c0258'
-  data.tar.gz: 19907e788d2b789ed04f49cdbaac2db7c6ddfe42315dbe53a440514d4b419019
+  metadata.gz: 2bd2b26a8cb5d3577ffaad3878ff961dec2bc6cb55c51897b2681febbf8f0b10
+  data.tar.gz: b48c9ff1050345351a9f938c6dd6dc8530fbc4842e0fc3c60702287fa3fb825c
 SHA512:
-  metadata.gz: 0231f799c80dc8dedbca766d45cc465d569d872ed2744c2348d31cac279d506e8118aacd5bb478833c7f10c427dc9ceff5c0e8aefe815090dbfbd927aaf0e13c
-  data.tar.gz: ecabbcb9bf64a5e9709f0918497ea31cd36829e06db4a8bec375a87cd63faf6ffc3efc2c33c9ca0f5e524f5d397d01aac41bd31fe36e0af47dd0996c4cb75097
+  metadata.gz: 4bc2817b7878c3041442e4e4607db55b2861e7cba16220e635ee28a4b9ebd6dbd0a7ab16033555fa51f4f98601fe0eda198fa91e3030dfff63839c7cdc9aa028
+  data.tar.gz: 254e72cd2ce295759819f05cde920cf4c3ea9ae0d45af9f21d6ac11d55549d0d3544f97f511dc5b1dc0cf44c03c25af4208e4ab4f317449d9aabea90cd485b99

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.7.4 (2020-12-16)
+
+- Added `safe_by_default` option to install generator
+- Fixed warnings with Active Record 6.1
+
 ## 0.7.3 (2020-11-24)
 
 - Added `safe_by_default` option

data/README.md

@@ -583,7 +583,9 @@ end
 
 Certain methods like `execute` and `change_table` cannot be inspected and are prevented from running by default. Make sure what you’re doing is really safe and use this pattern.
 
-## Safe by Default [experimental]
+## Safe by Default
+
+*Experimental*
 
 Make operations safe by default.
 

data/lib/generators/strong_migrations/install_generator.rb

@@ -13,8 +13,14 @@ module StrongMigrations
         Time.now.utc.strftime("%Y%m%d%H%M%S")
       end
 
+      def pgbouncer_message
+        if postgresql?
+          "\n# If you use PgBouncer in transaction mode, delete these lines and set timeouts on the database user"
+        end
+      end
+
       def target_version
-        case ActiveRecord::Base.connection_config[:adapter].to_s
+        case adapter
         when /mysql/
           # could try to connect to database and check for MariaDB
           # but this should be fine
@@ -23,6 +29,14 @@ module StrongMigrations
           "10"
         end
       end
+
+      def adapter
+        ActiveRecord::Base.connection_config[:adapter].to_s
+      end
+
+      def postgresql?
+        adapter =~ /postg/
+      end
     end
   end
 end

data/lib/generators/strong_migrations/templates/initializer.rb.tt

@@ -1,8 +1,7 @@
 # Mark existing migrations as safe
 StrongMigrations.start_after = <%= start_after %>
 
-# Set timeouts for migrations
-# If you use PgBouncer in transaction mode, delete these lines and set timeouts on the database user
+# Set timeouts for migrations<%= pgbouncer_message %>
 StrongMigrations.lock_timeout = 10.seconds
 StrongMigrations.statement_timeout = 1.hour
 
@@ -19,4 +18,8 @@ StrongMigrations.auto_analyze = true
 #   if method == :add_index && args[0].to_s == "users"
 #     stop! "No more indexes on the users table"
 #   end
-# end
+# end<% if postgresql? %>
+
+# Make some operations safe by default
+# See https://github.com/ankane/strong_migrations#safe-by-default
+# StrongMigrations.safe_by_default = true<% end %>

data/lib/strong_migrations/safe_methods.rb

@@ -7,12 +7,12 @@ module StrongMigrations
     # TODO check if invalid index with expected name exists and remove if needed
     def safe_add_index(table, columns, options)
       disable_transaction
-      @migration.add_index(table, columns, options.merge(algorithm: :concurrently))
+      @migration.add_index(table, columns, **options.merge(algorithm: :concurrently))
     end
 
     def safe_remove_index(table, options)
       disable_transaction
-      @migration.remove_index(table, options.merge(algorithm: :concurrently))
+      @migration.remove_index(table, **options.merge(algorithm: :concurrently))
     end
 
     def safe_add_reference(table, reference, options)

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.7.3"
+  VERSION = "0.7.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.7.4
 platform: ruby
 authors:
 - Andrew Kane
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-24 00:00:00.000000000 Z
+date: 2020-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -138,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.0.rc.1
 signing_key:
 specification_version: 4
 summary: Catch unsafe migrations in development