strong_migrations 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e758beb05db7ba2729b599570f430312bfe8c133a83e7bf5cc9403e4c6d768a9
-  data.tar.gz: b24ed790565dc4c19e9d20c6a4a89e3bc518ea8402c9b2e685d6fcf051b5ef26
+  metadata.gz: fee3961cfdf8fe1ad8c3afbf5fa606c142bd647e318c256ec20c7e8d2d34d168
+  data.tar.gz: db9d38d31fd26ef299f42ef48c2457bef2fcdb29de9a942b007437efeba26b25
 SHA512:
-  metadata.gz: efa52a6f8061cf4fa5047b74b704849a2534a2c76f616f981b6f966269eeab295e012e1287c3912a459f1282055f4447edecd1145a8d912d6833db2912ed31e3
-  data.tar.gz: aa22a6034264f82d77ebdc2584fdbf96743a9b62fc49f3f2ec9e76319c5f3c611267f62ac3da9f083a00cfc02e7fc5a027bf88281707c736b9f6874ac9fc5201
+  metadata.gz: 47316b6a2c73fd55fe3ea64a0abd1086d10e959dc10eff0e986b493f221a6a439adc2a65a203c4438a6fc14191864880372cad19561c57177118bad767a35009
+  data.tar.gz: 89a78de250e9a5fe952d1fc795bc87ec4cce8dd2f442b584a547d48044aa12b0832d7edafc79141afa4e4ca6681ee2f87281bd36548c3b99bf17ecec3845753d

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.6.3 (2020-04-04)
+
+- Increasing precision of `decimal` or `numeric` column is safe in Postgres 9.2+
+- Making `decimal` or `numeric` column unconstrained is safe in Postgres 9.2+
+- Changing between `timestamp` and `timestamptz` when session time zone is UTC in Postgres 12+
+- Increasing the length of a `varchar` column from under 255 up to 255 in MySQL and MariaDB
+- Increasing the length of a `varchar` column over 255 in MySQL and MariaDB
+
 ## 0.6.2 (2020-02-03)
 
 - Fixed PostgreSQL version check

data/README.md

@@ -303,7 +303,17 @@ class ChangeSomeColumnType < ActiveRecord::Migration[6.0]
 end
 ```
 
-One exception is changing a `varchar` column to `text`, which is safe in Postgres.
+A few changes are safe in Postgres:
+
+- Changing between `varchar` and `text` columns
+- Increasing the precision of a `decimal` or `numeric` column
+- Making a `decimal` or `numeric` column unconstrained
+- Changing between `timestamp` and `timestamptz` columns when session time zone is UTC in Postgres 12+
+
+And a few in MySQL and MariaDB:
+
+- Increasing the length of a `varchar` column from under 255 up to 255
+- Increasing the length of a `varchar` column over 255
 
 #### Good
 
@@ -690,5 +700,12 @@ To get started with development:
 git clone https://github.com/ankane/strong_migrations.git
 cd strong_migrations
 bundle install
+
+# Postgres
+createdb strong_migrations_test
 bundle exec rake test
+
+# MySQL and MariaDB
+mysqladmin create strong_migrations_test
+ADAPTER=mysql2 bundle exec rake test
 ```

data/lib/strong_migrations/checker.rb

@@ -101,13 +101,50 @@ Then add the NOT NULL constraint."
             raise_error :add_column_json
           end
         when :change_column
-          table, column, type = args
+          table, column, type, options = args
+          options ||= {}
 
           safe = false
-          # assume Postgres 9.1+ since previous versions are EOL
-          if postgresql? && type.to_s == "text"
-            found_column = connection.columns(table).find { |c| c.name.to_s == column.to_s }
-            safe = found_column && found_column.type == :string
+          existing_column = connection.columns(table).find { |c| c.name.to_s == column.to_s }
+          if existing_column
+            sql_type = existing_column.sql_type.split("(").first
+            if postgresql?
+              case type.to_s
+              when "string", "text"
+                # safe to change limit for varchar
+                safe = ["character varying", "text"].include?(sql_type)
+              when "numeric", "decimal"
+                # numeric and decimal are equivalent and can be used interchangably
+                safe = ["numeric", "decimal"].include?(sql_type) &&
+                  (
+                    (
+                      # unconstrained
+                      !options[:precision] && !options[:scale]
+                    ) || (
+                      # increased precision, same scale
+                      options[:precision] && existing_column.precision &&
+                      options[:precision] >= existing_column.precision &&
+                      options[:scale] == existing_column.scale
+                    )
+                  )
+              when "datetime", "timestamp", "timestamptz"
+                safe = ["timestamp without time zone", "timestamp with time zone"].include?(sql_type) &&
+                  postgresql_version >= Gem::Version.new("12") &&
+                  connection.select_all("SHOW timezone").first["TimeZone"] == "UTC"
+              end
+            elsif mysql? || mariadb?
+              case type.to_s
+              when "string"
+                # https://dev.mysql.com/doc/refman/5.7/en/innodb-online-ddl-operations.html
+                # https://mariadb.com/kb/en/innodb-online-ddl-operations-with-the-instant-alter-algorithm/#changing-the-data-type-of-a-column
+                # increased limit, but doesn't change number of length bytes
+                # 1-255 = 1 byte, 256-65532 = 2 bytes, 65533+ = too big for varchar
+                limit = options[:limit] || 255
+                safe = ["varchar"].include?(sql_type) &&
+                  limit >= existing_column.limit &&
+                  (limit <= 255 || existing_column.limit > 255)
+              end
+            end
           end
           raise_error :change_column unless safe
         when :create_table
@@ -325,7 +362,8 @@ Then add the NOT NULL constraint."
       end
 
       # escape % not followed by {
-      @migration.stop!(message.gsub(/%(?!{)/, "%%") % vars, header: header || "Dangerous operation detected")
+      message = message.gsub(/%(?!{)/, "%%") % vars if message.include?("%")
+      @migration.stop!(message, header: header || "Dangerous operation detected")
     end
 
     def constraint_str(statement, identifiers)

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.6.2"
+  VERSION = "0.6.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Andrew Kane
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-03 00:00:00.000000000 Z
+date: 2020-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -82,6 +82,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mysql2
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - andrew@chartkick.com