strong_migrations 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0dd3cbacfcf395cdb4ae90cb70d0da70d6411c18
-  data.tar.gz: 4e9d3a96ee6e57347b448b7f8bd3c7a4a412b0d5
+  metadata.gz: d1d122ea065266614d32562e0692da6e53a44113
+  data.tar.gz: bffe96798471bf21ab7edb47a81ff4b97891b707
 SHA512:
-  metadata.gz: fb8c4bc25cdea84f541199bf56cfdf27d64d8667e3c740729c06a1fdd3de2116c6b8d0ed794b8dc8a67486a7b84262c78f1a4dd428bf5a67518d00f2e9efadae
-  data.tar.gz: 5e3eef7979383a2dd249ddbfd15c0e7fca2caaad288b69acb10ed1f4cec3ad6d8155bb004dc1daba35b36dcc2a08abc99304dad0a7112327635b802b7c927775
+  metadata.gz: 28c244787f1be158f9efa4f3151a93247b1e231b3e2613d03ce5b324b00649ea7118529af59a14a9643f923ae7529435557ab5e97ffeedd8a0b7f51b83297912
+  data.tar.gz: 88d883bd199c79f143c73cfd54b1a921fbe24549b82c847793d0ea8a10544d46b8c699a1d6895d4d1ff3a1b5440bf6c61b380c2e8b119d975ee2868e07212b4c

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.2.2
+
+- Friendlier output
+- Better method of hooking into ActiveRecord
+
 ## 0.2.1
 
 - Recommend `disable_ddl_transaction!` over `commit_db_transaction`

data/README.md

@@ -24,7 +24,7 @@ Strong Migrations detects potentially dangerous operations in migrations, preven
   \ \  /\  / /  \    | |    | |  | |
    \ \/  \/ / /\ \   | |    | |  | |
     \  /\  / ____ \ _| |_   | |  |_|
-     \/  \/_/    \_\_____|  |_|  (_)
+     \/  \/_/    \_\_____|  |_|  (_)  #strong_migrations
 
 ActiveRecord caches attributes which causes problems
 when removing columns. Be sure to ignore the column:
@@ -286,3 +286,12 @@ Everyone is encouraged to help improve this project. Here are a few ways you can
 - Fix bugs and [submit pull requests](https://github.com/ankane/strong_migrations/pulls)
 - Write, clarify, or fix documentation
 - Suggest or add new features
+
+To get started with development and testing:
+
+```sh
+git clone https://github.com/ankane/strong_migrations.git
+cd strong_migrations
+bundle install
+bundle exec rake test
+```

data/lib/strong_migrations.rb

@@ -1,5 +1,6 @@
-require "active_record"
+require "active_support"
 require "strong_migrations/version"
+require "strong_migrations/database_tasks"
 require "strong_migrations/unsafe_migration"
 require "strong_migrations/migration"
 require "strong_migrations/railtie" if defined?(Rails)
@@ -53,9 +54,7 @@ If you really have to:
 5. Stop writing to the old column
 6. Drop the old column",
 
-    remove_column:
-      if ActiveRecord::VERSION::MAJOR >= 5
-"ActiveRecord caches attributes which causes problems
+    remove_column: "ActiveRecord caches attributes which causes problems
 when removing columns. Be sure to ignore the column:
 
 class User < ApplicationRecord
@@ -64,21 +63,7 @@ end
 
 Once that's deployed, wrap this step in a safety_assured { ... } block.
 
-More info: https://github.com/ankane/strong_migrations#removing-a-column"
-      else
-"ActiveRecord caches attributes which causes problems
-when removing columns. Be sure to ignore the column:
-
-class User < ActiveRecord::Base
-  def self.columns
-    super.reject { |c| c.name == \"some_column\" }
-  end
-end
-
-Once that's deployed, wrap this step in a safety_assured { ... } block.
-
-More info: https://github.com/ankane/strong_migrations#removing-a-column"
-      end,
+More info: https://github.com/ankane/strong_migrations#removing-a-column",
 
     rename_column:
 "If you really have to:
@@ -141,4 +126,25 @@ you're doing is safe before proceeding, then wrap it in a safety_assured { ... }
   }
 end
 
-ActiveRecord::Migration.send(:prepend, StrongMigrations::Migration)
+ActiveSupport.on_load(:active_record) do
+  ActiveRecord::Migration.prepend(StrongMigrations::Migration)
+
+  if ActiveRecord::VERSION::MAJOR < 5
+    StrongMigrations.error_messages[:remove_column] = "ActiveRecord caches attributes which causes problems
+when removing columns. Be sure to ignore the column:
+
+class User < ActiveRecord::Base
+  def self.columns
+    super.reject { |c| c.name == \"some_column\" }
+  end
+end
+
+Once that's deployed, wrap this step in a safety_assured { ... } block.
+
+More info: https://github.com/ankane/strong_migrations#removing-a-column"
+  end
+
+  if defined?(ActiveRecord::Tasks::DatabaseTasks)
+    ActiveRecord::Tasks::DatabaseTasks.singleton_class.prepend(StrongMigrations::DatabaseTasks)
+  end
+end

data/lib/strong_migrations/database_tasks.rb

@@ -0,0 +1,28 @@
+module StrongMigrations
+  module DatabaseTasks
+    def migrate
+      super
+    rescue => e
+      if e.cause.is_a?(StrongMigrations::UnsafeMigration)
+        # strip cause and clean backtrace
+        def e.cause
+          nil
+        end
+
+        def e.message
+          super.sub("\n\n\n", "\n\n") + "\n"
+        end
+
+        unless Rake.application.options.trace
+          def e.backtrace
+            bc = ActiveSupport::BacktraceCleaner.new
+            bc.add_silencer { |line| line =~ /strong_migrations/ }
+            bc.clean(super)
+          end
+        end
+      end
+
+      raise e
+    end
+  end
+end

data/lib/strong_migrations/migration.rb

@@ -102,7 +102,7 @@ module StrongMigrations
   \ \  /\  / /  \    | |    | |  | |
    \ \/  \/ / /\ \   | |    | |  | |
     \  /\  / ____ \ _| |_   | |  |_|
-     \/  \/_/    \_\_____|  |_|  (_)
+     \/  \/_/    \_\_____|  |_|  (_)  #strong_migrations
 
 '
       message = StrongMigrations.error_messages[message_key] || "Missing message"

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Bob Remeika
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-08 00:00:00.000000000 Z
+date: 2018-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -98,6 +98,7 @@ files:
 - README.md
 - Rakefile
 - lib/strong_migrations.rb
+- lib/strong_migrations/database_tasks.rb
 - lib/strong_migrations/migration.rb
 - lib/strong_migrations/railtie.rb
 - lib/strong_migrations/unsafe_migration.rb