strong_migrations 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a340806664f60f492f6d01eef606024ac84a3fab
-  data.tar.gz: 64a0c246f0f557aa1bf8fe4bb3966632fdf8bd36
+  metadata.gz: bb8e5f835e883f2053abe736e2cf1f86547cb78f
+  data.tar.gz: d4488980ee75f4297fdc6bf0d22e0595debe0c48
 SHA512:
-  metadata.gz: d75b1ed62073dfb24a46cf33332ec5fe5b649a36e868fe37f2837f0138e8c4b7df25b84dcec3ce84e2730b85b7d24c00feed54115b00ebab612cd78a86ae6761
-  data.tar.gz: bce990568a87049d8834c44da5284b53d830f8ae89a0b75d0787e69a14f57d0fae5d74c4b6e534293759f7194a87bc9c3c4b8b1a4c30d30cd358d6f57d38683f
+  metadata.gz: 57b28bb5f980754035971fc2918d75c24e4778d7ebf8532989f3dc2a17fe5b0447388d8007bd8822713fa0bf901b33b508a3aa89c5dc718d79b78df8d1c76f60
+  data.tar.gz: 41f2e2e734cf6331cdabc3270d07b890a73ed323a9007e644dfa7c9124451aff656ab77d3a97cc352c8033dfb0fd61a65d6a6720f40f370968a9e8435ceb644d

data/CHANGELOG.md

@@ -0,0 +1,17 @@
+## 0.1.3
+
+- Disabled dangerous rake tasks in production
+- Added ability to use `SAFETY_ASSURED` env var
+
+## 0.1.2
+
+- Skip checks on down migrations and rollbacks
+- Added check for indexes with more than 3 columns
+
+## 0.1.1
+
+- Fixed `add_index` check for MySQL
+
+## 0.1.0
+
+- First release

data/README.md

@@ -31,7 +31,7 @@ For more info, check out:
 
 Also checks for best practices:
 
-- keeping indexes under three columns
+- keeping indexes to three columns or less
 
 ## The Zero Downtime Way
 
@@ -135,6 +135,14 @@ class MySafeMigration < ActiveRecord::Migration
 end
 ```
 
+## Production
+
+Dangerous rake tasks are disabled in production - `db:drop`, `db:reset`, `db:schema:load`, and `db:structure:load`. To get around this, use:
+
+```sh
+SAFETY_ASSURED=1 rake db:drop
+```
+
 ## Credits
 
 Thanks to Bob Remeika and David Waller for the [original code](https://github.com/foobarfighter/safe-migrations).

data/lib/strong_migrations.rb

@@ -2,5 +2,6 @@ require "active_record"
 require "strong_migrations/version"
 require "strong_migrations/unsafe_migration"
 require "strong_migrations/migration"
+require "strong_migrations/railtie" if defined?(Rails)
 
 ActiveRecord::Migration.send(:prepend, StrongMigrations::Migration)

data/lib/strong_migrations/migration.rb

@@ -14,7 +14,7 @@ module StrongMigrations
     end
 
     def method_missing(method, *args, &block)
-      unless @safe || is_a?(ActiveRecord::Schema) || @direction == :down
+      unless @safe || ENV["SAFETY_ASSURED"] || is_a?(ActiveRecord::Schema) || @direction == :down
         case method
         when :remove_column
           raise_error :remove_column

data/lib/strong_migrations/railtie.rb

@@ -0,0 +1,10 @@
+# ensure activerecord tasks are loaded first
+require "active_record/railtie"
+
+module StrongMigrations
+  class Railtie < Rails::Railtie
+    rake_tasks do
+      load "tasks/strong_migrations.rake"
+    end
+  end
+end

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/tasks/strong_migrations.rake

@@ -0,0 +1,11 @@
+# http://nithinbekal.com/posts/safe-rake-tasks
+
+namespace :strong_migrations do
+  task safety_assured: :environment do
+    raise "Set SAFETY_ASSURED=1 to run this task in production" if Rails.env.production? && !ENV["SAFETY_ASSURED"]
+  end
+end
+
+["db:drop", "db:reset", "db:schema:load", "db:structure:load"].each do |t|
+  Rake::Task[t].enhance ["strong_migrations:safety_assured"]
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Bob Remeika
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-02-25 00:00:00.000000000 Z
+date: 2016-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -92,14 +92,17 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/strong_migrations.rb
 - lib/strong_migrations/migration.rb
+- lib/strong_migrations/railtie.rb
 - lib/strong_migrations/unsafe_migration.rb
 - lib/strong_migrations/version.rb
+- lib/tasks/strong_migrations.rake
 - strong_migrations.gemspec
 homepage: https://github.com/ankane/strong_migrations
 licenses: []
@@ -120,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.1
 signing_key: 
 specification_version: 4
 summary: Catch unsafe migrations at dev time