strong_migrations 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 802c5c2d23094377d345af4b5024f7b59234c57d
-  data.tar.gz: 5c6d8799de8f254ce8cad115f348a4f36c81b4d2
+  metadata.gz: a340806664f60f492f6d01eef606024ac84a3fab
+  data.tar.gz: 64a0c246f0f557aa1bf8fe4bb3966632fdf8bd36
 SHA512:
-  metadata.gz: 26e985a319fb114d949a22346f276d4fc4102f370416d3a96c8adbd65192b0af8289d06e30666f54562c4638803711c6794c1abaf90273579cbab3d9a0ab6392
-  data.tar.gz: 6c5f3aee2424a5bf1e87373c18b90f8eb71518316b817dd8b7faec715b0895065fa066c653730558ecee1a0f54db3127a6733f6568a734b5701b5da8c106b0c7
+  metadata.gz: d75b1ed62073dfb24a46cf33332ec5fe5b649a36e868fe37f2837f0138e8c4b7df25b84dcec3ce84e2730b85b7d24c00feed54115b00ebab612cd78a86ae6761
+  data.tar.gz: bce990568a87049d8834c44da5284b53d830f8ae89a0b75d0787e69a14f57d0fae5d74c4b6e534293759f7194a87bc9c3c4b8b1a4c30d30cd358d6f57d38683f

data/README.md

@@ -2,6 +2,8 @@
 
 Catch unsafe migrations at dev time
 
+:tangerine: Battle-tested at [Instacart](https://www.instacart.com/opensource)
+
 [![Build Status](https://travis-ci.org/ankane/strong_migrations.svg)](https://travis-ci.org/ankane/strong_migrations)
 
 ## Installation
@@ -27,6 +29,10 @@ For more info, check out:
 - [Rails Migrations with No Downtime](http://pedro.herokuapp.com/past/2011/7/13/rails_migrations_with_no_downtime/)
 - [Safe Operations For High Volume PostgreSQL](https://www.braintreepayments.com/blog/safe-operations-for-high-volume-postgresql/) (if it’s relevant)
 
+Also checks for best practices:
+
+- keeping indexes under three columns
+
 ## The Zero Downtime Way
 
 ### Adding a column with a default value

data/lib/strong_migrations/migration.rb

@@ -8,8 +8,13 @@ module StrongMigrations
       @safe = previous_value
     end
 
+    def migrate(direction)
+      @direction = direction
+      super
+    end
+
     def method_missing(method, *args, &block)
-      unless @safe || is_a?(ActiveRecord::Schema)
+      unless @safe || is_a?(ActiveRecord::Schema) || @direction == :down
         case method
         when :remove_column
           raise_error :remove_column
@@ -22,6 +27,10 @@ module StrongMigrations
         when :rename_column
           raise_error :rename_column
         when :add_index
+          columns = args[1]
+          if columns.is_a?(Array) && columns.size > 3
+            raise_error :add_index_columns
+          end
           options = args[2]
           if %w(PostgreSQL PostGIS).include?(connection.adapter_name) && !(options && options[:algorithm] == :concurrently)
             raise_error :add_index
@@ -107,6 +116,10 @@ Once it's deployed, wrap this step in a safety_assured { ... } block."
     commit_db_transaction
     add_index :users, :some_column, algorithm: :concurrently
   end"
+        when :add_index_columns
+"Adding an index with more than three columns only helps on extremely large tables.
+
+If you're sure this is what you want, wrap it in a safety_assured { ... } block."
         when :change_table
 "The strong_migrations gem does not support inspecting what happens inside a
 change_table block, so cannot help you here. Please make really sure that what

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Bob Remeika
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-11-29 00:00:00.000000000 Z
+date: 2016-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -120,8 +120,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Catch unsafe migrations at dev time
 test_files: []
+has_rdoc: