strong_migrations 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a0871a07d2e13749e0f984373c303dd837d7ea95
-  data.tar.gz: 146fa1034aa8c8c8d5094b0bffa5079e728e6c54
+  metadata.gz: 802c5c2d23094377d345af4b5024f7b59234c57d
+  data.tar.gz: 5c6d8799de8f254ce8cad115f348a4f36c81b4d2
 SHA512:
-  metadata.gz: 4743a779ecede6c6fca241a2f7c0eee01e46c24c79b5af071f850fb4ced23c852f9390f49afbe97323dd247d1dd0a378a3001f0ed6ba57839a34ce3e29ab9b0c
-  data.tar.gz: 8ed8682c0b22ba7c0f7881b9036e6c6e02dc40ffd7f112c08403c0276cbc986f8672e4f3b759ddaeb2b2dd4fc6b7825923917e078c9861a4f887713098cf005c
+  metadata.gz: 26e985a319fb114d949a22346f276d4fc4102f370416d3a96c8adbd65192b0af8289d06e30666f54562c4638803711c6794c1abaf90273579cbab3d9a0ab6392
+  data.tar.gz: 6c5f3aee2424a5bf1e87373c18b90f8eb71518316b817dd8b7faec715b0895065fa066c653730558ecee1a0f54db3127a6733f6568a734b5701b5da8c106b0c7

data/.travis.yml

@@ -9,7 +9,13 @@ gemfile:
 script: bundle exec rake test
 before_script:
   - psql -c 'create database strong_migrations_test;' -U postgres
+  - mysql -e 'create database strong_migrations_test;'
 notifications:
   email:
     on_success: never
     on_failure: change
+matrix:
+  include:
+    - gemfile: test/gemfiles/mysql2.gemfile
+      env: ADAPTER=mysql2
+      rvm: 2.2

data/README.md

@@ -14,13 +14,13 @@ gem 'strong_migrations'
 
 ## Dangerous Operations
 
-- adding an index non-concurrently
-- adding a column with a non-null default value
+- adding a column with a non-null default value to an existing table
 - changing the type of a column
 - renaming a table
 - renaming a column
 - removing a column
-- adding a `json` column (Postgres only)
+- adding an index non-concurrently (Postgres only)
+- adding a `json` column to an existing table (Postgres only)
 
 For more info, check out:
 
@@ -29,19 +29,6 @@ For more info, check out:
 
 ## The Zero Downtime Way
 
-### Adding an index
-
-Add indexes concurrently.
-
-```ruby
-class AddSomeIndexToUsers < ActiveRecord::Migration
-  def change
-    commit_db_transaction
-    add_index :users, :some_index, algorithm: :concurrently
-  end
-end
-```
-
 ### Adding a column with a default value
 
 1. Add the column without a default value
@@ -75,8 +62,6 @@ end
 
 ### Renaming or changing the type of a column
 
-There’s no way to do this without downtime.
-
 If you really have to:
 
 1. Create a new column
@@ -88,11 +73,18 @@ If you really have to:
 
 ### Renaming a table
 
-Same as renaming a column - see above.
+If you really have to:
+
+1. Create a new table
+2. Write to both tables
+3. Backfill data from the old table to new table
+4. Move reads from the old table to the new table
+5. Stop writing to the old table
+6. Drop the old table
 
 ### Removing a column
 
-Tell ActiveRecord to [ignore the column](http://pedro.herokuapp.com/past/2011/7/13/rails_migrations_with_no_downtime/) from its cache.
+Tell ActiveRecord to ignore the column from its cache.
 
 ```ruby
 class User
@@ -104,9 +96,22 @@ end
 
 Once it’s deployed, create a migration to remove the column.
 
-### Adding a json column
+### Adding an index (Postgres)
+
+Add indexes concurrently.
+
+```ruby
+class AddSomeIndexToUsers < ActiveRecord::Migration
+  def change
+    commit_db_transaction
+    add_index :users, :some_index, algorithm: :concurrently
+  end
+end
+```
+
+### Adding a json column (Postgres)
 
-There’s no equality operator for the `json` column type. Replace all calls to `uniq` with a custom scope.
+There’s no equality operator for the `json` column type, which causes issues for `SELECT DISTINCT` queries. Replace all calls to `uniq` with a custom scope.
 
 ```ruby
 scope :uniq_on_id, -> { select("DISTINCT ON (your_table.id) your_table.*") }

data/lib/strong_migrations/migration.rb

@@ -23,7 +23,7 @@ module StrongMigrations
           raise_error :rename_column
         when :add_index
           options = args[2]
-          unless options && options[:algorithm] == :concurrently
+          if %w(PostgreSQL PostGIS).include?(connection.adapter_name) && !(options && options[:algorithm] == :concurrently)
             raise_error :add_index
           end
         when :add_column
@@ -83,9 +83,7 @@ end
 
 Once it's deployed, wrap this step in a safety_assured { ... } block."
         when :rename_column
-"There's no way to rename a column without downtime.
-
-If you really have to:
+"If you really have to:
 
 1. Create a new column
 2. Write to both columns
@@ -94,9 +92,7 @@ If you really have to:
 5. Stop writing to the old column
 6. Drop the old column"
         when :rename_table
-"There's no way to rename a table without downtime.
-
-If you really have to:
+"If you really have to:
 
 1. Create a new table
 2. Write to both tables

data/lib/strong_migrations/version.rb

@@ -1,3 +1,3 @@
 module StrongMigrations
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/strong_migrations.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activerecord", ">= 3.2.0"
 
-  spec.add_development_dependency "bundler", "~> 1.10"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "pg"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: strong_migrations
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Bob Remeika
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-11-23 00:00:00.000000000 Z
+date: 2015-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -30,30 +30,30 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement